Log

Author Commit Date CI Message
Ran Benita 6f8bb5ee 2019-11-09T00:05:59 atom: remove redundant field The field is redundant. Due to alignment, this will only save memory on 32bit architectures. Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita 2a615593 2019-11-08T22:40:13 test/atom: increase iteration count and print random seed on failure Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita 2af474e8 2019-11-02T13:31:44 parser: get rid of "stealing" atoms This requires (well, at least implemented by) casting away `const` which is undefined behavior, and clang started to warn about it. The micro optimization didn't save too many allocations, anyway. Signed-off-by: Ran Benita <ran@unusedvar.com>
Peter Hutterer 31e561fc 2019-11-05T13:33:11 test: remove a superfluous string-is-null check A few lines above we check path_rel[0], so any null pointer will blow up before we get here. Found by coverity Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer 96ef14ac 2019-11-05T13:22:49 test: fix a potential memory leak Found by coverity Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Ran Benita 3515ba19 2019-11-01T10:45:43 test: xkeyboard-config: bring back the progress bar Signed-off-by: Ran Benita <ran@unusedvar.com>
Peter Hutterer 8f93e22a 2019-11-01T18:41:16 test: xkeyboard-config: invoke the python3 command (#120) python3 is always python3, but python could be python2 in some cases. Or just missing (e.g. RHEL8). Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer 0609073c 2019-11-01T11:09:16 test: xkeyboard-config: add missing variant tests Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer f4a0f738 2019-11-01T09:54:29 test: xkeyboard-config: use universal_newlines instead of decode This way stdin/stdout of the process are opened in text mode and we don't need manually decode. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer 7832cc72 2019-10-30T12:03:48 test: xkeyboard-config: flake8 fixes Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer cd5a24aa 2019-10-30T11:22:49 test: xkeyboard-config: handle keyboard interrupts correctly In python multiprocessing, each process needs to handle (and ignore) the KeyboardInterrupt to avoid exception logging. This is a separate patch for easier reviewing, the first hunks merely re-indent all of the xkbcommontool/xkbcomp functions into a try/except KeyboardInterrupt block. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer 9fc0cb87 2019-10-30T10:53:58 test: xkeyboard-config: print to stderr on failure, stdout otherwise This is a change in behavior and requires any automated callers to adjust accordingly. Still, much easier to get the errors that way rather than it being mixed into a thousands-of-lines output file. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer f5383847 2019-10-29T16:06:10 test: xkeyboard-config: add a multiprocessing.Pool() to speed up the test Collect all options into a dictionary, then process that as async actions through a process pool. This of course requires collecting the various print statements to avoid mangled output. This dropped the time to completion from around 14 min to 8 min on my local machine (unscientific single run only for the original timing). Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer 1e131906 2019-10-30T11:15:49 test: xkeyboard-config: use argparse for the path and the tool selection Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Ran Benita 90497b84 2019-10-31T21:21:35 scripts/makeheader: slight simplification Signed-off-by: Ran Benita <ran@unusedvar.com>
Sebastian Wick f0c0cb80 2019-10-31T17:04:49 scripts/makeheader: allow overriding the prefix path of the X11 headers with X11_HEADERS_PREFIX Signed-off-by: Sebastian Wick <sebastian@sebastianwick.net>
Peter Hutterer 255200fa 2019-10-28T11:40:56 test: add test for the various default include paths All tests create a temporary directory, set up the environment for that directory and then check the include paths for the presence of that directory, ideally in the right position of the list. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer e23f1061 2019-10-25T14:36:16 Use XDG_CONFIG_HOME as first XKB search path Use $XDG_CONFIG_HOME/xkb as the primary lookup path for XKB rules. Same motivation as in 3a91788d9254b, however the XDG directories are more standard and recommended these days than application-specific dotfiles. The XDG spec says to fall back to $HOME/.config where XDG_CONFIG_HOME is not set so we implement that behavior as well. Fixes #112 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Ran Benita 6d83838c 2019-10-20T23:07:52 Bump version to 0.9.1 Signed-off-by: Ran Benita <ran@unusedvar.com>
Jan Alexander Steffens (heftig) 4b378398 2019-10-20T19:06:19 context: Don't fail to create the context if HOME isn't available E.g. when Mutter has CAP_SYS_NICE and thus secure_getenv returns NULL. Fixes https://bugs.archlinux.org/task/64191 [ran: changed to ignore error] Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita aa118b4b 2019-10-19T00:55:21 README: update my email address Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita a88a0710 2019-10-19T00:33:09 Bump version to 0.9.0 Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita e41dc19a 2019-10-19T00:41:16 build: remove leftover autotools file Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita 45496c33 2019-10-19T00:37:48 test: fix printf("%s", NULL) in error path ../test/common.c: In function ‘test_get_path’: ../test/common.c:171:9: warning: ‘%s’ directive argument is null [-Wformat-overflow=] 171 | fprintf(stderr, "Failed to allocate path (%d chars) for %s\n", | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 172 | (int) path_len, path); | ~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita 076047b2 2019-10-16T10:32:19 keymap-dump: use consistent capitalization for "Group<N>" It's used capitalized everywhere except a couple places. Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita a6ed0304 2019-10-16T10:27:12 keymap-dump: fix invalid names used for levels above 8 xkbcomp only accepts the "Level" prefix for a level name for levels 1 to 8, but the keymap dumping code added it always, e.g. "Level15". The plain integer, e.g. "8", "15" is always accepted, so just use that. Fixes https://github.com/xkbcommon/libxkbcommon/issues/113 Signed-off-by: Ran Benita <ran@unusedvar.com> Reported-by: progandy
Ran Benita 3a91788d 2019-10-03T17:27:00 context: move ~/.xkb to before XKB_CONFIG_ROOT in the default include path Previously, the default include path was XKB_CONFIG_ROOT:~/.xkb. The ~/.xkb include path is intended to allow the local user to customize their keymaps without having to modify system paths. But usually, the user only wants to customize specific parts. When XKB_CONFIG_ROOT is first, the user can only customize through the "entry point" (the RMLVO). When ~/.xkb is first, the user can drop in a file and it will override the system one. The impetus for this change is the rules file. "evdev" is hard-coded everywhere, so it not often not possible to change to something else. And the rules files determines how the rest of the RMLVO is interpreted. So, to enable customization, we have these options: A: System includes user. B: User includes system. C: Library goes over both in one or the other order. Option A is problematic due to backward compatibility and is also unnatural. Option B gives the user control and is backward compatible, so that's what we choose. This is also how Compose files are handled, and that seems to work fine in the wild. Option C is actually less flexible than B, and more complicated. (The rules file format doesn't have an include statement yet, but it's planned). Signed-off-by: Ran Benita <ran@unusedvar.com>
Alan Coopersmith 934d5741 2019-09-09T17:56:42 build: Solaris needs __EXTENSIONS__ instead of _GNU_SOURCE Fix meson build on Solaris by using __EXTENSIONS__ where Linux & other platforms use _GNU_SOURCE. Without this the build fails due to missing prototypes for functions like strdup & getopt not defined in the C99 standard. (In autoconf, this was handled by AC_USE_SYSTEM_EXTENSIONS.) Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Ran Benita 25cd67da 2019-08-10T14:11:36 build: remove autotools build We introduced meson 2 years ago, hopefully that's was enough time for everyone to convert. Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita e7bb7045 2019-08-10T14:04:29 ci: remove travis CI We moved to Azure Pipelines. Signed-off-by: Ran Benita <ran@unusedvar.com>
Ran Benita d486b542 2019-08-09T23:07:28 Set up CI with Azure Pipelines [skip ci]
Adrian Perez de Castro cc0e3617 2019-08-06T23:55:22 CI: Install graphviz using APT This adds the missing graphviz dependency, from which Doxygen uses "dot" to create diagrams for the documentation. Also, the meson dependency is removed as it is installed using Pip, and ninja-build added.
Adrian Perez de Castro c408adc2 2019-08-06T18:59:10 CI: Publish test results from Meson
Adrian Perez de Castro f796bbb8 2019-08-06T17:25:25 CI: Try builds both with Clang and GCC
Adrian Perez de Castro 510cbdd2 2019-08-06T16:55:41 CI: Enable a macOS job
Adrian Perez de Castro af22f9dc 2019-08-06T16:24:43 CI: Make Autotools and Meson builds parallel This splits the steps for installing dependencies into a new template file, as well as the build steps for Autotools. Both gets used to define two jobs which can run in parallel for both build systems.
Adrian Perez de Castro 789bd05c 2019-08-06T16:16:21 CI: Always try to gather test results Resulting test logs should be always attached to the task, regardless of whether the test suite ran successfully or not.
Adrian Perez de Castro ef74ee1b 2019-08-06T15:34:37 CI: Split Meson build steps into a separate YAML file
Adrian Perez de Castro 7413c6f5 2019-08-06T12:25:29 CI: Save the Meson logs as downloadable files This uploads the files saves to meson-build/meson-logs/ and associates them to the pipeline task, which makes them availabl for download in the Azure Pipelines web interface.
Adrian Perez 69651bf7 2019-08-06T11:53:02 CI: Initial set up to use Azure Pipelines For the moment, configure only basic builds with Ubuntu 16.04, more to be added as follow-ups. [skip ci]
Ran Benita ab4b4b7f 2019-07-25T10:12:53 travis: improve configuration and add macOS Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 7407d311 2019-07-25T13:49:41 test/symbols-leak-test: fix sed regex on macOS Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita c68a8e29 2019-07-25T13:34:49 build: fixup autotools build after 97f41fe Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 97f41fe4 2019-07-25T13:24:00 test/symbols-leak-test: make it work with macOS diff The <() stuff fails with an error: diff: extra operand `/dev/fd/61' Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 6728ebca 2019-07-25T11:59:07 test/rmlvo-to-keymap: drop basename usage It wants some libgen.h include which is POSIX only, let's just remove it as it's hardly important. Signed-off-by: Ran Benita <ran234@gmail.com>
worldofpeace 32d178b5 2019-07-19T02:56:41 test/rmlvo-to-keymap.c: fix compilation on Darwin (#101) program_invocation_short_name isn't portable.
Daniel Stone 909cc04d 2019-07-02T13:48:32 interactive-wayland: Port to stable xdg-shell (#100) xdg_shell v6 was pretty close to the finalised stable version of xdg-shell. We can now just use the stable version, which is supported everywhere (Enlightenment, KWin, Mutter, Weston, wlroots). This requires bumping the wayland-protocols dependency. Signed-off-by: Daniel Stone <daniels@collabora.com>
Ran Benita 06a80bee 2019-06-11T19:59:25 Merge pull request #98 from michaelforney/popcount Use bitwise test for power-of-2 instead of popcount
Michael Forney 9d58bbd4 2019-06-04T14:01:02 Use bitwise test instead of popcount to check if one bit is set We don't need to determine the total number of bits set to determine if exactly one is set. Additionally, on x86_64 without any -march=* flag, __builtin_popcount will get compiled to a function call to the compiler runtime (on gcc), or a long sequence of bit operations (on clang). Signed-off-by: Michael Forney <mforney@mforney.org>
Ran Benita db33ec0d 2019-06-05T09:49:04 Merge pull request #96 from Jjagg/patch-1 Fix a few doc typos
Jesse 8129f3b2 2019-06-04T23:44:42 Fix some doc typos
Ran Benita db7e79e7 2019-03-24T14:05:17 Merge pull request #95 from Hi-Angel/fix-lgtm-warnings Fix some of LGTM warnings
Konstantin Kharlamov 75d1110c 2019-03-23T23:29:29 symbols: add a comment to suppress warning from code analyzers Signed-off-by: Konstantin Kharlamov <Hi-Angel@yandex.ru>
Ran Benita 83cfbf88 2019-03-12T19:39:23 Merge pull request #94 from milloni/milloni/m4 Makefile.am: add include dir for AC_CONFIG_MACRO_DIR to work
milloni 10311c95 2019-03-12T16:22:15 Makefile.am: add include dir for AC_CONFIG_MACRO_DIR to work With older versions of autotools, one needs to add this line to Makefile.am. From the autoconf docs: "Note that if you use aclocal from Automake to generate aclocal.m4, you must also set ACLOCAL_AMFLAGS = -I dir in your top-level Makefile.am". [1] I couldn't build with autoconf 2.68 without this. [1] https://www.gnu.org/software/autoconf/manual/autoconf-2.65/html_node/Input.html Signed-off-by: milloni <milloni@preemptable.org>
Ran Benita 255047f7 2019-02-26T18:27:53 README: usage questions are alright Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 6f0f9534 2019-02-26T18:26:01 README: stop pointing at bugs.freedesktop.org No-one filed bugs in there for a while, let's consolidate on the more popular one. Signed-off-by: Ran Benita <ran234@gmail.com>
maxice8 9badb4e4 2019-02-23T05:55:00 meson.build: use program from build machine not host or target. We can't always execute binaries from the host or target machine, as is the case in cross compilation. closes #89
Ran Benita d40b368b 2019-02-22T22:26:49 Bump version to 0.8.4 Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 2d9e1751 2019-02-22T22:26:11 Update NEWS Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita df28d5e8 2019-02-22T15:37:27 build: fix meson build from tarball generated by autotools These files are used by the meson build only. Previously, trying to build with meson using the tarball generated by distcheck would fail. Fixes https://github.com/xkbcommon/libxkbcommon/issues/87. Reported-by: manesm52 Signed-off-by: Ran Benita <ran234@gmail.com>
Peter Hutterer 3f509533 2019-02-11T09:19:28 meson.build: link the sources directly into libxkbcommon-x11 Similar to 75ce741ab97e3d17a0c9b06dd4bdf57c00d5538e, just for the -x11 sublibrary. This works around meson bug 3937, 'link_whole' arguments don't get added into the final static library and we end up with a virtually empty 8-byte libxkbcommon-x11.a file, see https://github.com/mesonbuild/meson/issues/3937 The internal lib is still built for the one test case that requires it. Fixes #86 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Ran Benita 9f93ebcf 2019-02-08T12:39:01 Bump version to 0.8.3 Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 53e7a315 2019-02-08T12:38:02 Update NEWS Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita caddfdb0 2019-02-08T12:29:27 meson: make comment make sense now Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 327fd9a1 2019-02-08T12:18:00 Merge pull request #85 from whot/wip/static-lib-sources meson.build: manually link all sources into the library
Peter Hutterer 75ce741a 2019-02-08T12:15:48 meson.build: manually link all sources into the library This works around meson bug 3937, 'link_whole' arguments don't get added into the final static library and we end up with a virtually empty 8-byte libxkbcommon.a file, see https://github.com/mesonbuild/meson/issues/3937 Workaround is simply to add all sources to both libraries we need them in. This obviously compiles them twice but this year's winter was cold and bit of extra warmth will be appreciated. Fixes #84 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Ran Benita 73794e1e 2019-01-28T16:29:09 docs: fix a doxygen reference warning
Ran Benita 828cec7b 2019-01-25T12:50:55 Merge pull request #81 from whot/master keysyms: fix comment for XKB_KEY_OCARON
Peter Hutterer e08d589f 2019-01-25T09:26:58 keysyms: fix comment for XKB_KEY_OCARON Reported-by: Keve Müller Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Ran Benita bc04af63 2019-01-22T09:48:23 Merge pull request #79 from jwrdegoede/add-2-new-keysyms Sync Keysyms with recent xproto additions
Hans de Goede 9b85d96d 2019-01-22T08:31:43 Sync Keysyms with recent xproto additions xproto recently has been extended with 2 new keysyms: XF86XK_MonBrightnessCycle XF86XK_RotationLockToggle This commit is the result of running "scripts/update-keysyms" on a system with the updated xproto installed. Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Ran Benita 293c704c 2018-10-01T10:24:45 Merge pull request #69 from alanc/master Fix off-by-one error in index check in xkb_file_type_to_string
Alan Coopersmith 31f1f355 2018-09-30T16:04:29 Fix off-by-one error in index check in xkb_file_type_to_string Found by Oracle's Parfait 2.2 static analyzer: Error: Buffer overrun Read outside array bounds [read-outside-array-bounds] (CWE 125): In array dereference of xkb_file_type_strings[type] with index type Array size is 56 bytes, index <= 56 at line 734 of src/xkbcomp/ast-build.c in function 'xkb_file_type_to_string'. Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Ran Benita c9a499c9 2018-08-24T09:14:14 darray: fix unprotected macro argument Reported-by: @msmeissn Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 87b0765f 2018-08-21T09:05:09 Merge pull request #68 from whot/wip/xkeyboard-config-tester xkeyboard-config combination tester
Peter Hutterer 878bc085 2018-08-20T16:46:19 test: allow for absolute paths to be resolved This makes it possible to check a keymap sitting elsewhere than in the test directory. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer 16c84cdd 2018-08-20T15:50:35 test: drop the rmlvo ability from print-compiled-keymap This is now handled by the rmlvo-to-keymap tool Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer d1cb8ad4 2018-08-14T11:16:30 test: add a tool to test-compile all LVO combinations from xkeyboard-config This test contains of two parts: - a simple program to convert RMLVO commandline arguments into a keymap (and print that keymap if requested). - a python script that runs through rules/evdev.xml, and tries to compile a keymap for sort-of every layout/variant/option combination. Sort-of, because we can have multiple options and it really only does one per layout(variant) combination. Same thing can be done using xkbcomp, but right now it doesn't take that as argument, it's hard-coded. This takes quite a while, installing python-tqdm is recommended to see fancy progress bars instead of just miles of dumps. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Ran Benita d7891d09 2018-08-18T15:12:15 build: turn off strict aliasing The benchmarks don't show any effect, so turn it off to have one less thing to worry about. The parser does a lot of casting between AST nodes. Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita a9ace75f 2018-08-18T14:28:15 x11: fix undefined behavior when copying the coordinates of ptr movements actions Left shift of a negative integer. For some reason the protocol representation here got really botched (in the spec it is just a nice and simple INT16). Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita f8134c85 2018-08-05T08:51:30 Bump version to 0.8.2 Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita e3f9c1b4 2018-08-05T08:49:36 Update NEWS Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita a3e110d6 2018-08-05T08:45:19 Merge pull request #67 from fooishbar/fix-more-fuzz Fix more fuzz-testing fallout
Daniel Stone bb4909d2 2017-10-30T11:21:55 Fail expression lookup on invalid atoms If we fail atom lookup, then we should not claim that we successfully looked up the expression. Signed-off-by: Daniel Stone <daniels@collabora.com>
Daniel Stone 5440aaa5 2017-06-26T21:52:27 Fix signed vs. unsigned confusion in name sanitisation Don't try to divide through a signed char when indexing an array, lest ye try to index off the start of it. Signed-off-by: Daniel Stone <daniels@collabora.com>
Daniel Stone 4fcbc470 2017-06-26T21:49:49 darray: Don't call memcpy() on NULL The only time we could ever hit this was with count == 0, which seems unnecessarily pedantic. But OK. Signed-off-by: Daniel Stone <daniels@collabora.com>
Daniel Stone ae7856db 2017-06-26T21:38:52 text: NULL-terminate SI mask names The list should have a NULL sentry. Add one. testcase: 'interpret KP_Delete+AnyOfOrNaneo(ll)' Signed-off-by: Daniel Stone <daniels@collabora.com>
Daniel Stone 38e1766b 2017-06-26T17:21:45 xkbcomp: Don't falsely promise from ExprResolveLhs Every user of ExprReturnLhs goes on to unconditionally dereference the field return, which can be NULL if xkb_intern_atom fails. Return false if this is the case, so we fail safely. testcase: splice geometry data into interp Signed-off-by: Daniel Stone <daniels@collabora.com>
Daniel Stone 4e2ee9c3 2017-06-26T17:18:16 xkbcomp: Don't explode on invalid virtual modifiers testcase: 'virtualModifiers=LevelThreC' Signed-off-by: Daniel Stone <daniels@collabora.com>
Daniel Stone 96df3106 2017-06-26T17:12:29 xkbcomp: Don't crash on no-op modmask expressions If we have an expression of the form 'l1' in an interp section, we unconditionally try to dereference its args, even if it has none. Signed-off-by: Daniel Stone <daniels@collabora.com>
Daniel Stone a8ea7a1d 2017-06-26T16:45:16 parser: Don't set more maps when we don't have any If the scanner indicates that we might have something which looks like a map, but the parser in fact fails to create that map, we will try to access the map regardless. Stop doing that. testcase: 'xkb_keymap {' -> '#kb_keymap' Signed-off-by: Daniel Stone <daniels@collabora.com>
Ran Benita 87046f56 2018-08-03T13:55:52 Bump version to 0.8.1 Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 1a138abf 2018-08-03T13:55:17 Update NEWS Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 1f366691 2018-08-01T12:25:18 Merge pull request #66 from whot/master Coverity fixes (one real bug)
Peter Hutterer c8168297 2018-08-01T18:47:24 action: make a note that we may not null-terminate private strings Coverity complains that a 7-byte string may not be null-terminated when copied into act->data (size 7). This is fine, make a note of it. All the strings in xkeyboard-config only use 6 bytes + null terminator so this won't be an issue. The server (the only user of these) uses an 8-byte array and forcibly null-terminates the string, see XkbDDXPrivate(). Everything else treats it as byte-array size 7 anyway so whether it's null-terminated doesn't matter. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer c1e5ac16 2018-07-30T14:11:46 xkbcomp: fix pointer value for FreeStmt Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer badb428e 2018-07-23T11:48:35 keycodes: don't try to copy zero key aliases Move the aliases copy to within the (num_key_aliases > 0) block. Passing info->aliases into this fuction with invalid aliases will cause log messages but num_key_aliases stays on 0. The key_aliases array is never allocated and remains NULL. We then loop through the aliases, causing a null-pointer dereference. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer 9045b035 2018-07-23T11:17:17 text: init the target buffer to zero There's a (theoretical?) path where we might end up strcpy() buf without ever writing to it. This happens if the mask is nonzero but specifies a modifier larger than the one in the xkb_mod_set. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Ran Benita 842e4351 2018-03-12T09:43:55 compose: fix infinite loop in parser on some inputs The parser would enter an infinite loop if an unterminated keysym literal occurs at EOF. Found with the afl fuzzer. Signed-off-by: Ran Benita <ran234@gmail.com>