|
db7e79e7
|
2019-03-24T14:05:17
|
|
Merge pull request #95 from Hi-Angel/fix-lgtm-warnings
Fix some of LGTM warnings
|
|
75d1110c
|
2019-03-23T23:29:29
|
|
symbols: add a comment to suppress warning from code analyzers
Signed-off-by: Konstantin Kharlamov <Hi-Angel@yandex.ru>
|
|
|
83cfbf88
|
2019-03-12T19:39:23
|
|
Merge pull request #94 from milloni/milloni/m4
Makefile.am: add include dir for AC_CONFIG_MACRO_DIR to work
|
|
10311c95
|
2019-03-12T16:22:15
|
|
Makefile.am: add include dir for AC_CONFIG_MACRO_DIR to work
With older versions of autotools, one needs to add this line to
Makefile.am. From the autoconf docs: "Note that if you use aclocal from
Automake to generate aclocal.m4, you must also set ACLOCAL_AMFLAGS = -I dir
in your top-level Makefile.am". [1]
I couldn't build with autoconf 2.68 without this.
[1] https://www.gnu.org/software/autoconf/manual/autoconf-2.65/html_node/Input.html
Signed-off-by: milloni <milloni@preemptable.org>
|
|
|
255047f7
|
2019-02-26T18:27:53
|
|
README: usage questions are alright
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
6f0f9534
|
2019-02-26T18:26:01
|
|
README: stop pointing at bugs.freedesktop.org
No-one filed bugs in there for a while, let's consolidate on the more
popular one.
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
9badb4e4
|
2019-02-23T05:55:00
|
|
meson.build: use program from build machine not host or target.
We can't always execute binaries from the host or target machine,
as is the case in cross compilation.
closes #89
|
|
|
d40b368b
|
2019-02-22T22:26:49
|
|
Bump version to 0.8.4
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
2d9e1751
|
2019-02-22T22:26:11
|
|
Update NEWS
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
df28d5e8
|
2019-02-22T15:37:27
|
|
build: fix meson build from tarball generated by autotools
These files are used by the meson build only. Previously, trying to
build with meson using the tarball generated by distcheck would fail.
Fixes https://github.com/xkbcommon/libxkbcommon/issues/87.
Reported-by: manesm52
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
3f509533
|
2019-02-11T09:19:28
|
|
meson.build: link the sources directly into libxkbcommon-x11
Similar to 75ce741ab97e3d17a0c9b06dd4bdf57c00d5538e, just for the -x11
sublibrary.
This works around meson bug 3937, 'link_whole' arguments don't get added into
the final static library and we end up with a virtually empty 8-byte
libxkbcommon-x11.a file, see https://github.com/mesonbuild/meson/issues/3937
The internal lib is still built for the one test case that requires it.
Fixes #86
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
|
9f93ebcf
|
2019-02-08T12:39:01
|
|
Bump version to 0.8.3
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
53e7a315
|
2019-02-08T12:38:02
|
|
Update NEWS
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
caddfdb0
|
2019-02-08T12:29:27
|
|
meson: make comment make sense now
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
327fd9a1
|
2019-02-08T12:18:00
|
|
Merge pull request #85 from whot/wip/static-lib-sources
meson.build: manually link all sources into the library
|
|
|
75ce741a
|
2019-02-08T12:15:48
|
|
meson.build: manually link all sources into the library
This works around meson bug 3937, 'link_whole' arguments don't get added into
the final static library and we end up with a virtually empty 8-byte
libxkbcommon.a file, see https://github.com/mesonbuild/meson/issues/3937
Workaround is simply to add all sources to both libraries we need them in.
This obviously compiles them twice but this year's winter was cold and
bit of extra warmth will be appreciated.
Fixes #84
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
|
73794e1e
|
2019-01-28T16:29:09
|
|
docs: fix a doxygen reference warning
|
|
|
828cec7b
|
2019-01-25T12:50:55
|
|
Merge pull request #81 from whot/master
keysyms: fix comment for XKB_KEY_OCARON
|
|
|
e08d589f
|
2019-01-25T09:26:58
|
|
keysyms: fix comment for XKB_KEY_OCARON
Reported-by: Keve Müller
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
|
bc04af63
|
2019-01-22T09:48:23
|
|
Merge pull request #79 from jwrdegoede/add-2-new-keysyms
Sync Keysyms with recent xproto additions
|
|
9b85d96d
|
2019-01-22T08:31:43
|
|
Sync Keysyms with recent xproto additions
xproto recently has been extended with 2 new keysyms:
XF86XK_MonBrightnessCycle
XF86XK_RotationLockToggle
This commit is the result of running "scripts/update-keysyms" on a system
with the updated xproto installed.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
|
|
293c704c
|
2018-10-01T10:24:45
|
|
Merge pull request #69 from alanc/master
Fix off-by-one error in index check in xkb_file_type_to_string
|
|
31f1f355
|
2018-09-30T16:04:29
|
|
Fix off-by-one error in index check in xkb_file_type_to_string
Found by Oracle's Parfait 2.2 static analyzer:
Error: Buffer overrun
Read outside array bounds [read-outside-array-bounds] (CWE 125):
In array dereference of xkb_file_type_strings[type] with index type
Array size is 56 bytes, index <= 56
at line 734 of src/xkbcomp/ast-build.c in function 'xkb_file_type_to_string'.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
|
c9a499c9
|
2018-08-24T09:14:14
|
|
darray: fix unprotected macro argument
Reported-by: @msmeissn
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
87b0765f
|
2018-08-21T09:05:09
|
|
Merge pull request #68 from whot/wip/xkeyboard-config-tester
xkeyboard-config combination tester
|
|
|
878bc085
|
2018-08-20T16:46:19
|
|
test: allow for absolute paths to be resolved
This makes it possible to check a keymap sitting elsewhere than in the test
directory.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
|
16c84cdd
|
2018-08-20T15:50:35
|
|
test: drop the rmlvo ability from print-compiled-keymap
This is now handled by the rmlvo-to-keymap tool
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
|
d1cb8ad4
|
2018-08-14T11:16:30
|
|
test: add a tool to test-compile all LVO combinations from xkeyboard-config
This test contains of two parts:
- a simple program to convert RMLVO commandline arguments into a keymap (and
print that keymap if requested).
- a python script that runs through rules/evdev.xml, and tries to compile a
keymap for sort-of every layout/variant/option combination. Sort-of, because
we can have multiple options and it really only does one per layout(variant)
combination.
Same thing can be done using xkbcomp, but right now it doesn't take that as
argument, it's hard-coded.
This takes quite a while, installing python-tqdm is recommended to see fancy
progress bars instead of just miles of dumps.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
|
d7891d09
|
2018-08-18T15:12:15
|
|
build: turn off strict aliasing
The benchmarks don't show any effect, so turn it off to have one less
thing to worry about. The parser does a lot of casting between AST
nodes.
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
a9ace75f
|
2018-08-18T14:28:15
|
|
x11: fix undefined behavior when copying the coordinates of ptr movements actions
Left shift of a negative integer. For some reason the protocol
representation here got really botched (in the spec it is just a nice
and simple INT16).
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
e3f9c1b4
|
2018-08-05T08:49:36
|
|
Update NEWS
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
f8134c85
|
2018-08-05T08:51:30
|
|
Bump version to 0.8.2
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
a3e110d6
|
2018-08-05T08:45:19
|
|
Merge pull request #67 from fooishbar/fix-more-fuzz
Fix more fuzz-testing fallout
|
|
bb4909d2
|
2017-10-30T11:21:55
|
|
Fail expression lookup on invalid atoms
If we fail atom lookup, then we should not claim that we successfully
looked up the expression.
Signed-off-by: Daniel Stone <daniels@collabora.com>
|
|
|
5440aaa5
|
2017-06-26T21:52:27
|
|
Fix signed vs. unsigned confusion in name sanitisation
Don't try to divide through a signed char when indexing an array, lest
ye try to index off the start of it.
Signed-off-by: Daniel Stone <daniels@collabora.com>
|
|
|
4fcbc470
|
2017-06-26T21:49:49
|
|
darray: Don't call memcpy() on NULL
The only time we could ever hit this was with count == 0, which seems
unnecessarily pedantic. But OK.
Signed-off-by: Daniel Stone <daniels@collabora.com>
|
|
|
ae7856db
|
2017-06-26T21:38:52
|
|
text: NULL-terminate SI mask names
The list should have a NULL sentry. Add one.
testcase: 'interpret KP_Delete+AnyOfOrNaneo(ll)'
Signed-off-by: Daniel Stone <daniels@collabora.com>
|
|
|
38e1766b
|
2017-06-26T17:21:45
|
|
xkbcomp: Don't falsely promise from ExprResolveLhs
Every user of ExprReturnLhs goes on to unconditionally dereference the
field return, which can be NULL if xkb_intern_atom fails. Return false
if this is the case, so we fail safely.
testcase: splice geometry data into interp
Signed-off-by: Daniel Stone <daniels@collabora.com>
|
|
|
4e2ee9c3
|
2017-06-26T17:18:16
|
|
xkbcomp: Don't explode on invalid virtual modifiers
testcase: 'virtualModifiers=LevelThreC'
Signed-off-by: Daniel Stone <daniels@collabora.com>
|
|
|
96df3106
|
2017-06-26T17:12:29
|
|
xkbcomp: Don't crash on no-op modmask expressions
If we have an expression of the form 'l1' in an interp section, we
unconditionally try to dereference its args, even if it has none.
Signed-off-by: Daniel Stone <daniels@collabora.com>
|
|
|
a8ea7a1d
|
2017-06-26T16:45:16
|
|
parser: Don't set more maps when we don't have any
If the scanner indicates that we might have something which looks like a
map, but the parser in fact fails to create that map, we will try to
access the map regardless. Stop doing that.
testcase: 'xkb_keymap {' -> '#kb_keymap'
Signed-off-by: Daniel Stone <daniels@collabora.com>
|
|
|
87046f56
|
2018-08-03T13:55:52
|
|
Bump version to 0.8.1
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
1a138abf
|
2018-08-03T13:55:17
|
|
Update NEWS
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
1f366691
|
2018-08-01T12:25:18
|
|
Merge pull request #66 from whot/master
Coverity fixes (one real bug)
|
|
|
c8168297
|
2018-08-01T18:47:24
|
|
action: make a note that we may not null-terminate private strings
Coverity complains that a 7-byte string may not be null-terminated when copied
into act->data (size 7). This is fine, make a note of it.
All the strings in xkeyboard-config only use 6 bytes + null terminator so this
won't be an issue. The server (the only user of these) uses an 8-byte array
and forcibly null-terminates the string, see XkbDDXPrivate().
Everything else treats it as byte-array size 7 anyway so whether it's
null-terminated doesn't matter.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
|
c1e5ac16
|
2018-07-30T14:11:46
|
|
xkbcomp: fix pointer value for FreeStmt
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
|
badb428e
|
2018-07-23T11:48:35
|
|
keycodes: don't try to copy zero key aliases
Move the aliases copy to within the (num_key_aliases > 0) block.
Passing info->aliases into this fuction with invalid aliases will
cause log messages but num_key_aliases stays on 0. The key_aliases array
is never allocated and remains NULL. We then loop through the aliases, causing
a null-pointer dereference.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
|
9045b035
|
2018-07-23T11:17:17
|
|
text: init the target buffer to zero
There's a (theoretical?) path where we might end up strcpy() buf without ever
writing to it. This happens if the mask is nonzero but specifies a modifier
larger than the one in the xkb_mod_set.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
|
842e4351
|
2018-03-12T09:43:55
|
|
compose: fix infinite loop in parser on some inputs
The parser would enter an infinite loop if an unterminated keysym
literal occurs at EOF.
Found with the afl fuzzer.
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
917636b1
|
2018-03-11T17:07:06
|
|
xkbcomp: fix crash when parsing an xkb_geometry section
xkb_geometry sections are ignored; previously the had done so by
returning NULL for the section's XkbFile, however some sections of the
code do not expect this. Instead, create an XkbFile for it, it will
never be processes and discarded later.
Caught with the afl fuzzer.
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
e3cacae7
|
2018-03-10T23:32:12
|
|
xkbcomp: fix crashes in the parser when geometry tokens appear
In the XKB format, floats and various keywords can only be used in the
xkb_geometry section. xkbcommon removed support xkb_geometry, but still
parses it for backward compatibility. As part of ignoring it, the float
AST node and various keywords were removed, and instead NULL was
returned by their parsing actions. However, the rest of the code does
not handle NULLs, and so when they appear crashes usually ensue.
To fix this, restore the float AST node and the ignored keywords. None
of the evaluating code expects them, so nice error are displayed.
Caught with the afl fuzzer.
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
1f9d1248
|
2018-03-10T23:10:47
|
|
xkbcomp: fix stack overflow when evaluating boolean negation
The expression evaluator would go into an infinite recursion when
evaluating something like this as a boolean: `!True`. Instead of
recursing to just `True` and negating, it recursed to `!True` itself
again.
Bug inherited from xkbcomp.
Caught with the afl fuzzer.
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
2cb5c2a3
|
2018-03-11T00:04:05
|
|
Add fuzzing infrastructure
Though text formats aren't exactly fuzzer's strong suit, fuzzers can
catch many surface-level bugs.
The fuzz/ directory contains target programs, testcases and dictionaries
to drive the afl fuzzer.
This commit adds a fuzzer for the XKB keymap text format and the Compose
text format. On my slow machine, using a single core, a full cycle of
the XKB fuzzer takes 5 hours. For Compose, it takes a few minutes.
Fuzzing for the other file formats (rules files mostly) will be added
later.
To do some fuzzing, run `./fuzz/fuzz.sh`.
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
a54cfe08
|
2018-07-17T19:06:12
|
|
Merge pull request #65 from heftig/pc-fix2
meson: Fix xkbcommon-x11.pc Requires versioning
|
|
83a553a0
|
2018-07-17T17:21:02
|
|
meson: Fix xkbcommon-x11.pc Requires versioning
Old meson expects an array with one dependency per element. Providing a
string containing multiple deps results in only the first dep getting
its whitespace properly applied. As a result, the output was:
Requires.private: xcb >= 1.10 xcb-xkb>=1.10
And downstream projects failed to find a package named 'xcb-xkb>=1.10'.
Specifying an array of versioned deps results in correct output:
Requires.private: xcb >= 1.10, xcb-xkb >= 1.10
Fixes #64.
Signed-off-by: Jan Alexander Steffens (heftig) <jan.steffens@gmail.com>
|
|
|
a3c907d3
|
2018-07-17T01:15:30
|
|
meson: Fix xkbcommon-x11.pc Requires
The meson-generated pkgconfig file was missing Requires and
Requires.private.
[ran: adjust for older Meson versions.]
Signed-off-by: Jan Alexander Steffens (heftig) <jan.steffens@gmail.com>
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
c8e17eed
|
2018-07-05T18:13:14
|
|
bench: simplify the bench helpers
Trim the API a bit.
Also, just always use gettimeofday(), which is portable. Hopefully the
system clock doesn't change while a benchmark is running.
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
110d17c6
|
2018-06-23T23:17:07
|
|
travis: pin meson to an older version so it works with Python 3.4
The CI image only has Python 3.4. It's a bit of a hassle to change this,
so let's pin meson to the version before they bumped their requirement
instead.
I suppose it's not that bad in that it will guarantee compatibility with
older meson over time.
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
5cee660f
|
2018-06-23T22:00:19
|
|
keysym-utf: reject out-of-range Unicode codepoints in xkb_keysym_to_utf{8,32}
It used to be UTF-8 was defined for inputs > 0x10FFFF, but nowadays
that's the maximum and a codepoint is encoded up to 4 bytes, not 6.
Fixes: https://github.com/xkbcommon/libxkbcommon/issues/58
Fixes: https://github.com/xkbcommon/libxkbcommon/issues/59
Reported-by: @andrecbarros
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
b63196e9
|
2018-02-27T20:24:57
|
|
keysym-utf: replace the Unicode characters for leftanglebracket and rightanglebracket
Looking at leftanglebracket
- The standard[1] does not specify any Unicode value for it.
- The keysym list keysymdef.h in x11proto[2] says U+27E9 MATHEMATICAL
RIGHT ANGLE BRACKET in a comment.
- The keysym->unicode list in xkbcommon which comes from [3] has U+2329
LEFT-POINTING ANGLE BRACKET.
- The keysym->unicode list in Xlib[4] has U+2039 SINGLE LEFT-POINTING
ANGLE QUOTATION MARK.
[1] https://www.x.org/releases/X11R7.7/doc/xproto/x11protocol.html#Legacy_KEYSYMs
[2] https://cgit.freedesktop.org/xorg/proto/x11proto/tree/keysymdef.h
[3] https://www.cl.cam.ac.uk/%7Emgk25/ucs/keysym2ucs.c
[4] https://cgit.freedesktop.org/xorg/lib/libX11/tree/src/xlibi18n/imKStoUCS.c
The symbols we are using, {LEFT,RIGHT}-POINTING ANGLE BRACKET, are
deprecated according to Unicode[5]:
These characters are deprecated and are strongly discouraged for
mathematical use because of their canonical equivalence to CJK
punctuation.
[5] https://www.unicode.org/charts/PDF/U2300.pdf
Hence, switch to the MATHEMATICAL codepoints which seem to be the best
fit.
Fixes: https://github.com/xkbcommon/libxkbcommon/issues/47
Reported-by: @bytensky
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
b2529f2a
|
2018-02-27T12:32:40
|
|
build/autotools: remove redundant ACLOCAL_AMFLAGS
Will be deprecated in automake 2.0.
Replaced by AC_CONFIG_MACRO_DIR (already present) which is available
since autoconf 2.63.
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
776cb523
|
2018-02-25T11:51:05
|
|
build/meson: fix x11 test/demo compilation with non-standard xcb
The x11 tests/demos did not depend on xcb and xcb-xkb directly, only
indirectly through link_with: libxkbcommon_x11_internal. So linking
worked, but the xcb and xcb-xkb cflags were *not* included when
compiling them. So when using xcb installed in a non-standard location,
what would happen is:
- Library will link with custom xcb and compile with custom xcb headers.
- Test will link with custom xcb and compile with system xcb headers (if
exist, otherwise fail).
Fixes: https://github.com/xkbcommon/libxkbcommon/issues/57
Reported-by: @remexre
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
edb1c662
|
2018-02-14T15:07:46
|
|
build/meson: fix the -Wl,--version-script configure check
Hopefully this fixes compilation on darwin, which doesn't support
version scripts.
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
afea3dd0
|
2018-01-27T20:42:44
|
|
test/interactive-wayland: replace tabs with spaces
Match the style of all other files.
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
740c6688
|
2018-01-26T13:09:39
|
|
doc: improve the description of the consumed modifier modes
Hopefully it is more understandable now.
https://bugs.freedesktop.org/show_bug.cgi?id=104768
Reported-by: Gatis Paeglis <gatis.paeglis@qt.io>
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
767fa86d
|
2017-12-21T14:18:07
|
|
Convert http:// -> https:// where possible
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
4fccdee3
|
2017-12-18T16:41:21
|
|
x11: check and document the correct range of device IDs
The actual value is 127, not 255.
https://bugs.freedesktop.org/show_bug.cgi?id=104321
Reported-by: Gatis Paeglis <gatis.paeglis@qt.io>
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
b82e3b76
|
2017-12-15T21:41:51
|
|
Bump version to 0.8.0
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
3db1b9d5
|
2017-12-15T21:40:30
|
|
Update NEWS
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
8ce81c06
|
2017-12-15T16:17:45
|
|
README,PACKAGING: use the new meson unified command format
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
5c904212
|
2017-12-14T17:12:52
|
|
build: disable -Wdocumentation-deprecated-sync
We will never remove the deprecated functions and there is no real
reason to annoy users into stop using them.
If there *will* be a reason, *then* we will add the attribute.
Fixes: https://github.com/xkbcommon/libxkbcommon/issues/56
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
10e1a1b1
|
2017-12-12T14:53:25
|
|
travis: ensure all tests are valgrind-clean
The tests will fail if they have any memory leaks or perform invalid
accesses.
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
29998c25
|
2017-12-12T15:57:58
|
|
test/x11: properly clean up also when skipping test
To make valgrind happy.
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
47f45194
|
2017-12-12T15:44:52
|
|
compose/parser: be more careful when checking if sequence overrides or duplicates another
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
2963e29f
|
2017-12-12T14:43:24
|
|
xkbcomp/ast-build: fix memory leak when appending multi-keysyms
`syms` was not freed.
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
26453b84
|
2017-12-12T14:30:21
|
|
keymap: fix NULL dereference when dumping the default fallback type
The default fallback type uses
type->level_names = NULL
but the keymap-dump code was not checking this case.
Instead of adding more workarounds and possible bugs (e.g. previous
commit), let's just keep the number of level names separately. This has
the additional advantage retains extraneous level name if someone adds
them for some reason.
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
9f85d6b7
|
2017-12-12T14:02:17
|
|
xkbcomp/types: fix types being assigned the wrong number of levels in some circumstances
The buggy code assigned the number of levels based on the number of
level names in the definition, instead of the actual number of levels!
This would completely break type definitions which do not give names to
levels.
This was not noticed for so long because xkeyboard-config always gives
names to all levels.
This regressed in 61fed8dab9b8e27981f36ffc96666d7376546e30.
Reported-by: Gatis Paeglis <gatis.paeglis@qt.io>
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
18d6aebe
|
2017-12-11T22:41:55
|
|
keysym: add xkb_keysym_to_{lower,upper} to public API
These can be useful in some odd cases.
There is already an implementation (+ tests) for internal use, so all
that's needed is to export them.
If xkbcommon were to provide a way to convert a Unicode codepoint to a
keysym, this could have been implemented externally as follows:
uint32_t codepoint = xkb_keysym_to_utf32(keysym);
uint32_t upper_codepoint = my_unicode_library_to_upper(codepoint);
xkb_keysym_t upper_keysym = theoretical_xkb_keysym_from_utf32(upper_codepoint);
However keysym -> codepoint is not injective so such a function is not
possible strictly speaking.
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
6456835f
|
2017-12-03T13:04:35
|
|
test/data: sync with xkeyboard-config 2.22
Some tweaks to the de(neo) keyseq tests were required. It seems to have
improved.
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
8db924b8
|
2017-10-03T13:28:32
|
|
Merge pull request #53 from whitslack/missing-ucs-codes
keysym-utf: Add missing codes for signifblank and permille keysyms
|
|
0db1d313
|
2017-09-28T21:31:28
|
|
keysym-utf: Add missing codes for signifblank and permille keysyms
|
|
|
5eeba0fe
|
2017-09-10T09:18:54
|
|
build/meson: require meson >= 0.41.0
With previous versions, the compilation fails with linker errors.
Fixes https://github.com/xkbcommon/libxkbcommon/issues/52
Reported-by: @rezso
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
41f10188
|
2017-09-08T12:16:13
|
|
expr: paper over a maybe-uninitialized warning
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
14686cd1
|
2017-08-16T20:24:27
|
|
test/interactive-wayland: avoid unused function warning due to configuration
test/interactive-wayland.c:95:1: warning: ‘set_cloexec_or_close’ defined but not used [-Wunused-function]
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
76348754
|
2017-08-16T20:23:54
|
|
build: add missing configure function checks for test/interactive-wayland
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
f468f0b2
|
2017-08-13T17:55:45
|
|
xkbcommon-compose.h: change recommended locale fallback code to treat empty string same as unset
The previous code would cause failures to find the Compose file if one
of the environment variables LC_ALL, LC_CTYPE or LANG are set to the
empty string.
The description of the fallback procedure in loclale(7) talks about
"non-null environment variable"; I interpreted this to mean the
environment variable is unset, but it actually means unset or empty (I
verified this by looking at what glibc and musl do).
A recent bug in systemd https://github.com/systemd/systemd/issues/6407
exposed this issue. It causes these these variables to be set to the
empty string in TTY sessions.
Reported by "doodoo" in https://bbs.archlinux.org/viewtopic.php?id=228658
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
ba9568bd
|
2017-08-04T16:28:36
|
|
Bump version to 0.7.2
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
c99f6a58
|
2017-08-04T16:17:27
|
|
Update NEWS
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
5c2da779
|
2017-08-04T15:31:06
|
|
build/autotools: fix doc installation
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
fbd86e44
|
2017-08-03T13:38:14
|
|
test/symbols-leak-test.bash: make it easier to read
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
2a16c3c4
|
2017-08-02T18:28:17
|
|
build/autotools: fix symbol versioning configure check
Regressed in 4309735. I thought `$top_srcdir` works in configure too,
apparently not!
See: https://github.com/xkbcommon/libxkbcommon/issues/50#issuecomment-319693694
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
c665b450
|
2017-08-02T18:26:19
|
|
build/autotools: make doxygen's input relative
Was meant to be a part of 41bea9a.
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
cd642b27
|
2017-08-01T23:36:33
|
|
build/autotools: dist the meson build files
So that it's possible to build with meson from autotools-generated
tarballs.
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
fd82b89e
|
2017-08-01T23:32:57
|
|
build/autotools: install documentation under html/
To be consistent with the meson build; also makes more sense as doxygen
can generate more than html (though we currently are not doing that).
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
41bea9ab
|
2017-08-01T22:19:48
|
|
build: make doxygen run from the source tree
I couldn't find any other way to make this work!
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
ccc3415e
|
2017-07-31T20:57:31
|
|
Merge pull request #49 from bluetech/meson
build: add meson build system
|
|
|
86434d84
|
2017-07-25T21:57:42
|
|
build: add meson build system
Meson is easier to maintain, much faster, encourages better practices,
and is not built on a pile of shell scripts.
The autotools build system is kept intact for now, in order to ease the
migration. The intention is to remove it sooner rather than later, if
all goes well.
Run `meson build && mesonconf build` to see the configuration options
for the new system. Conversion should be straightforward. Environment
variables like CFLAGS work the same.
If meson is used, xorg-util-macros is not required.
In terms of functionality the two systems have about the same
capabilities. Here are some differences I noticed:
- Meson uses `-g` by default, autotools uses `-g -O2`.
- In autotools the default behavior is to install both static and shared
versions of the libraries. In meson the user must choose exactly one
(using -Ddefault_library=static/shared).
It is possible to workaround if needed (install twice...), but
hopefully meson will add the option in the future.
- Autotools has builtin ctags/cscope targets, meson doesn't.
Easy to run the tools directly.
- Meson has builtin benchmarks target. Handy.
- Meson has builtin support for sanitizers/clang-analyzer/lto/pgo/
coverage etc. Also handy.
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
75ec764c
|
2017-07-26T12:40:09
|
|
build: remove Android.mk
I don't think it will work with meson, and I also don't think anyone is
using it.
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
2f6616a5
|
2017-07-26T12:27:53
|
|
build: remove -uninstalled pkg-config files
Meson doesn't support them directly, and I don't think anyone is using
them.
Signed-off-by: Ran Benita <ran234@gmail.com>
|
|
|
a0c858cd
|
2017-07-31T18:22:54
|
|
travis: do the build out-of-tree
To catch problems like the previous commit.
Signed-off-by: Ran Benita <ran234@gmail.com>
|