kmx git

Commit	Date	Message
f9985688	2020-02-18T15:17:45	azure: docker: detect errors when building images The build step for our Docker images currently succeeds even if building the Docker image fails due to missing && chains in the build script. Fix this by adding them in.
68bfacb1	2020-02-18T15:17:17	azure: remove unused Linux setup script Since migrating to Docker containings for our build and test infrastructure, we do not use the "setup-linux.sh" script anymore. Remove it to avoid any confusion.
ee3307a1	2020-02-08T17:34:53	Merge pull request #5392 from pks-t/pks/ci-warnings azure: fix misleading messages printed to stderr being
6a61a418	2020-02-08T17:32:51	Merge pull request #5393 from pks-t/pks/tests-iterator-missing-ref tests: iterator: fix iterator expecting too few items
26b71d60	2020-02-07T14:36:10	tests: iterator: fix iterator expecting too few items The testcase iterator::workdir::filesystem_gunk sets up quite a lot of directories, which is why it only runs in case GITTEST_INVASIVE_SPEED is set in the environment. Because we do not run our default CI with this variable, we didn't notice commit 852c83ee4 (refs: refuse to delete HEAD, 2020-01-15) breaking the test as it introduced a new reference to the "testrepo" repository. Fix the oversight by increasing the number of expected iterator items.
49bb4237	2020-02-07T14:04:07	azure: test: silence termination message when killing git-daemon(1) In order to properly tear down the test environment, we will kill git-daemon(1) if we've exercised it. As git-daemon(1) is spawned as a background process, it is still owned by the shell and thus killing it later on will print a termination message to the shell's stderr, causing Azure to report it as an error. Fix this by disowning the background process.
fb03f02a	2020-02-07T13:56:36	azure: docker: avoid re-creating libgit2 home directory The Docker entrypoint currently creates the libgit2 user with "useradd --create-home". As we start the Docker container with two volumes pointing into "/home/libgit2/", the home directory will already exist. While useradd(1) copes with this just fine, it will print error messages to stderr which end up as failures in our Azure pipelines. Fix this by simply removing the "--create-home" parameter.
52cb4040	2020-02-07T13:52:07	azure: test: silence curl to not cause Azure to trop Without the "--silent" parameter, curl will print a progress meter to stderr. Azure has the nice feature of interpreting any output to stderr as errors with a big red warning towards the end of the build. Let's thus silence curl to not generate any misleading messages.
a3ec07d7	2020-02-07T13:34:18	azure: docker: pipe downloaded archives into tar(1) directly When building dependencies for our Docker images, we first download the sources to disk first, unpack them and finally remove the archive again. This can be sped up by piping the downloading archive into tar(1) directly to parallelize both tasks. Furthermore, let's silence curl(1) to not print to status information to stderr, which tends to be interpreted as errors by Azure Pipelines.
03ac24b1	2020-02-07T11:36:36	Merge pull request #5387 from pks-t/pks/transport-http-custom-headers transports: http: fix custom headers not being applied
65ac33ae	2020-02-07T11:18:24	Merge pull request #5382 from libgit2/pks/azure-coverity azure: fix Coverity pipeline
46228d86	2020-02-06T11:10:27	transports: http: fix custom headers not being applied In commit b9c5b15a7 (http: use the new httpclient, 2019-12-22), the HTTP code got refactored to extract a generic HTTP client that operates independently of the Git protocol. Part of refactoring was the creation of a new `git_http_request` struct that encapsulates the generation of requests. Our Git-specific HTTP transport was converted to use that in `generate_request`, but during the process we forgot to set up custom headers for the `git_http_request` and as a result we do not send out these headers anymore. Fix the issue by correctly setting up the request's custom headers and add a test to verify we correctly send them.
86c54cc8	2020-02-04T11:51:56	azure: coverity: fix Coverity builds due to various issues There's several issues with our Coverity builds, like e.g. missing wget in our containers. Simplify our Coverity pipeline and fix these issues.
ccffea6b	2020-02-04T11:47:16	azure: coverity: convert to use self-built containers Back in commit 5a6740e7f (azure: build Docker images as part of the pipeline, 2019-08-02), we have converted our pipelines to use self-built Docker images to ease making changes to our Dockerfiles. The commit didn't adjust our Coverity pipeline, though, so let's do this now.
b4eb0282	2020-02-04T11:46:05	azure: coverity: fix invalid syntax for Docker image In commit bbc0b20bd (azure: fix Coverity's build due to wrong container name, 2019-08-02), Coverity builds were fixed to use the correct container names. Unfortunately, the "fix" completely broke our Coverity builds due to using wrong syntax for the Docker task. Let's fix this by using "imageName" instead of the Docker dict.
bd6b1c41	2020-02-06T06:14:20	Merge pull request #5381 from pks-t/pks/tests-flaky-proxy azure: tests: re-run flaky proxy tests
c51bd2f2	2020-02-04T12:15:56	azure: tests: reset FAILED status if flaky re-run succeeds While we already do have logic to re-run flaky tests, the FAILED variable currently does not get reset to "0". As a result, successful reruns will still cause the test to be registered as failed. Fix this by resetting the variable accordingly.
b33ad764	2020-02-04T11:26:57	azure: tests: re-run flaky proxy tests The proxy tests regularly fail in our CI environment. Unfortunately, this is expected due to the network layer. Thus, let's re-try the proxy tests up to five times in case they fail.
55975171	2020-02-01T09:03:00	Merge pull request #5373 from pks-t/pks/fetchhead-strip-creds fetchhead: strip credentials from remote URL
93a9044f	2020-01-31T08:49:34	fetchhead: strip credentials from remote URL If fetching from an anonymous remote via its URL, then the URL gets written into the FETCH_HEAD reference. This is mainly done to give valuable context to some commands, like for example git-merge(1), which will put the URL into the generated MERGE_MSG. As a result, what gets written into FETCH_HEAD may become public in some cases. This is especially important considering that URLs may contain credentials, e.g. when cloning 'https://foo:bar@example.com/repo' we persist the complete URL into FETCH_HEAD and put it without any kind of sanitization into the MERGE_MSG. This is obviously bad, as your login data has now just leaked as soon as you do git-push(1). When writing the URL into FETCH_HEAD, upstream git does strip credentials first. Let's do the same by trying to parse the remote URL as a "real" URL, removing any credentials and then re-formatting the URL. In case this fails, e.g. when it's a file path or not a valid URL, we just fall back to using the URL as-is without any sanitization. Add tests to verify our behaviour.
a1bff63b	2020-01-31T13:44:47	Merge pull request #5375 from pks-t/pks/test-ci azure-pipelines: properly expand negotiate passwords
7aa99dd3	2020-01-31T11:41:43	azure-pipelines: properly expand negotiate passwords To allow testing against a Kerberos instance, we have added variables for the Kerberos password to allow authentication against LIBGIT2.ORG in commit e5fb5fe5a (ci: perform SPNEGO tests, 2019-10-20). To set up the password, we assign "GITTEST_NEGOTIATE_PASSWORD=$(GITTEST_NEGOTIATE_PASSWORD)" in the environmentVariables section which is then passed through to a template. As the template does build-time expansion of the environment variables, it will expand the above line verbosely, and due to the envVar section not doing any further expansion the password variable will end up with the value "$(GITTEST_NEGOTIATE_PASSWORD)" in the container's environment. Fix this fixed by doing expansion of GITTEST_NEGOTIATE_PASSWORD at build-time, as well.
aa4cd778	2020-01-30T10:40:44	Merge pull request #5336 from libgit2/ethomson/credtype cred: change enum to git_credential_t and GIT_CREDENTIAL_*
f9b41a66	2020-01-30T10:30:12	Merge pull request #5371 from ayush-1506/julia_link Update link to libgit2 Julia language binding
103a76b4	2020-01-30T17:58:43	Update link to Julia libgit2
3f54ba8b	2020-01-18T13:51:40	credential: change git_cred to git_credential We avoid abbreviations where possible; rename git_cred to git_credential. In addition, we have standardized on a trailing `_t` for enum types, instead of using "type" in the name. So `git_credtype_t` has become `git_credential_t` and its members have become `GIT_CREDENTIAL` instead of `GIT_CREDTYPE`. Finally, the source and header files have been renamed to `credential` instead of `cred`. Keep previous name and values as deprecated, and include the new header files from the previous ones.
4383ab40	2020-01-24T15:32:09	Merge pull request #5365 from libgit2/ethomson/no_void Return int from non-free functions
a3126a72	2020-01-18T17:50:38	repository functions: return an int Stop returning a void for functions, future-proofing them to allow them to fail.
cb43274a	2020-01-18T17:42:52	index functions: return an int Stop returning a void for functions, future-proofing them to allow them to fail.
82154e58	2020-01-18T17:41:21	remote functions: return an int Stop returning a void for functions, future-proofing them to allow them to fail.
3351506a	2020-01-18T17:38:36	tree functions: return an int Stop returning a void for functions, future-proofing them to allow them to fail.
2e8c3b0b	2020-01-18T17:17:46	oid functions: return an int Stop returning a void for functions, future-proofing them to allow them to fail.
9893d376	2020-01-18T15:41:20	git_attr_cache_flush: return an int Stop returning a void for functions, future-proofing them to allow them to fail.
4cae9e71	2020-01-18T18:02:08	git_libgit2_version: return an int Stop returning a void for functions, future-proofing them to allow them to fail.
f78f6bd5	2020-01-18T18:00:39	error functions: return an int Stop returning a void for functions, future-proofing them to allow them to fail.
4b331f02	2020-01-18T17:56:05	revwalk functions: return an int Stop returning a void for functions, future-proofing them to allow them to fail.
82050fa1	2020-01-18T17:53:26	mempack functions: return an int Stop returning a void for functions, future-proofing them to allow them to fail.
4460bf40	2020-01-24T11:08:44	Merge pull request #5286 from libgit2/ethomson/gssapi HTTP: Support Apache-based servers with Negotiate
e9cef7c4	2020-01-11T23:53:45	http: introduce GIT_ERROR_HTTP Disambiguate between general network problems and HTTP problems in error codes.
7fd9b3f5	2020-01-01T20:48:15	ci: add NTLM tests Download poxygit, a debugging git server, and clone from it using NTLM, both IIS-style (with connection affinity) and Apache-style ("broken", requiring constant reauthentication).
29762e40	2020-01-01T16:14:37	httpclient: use defines for status codes
3e9ee04f	2019-12-29T18:46:44	trace: compare against an int value When tracing is disabled, don't let `git_trace__level` return a void, since that can't be compared against.
76fd406a	2019-12-26T16:37:01	http: send probe packets When we're authenticating with a connection-based authentication scheme (NTLM, Negotiate), we need to make sure that we're still connected between the initial GET where we did the authentication and the POST that we're about to send. Our keep-alive session may have not kept alive, but more likely, some servers do not authenticate the entire keep-alive connection and may have "forgotten" that we were authenticated, namely Apache and nginx. Send a "probe" packet, that is an HTTP POST request to the upload-pack or receive-pack endpoint, that consists of an empty git pkt ("0000"). If we're authenticated, we'll get a 200 back. If we're not, we'll get a 401 back, and then we'll resend that probe packet with the first step of our authentication (asking to start authentication with the given scheme). We expect _yet another_ 401 back, with the authentication challenge. Finally, we will send our authentication response with the actual POST data. This will allow us to authenticate without draining the POST data in the initial request that gets us a 401.
b9c5b15a	2019-12-22T14:12:24	http: use the new httpclient Untangle the notion of the http transport from the actual http implementation. The http transport now uses the httpclient.
bf55facf	2019-10-25T12:24:34	tests: allow users to use expect/continue
7372573b	2019-10-25T12:22:10	httpclient: support expect/continue Allow users to opt-in to expect/continue handling when sending a POST and we're authenticated with a "connection-based" authentication mechanism like NTLM or Negotiate. If the response is a 100, return to the caller (to allow them to post their body). If the response is not a 100, buffer the response for the caller. HTTP expect/continue is generally safe, but some legacy servers have not implemented it correctly. Require it to be opt-in.
6c21c989	2019-12-14T21:32:07	httpclient: support CONNECT proxies Fully support HTTP proxies, in particular CONNECT proxies, that allow us to speak TLS through a proxy.
6b208836	2019-12-18T21:55:28	httpclient: handle chunked responses Detect responses that are sent with Transfer-Encoding: chunked, and record that information so that we can consume the entire message body.
6a095679	2019-12-14T10:34:36	httpclient: support authentication Store the last-seen credential challenges (eg, all the 'WWW-Authenticate' headers in a response message). Given some credentials, find the best (first) challenge whose mechanism supports these credentials. (eg, 'Basic' supports username/password credentials, 'Negotiate' supports default credentials). Set up an authentication context for this mechanism and these credentials. Continue exchanging challenge/responses until we're authenticated.
0e39a8fa	2019-12-29T10:05:14	net: free the url's query component
0b8358c8	2019-12-14T11:04:58	net: introduce path formatting function Introduce a function to format the path and query string for a URL, suitable for creating an HTTP request.
1152f361	2019-12-13T18:37:19	httpclient: consume final chunk message When sending a new request, ensure that we got the entirety of the response body. Our caller may have decided that they were done reading. If we were not at the end of the message, this means that we need to tear down the connection and cannot do keep-alive. However, if the caller read all of the message, but we still have a final end-of-response chunk signifier (ie, "0\r\n\r\n") on the socket, then we should consider that the response was successfully copmleted. If we're asked to send a new request, try to read from the socket, just to clear out that end-of-chunk message, marking ourselves as disconnected on any errors.
dcd3b815	2019-12-13T15:28:57	tests: support CLAR_TRACE_LEVEL The CLAR_TRACE_LEVEL environment variable was supported when building with GIT_TRACE. Now we always build with GIT_TRACE, but that variable is not provided to tests. Simply support clar tracing always.
84b99a95	2019-12-12T13:53:43	httpclient: add chunk support to POST Teach httpclient how to support chunking when POSTing request bodies.
eacecebd	2019-12-12T13:25:32	httpclient: introduce a simple http implementation Introduce a new http client implementation that can GET and POST to remote URLs. Consumers can use `git_http_client_init` to create a new client, `git_http_client_send_request` to send a request to the remote server and `git_http_client_read_response` to read the response. The http client implementation will perform the I/O with the remote server (http or https) but does not understand the git smart transfer protocol. This allows us to split the concerns of the http subtransport from the actual http implementation.
a591f362	2019-12-09T19:48:10	net: introduce url formatting function
031e3e4c	2019-11-27T14:20:44	ci: don't do negotiate tests on windows We can't get a kerberos TGT easily on Windows; skip the negotiate tests.
fe4efe2e	2019-12-03T10:17:30	tests: test that clone returns 4321 This conditional was backwards. We should instead test that clone returns 4321, not that 4321 returns clone.
7e0f5a6a	2019-10-22T22:37:14	smart protocol: correct case in error messages
2d6a61bd	2019-10-22T09:52:31	gssapi: validate that we were requested Negotiate
e761df5c	2019-10-22T09:35:48	gssapi: dispose after completion for retry Disposal pattern; dispose on completion, allowing us to retry authentication, which may happen on web servers that close connection-based authenticated sessions (NTLM/SPNEGO) unexpectedly.
d68f2b1a	2019-12-06T18:22:58	buf: add consume_bytes Allow users to consume a buffer by the number of bytes, not just to an ending pointer.
e995f74e	2019-12-06T15:39:08	net: introduce git_net_url_joinpath Provide a mechanism to add a path and query string to an existing url so that we can easily append `/info/refs?...` type url segments to a url given to us by a user.
471daeea	2019-12-01T14:00:49	net: refactor gitno redirect handling Move the redirect handling into `git_net_url` for consistency.
297c61e4	2019-12-01T10:06:11	net: add an isvalid function (Also, mark all the declarations as extern.)
a194e17f	2019-11-27T18:43:36	winhttp: refactor request sending Clarify what it means to not send a length; this allows us to refactor requests further.
da9bc8ac	2019-11-27T23:42:16	ci: enable GSSAPI for Ubuntu builds
9b96adf3	2019-11-22T18:03:50	docker build: add krb5 libraries and command-line tools
89d1fc2a	2019-10-22T09:30:50	gssapi: show information about disabled GSSAPI When USE_GSSAPI=OFF, still show information about what SPNEGO is, even though it's disabled. This is for parity with other disabled features like SSH and debugpool that still show details about what is disabled.
5625892b	2019-09-20T12:06:11	gssapi: delete half-built security context so auth can continue
2174aa0a	2019-10-21T11:47:23	gssapi: correct incorrect case in error message
3f6fe054	2019-10-20T17:23:01	gssapi: protect GSS_ERROR macro The GSS_ERROR(x) macro may expand to `(x & value)` on some implementations, instead of `((x) & value)`. This is the case on macOS, which means that if we attempt to wrap an expression in that macro, like `a = b`, then that would expand to `(a = b & value)`. Since `&` has a higher precedence, this is not at all what we want, and will set our result code to an incorrect value. Evaluate the expression then test it with `GSS_ERROR` independently to avoid this.
73fe690d	2019-10-20T17:22:27	gssapi: protect against empty messages
e5fb5fe5	2019-10-20T17:19:01	ci: perform SPNEGO tests Attempt to obtain a Kerberos ticket from LIBGIT2.ORG and then clone the Negotiate-protected site at test.libgit2.org with that ticket.
9bcf10e9	2020-01-24T09:56:59	Merge pull request #5364 from libgit2/ethomson/typet internal types: change enums from `type_t` to `_t`
917ba762	2020-01-18T14:14:00	auth: update enum type name for consistency libgit2 does not use `type_t` suffixes as it's redundant; thus, rename `git_http_authtype_t` to `git_http_auth_t` for consistency.
b59c71d8	2020-01-18T14:11:01	iterator: update enum type name for consistency libgit2 does not use `type_t` suffixes as it's redundant; thus, rename `git_iterator_type_t` to `git_iterator_t` for consistency.
df3063ea	2020-01-18T14:04:44	rebase: update enum type name for consistency libgit2 does not use `type_t` suffixes as it's redundant; thus, rename `git_rebase_type_t` to `git_rebase_t` for consistency.
94beb3a3	2020-01-18T14:03:23	merge: update enum type name for consistency libgit2 does not use `type_t` suffixes as it's redundant; thus, rename `git_merge_diff_type_t` to `git_merge_diff_t` for consistency.
a76348ee	2020-01-17T08:38:00	Merge pull request #5358 from lrm29/git_merge_driver_source_repo_non_const merge: Return non-const git_repository from accessor method
1908884d	2020-01-17T08:34:30	Merge pull request #5361 from csware/no-return-freed_object Do not return free'd git_repository object on error
47ac1187	2020-01-17T08:32:37	Merge pull request #5360 from josharian/fix-5357 refs: refuse to delete HEAD
a129941a	2020-01-16T17:44:55	Merge pull request #5351 from pks-t/pks/index-map-macros index: replace map macros with inline functions
470a05d0	2020-01-16T17:53:50	Do not return free'd git_repository object on error Regression introduced in commit dde6d9c706bf1ecab545da55ab874a016587af1f. This issue causes lots of crashes in TortoiseGit. Signed-off-by: Sven Strickroth <email@cs-ware.de>
852c83ee	2020-01-15T13:31:21	refs: refuse to delete HEAD This requires adding a new symbolic ref to the testrepo fixture. Some of the existing tests attempt to delete HEAD, expecting a different failure. Introduce and use a non-HEAD symbolic ref instead. Adjust a few other tests as needed. Fixes #5357
dea5ce3d	2020-01-15T17:30:59	Merge pull request #5359 from tniessen/make-type-mismatch-errors-consistent Make type mismatch errors consistent
5e1b6eaf	2020-01-15T12:58:59	Make type mismatch errors consistent
1bddbd02	2020-01-15T10:30:00	merge: Return non-const git_repository from git_merge_driver_source_repo accessor.
7fc97eb3	2020-01-09T14:21:41	index: fix resizing index map twice on case-insensitive systems Depending on whether the index map is case-sensitive or insensitive, we need to call either `git_idxmap_icase_resize` or `git_idxmap_resize`. There are multiple locations where we thus use the following pattern: if (index->ignore_case && git_idxmap_icase_resize(map, length) < 0) return -1; else if (git_idxmap_resize(map, length) < 0) return -1; The funny thing is: on case-insensitive systems, we will try to resize the map twice in case where `git_idxmap_icase_resize()` doesn't error. While this will still use the correct hashing function as both map types use the same, this bug will at least cause us to resize the map twice in a row. Fix the issue by introducing a new function `index_map_resize` that handles case-sensitivity, similar to how `index_map_set` and `index_map_delete`. Convert all call sites where we were previously resizing the map to use that new function.
ab45887f	2020-01-09T14:15:02	index: replace map macros with inline functions Traditionally, our maps were mostly implemented via macros that had weird call semantics. This shows in our index code, where we have macros that insert into an index map case-sensitively or insensitively, as they still return error codes via an error parameter. This is unwieldy and, most importantly, not necessary anymore, due to the introduction of our high-level map API and removal of macros. Replace them with inlined functions to make code easier to read.
cc4f4cbe	2020-01-12T10:12:57	Merge pull request #5355 from pks-t/pks/win32-relative-symlink-across-dirs win32: fix relative symlinks pointing into dirs
d5482339	2020-01-10T11:13:25	Merge pull request #5354 from josharian/issue-5353 ntlm: prevent (spurious) compiler warnings
dbb6429c	2020-01-10T14:30:18	Merge pull request #5305 from kas-luthor/bugfix/multiple-auth Adds support for multiple SSH auth mechanisms being used sequentially
7d55bee6	2020-01-10T12:44:51	win32: fix relative symlinks pointing into dirs On Windows platforms, we need some logic to emulate symlink(3P) defined by POSIX. As unprivileged symlinks on Windows are a rather new feature, our current implementation is comparatively new and still has some rough edges in special cases. One such case is relative symlinks. While relative symlinks to files in the same directory work as expected, libgit2 currently fails to create reltaive symlinks pointing into other directories. This is due to the fact that we forgot to translate the Unix-style target path to Windows-style. Most importantly, we are currently not converting directory separators from "/" to "\". Fix the issue by calling `git_win32_path_canonicalize` on the target. Add a test that verifies our ability to create such relative links across directories.
9181e4b5	2020-01-10T12:02:10	Merge pull request #5339 from josharian/issue-5321 netops: handle intact query parameters in service_suffix removal
93def7ad	2020-01-09T13:37:18	ntlm: prevent (spurious) compiler warnings Pull in commit https://github.com/ethomson/ntlmclient/commit/e7b2583e1bc28c33c43854e7c318e859b4e83bef to fix #5353.
7142964f	2019-12-13T10:56:19	netops: handle intact query parameters in service_suffix removal Some servers leave the query parameters intact in the Location header when responding with a redirect. The service_suffix removal check as written assumed that the server removed them. Handle both cases. Along with PR #5325, this fixes #5321. There are two new tests. The first already passed; the second previously failed.
258188dd	2020-01-09T10:09:35	Merge pull request #5340 from pks-t/pks/pack-zstream Refactor packfile code to use zstream abstraction
2dc7b5ef	2019-12-14T12:53:04	tests: pack: add missing asserts around `git_packbuilder_write`
0edc26c8	2019-12-13T18:54:13	pack: refactor streams to use `git_zstream` While we do have a `git_zstream` abstraction that encapsulates all the calls to zlib as well as its error handling, we do not use it in our pack file code. Refactor it to make the code a lot easier to understand.

f9985688

2020-02-18T15:17:45

azure: docker: detect errors when building images The build step for our Docker images currently succeeds even if building the Docker image fails due to missing && chains in the build script. Fix this by adding them in.

68bfacb1

2020-02-18T15:17:17

azure: remove unused Linux setup script Since migrating to Docker containings for our build and test infrastructure, we do not use the "setup-linux.sh" script anymore. Remove it to avoid any confusion.

ee3307a1

2020-02-08T17:34:53

Merge pull request #5392 from pks-t/pks/ci-warnings azure: fix misleading messages printed to stderr being

6a61a418

2020-02-08T17:32:51

Merge pull request #5393 from pks-t/pks/tests-iterator-missing-ref tests: iterator: fix iterator expecting too few items

26b71d60

2020-02-07T14:36:10

tests: iterator: fix iterator expecting too few items The testcase iterator::workdir::filesystem_gunk sets up quite a lot of directories, which is why it only runs in case GITTEST_INVASIVE_SPEED is set in the environment. Because we do not run our default CI with this variable, we didn't notice commit 852c83ee4 (refs: refuse to delete HEAD, 2020-01-15) breaking the test as it introduced a new reference to the "testrepo" repository. Fix the oversight by increasing the number of expected iterator items.

49bb4237

2020-02-07T14:04:07

azure: test: silence termination message when killing git-daemon(1) In order to properly tear down the test environment, we will kill git-daemon(1) if we've exercised it. As git-daemon(1) is spawned as a background process, it is still owned by the shell and thus killing it later on will print a termination message to the shell's stderr, causing Azure to report it as an error. Fix this by disowning the background process.

fb03f02a

2020-02-07T13:56:36

azure: docker: avoid re-creating libgit2 home directory The Docker entrypoint currently creates the libgit2 user with "useradd --create-home". As we start the Docker container with two volumes pointing into "/home/libgit2/", the home directory will already exist. While useradd(1) copes with this just fine, it will print error messages to stderr which end up as failures in our Azure pipelines. Fix this by simply removing the "--create-home" parameter.

52cb4040

2020-02-07T13:52:07

azure: test: silence curl to not cause Azure to trop Without the "--silent" parameter, curl will print a progress meter to stderr. Azure has the nice feature of interpreting any output to stderr as errors with a big red warning towards the end of the build. Let's thus silence curl to not generate any misleading messages.

a3ec07d7

2020-02-07T13:34:18

azure: docker: pipe downloaded archives into tar(1) directly When building dependencies for our Docker images, we first download the sources to disk first, unpack them and finally remove the archive again. This can be sped up by piping the downloading archive into tar(1) directly to parallelize both tasks. Furthermore, let's silence curl(1) to not print to status information to stderr, which tends to be interpreted as errors by Azure Pipelines.

03ac24b1

2020-02-07T11:36:36

Merge pull request #5387 from pks-t/pks/transport-http-custom-headers transports: http: fix custom headers not being applied

65ac33ae

2020-02-07T11:18:24

Merge pull request #5382 from libgit2/pks/azure-coverity azure: fix Coverity pipeline

46228d86

2020-02-06T11:10:27

transports: http: fix custom headers not being applied In commit b9c5b15a7 (http: use the new httpclient, 2019-12-22), the HTTP code got refactored to extract a generic HTTP client that operates independently of the Git protocol. Part of refactoring was the creation of a new `git_http_request` struct that encapsulates the generation of requests. Our Git-specific HTTP transport was converted to use that in `generate_request`, but during the process we forgot to set up custom headers for the `git_http_request` and as a result we do not send out these headers anymore. Fix the issue by correctly setting up the request's custom headers and add a test to verify we correctly send them.

86c54cc8

2020-02-04T11:51:56

azure: coverity: fix Coverity builds due to various issues There's several issues with our Coverity builds, like e.g. missing wget in our containers. Simplify our Coverity pipeline and fix these issues.

ccffea6b

2020-02-04T11:47:16

azure: coverity: convert to use self-built containers Back in commit 5a6740e7f (azure: build Docker images as part of the pipeline, 2019-08-02), we have converted our pipelines to use self-built Docker images to ease making changes to our Dockerfiles. The commit didn't adjust our Coverity pipeline, though, so let's do this now.

b4eb0282

2020-02-04T11:46:05

azure: coverity: fix invalid syntax for Docker image In commit bbc0b20bd (azure: fix Coverity's build due to wrong container name, 2019-08-02), Coverity builds were fixed to use the correct container names. Unfortunately, the "fix" completely broke our Coverity builds due to using wrong syntax for the Docker task. Let's fix this by using "imageName" instead of the Docker dict.

bd6b1c41

2020-02-06T06:14:20

Merge pull request #5381 from pks-t/pks/tests-flaky-proxy azure: tests: re-run flaky proxy tests

c51bd2f2

2020-02-04T12:15:56

azure: tests: reset FAILED status if flaky re-run succeeds While we already do have logic to re-run flaky tests, the FAILED variable currently does not get reset to "0". As a result, successful reruns will still cause the test to be registered as failed. Fix this by resetting the variable accordingly.

b33ad764

2020-02-04T11:26:57

azure: tests: re-run flaky proxy tests The proxy tests regularly fail in our CI environment. Unfortunately, this is expected due to the network layer. Thus, let's re-try the proxy tests up to five times in case they fail.

55975171

2020-02-01T09:03:00

Merge pull request #5373 from pks-t/pks/fetchhead-strip-creds fetchhead: strip credentials from remote URL

93a9044f

2020-01-31T08:49:34

fetchhead: strip credentials from remote URL If fetching from an anonymous remote via its URL, then the URL gets written into the FETCH_HEAD reference. This is mainly done to give valuable context to some commands, like for example git-merge(1), which will put the URL into the generated MERGE_MSG. As a result, what gets written into FETCH_HEAD may become public in some cases. This is especially important considering that URLs may contain credentials, e.g. when cloning 'https://foo:bar@example.com/repo' we persist the complete URL into FETCH_HEAD and put it without any kind of sanitization into the MERGE_MSG. This is obviously bad, as your login data has now just leaked as soon as you do git-push(1). When writing the URL into FETCH_HEAD, upstream git does strip credentials first. Let's do the same by trying to parse the remote URL as a "real" URL, removing any credentials and then re-formatting the URL. In case this fails, e.g. when it's a file path or not a valid URL, we just fall back to using the URL as-is without any sanitization. Add tests to verify our behaviour.

a1bff63b

2020-01-31T13:44:47

Merge pull request #5375 from pks-t/pks/test-ci azure-pipelines: properly expand negotiate passwords

7aa99dd3

2020-01-31T11:41:43

azure-pipelines: properly expand negotiate passwords To allow testing against a Kerberos instance, we have added variables for the Kerberos password to allow authentication against LIBGIT2.ORG in commit e5fb5fe5a (ci: perform SPNEGO tests, 2019-10-20). To set up the password, we assign "GITTEST_NEGOTIATE_PASSWORD=$(GITTEST_NEGOTIATE_PASSWORD)" in the environmentVariables section which is then passed through to a template. As the template does build-time expansion of the environment variables, it will expand the above line verbosely, and due to the envVar section not doing any further expansion the password variable will end up with the value "$(GITTEST_NEGOTIATE_PASSWORD)" in the container's environment. Fix this fixed by doing expansion of GITTEST_NEGOTIATE_PASSWORD at build-time, as well.

aa4cd778

2020-01-30T10:40:44

Merge pull request #5336 from libgit2/ethomson/credtype cred: change enum to git_credential_t and GIT_CREDENTIAL_*

f9b41a66

2020-01-30T10:30:12

Merge pull request #5371 from ayush-1506/julia_link Update link to libgit2 Julia language binding

103a76b4

2020-01-30T17:58:43

Update link to Julia libgit2

3f54ba8b

2020-01-18T13:51:40

credential: change git_cred to git_credential We avoid abbreviations where possible; rename git_cred to git_credential. In addition, we have standardized on a trailing `_t` for enum types, instead of using "type" in the name. So `git_credtype_t` has become `git_credential_t` and its members have become `GIT_CREDENTIAL` instead of `GIT_CREDTYPE`. Finally, the source and header files have been renamed to `credential` instead of `cred`. Keep previous name and values as deprecated, and include the new header files from the previous ones.

4383ab40

2020-01-24T15:32:09

Merge pull request #5365 from libgit2/ethomson/no_void Return int from non-free functions

a3126a72

2020-01-18T17:50:38

repository functions: return an int Stop returning a void for functions, future-proofing them to allow them to fail.

cb43274a

2020-01-18T17:42:52

index functions: return an int Stop returning a void for functions, future-proofing them to allow them to fail.

82154e58

2020-01-18T17:41:21

remote functions: return an int Stop returning a void for functions, future-proofing them to allow them to fail.

3351506a

2020-01-18T17:38:36

tree functions: return an int Stop returning a void for functions, future-proofing them to allow them to fail.

2e8c3b0b

2020-01-18T17:17:46

oid functions: return an int Stop returning a void for functions, future-proofing them to allow them to fail.

9893d376

2020-01-18T15:41:20

git_attr_cache_flush: return an int Stop returning a void for functions, future-proofing them to allow them to fail.

4cae9e71

2020-01-18T18:02:08

git_libgit2_version: return an int Stop returning a void for functions, future-proofing them to allow them to fail.

f78f6bd5

2020-01-18T18:00:39

error functions: return an int Stop returning a void for functions, future-proofing them to allow them to fail.

4b331f02

2020-01-18T17:56:05

revwalk functions: return an int Stop returning a void for functions, future-proofing them to allow them to fail.

82050fa1

2020-01-18T17:53:26

mempack functions: return an int Stop returning a void for functions, future-proofing them to allow them to fail.

4460bf40

2020-01-24T11:08:44

Merge pull request #5286 from libgit2/ethomson/gssapi HTTP: Support Apache-based servers with Negotiate

e9cef7c4

2020-01-11T23:53:45

http: introduce GIT_ERROR_HTTP Disambiguate between general network problems and HTTP problems in error codes.

7fd9b3f5

2020-01-01T20:48:15

ci: add NTLM tests Download poxygit, a debugging git server, and clone from it using NTLM, both IIS-style (with connection affinity) and Apache-style ("broken", requiring constant reauthentication).

29762e40

2020-01-01T16:14:37

httpclient: use defines for status codes

3e9ee04f

2019-12-29T18:46:44

trace: compare against an int value When tracing is disabled, don't let `git_trace__level` return a void, since that can't be compared against.

76fd406a

2019-12-26T16:37:01

http: send probe packets When we're authenticating with a connection-based authentication scheme (NTLM, Negotiate), we need to make sure that we're still connected between the initial GET where we did the authentication and the POST that we're about to send. Our keep-alive session may have not kept alive, but more likely, some servers do not authenticate the entire keep-alive connection and may have "forgotten" that we were authenticated, namely Apache and nginx. Send a "probe" packet, that is an HTTP POST request to the upload-pack or receive-pack endpoint, that consists of an empty git pkt ("0000"). If we're authenticated, we'll get a 200 back. If we're not, we'll get a 401 back, and then we'll resend that probe packet with the first step of our authentication (asking to start authentication with the given scheme). We expect _yet another_ 401 back, with the authentication challenge. Finally, we will send our authentication response with the actual POST data. This will allow us to authenticate without draining the POST data in the initial request that gets us a 401.

b9c5b15a

2019-12-22T14:12:24

http: use the new httpclient Untangle the notion of the http transport from the actual http implementation. The http transport now uses the httpclient.

bf55facf

2019-10-25T12:24:34

tests: allow users to use expect/continue

7372573b

2019-10-25T12:22:10

httpclient: support expect/continue Allow users to opt-in to expect/continue handling when sending a POST and we're authenticated with a "connection-based" authentication mechanism like NTLM or Negotiate. If the response is a 100, return to the caller (to allow them to post their body). If the response is *not* a 100, buffer the response for the caller. HTTP expect/continue is generally safe, but some legacy servers have not implemented it correctly. Require it to be opt-in.

6c21c989

2019-12-14T21:32:07

httpclient: support CONNECT proxies Fully support HTTP proxies, in particular CONNECT proxies, that allow us to speak TLS through a proxy.

6b208836

2019-12-18T21:55:28

httpclient: handle chunked responses Detect responses that are sent with Transfer-Encoding: chunked, and record that information so that we can consume the entire message body.

6a095679

2019-12-14T10:34:36

httpclient: support authentication Store the last-seen credential challenges (eg, all the 'WWW-Authenticate' headers in a response message). Given some credentials, find the best (first) challenge whose mechanism supports these credentials. (eg, 'Basic' supports username/password credentials, 'Negotiate' supports default credentials). Set up an authentication context for this mechanism and these credentials. Continue exchanging challenge/responses until we're authenticated.

0e39a8fa

2019-12-29T10:05:14

net: free the url's query component

0b8358c8

2019-12-14T11:04:58

net: introduce path formatting function Introduce a function to format the path and query string for a URL, suitable for creating an HTTP request.

1152f361

2019-12-13T18:37:19

httpclient: consume final chunk message When sending a new request, ensure that we got the entirety of the response body. Our caller may have decided that they were done reading. If we were not at the end of the message, this means that we need to tear down the connection and cannot do keep-alive. However, if the caller read all of the message, but we still have a final end-of-response chunk signifier (ie, "0\r\n\r\n") on the socket, then we should consider that the response was successfully copmleted. If we're asked to send a new request, try to read from the socket, just to clear out that end-of-chunk message, marking ourselves as disconnected on any errors.

dcd3b815

2019-12-13T15:28:57

tests: support CLAR_TRACE_LEVEL The CLAR_TRACE_LEVEL environment variable was supported when building with GIT_TRACE. Now we always build with GIT_TRACE, but that variable is not provided to tests. Simply support clar tracing always.

84b99a95

2019-12-12T13:53:43

httpclient: add chunk support to POST Teach httpclient how to support chunking when POSTing request bodies.

eacecebd

2019-12-12T13:25:32

httpclient: introduce a simple http implementation Introduce a new http client implementation that can GET and POST to remote URLs. Consumers can use `git_http_client_init` to create a new client, `git_http_client_send_request` to send a request to the remote server and `git_http_client_read_response` to read the response. The http client implementation will perform the I/O with the remote server (http or https) but does not understand the git smart transfer protocol. This allows us to split the concerns of the http subtransport from the actual http implementation.

a591f362

2019-12-09T19:48:10

net: introduce url formatting function

031e3e4c

2019-11-27T14:20:44

ci: don't do negotiate tests on windows We can't get a kerberos TGT easily on Windows; skip the negotiate tests.

fe4efe2e

2019-12-03T10:17:30

tests: test that clone returns 4321 This conditional was backwards. We should instead test that clone returns 4321, not that 4321 returns clone.

7e0f5a6a

2019-10-22T22:37:14

smart protocol: correct case in error messages

2d6a61bd

2019-10-22T09:52:31

gssapi: validate that we were requested Negotiate

e761df5c

2019-10-22T09:35:48

gssapi: dispose after completion for retry Disposal pattern; dispose on completion, allowing us to retry authentication, which may happen on web servers that close connection-based authenticated sessions (NTLM/SPNEGO) unexpectedly.

d68f2b1a

2019-12-06T18:22:58

buf: add consume_bytes Allow users to consume a buffer by the number of bytes, not just to an ending pointer.

e995f74e

2019-12-06T15:39:08

net: introduce git_net_url_joinpath Provide a mechanism to add a path and query string to an existing url so that we can easily append `/info/refs?...` type url segments to a url given to us by a user.

471daeea

2019-12-01T14:00:49

net: refactor gitno redirect handling Move the redirect handling into `git_net_url` for consistency.

297c61e4

2019-12-01T10:06:11

net: add an isvalid function (Also, mark all the declarations as extern.)

a194e17f

2019-11-27T18:43:36

winhttp: refactor request sending Clarify what it means to not send a length; this allows us to refactor requests further.

da9bc8ac

2019-11-27T23:42:16

ci: enable GSSAPI for Ubuntu builds

9b96adf3

2019-11-22T18:03:50

docker build: add krb5 libraries and command-line tools

89d1fc2a

2019-10-22T09:30:50

gssapi: show information about disabled GSSAPI When USE_GSSAPI=OFF, still show information about what SPNEGO is, even though it's disabled. This is for parity with other disabled features like SSH and debugpool that still show details about what is disabled.

5625892b

2019-09-20T12:06:11

gssapi: delete half-built security context so auth can continue

2174aa0a

2019-10-21T11:47:23

gssapi: correct incorrect case in error message

3f6fe054

2019-10-20T17:23:01

gssapi: protect GSS_ERROR macro The GSS_ERROR(x) macro may expand to `(x & value)` on some implementations, instead of `((x) & value)`. This is the case on macOS, which means that if we attempt to wrap an expression in that macro, like `a = b`, then that would expand to `(a = b & value)`. Since `&` has a higher precedence, this is not at all what we want, and will set our result code to an incorrect value. Evaluate the expression then test it with `GSS_ERROR` independently to avoid this.

73fe690d

2019-10-20T17:22:27

gssapi: protect against empty messages

e5fb5fe5

2019-10-20T17:19:01

ci: perform SPNEGO tests Attempt to obtain a Kerberos ticket from LIBGIT2.ORG and then clone the Negotiate-protected site at test.libgit2.org with that ticket.

9bcf10e9

2020-01-24T09:56:59

Merge pull request #5364 from libgit2/ethomson/typet internal types: change enums from `type_t` to `_t`

917ba762

2020-01-18T14:14:00

auth: update enum type name for consistency libgit2 does not use `type_t` suffixes as it's redundant; thus, rename `git_http_authtype_t` to `git_http_auth_t` for consistency.

b59c71d8

2020-01-18T14:11:01

iterator: update enum type name for consistency libgit2 does not use `type_t` suffixes as it's redundant; thus, rename `git_iterator_type_t` to `git_iterator_t` for consistency.

df3063ea

2020-01-18T14:04:44

rebase: update enum type name for consistency libgit2 does not use `type_t` suffixes as it's redundant; thus, rename `git_rebase_type_t` to `git_rebase_t` for consistency.

94beb3a3

2020-01-18T14:03:23

merge: update enum type name for consistency libgit2 does not use `type_t` suffixes as it's redundant; thus, rename `git_merge_diff_type_t` to `git_merge_diff_t` for consistency.

a76348ee

2020-01-17T08:38:00

Merge pull request #5358 from lrm29/git_merge_driver_source_repo_non_const merge: Return non-const git_repository from accessor method

1908884d

2020-01-17T08:34:30

Merge pull request #5361 from csware/no-return-freed_object Do not return free'd git_repository object on error

47ac1187

2020-01-17T08:32:37

Merge pull request #5360 from josharian/fix-5357 refs: refuse to delete HEAD

a129941a

2020-01-16T17:44:55

Merge pull request #5351 from pks-t/pks/index-map-macros index: replace map macros with inline functions

470a05d0

2020-01-16T17:53:50

Do not return free'd git_repository object on error Regression introduced in commit dde6d9c706bf1ecab545da55ab874a016587af1f. This issue causes lots of crashes in TortoiseGit. Signed-off-by: Sven Strickroth <email@cs-ware.de>

852c83ee

2020-01-15T13:31:21

refs: refuse to delete HEAD This requires adding a new symbolic ref to the testrepo fixture. Some of the existing tests attempt to delete HEAD, expecting a different failure. Introduce and use a non-HEAD symbolic ref instead. Adjust a few other tests as needed. Fixes #5357

dea5ce3d

2020-01-15T17:30:59

Merge pull request #5359 from tniessen/make-type-mismatch-errors-consistent Make type mismatch errors consistent

5e1b6eaf

2020-01-15T12:58:59

Make type mismatch errors consistent

1bddbd02

2020-01-15T10:30:00

merge: Return non-const git_repository from git_merge_driver_source_repo accessor.

7fc97eb3

2020-01-09T14:21:41

index: fix resizing index map twice on case-insensitive systems Depending on whether the index map is case-sensitive or insensitive, we need to call either `git_idxmap_icase_resize` or `git_idxmap_resize`. There are multiple locations where we thus use the following pattern: if (index->ignore_case && git_idxmap_icase_resize(map, length) < 0) return -1; else if (git_idxmap_resize(map, length) < 0) return -1; The funny thing is: on case-insensitive systems, we will try to resize the map twice in case where `git_idxmap_icase_resize()` doesn't error. While this will still use the correct hashing function as both map types use the same, this bug will at least cause us to resize the map twice in a row. Fix the issue by introducing a new function `index_map_resize` that handles case-sensitivity, similar to how `index_map_set` and `index_map_delete`. Convert all call sites where we were previously resizing the map to use that new function.

ab45887f

2020-01-09T14:15:02

index: replace map macros with inline functions Traditionally, our maps were mostly implemented via macros that had weird call semantics. This shows in our index code, where we have macros that insert into an index map case-sensitively or insensitively, as they still return error codes via an error parameter. This is unwieldy and, most importantly, not necessary anymore, due to the introduction of our high-level map API and removal of macros. Replace them with inlined functions to make code easier to read.

cc4f4cbe

2020-01-12T10:12:57

Merge pull request #5355 from pks-t/pks/win32-relative-symlink-across-dirs win32: fix relative symlinks pointing into dirs

d5482339

2020-01-10T11:13:25

Merge pull request #5354 from josharian/issue-5353 ntlm: prevent (spurious) compiler warnings

dbb6429c

2020-01-10T14:30:18

Merge pull request #5305 from kas-luthor/bugfix/multiple-auth Adds support for multiple SSH auth mechanisms being used sequentially

7d55bee6

2020-01-10T12:44:51

win32: fix relative symlinks pointing into dirs On Windows platforms, we need some logic to emulate symlink(3P) defined by POSIX. As unprivileged symlinks on Windows are a rather new feature, our current implementation is comparatively new and still has some rough edges in special cases. One such case is relative symlinks. While relative symlinks to files in the same directory work as expected, libgit2 currently fails to create reltaive symlinks pointing into other directories. This is due to the fact that we forgot to translate the Unix-style target path to Windows-style. Most importantly, we are currently not converting directory separators from "/" to "\". Fix the issue by calling `git_win32_path_canonicalize` on the target. Add a test that verifies our ability to create such relative links across directories.

9181e4b5

2020-01-10T12:02:10

Merge pull request #5339 from josharian/issue-5321 netops: handle intact query parameters in service_suffix removal

93def7ad

2020-01-09T13:37:18

ntlm: prevent (spurious) compiler warnings Pull in commit https://github.com/ethomson/ntlmclient/commit/e7b2583e1bc28c33c43854e7c318e859b4e83bef to fix #5353.

7142964f

2019-12-13T10:56:19

netops: handle intact query parameters in service_suffix removal Some servers leave the query parameters intact in the Location header when responding with a redirect. The service_suffix removal check as written assumed that the server removed them. Handle both cases. Along with PR #5325, this fixes #5321. There are two new tests. The first already passed; the second previously failed.

258188dd

2020-01-09T10:09:35

Merge pull request #5340 from pks-t/pks/pack-zstream Refactor packfile code to use zstream abstraction

2dc7b5ef

2019-12-14T12:53:04

tests: pack: add missing asserts around `git_packbuilder_write`

0edc26c8

2019-12-13T18:54:13

pack: refactor streams to use `git_zstream` While we do have a `git_zstream` abstraction that encapsulates all the calls to zlib as well as its error handling, we do not use it in our pack file code. Refactor it to make the code a lot easier to understand.

thodg/libgit2

Log