kmx git

Commit	Date	Message
c8c59a21	2022-04-20T08:58:58	Fix a -Wshadow warning
c37090f9	2022-04-18T12:30:08	wayland: Add support for TOOLTIP/POPUP_MENU
13393a1c	2022-04-15T14:28:07	video: Wayland: Clamp fullscreen window dimensions to desktop A scaled fullscreen window may exceed the bounds of the desktop. Clamp the window size to the desktop dimensions in fullscreen mode.
c2093fab	2022-04-08T13:58:45	video: wayland: Set the surface damage region when using fullscreen viewports When using emulated display modes, the output size is often larger than the drawable buffer. As the surface damage region is automatically calculated from the smaller drawable buffer size, the damage region needs to be manually set to cover the entire viewport region or visual repaint artifacts can result.
d1f7f9e3	2022-04-06T11:18:46	wayland: Pin the fake window position at (0, 0). I kind of thought it'd be nice to have it in the center, but this is an issue for applications that still assume global mouse and window positions are accessible. For example, this fixes cursor offset issues in UE5.
279aeb59	2022-04-06T01:32:57	wayland: Add a bug link for the detach FIXME
3ada694e	2022-04-06T01:18:03	wayland: Try to detach at the beginning of ShowWindow, just in case. It's possible that an external component (probably a GL/VK context) committed, so we need to cover our bases and detach in both HideWindow and ShowWindow. Fixes a crash in UE5 editor's pop-ups.
dcfb7fff	2022-04-06T00:55:32	wayland: Evaluate WINDOWPOS_CENTERED_DISPLAY for move events Partially fixes the mouse cursor in UE5 editor. Imperfect because UE5 uses window position and global mouse state to get position, but of course we don't have global mouse and this is just to get the right display index so this still fails overall. We really need to make global mouse support a feature query...
4d1905c9	2022-03-29T13:34:14	video: wayland: Use viewports for non-fullscreen windows with fractional scaling Use viewports for non-fullscreen windows when the desktop uses fractional scaling and the window is flagged as DPI-aware to provide a backbuffer mapped as close to 1:1 output as possible. In the cases of odd window sizes the backbuffer may be a pixel off of scaling perfectly into the window size due to its scaled size being rounded off, but a minute amount of scaling during output is likely preferable to the large amounts of overdraw needed with integer scaled buffers.
fa4c5198	2022-03-28T21:32:30	video: wayland: Expose more resolutions for mode emulation Expose as many emulated display modes as possible. They will currently display stretched to the display's native desktop aspect, but if an application requires a hardcoded resolution, it will work at minimum. Aside from the change in the emulated display mode list, the Wayland event handling code had to be updated to support separate scaling for the x and y axes, as square pixels are no longer guaranteed.
4d76c9cb	2022-03-25T20:35:07	video: wayland: Use wp-viewporter for fullscreen with non-native resolutions Wayland doesn't support mode switching, however Wayland compositors can support the wp_viewporter protocol, which allows for the mapping of arbitrarily sized buffer regions to output surfaces. Use this functionality, when available, for fullscreen output when using non-native display modes and/or when dealing with scaled desktops, which can incur significant overdraw without this extension. This also allows for the exposure of arbitrarily sized, emulated display modes, which can be useful for legacy compatability.
b4d28085	2022-03-24T18:30:32	wayland: Don't overwrite error message from SDL_EGL_CreateSurface SDL_EGL_CreateSurface sets a more specific error message, so overwriting it would lose information. Signed-off-by: Simon McVittie <smcv@collabora.com>
77a9ca6b	2022-01-26T18:26:07	wayland: Fix SDL_SetWindowSize() being dropped right after exiting fullscreen If we get a SDL_SetWindowSize() call right after SDL_SetWindowFullscreen() but before we've gotten a new configure event from the compositor, the attempt to set our window size will silently fail (when libdecor is enabled). Fix this by remembering that we need to commit a new size, so we can do that in decoration_frame_configure().
68a71f91	2022-01-25T11:18:04	wayland: Try to avoid committing before the window is shown
f0e768da	2022-01-25T13:07:00	wayland: Call SetFullscreen directly in ShowWindow. This cuts out an extra flush when getting the first configure event.
e2d74bcb	2022-01-25T11:16:09	wayland: Detach hidden surfaces in HideWindow, not ShowWindow
e1b4761c	2022-01-20T14:10:56	wayland: Avoid calling SetFullscreen in libdecor ShowWindow. This caused some weird stuff to happen in the libdecor path, probably because the window hasn't actually been mapped yet. It ends up calling stuff that should not yet apply, and so fullscreen in particular would have a really messed up titlebar. The good news is, libdecor is good about tracking fullscreen state, so we can let the callback do this for us. Keep this for xdg_shell because we actually map the window ourselves, so we know this call is valid for that path.
ed3442d7	2022-01-19T15:47:52	wayland: Fix building with SDL_OPENGL=OFF
d3952a8a	2022-01-16T15:14:33	wayland: Avoid spurious resize events
120c76c8	2022-01-03T09:40:00	Updated copyright for 2022
4c9966ee	2021-12-16T10:22:27	wayland: Add a note for why we check 0,0 for fullscreen configurations
a709b5b6	2021-12-04T14:14:47	video: wayland: Handle 0x0 xdg_toplevel_configure in fullscreen The xdg_shell spec seems to state[1] that xdg_toplevel_configure events can always provide a 0×0 width/height to signal that the compositor doesn't care. SDL previously assumed the provided width/height was always valid for fullscreen windows, and so applied it as-is. This broke SDL applications on KDE/KWin 5.23, which now sends 0×0 configure events (and, in 5.23.3, 1×1 events for some reason), breaking all SDL applications in fullscreen[2]. [1]: https://gitlab.freedesktop.org/wayland/wayland-protocols/-/issues/6 [2]: https://bugs.kde.org/show_bug.cgi?id=444962#c6
63ae103c	2021-11-11T13:16:34	wayland: QTWAYLAND_CONTENT_ORIENTATION can support multiple values as bitmasks
ae67c7d2	2021-11-09T01:30:00	Implemented SDL_SetWindowMouseRect() on Wayland
ad520573	2021-10-06T09:52:06	wayland: Only dispatch frame events in Wayland_GLES_SwapWindow Dispatching all events in Wayland_GLES_SwapWindow leads to resizes being acked before the program has a chance to handle the resize. This change reduces jumping on fullscreen transition with apps that call SDL_PollEvent before issuing any render calls.
9672d581	2021-09-26T14:22:11	Need to check structure version before setting xdg_toplevel to NULL
b592e78f	2021-09-25T12:55:41	wayland: Expose xdg_toplevel to SysWM
ae7ee2a5	2021-08-11T09:59:43	wayland: Ignore stateless/sizeless configs when starting in fullscreen mode
7be970db	2021-08-06T19:51:27	wayland: Avoid setting floating width/height when re-entering fullscreen
10979d37	2021-08-05T12:42:03	wayland: Always assume configure is wrong for non-resizable windows. Configure events from compositors have an extremely annoying habit of giving us completely bogus sizes, from all sorts of places. Thankfully, the protocol gives us the ability to completely ignore the width/height and just stick with what we know, so for all windows that are not meant to be resized, pretend we never even got the width/height at all, the compositor is required to respect our dimensions whether they match configure's suggestion or not.
32f909f7	2021-08-03T13:30:57	wayland: Remove redundant waylanddyn.h includes. All files including waylanddyn.h already include waylandvideo.h first.
7082fb04	2021-08-02T22:42:28	wayland: Only dispatch on fullscreen set when the window is visible. Fixes hang-on-startup described in #4572.
0f5b8a99	2021-08-02T19:48:31	wayland: For libdecor, dispatch immediately after setting fullscreen Reference: #4578
4562da62	2021-08-02T16:40:56	wayland: Make libdecor configure match xdg_toplevel
1fb1aa19	2021-08-02T12:57:28	wayland: Keep the fullscreen check for maximize/restore events
584673a5	2021-08-02T12:51:23	wayland: Don't ignore configs for non-fullscreen, non-resizable windows. This was causing configure events to not inform SDL of window size changes, even when they were based on resizes that we fully expected. The result was fullscreen->windowed not working at all, because it would retain the desktop resolution instead of reverting to the floating size that it had before moving to fullscreen mode. Fixes Super Hexagon fullscreen toggling.
25067298	2021-08-02T08:15:10	wayland: Flush in SetWindowFullscreen The flush has been removed in e5f9fae034df8ca305241c5a666e7702fcf9958f. Unfortunately, even though ideally the flush shouldn't be necessary, our resize sequence isn't... well, perfect, and removing that flush causes tons of troubles. We're also still flushing in other paths where the window size can be changed by the compositor and where we may potentially have to obey that change, like in Wayland_MaximizeWindow. This also removes the hack introduced in 7f261d3b7667978ced93a4fdc6aec2380df3d87f, which introduces problems with protocol violations and seems to not be necessary when flushing.
ea28187c	2021-08-02T08:07:23	wayland: Hack surface resize into compliance with set_window_geometry We have issues with correct resize sequence and happen to commit old-sized buffers even after configure event for the new size has been already acknowledged. While the reason for that stays unknown, let's at least workaround the problem by faking window geometry into expected size. This does not fix visual glitch on e.g. fullscreen toggling, but having a split-second glitch is still a much better outcome than being terminated by the compositor for protocol violation.
b5210cac	2021-08-02T13:47:32	wayland: Initialize floating size at window creation This allows the windowed size to be restored for windows initially created already in non-floating state.
dab33844	2021-08-02T11:58:47	wayland: Fix a warning in handle_configure_xdg_toplevel
754aa2d3	2021-08-02T11:55:02	Mostly revert cfcdfb7be9f5c97a51ddef9ad3677a604856266b. This was causing window changes to completely break, resulting in broken decorations and bizarre frame timing, I don't know what exactly it's doing but it's not good. Kept the libdecor_frame_is_floating logic, at least.
8803589f	2021-08-02T12:05:06	wayland: Avoid redundant SetWindowBordered for libdecor
b4c4060a	2021-08-02T04:52:25	wayland: Clean up Wayland_HandlePendingResize Commit 871c11191bfc7214061a3da37c112522a102ddf5 removed delayed resize handling, but it left the whole structure untouched that now became unnecessary. To help with code clarity, get rid of the structure where pending resize state used to be stored and pass all the data directly to Wayland_HandlePendingResize (now renamed to Wayland_HandleResize, since it's not "pending" anymore but applied immediately)
9bb24ad0	2021-08-02T05:49:35	wayland: Always call Wayland_SetWindowBordered when showing the window Otherwise our windows have no window decoration on compositors that support xdg-decoration-unstable-v1, but default to client-side mode. Contrary to what the comment was stating, there is nothing in the protocol that would make redundant calls to zxdg_toplevel_decoration_v1::set_mode problematic.
cfcdfb7b	2021-08-01T18:14:53	libdecor: use same fullscreen/maximised restore logic as for xdg-toplevel
42452f8c	2021-08-01T13:51:30	wayland: store and restore floating states Some Wayland compositors send (0,0) as "suggested" configure event sizes to indicate that the client has to decide on its own which sizes to used. This is commonly done when restoring from maximised, fullscreen or tiles states to fullscreen. We now store the last known floating states in a new set of variables and restore them when we receive such a (0,0) configure event.
71897cc1	2021-07-30T15:51:43	wayland: Always trigger a resize when handling a configure event. When we removed the OpenGL resize workaround it introduced a problem for fullscreen windows in particular: When leaving fullscreen we tried to send a resize event, but UpdateFullscreenMode would send a SIZE_CHANGED immediately after, deleting our resize event and causing the following configure event's resize to be ignored. This timing issue resulted in fullscreen windows not being resized at all when becoming a floating window. By always forcing resize events from configure events, we ensure that RESIZED always makes it through. SetWindowSize-type changes should be unaffected as they do not fire configure events.
c20ab7da	2021-07-30T00:22:50	wayland: Fix GetWindowWMInfo for <2.0.15
f20a8581	2021-07-29T00:13:17	commit after setting/unsetting limits
ad310d39	2021-07-28T12:31:25	wayland: libdecor support for SetWindowModalFor
93976ade	2021-07-28T12:22:09	wayland: libdecor support for GetWindowWMInfo
21cba924	2021-07-28T16:54:23	wayland: Don't create zxdg toplevel decoration twice Each window can have at most one zxdg toplevel decoration, but as of [1], we accidentally create two. (If libdecor is not in use). This causes wayland windows with server-side decorations (e.g. on KDE/KWin) to crash with the message: zxdg_decoration_manager_v1@7: error 1: decoration has been already constructed This extra zxdg_decoration_manager_v1.get_toplevel_decoration() call was introduced while deprecating wl-shell and xdg-shell-stable[1] support, and possibly was a bad interaction with [2], which moved the decoration creation around. Fixes: 6aae5b44f8 ("Remove wl-shell and xdg-shell-unstable-v6 support (#4323)") [1]: https://github.com/libsdl-org/SDL/pull/4323 [2]: https://github.com/libsdl-org/SDL/pull/4374
7b239edb	2021-07-28T01:00:00	wayland: Assign frame_callback on window creation. Fixes a crash when creating and destroying a window without calling SwapWindow.
03185e74	2021-07-27T18:35:00	wayland: Tag/Check wl_output objects as well, fixes crashes when libdecor is in use
871c1119	2021-07-27T18:24:09	wayland: handle pending resizes immediately, not on SwapWindow. This was originally a workaround for an old Mesa bug, since fixed, apparently, and causes other problems. Fixes #4326.
a3eb297e	2021-07-27T17:17:19	wayland: Rework enter/leave and update_scale_factor to avoid bogus wl_output data. Also remove get_window_scale_factor() which was just pointless indirection.
6aae5b44	2021-07-27T17:12:26	Remove wl-shell and xdg-shell-unstable-v6 support (#4323) * wayland-protocol: update wayland.xml to 1.19.0 * wayland: remove shell_surface field from SDL_SysWMinfo * wayland: remove wl_shell support * waypand-protocols: update xdg-shell.xml to 1.20 * wayland: remove xdg-shell-unstable-v6 support * wayland: deprecate wl shell surface syswm info, add xdg surface
ac904b8e	2021-06-21T01:25:25	wayland: ignore resize in fullscreen or maximised mode
ee062c64	2021-05-19T00:13:39	wayland: implement toggling decorations
2b3cf36f	2021-05-22T00:49:10	wayland: forward window events
48066984	2021-04-05T14:09:03	wayland: enable/disable ACTION_RESIZE for fullscreen
9e6fcbe7	2020-06-11T22:10:28	wayland: client-side decoration
e5f9fae0	2021-05-16T23:19:45	wayland: don't flush after setting fullscreen
f1633127	2021-07-24T13:41:55	Added a window flash operation to be explicit about window flash behavior
e1c3a250	2021-07-24T12:11:27	Changed SDL_FlashWindow() so it doesn't take a flash count, and added the hint SDL_HINT_WINDOW_FLASH_COUNT to control behavior on Windows
4ada14a2	2021-07-21T13:39:10	Replace libc functions to SDL equivalent in wayland video subsystem Wayland video subsystem uses a mix of libc and SDL function. This patch switches libc functions to SDL ones and fixes a mismatch in memory allocation/dealoccation of SDL_Cursor in SDL_waylandmouse.c (calloc on line 201 and SDL_free on line 313) which caused memory corruption if custom memory allocator where provided to SDL.
7f261d3b	2021-06-15T00:35:13	wayland: Fix returning to a window from fullscreen without calling SetWindowSize
d956636c	2021-06-04T18:39:47	wayland: Implement FlashWindow
2af3f64e	2021-06-02T14:37:09	wayland: Activate the window on first ShowWindow, if possible
151f9538	2021-06-02T11:41:44	wayland: Implement RaiseWindow with xdg-activation
d3244035	2021-05-17T01:24:35	wayland: Add support for maximized/restored events
f2f451a5	2021-05-10T13:29:54	wayland: Call SetWindowBordered at the end of ShowWindow
efbb6ff9	2021-05-10T12:42:28	wayland: Create the server decorations after the toplevel has been configured
c69fde34	2021-05-02T16:43:01	wayland: Maximize/Restore should set the relevant window flags. Also, Maximize should be ignored for fixed-size windows.
006378b9	2021-05-02T18:30:32	fix NULL frame_callback access
424bbaec	2021-05-01T18:53:12	wayland: destroy frame callback when window is destroyed
20928550	2021-05-01T09:00:24	wayland: Guard surface_frame_listener for OpenGL, document why it exists
c54c16d3	2021-04-30T13:19:36	wayland: don't hang in SDL_GL_SwapBuffers if the compositor is ghosting us. If you hide a window on Mutter, for example, the compositor never requests new frames, which will cause Mesa to block forever in eglSwapBuffers to satisfy the swap interval. We now always set the swap interval to 0 and manage this ourselves, handing the frame to Wayland when it requests a new one, and timing out at 10fps just to keep apps moving if the compositor wants no frames at all. My understanding is that other protocols are coming that might improve upon this solution, but for now it solves the total hang. Fixes #4335.
8e3ec34d	2021-04-20T12:40:40	wayland: Refactor toplevel mapping, implement HideWindow
fcbfe33c	2021-04-18T09:45:22	wayland: Implement SetWindowModalFor
213bfc19	2021-04-18T09:36:54	wayland: Implement RestoreWindow for xdg/zxdg
ed24c345	2021-04-16T21:35:50	wayland: Implement basic window move events via wl_surface_listener. This unearthed an unspeakably large amount of bugs in the wl_output enumerator, notably the fact that the wl_output user pointer was to temporary memory! This was "fixed" in e862856, and was then pointed out as a leak in 4183211, which was undone in d9ba204. The busted fix was correct that the malloc was an issue, but wrong about _why_; SDL_AddVideoDisplay copies by value and does not reuse the pointer, so generally you want your VideoDisplay to be on the stack, but of course the callbacks don't allow that, so a malloc was a workaround. But we can do better and just host our temporary display inside WaylandOutputData because that will be persistent while also not leaking. Wait, wasn't I talking about move events? Right, that: wl_surface_listener does at least give us the ability to know what monitor we're on, even though we have no idea where we are on the monitor. All we need to do is check the wl_output against the display list and then push a move event that both indicates the correct display while also not being _too_ much of a lie (but enough of a lie to where our event doesn't get discarded as "undefined" or whatever). The index check for the video display is what spawned the great nightmare you see before you; aside from the bugfix this is actually a really basic patch.
f6a09ef1	2021-04-07T16:16:23	wayland: Drop support for kwin specific decoration management KWin has supported the shared and formalised zxdg_decoration since Plasma 5.16 which came out mid 2019. Whilst it made sense to support them both for a while, it should not be needed for future SDL releases.
a92cca1a	2021-04-07T16:44:10	wayland: Use the window's display to get wl_output rather than fullscreen_mode. Because Wayland only supports FULLSCREEN_DESKTOP, fullscreen_mode never gets assigned at all, meaning driverdata is always NULL! Depending on what the compositor does this can lead to dramatically different results. GNOME was fine without this, but Plasma would trip an event that unintentionally unset the fullscreen mode and caused the game to fire a configure event _every frame_, and of course the configure would send the fullscreen_mode output which was still empty. The fix is to just use the SDL_VideoDisplay directly, which will always have a valid wl_output.
c7e29a9e	2021-04-06T18:10:40	wayland: Fix toggling fullscreen with fixed-size windows
57a927e8	2021-02-12T14:27:58	wayland: Explicitly set min/max size for xdg-shell
a99eec77	2021-02-12T14:31:43	wayland: Minor whitespace fix
e862856e	2021-02-01T08:57:39	wayland: Don't crash when the properties of already existing wl_output change
0ed16ced	2021-01-31T19:10:02	free 'outputs' in 'Wayland_DestroyWindow'
a0d3c6c6	2021-01-25T21:42:14	Rename SetWindowGrab() to SetWindowMouseGrab()
e1f73e64	2021-01-23T16:22:44	Refactor keyboard grab to be managed by the video core This gives us flexibility to add others hints to control keyboard grab behavior without having to touch all of the backends. It also allows us to possibly expose keyboard grab separately from mouse grab for applications that want to manage those independently.
e787282b	2021-01-23T15:40:22	Implement Wayland_SetWindowResizable
bd553ea8	2021-01-20T21:17:20	Implement support for inhibiting the screensaver on Wayland We support both the org.freedesktop.ScreenSaver D-Bus API (same as the X11 backend) and the Wayland idle_inhibit_unstable_v1 protocol. Some Wayland compositors only support one or the other, so we need both to for broad compatibility.
19236b46	2021-01-21T21:49:13	Implement support for minimizing windows on Wayland This required a bit of extra code to deal with the transition from minimized back to fullscreen
d789ba83	2021-01-19T18:20:07	Implement keyboard grab support for Wayland Use zwp_keyboard_shortcuts_inhibit_manager_v1 to allow SDL applications to capture system keyboard shortcuts like Alt+Tab when keyboard grab is enabled via SDL_HINT_GRAB_KEYBOARD.
6a342954	2021-01-14T14:42:53	Fixed bug 5451 - Can't create EGLSurface in Wayland from SDLWindow (no EGLNativeWindow pointer) sashikknox In some cases, need create EGLWindow with SDLWindow. In X11 i can get pointer to NativeWindow from struct SDL_SysWMinfo wmInfo ```C++ struct SDL_SysWMinfo wmInfo; SDL_GetWindowWMInfo(ptSDLWindow, &wmInfo) #if defined(__unix__) && defined(SDL_VIDEO_DRIVER_X11) nativeWindow=(EGLNativeWindowType)wmInfo.info.x11.window; nativeDisplay=(EGLNativeDisplayType)wmInfo.info.x11.display; #endif ``` than i can create EGLSurface ``` eglCreateWindowSurface(nativeDisplay, EGL_CONFIG, nativeWindow, SURFACE_ATTRIBUTES); ``` in Wayland i can do it with same way, just need pointer to EGLWindow, we already have pointer to wl_display from SDL_sysWMInfo, need add to wl struct in SDL_SysWMInfo another pointer to *struct wl_egl_window egl_window;. And in wayland backend, in function Wayland_GetWindowWMInfo return pointer to egl_window from SDL_WindowData** Now i use patched statically built SDL2 in port of Quake 2 GLES2 for SailfishOS (it use QtWayland): link to SDL2 commit and changed string for patch: - https://github.com/savegame/lp-public/commit/6858a618cd179b766fe3cab36055f07cb03ad0ea - https://github.com/savegame/lp-public/blob/b1e29e87b9d15780e47f04918b329ac15554fc69/SDL2/src/video/wayland/SDL_waylandwindow.c#L463 link to use in Quake2 port: 1. here i get pointer to EGLNativeWindowType: https://github.com/savegame/lp-public/blob/6d94fedb1b720da24999ae6286a1809cd3d55ff5/Engine/Sources/Compatibility/OpenGLES/EGLWrapper.c#L319 2. then use it for create EGLSurface: https://github.com/savegame/lp-public/blob/6d94fedb1b720da24999ae6286a1809cd3d55ff5/Engine/Sources/Compatibility/OpenGLES/EGLWrapper.c#L391
9130f7c3	2021-01-02T10:25:38	Updated copyright for 2021
958c4282	2020-06-04T09:13:49	Fixed build warning
aa259ed5	2020-05-28T15:18:41	wayland: Changed output removal in handle_surface_leave() No longer needs an extra malloc, handles unexpected cases like the same output being listed twice.
0eb6512b	2020-05-04T13:19:26	Fixed bug 5121 - Use SDL_calloc instead of calloc in Wayland_CreateWindow meyraud705 'SDL_Windows::driverdata' of a Wayland window is allocated by calloc in 'Wayland_CreateWindow' but freed by SDL_free in 'Wayland_DestroyWindow'.

c8c59a21

2022-04-20T08:58:58

Fix a -Wshadow warning

c37090f9

2022-04-18T12:30:08

wayland: Add support for TOOLTIP/POPUP_MENU

13393a1c

2022-04-15T14:28:07

video: Wayland: Clamp fullscreen window dimensions to desktop A scaled fullscreen window may exceed the bounds of the desktop. Clamp the window size to the desktop dimensions in fullscreen mode.

c2093fab

2022-04-08T13:58:45

video: wayland: Set the surface damage region when using fullscreen viewports When using emulated display modes, the output size is often larger than the drawable buffer. As the surface damage region is automatically calculated from the smaller drawable buffer size, the damage region needs to be manually set to cover the entire viewport region or visual repaint artifacts can result.

d1f7f9e3

2022-04-06T11:18:46

wayland: Pin the fake window position at (0, 0). I kind of thought it'd be nice to have it in the center, but this is an issue for applications that still assume global mouse and window positions are accessible. For example, this fixes cursor offset issues in UE5.

279aeb59

2022-04-06T01:32:57

wayland: Add a bug link for the detach FIXME

3ada694e

2022-04-06T01:18:03

wayland: Try to detach at the beginning of ShowWindow, just in case. It's possible that an external component (probably a GL/VK context) committed, so we need to cover our bases and detach in both HideWindow and ShowWindow. Fixes a crash in UE5 editor's pop-ups.

dcfb7fff

2022-04-06T00:55:32

wayland: Evaluate WINDOWPOS_CENTERED_DISPLAY for move events Partially fixes the mouse cursor in UE5 editor. Imperfect because UE5 uses window position and global mouse state to get position, but of course we don't have global mouse and this is just to get the right display index so this still fails overall. We really need to make global mouse support a feature query...

4d1905c9

2022-03-29T13:34:14

video: wayland: Use viewports for non-fullscreen windows with fractional scaling Use viewports for non-fullscreen windows when the desktop uses fractional scaling and the window is flagged as DPI-aware to provide a backbuffer mapped as close to 1:1 output as possible. In the cases of odd window sizes the backbuffer may be a pixel off of scaling perfectly into the window size due to its scaled size being rounded off, but a minute amount of scaling during output is likely preferable to the large amounts of overdraw needed with integer scaled buffers.

fa4c5198

2022-03-28T21:32:30

video: wayland: Expose more resolutions for mode emulation Expose as many emulated display modes as possible. They will currently display stretched to the display's native desktop aspect, but if an application requires a hardcoded resolution, it will work at minimum. Aside from the change in the emulated display mode list, the Wayland event handling code had to be updated to support separate scaling for the x and y axes, as square pixels are no longer guaranteed.

4d76c9cb

2022-03-25T20:35:07

video: wayland: Use wp-viewporter for fullscreen with non-native resolutions Wayland doesn't support mode switching, however Wayland compositors can support the wp_viewporter protocol, which allows for the mapping of arbitrarily sized buffer regions to output surfaces. Use this functionality, when available, for fullscreen output when using non-native display modes and/or when dealing with scaled desktops, which can incur significant overdraw without this extension. This also allows for the exposure of arbitrarily sized, emulated display modes, which can be useful for legacy compatability.

b4d28085

2022-03-24T18:30:32

wayland: Don't overwrite error message from SDL_EGL_CreateSurface SDL_EGL_CreateSurface sets a more specific error message, so overwriting it would lose information. Signed-off-by: Simon McVittie <smcv@collabora.com>

77a9ca6b

2022-01-26T18:26:07

wayland: Fix SDL_SetWindowSize() being dropped right after exiting fullscreen If we get a SDL_SetWindowSize() call right after SDL_SetWindowFullscreen() but before we've gotten a new configure event from the compositor, the attempt to set our window size will silently fail (when libdecor is enabled). Fix this by remembering that we need to commit a new size, so we can do that in decoration_frame_configure().

68a71f91

2022-01-25T11:18:04

wayland: Try to avoid committing before the window is shown

f0e768da

2022-01-25T13:07:00

wayland: Call SetFullscreen directly in ShowWindow. This cuts out an extra flush when getting the first configure event.

e2d74bcb

2022-01-25T11:16:09

wayland: Detach hidden surfaces in HideWindow, not ShowWindow

e1b4761c

2022-01-20T14:10:56

wayland: Avoid calling SetFullscreen in libdecor ShowWindow. This caused some weird stuff to happen in the libdecor path, probably because the window hasn't actually been mapped yet. It ends up calling stuff that should not yet apply, and so fullscreen in particular would have a really messed up titlebar. The good news is, libdecor is good about tracking fullscreen state, so we can let the callback do this for us. Keep this for xdg_shell because we actually map the window ourselves, so we know this call is valid for that path.

ed3442d7

2022-01-19T15:47:52

wayland: Fix building with SDL_OPENGL=OFF

d3952a8a

2022-01-16T15:14:33

wayland: Avoid spurious resize events

120c76c8

2022-01-03T09:40:00

Updated copyright for 2022

4c9966ee

2021-12-16T10:22:27

wayland: Add a note for why we check 0,0 for fullscreen configurations

a709b5b6

2021-12-04T14:14:47

video: wayland: Handle 0x0 xdg_toplevel_configure in fullscreen The xdg_shell spec seems to state[1] that xdg_toplevel_configure events can always provide a 0×0 width/height to signal that the compositor doesn't care. SDL previously assumed the provided width/height was always valid for fullscreen windows, and so applied it as-is. This broke SDL applications on KDE/KWin 5.23, which now sends 0×0 configure events (and, in 5.23.3, 1×1 events for some reason), breaking all SDL applications in fullscreen[2]. [1]: https://gitlab.freedesktop.org/wayland/wayland-protocols/-/issues/6 [2]: https://bugs.kde.org/show_bug.cgi?id=444962#c6

63ae103c

2021-11-11T13:16:34

wayland: QTWAYLAND_CONTENT_ORIENTATION can support multiple values as bitmasks

ae67c7d2

2021-11-09T01:30:00

Implemented SDL_SetWindowMouseRect() on Wayland

ad520573

2021-10-06T09:52:06

wayland: Only dispatch frame events in Wayland_GLES_SwapWindow Dispatching all events in Wayland_GLES_SwapWindow leads to resizes being acked before the program has a chance to handle the resize. This change reduces jumping on fullscreen transition with apps that call SDL_PollEvent before issuing any render calls.

9672d581

2021-09-26T14:22:11

Need to check structure version before setting xdg_toplevel to NULL

b592e78f

2021-09-25T12:55:41

wayland: Expose xdg_toplevel to SysWM

ae7ee2a5

2021-08-11T09:59:43

wayland: Ignore stateless/sizeless configs when starting in fullscreen mode

7be970db

2021-08-06T19:51:27

wayland: Avoid setting floating width/height when re-entering fullscreen

10979d37

2021-08-05T12:42:03

wayland: Always assume configure is wrong for non-resizable windows. Configure events from compositors have an extremely annoying habit of giving us completely bogus sizes, from all sorts of places. Thankfully, the protocol gives us the ability to completely ignore the width/height and just stick with what we know, so for all windows that are not meant to be resized, pretend we never even got the width/height at all, the compositor is required to respect our dimensions whether they match configure's suggestion or not.

32f909f7

2021-08-03T13:30:57

wayland: Remove redundant waylanddyn.h includes. All files including waylanddyn.h already include waylandvideo.h first.

7082fb04

2021-08-02T22:42:28

wayland: Only dispatch on fullscreen set when the window is visible. Fixes hang-on-startup described in #4572.

0f5b8a99

2021-08-02T19:48:31

wayland: For libdecor, dispatch immediately after setting fullscreen Reference: #4578

4562da62

2021-08-02T16:40:56

wayland: Make libdecor configure match xdg_toplevel

1fb1aa19

2021-08-02T12:57:28

wayland: Keep the fullscreen check for maximize/restore events

584673a5

2021-08-02T12:51:23

wayland: Don't ignore configs for non-fullscreen, non-resizable windows. This was causing configure events to not inform SDL of window size changes, even when they were based on resizes that we fully expected. The result was fullscreen->windowed not working at all, because it would retain the desktop resolution instead of reverting to the floating size that it had before moving to fullscreen mode. Fixes Super Hexagon fullscreen toggling.

25067298

2021-08-02T08:15:10

wayland: Flush in SetWindowFullscreen The flush has been removed in e5f9fae034df8ca305241c5a666e7702fcf9958f. Unfortunately, even though ideally the flush shouldn't be necessary, our resize sequence isn't... well, perfect, and removing that flush causes tons of troubles. We're also still flushing in other paths where the window size can be changed by the compositor and where we may potentially have to obey that change, like in Wayland_MaximizeWindow. This also removes the hack introduced in 7f261d3b7667978ced93a4fdc6aec2380df3d87f, which introduces problems with protocol violations and seems to not be necessary when flushing.

ea28187c

2021-08-02T08:07:23

wayland: Hack surface resize into compliance with set_window_geometry We have issues with correct resize sequence and happen to commit old-sized buffers even after configure event for the new size has been already acknowledged. While the reason for that stays unknown, let's at least workaround the problem by faking window geometry into expected size. This does not fix visual glitch on e.g. fullscreen toggling, but having a split-second glitch is still a much better outcome than being terminated by the compositor for protocol violation.

b5210cac

2021-08-02T13:47:32

wayland: Initialize floating size at window creation This allows the windowed size to be restored for windows initially created already in non-floating state.

dab33844

2021-08-02T11:58:47

wayland: Fix a warning in handle_configure_xdg_toplevel

754aa2d3

2021-08-02T11:55:02

Mostly revert cfcdfb7be9f5c97a51ddef9ad3677a604856266b. This was causing window changes to completely break, resulting in broken decorations and bizarre frame timing, I don't know what exactly it's doing but it's not good. Kept the libdecor_frame_is_floating logic, at least.

8803589f

2021-08-02T12:05:06

wayland: Avoid redundant SetWindowBordered for libdecor

b4c4060a

2021-08-02T04:52:25

wayland: Clean up Wayland_HandlePendingResize Commit 871c11191bfc7214061a3da37c112522a102ddf5 removed delayed resize handling, but it left the whole structure untouched that now became unnecessary. To help with code clarity, get rid of the structure where pending resize state used to be stored and pass all the data directly to Wayland_HandlePendingResize (now renamed to Wayland_HandleResize, since it's not "pending" anymore but applied immediately)

9bb24ad0

2021-08-02T05:49:35

wayland: Always call Wayland_SetWindowBordered when showing the window Otherwise our windows have no window decoration on compositors that support xdg-decoration-unstable-v1, but default to client-side mode. Contrary to what the comment was stating, there is nothing in the protocol that would make redundant calls to zxdg_toplevel_decoration_v1::set_mode problematic.

cfcdfb7b

2021-08-01T18:14:53

libdecor: use same fullscreen/maximised restore logic as for xdg-toplevel

42452f8c

2021-08-01T13:51:30

wayland: store and restore floating states Some Wayland compositors send (0,0) as "suggested" configure event sizes to indicate that the client has to decide on its own which sizes to used. This is commonly done when restoring from maximised, fullscreen or tiles states to fullscreen. We now store the last known floating states in a new set of variables and restore them when we receive such a (0,0) configure event.

71897cc1

2021-07-30T15:51:43

wayland: Always trigger a resize when handling a configure event. When we removed the OpenGL resize workaround it introduced a problem for fullscreen windows in particular: When leaving fullscreen we tried to send a resize event, but UpdateFullscreenMode would send a SIZE_CHANGED immediately after, deleting our resize event and causing the following configure event's resize to be ignored. This timing issue resulted in fullscreen windows not being resized at all when becoming a floating window. By always forcing resize events from configure events, we ensure that RESIZED always makes it through. SetWindowSize-type changes should be unaffected as they do not fire configure events.

c20ab7da

2021-07-30T00:22:50

wayland: Fix GetWindowWMInfo for <2.0.15

f20a8581

2021-07-29T00:13:17

commit after setting/unsetting limits

ad310d39

2021-07-28T12:31:25

wayland: libdecor support for SetWindowModalFor

93976ade

2021-07-28T12:22:09

wayland: libdecor support for GetWindowWMInfo

21cba924

2021-07-28T16:54:23

wayland: Don't create zxdg toplevel decoration twice Each window can have at most one zxdg toplevel decoration, but as of [1], we accidentally create two. (If libdecor is not in use). This causes wayland windows with server-side decorations (e.g. on KDE/KWin) to crash with the message: zxdg_decoration_manager_v1@7: error 1: decoration has been already constructed This extra zxdg_decoration_manager_v1.get_toplevel_decoration() call was introduced while deprecating wl-shell and xdg-shell-stable[1] support, and possibly was a bad interaction with [2], which moved the decoration creation around. Fixes: 6aae5b44f8 ("Remove wl-shell and xdg-shell-unstable-v6 support (#4323)") [1]: https://github.com/libsdl-org/SDL/pull/4323 [2]: https://github.com/libsdl-org/SDL/pull/4374

7b239edb

2021-07-28T01:00:00

wayland: Assign frame_callback on window creation. Fixes a crash when creating and destroying a window without calling SwapWindow.

03185e74

2021-07-27T18:35:00

wayland: Tag/Check wl_output objects as well, fixes crashes when libdecor is in use

871c1119

2021-07-27T18:24:09

wayland: handle pending resizes immediately, not on SwapWindow. This was originally a workaround for an old Mesa bug, since fixed, apparently, and causes other problems. Fixes #4326.

a3eb297e

2021-07-27T17:17:19

wayland: Rework enter/leave and update_scale_factor to avoid bogus wl_output data. Also remove get_window_scale_factor() which was just pointless indirection.

6aae5b44

2021-07-27T17:12:26

Remove wl-shell and xdg-shell-unstable-v6 support (#4323) * wayland-protocol: update wayland.xml to 1.19.0 * wayland: remove shell_surface field from SDL_SysWMinfo * wayland: remove wl_shell support * waypand-protocols: update xdg-shell.xml to 1.20 * wayland: remove xdg-shell-unstable-v6 support * wayland: deprecate wl shell surface syswm info, add xdg surface

ac904b8e

2021-06-21T01:25:25

wayland: ignore resize in fullscreen or maximised mode

ee062c64

2021-05-19T00:13:39

wayland: implement toggling decorations

2b3cf36f

2021-05-22T00:49:10

wayland: forward window events

48066984

2021-04-05T14:09:03

wayland: enable/disable ACTION_RESIZE for fullscreen

9e6fcbe7

2020-06-11T22:10:28

wayland: client-side decoration

e5f9fae0

2021-05-16T23:19:45

wayland: don't flush after setting fullscreen

f1633127

2021-07-24T13:41:55

Added a window flash operation to be explicit about window flash behavior

e1c3a250

2021-07-24T12:11:27

Changed SDL_FlashWindow() so it doesn't take a flash count, and added the hint SDL_HINT_WINDOW_FLASH_COUNT to control behavior on Windows

4ada14a2

2021-07-21T13:39:10

Replace libc functions to SDL equivalent in wayland video subsystem Wayland video subsystem uses a mix of libc and SDL function. This patch switches libc functions to SDL ones and fixes a mismatch in memory allocation/dealoccation of SDL_Cursor in SDL_waylandmouse.c (calloc on line 201 and SDL_free on line 313) which caused memory corruption if custom memory allocator where provided to SDL.

7f261d3b

2021-06-15T00:35:13

wayland: Fix returning to a window from fullscreen without calling SetWindowSize

d956636c

2021-06-04T18:39:47

wayland: Implement FlashWindow

2af3f64e

2021-06-02T14:37:09

wayland: Activate the window on first ShowWindow, if possible

151f9538

2021-06-02T11:41:44

wayland: Implement RaiseWindow with xdg-activation

d3244035

2021-05-17T01:24:35

wayland: Add support for maximized/restored events

f2f451a5

2021-05-10T13:29:54

wayland: Call SetWindowBordered at the end of ShowWindow

efbb6ff9

2021-05-10T12:42:28

wayland: Create the server decorations after the toplevel has been configured

c69fde34

2021-05-02T16:43:01

wayland: Maximize/Restore should set the relevant window flags. Also, Maximize should be ignored for fixed-size windows.

006378b9

2021-05-02T18:30:32

fix NULL frame_callback access

424bbaec

2021-05-01T18:53:12

wayland: destroy frame callback when window is destroyed

20928550

2021-05-01T09:00:24

wayland: Guard surface_frame_listener for OpenGL, document why it exists

c54c16d3

2021-04-30T13:19:36

wayland: don't hang in SDL_GL_SwapBuffers if the compositor is ghosting us. If you hide a window on Mutter, for example, the compositor never requests new frames, which will cause Mesa to block forever in eglSwapBuffers to satisfy the swap interval. We now always set the swap interval to 0 and manage this ourselves, handing the frame to Wayland when it requests a new one, and timing out at 10fps just to keep apps moving if the compositor wants no frames at all. My understanding is that other protocols are coming that might improve upon this solution, but for now it solves the total hang. Fixes #4335.

8e3ec34d

2021-04-20T12:40:40

wayland: Refactor toplevel mapping, implement HideWindow

fcbfe33c

2021-04-18T09:45:22

wayland: Implement SetWindowModalFor

213bfc19

2021-04-18T09:36:54

wayland: Implement RestoreWindow for xdg/zxdg

ed24c345

2021-04-16T21:35:50

wayland: Implement basic window move events via wl_surface_listener. This unearthed an unspeakably large amount of bugs in the wl_output enumerator, notably the fact that the wl_output user pointer was to temporary memory! This was "fixed" in e862856, and was then pointed out as a leak in 4183211, which was undone in d9ba204. The busted fix was correct that the malloc was an issue, but wrong about _why_; SDL_AddVideoDisplay copies by value and does not reuse the pointer, so generally you want your VideoDisplay to be on the stack, but of course the callbacks don't allow that, so a malloc was a workaround. But we can do better and just host our temporary display inside WaylandOutputData because that will be persistent while also not leaking. Wait, wasn't I talking about move events? Right, that: wl_surface_listener does at least give us the ability to know what monitor we're on, even though we have no idea where we are on the monitor. All we need to do is check the wl_output against the display list and then push a move event that both indicates the correct display while also not being _too_ much of a lie (but enough of a lie to where our event doesn't get discarded as "undefined" or whatever). The index check for the video display is what spawned the great nightmare you see before you; aside from the bugfix this is actually a really basic patch.

f6a09ef1

2021-04-07T16:16:23

wayland: Drop support for kwin specific decoration management KWin has supported the shared and formalised zxdg_decoration since Plasma 5.16 which came out mid 2019. Whilst it made sense to support them both for a while, it should not be needed for future SDL releases.

a92cca1a

2021-04-07T16:44:10

wayland: Use the window's display to get wl_output rather than fullscreen_mode. Because Wayland only supports FULLSCREEN_DESKTOP, fullscreen_mode never gets assigned at all, meaning driverdata is always NULL! Depending on what the compositor does this can lead to dramatically different results. GNOME was fine without this, but Plasma would trip an event that unintentionally unset the fullscreen mode and caused the game to fire a configure event _every frame_, and of course the configure would send the fullscreen_mode output which was still empty. The fix is to just use the SDL_VideoDisplay directly, which will always have a valid wl_output.

c7e29a9e

2021-04-06T18:10:40

wayland: Fix toggling fullscreen with fixed-size windows

57a927e8

2021-02-12T14:27:58

wayland: Explicitly set min/max size for xdg-shell

a99eec77

2021-02-12T14:31:43

wayland: Minor whitespace fix

e862856e

2021-02-01T08:57:39

wayland: Don't crash when the properties of already existing wl_output change

0ed16ced

2021-01-31T19:10:02

free 'outputs' in 'Wayland_DestroyWindow'

a0d3c6c6

2021-01-25T21:42:14

Rename SetWindowGrab() to SetWindowMouseGrab()

e1f73e64

2021-01-23T16:22:44

Refactor keyboard grab to be managed by the video core This gives us flexibility to add others hints to control keyboard grab behavior without having to touch all of the backends. It also allows us to possibly expose keyboard grab separately from mouse grab for applications that want to manage those independently.

e787282b

2021-01-23T15:40:22

Implement Wayland_SetWindowResizable

bd553ea8

2021-01-20T21:17:20

Implement support for inhibiting the screensaver on Wayland We support both the org.freedesktop.ScreenSaver D-Bus API (same as the X11 backend) and the Wayland idle_inhibit_unstable_v1 protocol. Some Wayland compositors only support one or the other, so we need both to for broad compatibility.

19236b46

2021-01-21T21:49:13

Implement support for minimizing windows on Wayland This required a bit of extra code to deal with the transition from minimized back to fullscreen

d789ba83

2021-01-19T18:20:07

Implement keyboard grab support for Wayland Use zwp_keyboard_shortcuts_inhibit_manager_v1 to allow SDL applications to capture system keyboard shortcuts like Alt+Tab when keyboard grab is enabled via SDL_HINT_GRAB_KEYBOARD.

6a342954

2021-01-14T14:42:53

Fixed bug 5451 - Can't create EGLSurface in Wayland from SDLWindow (no EGLNativeWindow pointer) sashikknox In some cases, need create EGLWindow with SDLWindow. In X11 i can get pointer to NativeWindow from **struct SDL_SysWMinfo wmInfo** ```C++ struct SDL_SysWMinfo wmInfo; SDL_GetWindowWMInfo(ptSDLWindow, &wmInfo) #if defined(__unix__) && defined(SDL_VIDEO_DRIVER_X11) nativeWindow=(EGLNativeWindowType)wmInfo.info.x11.window; nativeDisplay=(EGLNativeDisplayType)wmInfo.info.x11.display; #endif ``` than i can create EGLSurface ``` eglCreateWindowSurface(nativeDisplay, EGL_CONFIG, nativeWindow, SURFACE_ATTRIBUTES); ``` in Wayland i can do it with same way, just need pointer to **EGLWindow**, we already have pointer to **wl_display** from **SDL_sysWMInfo**, need add to **wl** struct in SDL_SysWMInfo another pointer to **struct wl_egl_window *egl_window;**. And in wayland backend, in function **Wayland_GetWindowWMInfo** return pointer to **egl_window** from **SDL_WindowData** Now i use patched statically built SDL2 in port of Quake 2 GLES2 for SailfishOS (it use QtWayland): link to SDL2 commit and changed string for patch: - https://github.com/savegame/lp-public/commit/6858a618cd179b766fe3cab36055f07cb03ad0ea - https://github.com/savegame/lp-public/blob/b1e29e87b9d15780e47f04918b329ac15554fc69/SDL2/src/video/wayland/SDL_waylandwindow.c#L463 link to use in Quake2 port: 1. here i get pointer to EGLNativeWindowType: https://github.com/savegame/lp-public/blob/6d94fedb1b720da24999ae6286a1809cd3d55ff5/Engine/Sources/Compatibility/OpenGLES/EGLWrapper.c#L319 2. then use it for create EGLSurface: https://github.com/savegame/lp-public/blob/6d94fedb1b720da24999ae6286a1809cd3d55ff5/Engine/Sources/Compatibility/OpenGLES/EGLWrapper.c#L391

9130f7c3

2021-01-02T10:25:38

958c4282

2020-06-04T09:13:49

Fixed build warning

aa259ed5

2020-05-28T15:18:41

wayland: Changed output removal in handle_surface_leave() No longer needs an extra malloc, handles unexpected cases like the same output being listed twice.

0eb6512b

2020-05-04T13:19:26

Fixed bug 5121 - Use SDL_calloc instead of calloc in Wayland_CreateWindow meyraud705 'SDL_Windows::driverdata' of a Wayland window is allocated by calloc in 'Wayland_CreateWindow' but freed by SDL_free in 'Wayland_DestroyWindow'.

kc3-lang/SDL/src/video/wayland/SDL_waylandwindow.c

src/video/wayland/SDL_waylandwindow.c

Log