kmx git

Commit	Date	Message
f8ae3ef1	2022-06-15T22:01:59	wayland: use libdecor resize edge enums for libdecor
e427e80b	2022-06-14T10:41:18	wayland: Use the output descriptions from xdg-output when available Some compositors will provide 'nicer' / 'human readable' output descriptions via the xdg-output protocol. Use these description strings, when available, instead of the model name provided by wl-output. On compositors such as GNOME where this is provided, the display names provided to applications by SDL will now match those in the desktop display settings panel. On compositors where this data isn't provided, the old behavior of using the model string provided by wl-output will remain unchanged. Additionally, per the protocol spec, output data provided by xdg-output should supersede wl-output data, so this is the recommended behavior in general.
714502d3	2022-06-13T22:15:56	minor windows warning fixes.
507ce36d	2022-05-10T10:35:06	video: Note unused SDL_surface creation parameters for removal in SDL 3 Signed-off-by: Simon McVittie <smcv@collabora.com>
535fdc3a	2022-05-10T10:34:41	video: Detect and reject nonsense SDL_surface dimensions Signed-off-by: Simon McVittie <smcv@collabora.com>
8c9f7104	2022-05-10T10:33:54	video: Harden calculation of SDL_surface pitch and size against overflow If the width is sufficiently ludicrous, then the calculated pitch or the image size could conceivably be a signed integer overflow, which is undefined behaviour. Calculate in the unsigned size_t domain, with overflow checks. Signed-off-by: Simon McVittie <smcv@collabora.com>
63b3b9a5	2022-06-13T16:02:40	Fix some typos in diagnostic messages Detected by Debian's packaging QA tool, Lintian. Signed-off-by: Simon McVittie <smcv@collabora.com>
9a036767	2022-06-12T15:28:49	windows: Get better name for the physical display, for Vista and later. Fixes #5321.
fd8cafc7	2022-06-11T17:11:55	Rename variables in SDL_egl.c to be more intuitive
ab81a559	2022-06-07T02:01:27	Windows DPI scaling/highdpi support Adds hint "SDL_WINDOWS_DPI_SCALING" which can be set to "1" to change the SDL coordinate system units to be DPI-scaled points, rather than pixels everywhere. This means windows will be appropriately sized, even when created on high-DPI displays with scaling. e.g. requesting a 640x480 window from SDL, on a display with 125% scaling in Windows display settings, will create a window with an 800x600 client area (in pixels). Setting this to "1" implicitly requests process DPI awareness (setting SDL_WINDOWS_DPI_AWARENESS is unnecessary), and forces SDL_WINDOW_ALLOW_HIGHDPI on all windows.
448e05e3	2022-06-05T12:51:57	add DPI_AWARENESS_CONTEXT_UNAWARE_GDISCALED define
1b797957	2022-06-05T12:36:58	SDL_windowsvideo.c: add HIGHDPI_DEBUG ifdef, print DPI awareness at startup if defined document some additional quirks
1488c408	2022-06-05T12:01:32	WM_DPICHANGED: remove some dead code, add comment
60ef11b3	2022-06-03T00:21:36	Fix Watcom compile errors
d3b970d4	2022-05-29T21:56:37	HighDPI: remove SWP_NOSIZE in WIN_SetWindowPosition If the move results in a DPI change, we need to allow the window to resize (e.g. AdjustWindowRectExForDpi frame sizes are different). - WM_DPICHANGED: Don't assume WM_GETDPISCALEDSIZE is always called for PMv2 awareness - it's only called during interactive dragging. - WIN_AdjustWindowRectWithStyle: always calculate final window size including frame based on the destination rect, not based on the current window DPI. - Update wmmsg.h to include WM_GETDPISCALEDSIZE (for WMMSG_DEBUG) - WIN_AdjustWindowRectWithStyle: add optional logging - WM_GETMINMAXINFO: add optional HIGHDPI_DEBUG logging - WM_DPICHANGED: fix potentially clobbering data->expected_resize Together these changes fix the following scenario: - launch testwm2 with the SDL_WINDOWS_DPI_AWARENESS=permonitorv2 environment variable - Windows 10 21H2 (OS Build 19044.1706) - Left (primary) monitor: 3840x2160, 125% scaling - Right (secondary) monitor: 2560x1440, 100% scaling - Alt+Enter, Alt+Enter (to enter + leave desktop fullscreen), Alt+Right (to move window to right monitor). Ensure the window client area stays 640x480. Drag the window back to the 125% monitor, ensure client area stays 640x480.
51ebefee	2022-02-28T00:43:43	Support PMv2 DPI awareness, add SDL_HINT_WINDOWS_DPI_AWARENESS The hint allows setting a specific DPI awareness ("unaware", "system", "permonitor", "permonitorv2"). This is the first part of High-DPI support on Windows ( https://github.com/libsdl-org/SDL/issues/2119 ). It doesn't implement a virtualized SDL coordinate system, which will be addressed in a later commit. (This hint could be useful for SDL apps that want 1 SDL unit = 1 pixel, though.) Detecting and behaving correctly under per-monitor V2 (calling AdjustWindowRectExForDpi where needed) should fix the following issues: https://github.com/libsdl-org/SDL/issues/3286 https://github.com/libsdl-org/SDL/issues/4712
4a3277b0	2022-05-19T15:13:02	wayland: Always commit window constraints before entering fullscreen XDG-toplevel min/max size values are double-buffered data and must be committed before entering the fullscreen state, or a max window size value smaller than the display dimensions may cause the compositor to incorrectly configure the fullscreen window size. This fixes windowed->fullscreen transitions on GNOME, where, previously, certain combinations of window flags and min/max size values could cause entering fullscreen mode to fail with odd window sizes and/or offsets due to the new max size values not being committed before entering fullscreen, causing the compositor to clamp to the old values. In the case of libdecor, it has its own layer of buffering on top of the xdg-toplevel surface for the min/max window dimensions, so both a frame commit and surface commit are required to set the state properly.
78698a0b	2022-05-17T12:37:16	wayland: Use a separate frame callback for setting the surface damage region Previously, the surface damage region was being set in the same callback used for preventing render hangs in the GL backend when the surface was not visible. This was not ideal, as the callback was never fired in the case of using a different render backend or having a swap interval of 0. Use a separate frame callback for setting the surface damage region to ensure that it fires reliably, regardless of the backend being used or swap interval.
146ea9b0	2022-05-16T18:18:55	wayland: Only set the surface opaque region if EGL transparency is disabled Check if the "SDL_VIDEO_EGL_ALLOW_TRANSPARENCY" hint is enabled and don't mark surfaces as opqaue if it is.
a20516d4	2022-05-16T10:35:56	wayland: Swap emulated mode dimensions in more cases Some compositors (GNOME for example) don't set the transform flag when dealing with portrait mode displays, so the video modes won't have the width/height swapped in all cases where they should be. Check for both the 90/270 degree transform flag and if the display is taller than it is wide when determining whether to swap the width and height of the emulated video modes, and adjust the comparison logic when size testing against the native mode to account for this.
e1c83504	2022-05-15T10:35:59	wayland: Add a hint to disable video mode emulation under Wayland Add the hint "SDL_VIDEO_WAYLAND_MODE_EMULATION", which can be used to disable mode emulation under Wayland. When disabled, only the desktop and/or native display resolution is exposed.
e9d3dcea	2022-05-14T18:32:05	wayland: Unify integer and fractional output scaling Previously, scale values used by the displays and surfaces were always integers, with fractional scale values only being calculated when the backbuffer and viewport sizes were being determined. Now, if xdg-output is available, the fractional scale of output displays is calculated when the displays are enumerated and the true scale values of the output devices are used whenever possible. This unifies the integer and fractional scaling systems, allows for the use of more accurate scale values that minimize overdraw when windows straddle multiple outputs, and lays the groundwork for the pending Wayland scaling protocols that will report the preferred scale values per-surface instead of per-output.
4fde7dd8	2022-05-14T14:42:52	wayland: Refactor the Wayland mode emulation and viewport logic Compartmentalize the fullscreen mode emulation code blocks, unify the windowed/fullscreen viewport logic, consolidate all window geometry code into a central function to eliminate blocks of duplicate code and rename related variables and functions to more explicitly reflect their purpose.
b75cd2b3	2022-06-10T14:12:03	x11: Force window back to expected size after SDL_SetWindowBordered. This helps if the window manager decided to let it fill the space that an existing border was using before its removal. Fixes #5718.
d11702ce	2022-05-05T02:34:16	ime: wayland: Make use of `SDL_TEXTEDITING_EXT` Because we were sending multiple chunks of preedit strings, `SDL_SendEditingText` was using the old `SDL_TEXTEDITING` event only. Now if `SDL_HINT_IME_SUPPORT_EXTENDED_TEXT` is enabled, we send the full string and correctly set the cursor position and selection size.
0fcfaf9e	2022-06-08T14:20:50	emscripten: use MAIN_THREAD_EM_ASM for the fb/cursor proxying This is how everything else was handled and fixes undefined symbol errors in non-threads builds.
ec0204d2	2022-06-06T14:38:26	x11: Don't use GetXftDPI() when XRandR can tell us the DPI per-output. Fixes #5764.
50d8642f	2022-06-06T20:18:38	Add optimiztion function with LSX in LoongArch 1. yuv420_rgb24_lsx 1. yuv420_rgba_lsx 2. yuv420_bgra_lsx 3. yuv420_argb_lsx 4. yuv420_abgr_lsx
a236bf4f	2022-06-06T02:13:37	x11: Hook up display hotplug notifications. Obviously this needs XRandR support. Fixes #4977.
847539af	2022-06-01T23:06:19	wayland: Only call libdecor_dispatch() if we've loaded libdecor As of #5703, we call libdecor_dispatch() in Wayland_WaitEventTimeout(), but this will crash if we don't load libdecor, as SDL_VideoData::shell.libdecor will be NULL. Since we don't load libdecor if we don't intend to use it (i.e., if should_use_libdecor returns false), this results in a crash under KDE in almost all circumstances.
c87b0142	2022-05-30T12:02:08	Fixed building with C89 compiler
f78f7752	2022-05-28T03:53:43	ime: windows: allocate space for null terminator
347659e8	2022-05-25T22:07:12	riscos: Ensure that last_mouse_buttons is initialised correctly
cb43eb43	2022-05-25T21:43:36	riscos: Ensure the mouse focus is set when creating the window
6eda520f	2022-05-25T21:40:28	riscos: Add a basic implementation of SDL_ShowCursor()
412ceb84	2022-05-24T16:27:54	video: Only check major version in SDL_GetWindowWMInfo Since #5602, SDL is intended to have the same ABI across the whole major-version 2 cycle, so we should not check that the minor version matches the one that was used to compile an application. There are two checks that could make sense here. The first check is that the major version matches the expected major version. This is usually unnecessary and is not usually done (if we're calling into the wrong library we'll likely crash anyway), but since we have the information, we might as well continue to use it. The second check is whether the version provided by the caller is equal to or greater than a threshold version at which additional fields were added to the struct. If it is, we should populate those fields; if it is not, then we cannot. This is only useful on platforms where additional fields have genuinely been added during the lifetime of SDL 2, like Windows and DirectFB (but not X11). This commit changes the first check to be consistent about only looking at the minor version, while leaving the second check using SDL_VERSIONNUM (which will be removed or widened in SDL 3, but it's fine for now). Resolves: https://github.com/libsdl-org/SDL/issues/5711 Fixes: cd7c2f1 "Switch versioning scheme to be the same as GLib and Flatpak" Signed-off-by: Simon McVittie <smcv@collabora.com>
e4b5afa5	2022-05-21T13:16:12	fix unused variable depending on YUV format
e59cba95	2022-05-21T13:50:56	add libdecor_dispatch
9edd411a	2022-05-19T17:15:10	x11: send move/resize events when waiting on fullscreen change. Otherwise we ignore the Configure/etc events when they come in because the window is already in an identical state as far as SDL is concerned. Fixes #5593. May also fix: Issue #5572. Issue #5595.
b798e49c	2022-05-19T21:44:38	Fix build warning with MSVC
9dfa000b	2022-05-18T20:20:03	Initial support for building for Windows with OpenWatcom
5669743a	2022-05-19T09:45:57	Make sure SDL_CaptureMouse() is only called on the main thread Windows handles mouse capture on a per-thread basis, and capture must be done on the thread used to create a window. Fixes https://github.com/libsdl-org/SDL/issues/5577
501a4991	2022-05-05T18:44:32	Add clang-format on/off comments where necessary. Comments were added in places where INDENT-ON/OFF comments are. Places like stdlib's asm don't need it as clang-format doesn't try to indent it.
0e6d4baa	2022-05-19T01:23:24	Fixed compile warning on gcc 11
c7dff3a2	2022-05-19T00:35:22	Attempt to get the X1 and X2 button state on X11 by using the current event state instead of direct X11 query.
57130b75	2022-05-19T00:31:20	Revert "x11: get x1/x2 button state in GetGlobalMouseState" This reverts commit 3fcc2cb500a752698687ad0c8bb14778e6cb84c3. Button4 and Button5 are for the scrollwheel, not the extended buttons. I don't know of a way to query the state of the extended buttons using X11.
e19a9a79	2022-05-18T15:29:59	Fixed a message box getting the mouse capture state out of sync
c8eea020	2022-05-18T21:14:20	Fix C89 build errors in Windows builds
0cca71a8	2022-05-18T22:12:05	Use SDLCALL for callbacks in public APIs
06aca7ed	2022-05-18T10:09:24	Fixed warping back into the window when gaining focus with warp relative mode enabled
56665e1d	2022-05-17T12:50:13	cocoa: Try to use better system cursors. These try to pull from the .pdf files that are installed with macOS, which fit our needs better, and fall back to the most reasonable defaults available from NSCursor if we can't load them. Since these are installed under /System, they should be sandbox accessible, and if this totally fails, it should still go on, albeit with a less good cursor. Reference Issue #2123.
e9c7b519	2022-05-16T21:03:41	macOS: Fix reference counts of internal window data. Fixes crashes when destroying or recreating a window (#5664).
2317a96c	2022-05-16T10:50:13	x11: Use XC_top_left_corner/XC_top_right_corner instead of XC_fleur. On Gnome (and hopefully others!), this produces something that actually matches SDL_SYSTEM_CURSOR_SIZENWSE/SDL_SYSTEM_CURSOR_SIZENESW. On other desktop enviroments, it probably fits the spirit better than XC_fleur in any case. Reference Issue #2123.
e4bb3c86	2022-05-11T18:13:44	wayland: Fix build for configs without libdecor
6222bd31	2022-05-11T16:26:43	wayland: Don't create a new libdecor context if one already exists
6f88cbe4	2022-05-11T16:04:34	wayland: Support xdg_decoration requesting client-side decorations. Don't be fooled by the diff size - this ended up being a big refactor of the shell surface management, masked only by some helper macros I wrote for the popup support. This change makes it so when xdg_decoration is supported, but CSD is requested, the system bails on xdg support entirely and resets all the windows to use libdecor instead. This transition isn't pretty, but once it's done it will be smooth if decorations are an OS toggle since libdecor will take things from there. In hindsight, we really should have designed libdecor to be passed a toplevel, having it manage that for us keeps causing major refactors for _every_ change.
9b75fa01	2022-05-11T18:31:34	N-Gage port: add changes from code reviews, overall cleanup (#5618) * Add changes from code review by @ccawley2011, #5597, overall cleanup * Update N-Gage README, minor cleanup and rephrasing * Call SDL_SetMainReady() before calling SDL_main, return SDL_main instead of main
6da99d4a	2022-05-11T08:40:17	Don't use SDL_SIMDFree() if the pixels haven't been allocated with SDL_SIMDAlloc()
2f924020	2022-05-05T20:12:07	Add SDL_SCANCODE_CALL and SDL_SCANCODE_ENDCALL
2bc37362	2022-05-05T13:31:26	Add SDL_SCANCODE_SOFTLEFT and SDL_SCANCODE_SOFTRIGHT
f871c178	2022-05-10T17:32:24	macOS: remove dead code for supporting 10.6 at runtime.
ec8fa577	2022-05-07T21:57:23	macOS: always use Objective-C ARC (automatic ref counting). Change Cocoa SDL_VideoData and SDL_WindowData implementations from C structs to Objective-C objects, since bridging between C and ObjC is easier that way.
adac3bd1	2022-05-03T12:31:50	video: restore ability to disable fb accel via hint Somewhere in code refactoring between .20 and .22 this check was lost, and so the hint had no effect anymore.
fbd230bb	2022-05-03T17:51:49	Add support for the Nokia N-Gage (#5597) * Add initial support for the Nokia N-Gage * N-Gage: disable clipping for the time being, issue needs to be resolved later * Move va_copy definition to SDL_internal.h * Move stdlib.h include to SDL_config_ngage.h, much cleaner this way * Remove redundant include, add HAVE_STDLIB_H * Revert "N-Gage: disable clipping for the time being, issue needs to be resolved later" This reverts commit 4f5f0fc36cc7f34fad05e45671dfa7b8dc32fd51. * N-Gage: fix clipping issue by providing proper math functions
3fcc2cb5	2022-05-03T11:19:39	x11: get x1/x2 button state in GetGlobalMouseState
6c2928b4	2022-04-29T19:30:47	Switch uses of MIN() to SDL_min() We're excluding files in src/hidapi to minimize the diff against the upstream project.
7e636b03	2022-04-29T10:16:14	Removed log message length limitation for Apple platforms This works in conjunction with https://github.com/libsdl-org/SDL/pull/5584
12f15aaa	2022-04-27T10:03:32	fix build
05bd225a	2022-04-26T23:14:44	x11: If XRandR isn't available, add a generic display. We can get _some_ of the info we need out of standard Xlib and report a single display (which might actually be multiple physical displays mushed into a single desktop). This is better than nothing, but you should really just build with XRandR support and get a better X server. :)
ccc70e64	2022-04-26T23:14:21	x11: Fixed some compiler warnings.
7d7ec9c9	2022-04-26T16:41:28	x11: Remove XVidMode and Xinerama support. Fixes #1782.
b293888c	2022-04-26T19:44:34	Fixes an issue introduced via #5573 when building for i686
01ef98a5	2022-04-26T10:19:03	Don't force keyboard auto-repeat on, if the user has disabled it for some reason Fixes https://github.com/libsdl-org/SDL/issues/2400
795744fc	2022-01-07T10:11:46	Turn off relative mouse before window checks as well
e2d268a3	2022-01-06T23:42:44	SDL_cocoamouse.m: SetRelativeMouseMode even if out of focus Should fix #3087
76afb858	2022-04-25T10:35:56	Introduces Cocoa_GetWindowDisplayIndex. This enable a proper management for dpi when switching between retina and non-retina displays.
53dea983	2022-04-25T13:51:15	x11: revert checks for _NET_WM_STATE_FULLSCREEN changes. This reverts commit 85977354fbce9ecb2add660a88e6bec3532c3e26. This reverts commit 0249df9d960f9bc28b476e1171c5501fc37cca12. Fixes #5572. Reopens #5390.
aeadbdd7	2022-04-20T09:00:00	Remove an unused function prototype
c8c59a21	2022-04-20T08:58:58	Fix a -Wshadow warning
3753a7b1	2022-04-19T14:42:39	Fix recent changes in VitaSDK
02225aa7	2022-04-18T22:57:03	Fixed build
49a2e4b0	2022-04-19T00:36:53	x11: Revert "Fix keymap updating for X11 backend" This reverts commit de6d290266d1def0eef9df81bf9be41c12a98c61. This patch had multiple issues, discussed in #5520.
9919d1a7	2022-04-18T11:51:09	Remove HWND_TOPMOST for fullscreen windows Fixes https://github.com/libsdl-org/SDL/issues/5509
2b529461	2022-04-15T11:51:02	video: Don't minimize fullscreen windows on focus loss by default when mode switching is disabled When mode switching is disabled in a video backend, fullscreen windows are basically just fullscreen desktop windows with different internal scaling. As no mode switching occurs, there's no need to minimize them on focus loss by default. This can still be overridden by explicitly setting the internal hint for minimizing on focus loss. This has the side effect of fixing a bug on GNOME, where, when a fullscreen Wayland window has it's focus lost and restored via alt+tab followed by switching back to windowed mode, the top portion of the window won't end up being obstructed by GNOME's top bar.
c37090f9	2022-04-18T12:30:08	wayland: Add support for TOOLTIP/POPUP_MENU
254fcc90	2022-04-18T09:03:14	Revert "video: Prefer Wayland over X11" This reverts commit 8ceba27d6291f1195e13608033ec439aec621fc6. SDL Wayland support is stable, but there are a number of issues with third-party software (NVIDIA drivers, libwayland event overflow, libdecor not handling plugin load failures, Steam overlay not working with Wayland, etc.) that make it better to default to X11 at this time. Games which would like to prefer wayland when available can use the following code before SDL_Init(): SDL_SetHint(SDL_HINT_VIDEODRIVER, "wayland,x11"); Fixes https://github.com/libsdl-org/SDL/issues/5527
c1336b21	2022-04-17T12:43:32	hints: Make SDL_VIDEODRIVER and SDL_AUDIODRIVER formal hints. They were just environment variables before. Fixes #5528.
67e0f546	2022-04-15T18:24:57	x11: Update the display when the WM changes a window's fullscreen state. Fixes #5390.
edb473cf	2022-04-15T15:03:28	video: Wayland: Always round scaled pointer coordinates down Rounding up can cause the pointer coordinates to exceed the window boundaries at the right and bottom edges.
13393a1c	2022-04-15T14:28:07	video: Wayland: Clamp fullscreen window dimensions to desktop A scaled fullscreen window may exceed the bounds of the desktop. Clamp the window size to the desktop dimensions in fullscreen mode.
01b14e14	2022-04-12T08:49:19	avoid NullPointer in SDL_GL_MakeCurrent
9c2f46b0	2022-04-12T15:23:22	Wayland: Add SDL_HINT_VIDEO_WAYLAND_PREFER_LIBDECOR This hint allows libdecor to be used even when xdg-decoration is available. It's mostly useful for debugging libdecor, but could in theory be used by applications which want to (for example) bundle their own libdecor plugins.
c2093fab	2022-04-08T13:58:45	video: wayland: Set the surface damage region when using fullscreen viewports When using emulated display modes, the output size is often larger than the drawable buffer. As the surface damage region is automatically calculated from the smaller drawable buffer size, the damage region needs to be manually set to cover the entire viewport region or visual repaint artifacts can result.
5613a560	2022-04-07T11:32:22	Make sure the UIKit message box is being handled on the main thread Potentially fixes https://github.com/libsdl-org/SDL/issues/4865
49b9e347	2022-04-07T08:24:03	Only update modifier state for keys that are pressed in another application Fixes https://github.com/libsdl-org/SDL/issues/4432
85977354	2022-04-07T09:14:33	x11: Treat WM setting the window "fullscreen" like FULLSCREEN_DESKTOP. Fixes #5390.
d1f7f9e3	2022-04-06T11:18:46	wayland: Pin the fake window position at (0, 0). I kind of thought it'd be nice to have it in the center, but this is an issue for applications that still assume global mouse and window positions are accessible. For example, this fixes cursor offset issues in UE5.
279aeb59	2022-04-06T01:32:57	wayland: Add a bug link for the detach FIXME
3ada694e	2022-04-06T01:18:03	wayland: Try to detach at the beginning of ShowWindow, just in case. It's possible that an external component (probably a GL/VK context) committed, so we need to cover our bases and detach in both HideWindow and ShowWindow. Fixes a crash in UE5 editor's pop-ups.
dcfb7fff	2022-04-06T00:55:32	wayland: Evaluate WINDOWPOS_CENTERED_DISPLAY for move events Partially fixes the mouse cursor in UE5 editor. Imperfect because UE5 uses window position and global mouse state to get position, but of course we don't have global mouse and this is just to get the right display index so this still fails overall. We really need to make global mouse support a feature query...

f8ae3ef1

2022-06-15T22:01:59

wayland: use libdecor resize edge enums for libdecor

e427e80b

2022-06-14T10:41:18

wayland: Use the output descriptions from xdg-output when available Some compositors will provide 'nicer' / 'human readable' output descriptions via the xdg-output protocol. Use these description strings, when available, instead of the model name provided by wl-output. On compositors such as GNOME where this is provided, the display names provided to applications by SDL will now match those in the desktop display settings panel. On compositors where this data isn't provided, the old behavior of using the model string provided by wl-output will remain unchanged. Additionally, per the protocol spec, output data provided by xdg-output should supersede wl-output data, so this is the recommended behavior in general.

714502d3

2022-06-13T22:15:56

minor windows warning fixes.

507ce36d

2022-05-10T10:35:06

video: Note unused SDL_surface creation parameters for removal in SDL 3 Signed-off-by: Simon McVittie <smcv@collabora.com>

535fdc3a

2022-05-10T10:34:41

video: Detect and reject nonsense SDL_surface dimensions Signed-off-by: Simon McVittie <smcv@collabora.com>

8c9f7104

2022-05-10T10:33:54

video: Harden calculation of SDL_surface pitch and size against overflow If the width is sufficiently ludicrous, then the calculated pitch or the image size could conceivably be a signed integer overflow, which is undefined behaviour. Calculate in the unsigned size_t domain, with overflow checks. Signed-off-by: Simon McVittie <smcv@collabora.com>

63b3b9a5

2022-06-13T16:02:40

Fix some typos in diagnostic messages Detected by Debian's packaging QA tool, Lintian. Signed-off-by: Simon McVittie <smcv@collabora.com>

9a036767

2022-06-12T15:28:49

windows: Get better name for the physical display, for Vista and later. Fixes #5321.

fd8cafc7

2022-06-11T17:11:55

Rename variables in SDL_egl.c to be more intuitive

ab81a559

2022-06-07T02:01:27

Windows DPI scaling/highdpi support Adds hint "SDL_WINDOWS_DPI_SCALING" which can be set to "1" to change the SDL coordinate system units to be DPI-scaled points, rather than pixels everywhere. This means windows will be appropriately sized, even when created on high-DPI displays with scaling. e.g. requesting a 640x480 window from SDL, on a display with 125% scaling in Windows display settings, will create a window with an 800x600 client area (in pixels). Setting this to "1" implicitly requests process DPI awareness (setting SDL_WINDOWS_DPI_AWARENESS is unnecessary), and forces SDL_WINDOW_ALLOW_HIGHDPI on all windows.

448e05e3

2022-06-05T12:51:57

add DPI_AWARENESS_CONTEXT_UNAWARE_GDISCALED define

1b797957

2022-06-05T12:36:58

SDL_windowsvideo.c: add HIGHDPI_DEBUG ifdef, print DPI awareness at startup if defined document some additional quirks

1488c408

2022-06-05T12:01:32

WM_DPICHANGED: remove some dead code, add comment

60ef11b3

2022-06-03T00:21:36

Fix Watcom compile errors

d3b970d4

2022-05-29T21:56:37

HighDPI: remove SWP_NOSIZE in WIN_SetWindowPosition If the move results in a DPI change, we need to allow the window to resize (e.g. AdjustWindowRectExForDpi frame sizes are different). - WM_DPICHANGED: Don't assume WM_GETDPISCALEDSIZE is always called for PMv2 awareness - it's only called during interactive dragging. - WIN_AdjustWindowRectWithStyle: always calculate final window size including frame based on the destination rect, not based on the current window DPI. - Update wmmsg.h to include WM_GETDPISCALEDSIZE (for WMMSG_DEBUG) - WIN_AdjustWindowRectWithStyle: add optional logging - WM_GETMINMAXINFO: add optional HIGHDPI_DEBUG logging - WM_DPICHANGED: fix potentially clobbering data->expected_resize Together these changes fix the following scenario: - launch testwm2 with the SDL_WINDOWS_DPI_AWARENESS=permonitorv2 environment variable - Windows 10 21H2 (OS Build 19044.1706) - Left (primary) monitor: 3840x2160, 125% scaling - Right (secondary) monitor: 2560x1440, 100% scaling - Alt+Enter, Alt+Enter (to enter + leave desktop fullscreen), Alt+Right (to move window to right monitor). Ensure the window client area stays 640x480. Drag the window back to the 125% monitor, ensure client area stays 640x480.

51ebefee

2022-02-28T00:43:43

Support PMv2 DPI awareness, add SDL_HINT_WINDOWS_DPI_AWARENESS The hint allows setting a specific DPI awareness ("unaware", "system", "permonitor", "permonitorv2"). This is the first part of High-DPI support on Windows ( https://github.com/libsdl-org/SDL/issues/2119 ). It doesn't implement a virtualized SDL coordinate system, which will be addressed in a later commit. (This hint could be useful for SDL apps that want 1 SDL unit = 1 pixel, though.) Detecting and behaving correctly under per-monitor V2 (calling AdjustWindowRectExForDpi where needed) should fix the following issues: https://github.com/libsdl-org/SDL/issues/3286 https://github.com/libsdl-org/SDL/issues/4712

4a3277b0

2022-05-19T15:13:02

wayland: Always commit window constraints before entering fullscreen XDG-toplevel min/max size values are double-buffered data and must be committed before entering the fullscreen state, or a max window size value smaller than the display dimensions may cause the compositor to incorrectly configure the fullscreen window size. This fixes windowed->fullscreen transitions on GNOME, where, previously, certain combinations of window flags and min/max size values could cause entering fullscreen mode to fail with odd window sizes and/or offsets due to the new max size values not being committed before entering fullscreen, causing the compositor to clamp to the old values. In the case of libdecor, it has its own layer of buffering on top of the xdg-toplevel surface for the min/max window dimensions, so both a frame commit and surface commit are required to set the state properly.

78698a0b

2022-05-17T12:37:16

wayland: Use a separate frame callback for setting the surface damage region Previously, the surface damage region was being set in the same callback used for preventing render hangs in the GL backend when the surface was not visible. This was not ideal, as the callback was never fired in the case of using a different render backend or having a swap interval of 0. Use a separate frame callback for setting the surface damage region to ensure that it fires reliably, regardless of the backend being used or swap interval.

146ea9b0

2022-05-16T18:18:55

wayland: Only set the surface opaque region if EGL transparency is disabled Check if the "SDL_VIDEO_EGL_ALLOW_TRANSPARENCY" hint is enabled and don't mark surfaces as opqaue if it is.

a20516d4

2022-05-16T10:35:56

wayland: Swap emulated mode dimensions in more cases Some compositors (GNOME for example) don't set the transform flag when dealing with portrait mode displays, so the video modes won't have the width/height swapped in all cases where they should be. Check for both the 90/270 degree transform flag and if the display is taller than it is wide when determining whether to swap the width and height of the emulated video modes, and adjust the comparison logic when size testing against the native mode to account for this.

e1c83504

2022-05-15T10:35:59

wayland: Add a hint to disable video mode emulation under Wayland Add the hint "SDL_VIDEO_WAYLAND_MODE_EMULATION", which can be used to disable mode emulation under Wayland. When disabled, only the desktop and/or native display resolution is exposed.

e9d3dcea

2022-05-14T18:32:05

wayland: Unify integer and fractional output scaling Previously, scale values used by the displays and surfaces were always integers, with fractional scale values only being calculated when the backbuffer and viewport sizes were being determined. Now, if xdg-output is available, the fractional scale of output displays is calculated when the displays are enumerated and the true scale values of the output devices are used whenever possible. This unifies the integer and fractional scaling systems, allows for the use of more accurate scale values that minimize overdraw when windows straddle multiple outputs, and lays the groundwork for the pending Wayland scaling protocols that will report the preferred scale values per-surface instead of per-output.

4fde7dd8

2022-05-14T14:42:52

wayland: Refactor the Wayland mode emulation and viewport logic Compartmentalize the fullscreen mode emulation code blocks, unify the windowed/fullscreen viewport logic, consolidate all window geometry code into a central function to eliminate blocks of duplicate code and rename related variables and functions to more explicitly reflect their purpose.

b75cd2b3

2022-06-10T14:12:03

x11: Force window back to expected size after SDL_SetWindowBordered. This helps if the window manager decided to let it fill the space that an existing border was using before its removal. Fixes #5718.

d11702ce

2022-05-05T02:34:16

ime: wayland: Make use of `SDL_TEXTEDITING_EXT` Because we were sending multiple chunks of preedit strings, `SDL_SendEditingText` was using the old `SDL_TEXTEDITING` event only. Now if `SDL_HINT_IME_SUPPORT_EXTENDED_TEXT` is enabled, we send the full string and correctly set the cursor position and selection size.

0fcfaf9e

2022-06-08T14:20:50

emscripten: use MAIN_THREAD_EM_ASM for the fb/cursor proxying This is how everything else was handled and fixes undefined symbol errors in non-threads builds.

ec0204d2

2022-06-06T14:38:26

x11: Don't use GetXftDPI() when XRandR can tell us the DPI per-output. Fixes #5764.

50d8642f

2022-06-06T20:18:38

Add optimiztion function with LSX in LoongArch 1. yuv420_rgb24_lsx 1. yuv420_rgba_lsx 2. yuv420_bgra_lsx 3. yuv420_argb_lsx 4. yuv420_abgr_lsx

a236bf4f

2022-06-06T02:13:37

x11: Hook up display hotplug notifications. Obviously this needs XRandR support. Fixes #4977.

847539af

2022-06-01T23:06:19

wayland: Only call libdecor_dispatch() if we've loaded libdecor As of #5703, we call libdecor_dispatch() in Wayland_WaitEventTimeout(), but this will crash if we don't load libdecor, as SDL_VideoData::shell.libdecor will be NULL. Since we don't load libdecor if we don't intend to use it (i.e., if should_use_libdecor returns false), this results in a crash under KDE in almost all circumstances.

c87b0142

2022-05-30T12:02:08

Fixed building with C89 compiler

f78f7752

2022-05-28T03:53:43

ime: windows: allocate space for null terminator

347659e8

2022-05-25T22:07:12

riscos: Ensure that last_mouse_buttons is initialised correctly

cb43eb43

2022-05-25T21:43:36

riscos: Ensure the mouse focus is set when creating the window

6eda520f

2022-05-25T21:40:28

riscos: Add a basic implementation of SDL_ShowCursor()

412ceb84

2022-05-24T16:27:54

video: Only check major version in SDL_GetWindowWMInfo Since #5602, SDL is intended to have the same ABI across the whole major-version 2 cycle, so we should not check that the minor version matches the one that was used to compile an application. There are two checks that could make sense here. The first check is that the major version matches the expected major version. This is usually unnecessary and is not usually done (if we're calling into the wrong library we'll likely crash anyway), but since we have the information, we might as well continue to use it. The second check is whether the version provided by the caller is equal to or greater than a threshold version at which additional fields were added to the struct. If it is, we should populate those fields; if it is not, then we cannot. This is only useful on platforms where additional fields have genuinely been added during the lifetime of SDL 2, like Windows and DirectFB (but not X11). This commit changes the first check to be consistent about only looking at the minor version, while leaving the second check using SDL_VERSIONNUM (which will be removed or widened in SDL 3, but it's fine for now). Resolves: https://github.com/libsdl-org/SDL/issues/5711 Fixes: cd7c2f1 "Switch versioning scheme to be the same as GLib and Flatpak" Signed-off-by: Simon McVittie <smcv@collabora.com>

e4b5afa5

2022-05-21T13:16:12

fix unused variable depending on YUV format

e59cba95

2022-05-21T13:50:56

add libdecor_dispatch

9edd411a

2022-05-19T17:15:10

x11: send move/resize events when waiting on fullscreen change. Otherwise we ignore the Configure/etc events when they come in because the window is already in an identical state as far as SDL is concerned. Fixes #5593. May also fix: Issue #5572. Issue #5595.

b798e49c

2022-05-19T21:44:38

Fix build warning with MSVC

9dfa000b

2022-05-18T20:20:03

Initial support for building for Windows with OpenWatcom

5669743a

2022-05-19T09:45:57

Make sure SDL_CaptureMouse() is only called on the main thread Windows handles mouse capture on a per-thread basis, and capture must be done on the thread used to create a window. Fixes https://github.com/libsdl-org/SDL/issues/5577

501a4991

2022-05-05T18:44:32

Add clang-format on/off comments where necessary. Comments were added in places where INDENT-ON/OFF comments are. Places like stdlib's asm don't need it as clang-format doesn't try to indent it.

0e6d4baa

2022-05-19T01:23:24

Fixed compile warning on gcc 11

c7dff3a2

2022-05-19T00:35:22

Attempt to get the X1 and X2 button state on X11 by using the current event state instead of direct X11 query.

57130b75

2022-05-19T00:31:20

Revert "x11: get x1/x2 button state in GetGlobalMouseState" This reverts commit 3fcc2cb500a752698687ad0c8bb14778e6cb84c3. Button4 and Button5 are for the scrollwheel, not the extended buttons. I don't know of a way to query the state of the extended buttons using X11.

e19a9a79

2022-05-18T15:29:59

Fixed a message box getting the mouse capture state out of sync

c8eea020

2022-05-18T21:14:20

Fix C89 build errors in Windows builds

0cca71a8

2022-05-18T22:12:05

Use SDLCALL for callbacks in public APIs

06aca7ed

2022-05-18T10:09:24

Fixed warping back into the window when gaining focus with warp relative mode enabled

56665e1d

2022-05-17T12:50:13

cocoa: Try to use better system cursors. These try to pull from the .pdf files that are installed with macOS, which fit our needs better, and fall back to the most reasonable defaults available from NSCursor if we can't load them. Since these are installed under /System, they should be sandbox accessible, and if this totally fails, it should still go on, albeit with a less good cursor. Reference Issue #2123.

e9c7b519

2022-05-16T21:03:41

macOS: Fix reference counts of internal window data. Fixes crashes when destroying or recreating a window (#5664).

2317a96c

2022-05-16T10:50:13

x11: Use XC_top_left_corner/XC_top_right_corner instead of XC_fleur. On Gnome (and hopefully others!), this produces something that actually matches SDL_SYSTEM_CURSOR_SIZENWSE/SDL_SYSTEM_CURSOR_SIZENESW. On other desktop enviroments, it probably fits the spirit better than XC_fleur in any case. Reference Issue #2123.

e4bb3c86

2022-05-11T18:13:44

wayland: Fix build for configs without libdecor

6222bd31

2022-05-11T16:26:43

wayland: Don't create a new libdecor context if one already exists

6f88cbe4

2022-05-11T16:04:34

wayland: Support xdg_decoration requesting client-side decorations. Don't be fooled by the diff size - this ended up being a big refactor of the shell surface management, masked only by some helper macros I wrote for the popup support. This change makes it so when xdg_decoration is supported, but CSD is requested, the system bails on xdg support entirely and resets all the windows to use libdecor instead. This transition isn't pretty, but once it's done it will be smooth if decorations are an OS toggle since libdecor will take things from there. In hindsight, we really should have designed libdecor to be passed a toplevel, having it manage that for us keeps causing major refactors for _every_ change.

9b75fa01

2022-05-11T18:31:34

N-Gage port: add changes from code reviews, overall cleanup (#5618) * Add changes from code review by @ccawley2011, #5597, overall cleanup * Update N-Gage README, minor cleanup and rephrasing * Call SDL_SetMainReady() before calling SDL_main, return SDL_main instead of main

6da99d4a

2022-05-11T08:40:17

Don't use SDL_SIMDFree() if the pixels haven't been allocated with SDL_SIMDAlloc()

2f924020

2022-05-05T20:12:07

Add SDL_SCANCODE_CALL and SDL_SCANCODE_ENDCALL

2bc37362

2022-05-05T13:31:26

Add SDL_SCANCODE_SOFTLEFT and SDL_SCANCODE_SOFTRIGHT

f871c178

2022-05-10T17:32:24

macOS: remove dead code for supporting 10.6 at runtime.

ec8fa577

2022-05-07T21:57:23

macOS: always use Objective-C ARC (automatic ref counting). Change Cocoa SDL_VideoData and SDL_WindowData implementations from C structs to Objective-C objects, since bridging between C and ObjC is easier that way.

adac3bd1

2022-05-03T12:31:50

video: restore ability to disable fb accel via hint Somewhere in code refactoring between .20 and .22 this check was lost, and so the hint had no effect anymore.

fbd230bb

2022-05-03T17:51:49

Add support for the Nokia N-Gage (#5597) * Add initial support for the Nokia N-Gage * N-Gage: disable clipping for the time being, issue needs to be resolved later * Move va_copy definition to SDL_internal.h * Move stdlib.h include to SDL_config_ngage.h, much cleaner this way * Remove redundant include, add HAVE_STDLIB_H * Revert "N-Gage: disable clipping for the time being, issue needs to be resolved later" This reverts commit 4f5f0fc36cc7f34fad05e45671dfa7b8dc32fd51. * N-Gage: fix clipping issue by providing proper math functions

3fcc2cb5

2022-05-03T11:19:39

x11: get x1/x2 button state in GetGlobalMouseState

6c2928b4

2022-04-29T19:30:47

Switch uses of MIN() to SDL_min() We're excluding files in src/hidapi to minimize the diff against the upstream project.

7e636b03

2022-04-29T10:16:14

Removed log message length limitation for Apple platforms This works in conjunction with https://github.com/libsdl-org/SDL/pull/5584

12f15aaa

2022-04-27T10:03:32

fix build

05bd225a

2022-04-26T23:14:44

x11: If XRandR isn't available, add a generic display. We can get _some_ of the info we need out of standard Xlib and report a single display (which might actually be multiple physical displays mushed into a single desktop). This is better than nothing, but you should really just build with XRandR support and get a better X server. :)

ccc70e64

2022-04-26T23:14:21

x11: Fixed some compiler warnings.

7d7ec9c9

2022-04-26T16:41:28

x11: Remove XVidMode and Xinerama support. Fixes #1782.

b293888c

2022-04-26T19:44:34

Fixes an issue introduced via #5573 when building for i686

01ef98a5

2022-04-26T10:19:03

Don't force keyboard auto-repeat on, if the user has disabled it for some reason Fixes https://github.com/libsdl-org/SDL/issues/2400

795744fc

2022-01-07T10:11:46

Turn off relative mouse before window checks as well

e2d268a3

2022-01-06T23:42:44

SDL_cocoamouse.m: SetRelativeMouseMode even if out of focus Should fix #3087

76afb858

2022-04-25T10:35:56

Introduces Cocoa_GetWindowDisplayIndex. This enable a proper management for dpi when switching between retina and non-retina displays.

53dea983

2022-04-25T13:51:15

x11: revert checks for _NET_WM_STATE_FULLSCREEN changes. This reverts commit 85977354fbce9ecb2add660a88e6bec3532c3e26. This reverts commit 0249df9d960f9bc28b476e1171c5501fc37cca12. Fixes #5572. Reopens #5390.

aeadbdd7

2022-04-20T09:00:00

Remove an unused function prototype

c8c59a21

2022-04-20T08:58:58

Fix a -Wshadow warning

3753a7b1

2022-04-19T14:42:39

Fix recent changes in VitaSDK

02225aa7

2022-04-18T22:57:03

Fixed build

49a2e4b0

2022-04-19T00:36:53

x11: Revert "Fix keymap updating for X11 backend" This reverts commit de6d290266d1def0eef9df81bf9be41c12a98c61. This patch had multiple issues, discussed in #5520.

9919d1a7

2022-04-18T11:51:09

Remove HWND_TOPMOST for fullscreen windows Fixes https://github.com/libsdl-org/SDL/issues/5509

2b529461

2022-04-15T11:51:02

video: Don't minimize fullscreen windows on focus loss by default when mode switching is disabled When mode switching is disabled in a video backend, fullscreen windows are basically just fullscreen desktop windows with different internal scaling. As no mode switching occurs, there's no need to minimize them on focus loss by default. This can still be overridden by explicitly setting the internal hint for minimizing on focus loss. This has the side effect of fixing a bug on GNOME, where, when a fullscreen Wayland window has it's focus lost and restored via alt+tab followed by switching back to windowed mode, the top portion of the window won't end up being obstructed by GNOME's top bar.

c37090f9

2022-04-18T12:30:08

wayland: Add support for TOOLTIP/POPUP_MENU

254fcc90

2022-04-18T09:03:14

Revert "video: Prefer Wayland over X11" This reverts commit 8ceba27d6291f1195e13608033ec439aec621fc6. SDL Wayland support is stable, but there are a number of issues with third-party software (NVIDIA drivers, libwayland event overflow, libdecor not handling plugin load failures, Steam overlay not working with Wayland, etc.) that make it better to default to X11 at this time. Games which would like to prefer wayland when available can use the following code before SDL_Init(): SDL_SetHint(SDL_HINT_VIDEODRIVER, "wayland,x11"); Fixes https://github.com/libsdl-org/SDL/issues/5527

c1336b21

2022-04-17T12:43:32

hints: Make SDL_VIDEODRIVER and SDL_AUDIODRIVER formal hints. They were just environment variables before. Fixes #5528.

67e0f546

2022-04-15T18:24:57

x11: Update the display when the WM changes a window's fullscreen state. Fixes #5390.

edb473cf

2022-04-15T15:03:28

video: Wayland: Always round scaled pointer coordinates down Rounding up can cause the pointer coordinates to exceed the window boundaries at the right and bottom edges.

13393a1c

2022-04-15T14:28:07

video: Wayland: Clamp fullscreen window dimensions to desktop A scaled fullscreen window may exceed the bounds of the desktop. Clamp the window size to the desktop dimensions in fullscreen mode.

01b14e14

2022-04-12T08:49:19

avoid NullPointer in SDL_GL_MakeCurrent

9c2f46b0

2022-04-12T15:23:22

Wayland: Add SDL_HINT_VIDEO_WAYLAND_PREFER_LIBDECOR This hint allows libdecor to be used even when xdg-decoration is available. It's mostly useful for debugging libdecor, but could in theory be used by applications which want to (for example) bundle their own libdecor plugins.

c2093fab

2022-04-08T13:58:45

video: wayland: Set the surface damage region when using fullscreen viewports When using emulated display modes, the output size is often larger than the drawable buffer. As the surface damage region is automatically calculated from the smaller drawable buffer size, the damage region needs to be manually set to cover the entire viewport region or visual repaint artifacts can result.

5613a560

2022-04-07T11:32:22

Make sure the UIKit message box is being handled on the main thread Potentially fixes https://github.com/libsdl-org/SDL/issues/4865

49b9e347

2022-04-07T08:24:03

Only update modifier state for keys that are pressed in another application Fixes https://github.com/libsdl-org/SDL/issues/4432

85977354

2022-04-07T09:14:33

x11: Treat WM setting the window "fullscreen" like FULLSCREEN_DESKTOP. Fixes #5390.

d1f7f9e3

2022-04-06T11:18:46

wayland: Pin the fake window position at (0, 0). I kind of thought it'd be nice to have it in the center, but this is an issue for applications that still assume global mouse and window positions are accessible. For example, this fixes cursor offset issues in UE5.

279aeb59

2022-04-06T01:32:57

wayland: Add a bug link for the detach FIXME

3ada694e

2022-04-06T01:18:03

wayland: Try to detach at the beginning of ShowWindow, just in case. It's possible that an external component (probably a GL/VK context) committed, so we need to cover our bases and detach in both HideWindow and ShowWindow. Fixes a crash in UE5 editor's pop-ups.

dcfb7fff

2022-04-06T00:55:32

wayland: Evaluate WINDOWPOS_CENTERED_DISPLAY for move events Partially fixes the mouse cursor in UE5 editor. Imperfect because UE5 uses window position and global mouse state to get position, but of course we don't have global mouse and this is just to get the right display index so this still fails overall. We really need to make global mouse support a feature query...

kc3-lang/SDL/src/video

src/video

Log