|
cd157aae
|
2022-01-12T14:44:50
|
|
Revert "Use STL container for vulkan memory allocator"
This reverts commit cc516f97018fdcbcded2b0bad712a0bc2af4e227.
Reason for revert:
This is not the right way to use STL containers in VMA.
See [1] for detail.
[1] https://chromium-review.googlesource.com/c/external/github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator/+/3381940
Original change's description:
> Use STL container for vulkan memory allocator
>
> There is a crash related to VMA containers, so switch to STL
> containers to see if it can workaround the issue.
>
> Bug: chromium:1266412
> Change-Id: I8416e4b4a27588ac2d710a4ef7600cd91b080535
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3327744
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Peng Huang <penghuang@chromium.org>
Bug: chromium:1266412
Change-Id: Ib020c824a3576489c728503a2ced68ca772d4065
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3381979
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
|
|
d4c8209b
|
2022-01-10T13:30:06
|
|
Fix validation of copyImageSubData related to texture completeness
Fixed an edge case in validation code where we were not properly
ignoring format rules for texture completeness as required for
copyImageSubData by the ES 3.2 specification
Bug: angleproject:5363
Tests: KHR-GLES32.core.copy_image.r32*_texture
Change-Id: Ibf8a6f4708e2135f0eb6f4ba58d4ce413f11ce5b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3379224
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
|
|
|
96fd9b72
|
2022-01-10T13:17:43
|
|
Fix validation of glCompressedTexImage3D
GLES 3.2 spec allows for glCompressedTexImage3D to accept
TEXTURE_CUBE_MAP_ARRAY as a target as well. Account for this
during validation.
Bug: angleproject:5393
Tests: KHR-GLES32.core.texture_cube_map_array.etc2_texture
Change-Id: Ieb75e63021bea2ea6f8fcc68bd6b666d0bd7f5dc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3379225
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
|
|
926b43e7
|
2022-01-06T13:31:54
|
|
Reland: Frontend: separate lock in swap prep
Swapchain-based backends like Vulkan might block a lot in
vkAcquireNextImageKHR, which is bad for overall fast progress if we also
hold the global EGL lock there.
This CL starts to split the global EGL lock. We release the EGL lock
when performing vkAcquireNextImageKHR, and only maintain a lock for
surfaces.
This is done via a new custom entry point, EGL_PrepareSwapBuffers, so
that we can control how the global lock is used throughout the entire
call.
Bug: angleproject:6851
Change-Id: I095cd8b3bdbb13c842cab0a46148e2122582cdfd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3373426
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Lingfeng Yang <lfy@google.com>
|
|
|
2d105177
|
2022-01-10T11:44:37
|
|
Enable a few features for Samsung
Check for Samsung vendorID and enable a few features.
Bug: angleproject:5111
Change-Id: I17a93bfb9a094b80d185eb3d2a08ed00f528a30b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3379223
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
|
|
345cdcb0
|
2022-01-10T22:41:46
|
|
Rename features for consistency.
supports_custom_border_color -> supportsCustomBorderColor
supports_protected_memory -> supportsProtectedMemory
Also drop EXT from the end of the variable name as other variables don't
have that.
Bug: angleproject:6731
Change-Id: I60b20d84387bccbca0c4c1cbc7e341c1f5e8f0ba
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3378827
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Roman Lavrov <romanl@google.com>
|
|
b0e15ee4
|
2021-12-28T20:37:33
|
|
Decide GL_KHR_parallel_shader_compile in backends
GL_KHR_parallel_shader_compile was previously being enabled
unconditionally in the front end. However, some backends (Vulkan)
perform worse with parallel shader compilation. This CL moves the
decision of enabling GL_KHR_parallel_shader_compile to the backends.
To support single-threaded shader compilation without affecting the
generic worker thread pool, Context::mSingleThreadPool is added to own
the single-threaded WorkerThreadPool and can be returned by the new
function Context::getShaderCompileThreadPool(). Otherwise, if the
extension is enabled, the (renamed) Context::mMultiThreadPool is
returned.
Bug: angleproject:6748
Change-Id: Ic8d3a183f397608f3002a05480deb976dfe44792
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3360337
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
a026d053
|
2021-12-22T01:08:33
|
|
Add support for subgroupSize of 16 in Debug Overlay Module
The subgroupSize on some Android devices is 16, which is not
supported by current OverlayCull and OverlayDraw compute
shaders. This change adds support for subgroupSize of 16.
This change also removes the subgroupBallot and subgroupArithmetic
paths in OverlayCull compute shader.
These two paths were added by Shabi as an experiment,
and he suggested to remove them for easier code maintenance purposes.
Bug: angleproject:6806
Change-Id: I5ce68cb18fbf3472c987d811c89f065cb8581858
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3352865
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Yuxin Hu <yuxinhu@google.com>
|
|
f180ecc9
|
2022-01-11T10:32:23
|
|
Supress TransformFeedbackPausedDrawThenResume on Mac AMD
Mac AMD OpenGL fails this test the same way as
TransformFeedbackTest.TransformFeedbackQueryPausedDrawThenResume
Bug: angleproject:6643
Change-Id: Ifbae1751deeaddbe64fa1ac284e0fa04e02c666f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3380009
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
|
|
0b02a592
|
2022-01-10T20:27:25
|
|
Metal: Generated Metal shaders do not compile offline
Add an explicit include for the Metal stdlib to fix missing
symbol errors
Bug: angleproject:6886
Change-Id: Ie84ef1c16f964387b63e36490d7e9abc0c1763f2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3379238
Reviewed-by: Kyle Piddington <kpiddington@apple.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
|
|
6a255833
|
2022-01-07T16:13:58
|
|
Metal: Fix transform feedback issue
The issue is if you issue 2 draw commands back to back,
Metal partially ignores the 2nd.
Bug: angleproject:6884
Change-Id: I702335ca06828bed1f553f1f5563ddc99f00bc99
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3373736
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kyle Piddington <kpiddington@apple.com>
Commit-Queue: Gregg Tavares <gman@chromium.org>
|
|
|
37cde9e9
|
2022-01-10T10:59:28
|
|
Update GLES31 expectations file
The commit f9dbd4efb3b8c1550 fixed a validation bug related to
framebuffer and texture buffers but missed updating the
expectations file. Remove skip for related test.
Bug: angleproject:5579
Tests: dEQP-GLES31.functional.debug.negative_coverage.get_error.buffer.framebuffer_texture
Change-Id: Id8807479e63d886b85512a88eaaeac93488e0545
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3377763
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
|
|
|
e38dab0a
|
2022-01-10T10:58:40
|
|
Add missing implementation for glGetnUniformuiv()
GL_KHR_robustness became core in GLES 3.2 and added
glGetnUniformuiv() function in gles_3_2 entry points but this
function was missing implementation in Context.cpp. Also fixes
ES32 validation for glGetnUniform*v
Bug: angleproject:6593
Tests: KHR-NoContext.es32.robustness.getnuniform
Change-Id: Ic26190e59d448d93ae9e2e0d2a7faff14c3776f8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3373436
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
|
|
74e03b9a
|
2022-01-06T11:23:12
|
|
Expose the registryID of GPUs on Mac via SystemInfo
As part of a new extension, ANGLE_platform_angle_device_id,
GPU selection on Mac will depend on the registry ID of each GPU.
These Ids must be listed in SystemInfo for Chrome to select from.
Bug: angleproject:6143
Change-Id: I7ee4a796d2cb26138893dc068a60cac355fe7ba9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3370661
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
|
|
9d11a341
|
2021-12-16T13:47:04
|
|
Vulkan: Fix Vulkan SCB vs multiple subpasses
vkCmdNextSubpass must be called on the primary command buffer, so the
render pass command buffers need to be split on subpass boundaries.
This is only done when using Vulkan secondary command buffers.
Bug: angleproject:6811
Change-Id: I087fff305c757c78e87bfde4410e7de6bd1a6ba6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3344774
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
acd8fc76
|
2021-12-16T01:05:02
|
|
Vulkan: Distinguish RP and outside-RP command buffer types
What goes inside and outside a render pass command buffer is largely
mutually exclusive. Moreover, the size and frequency of allocations is
different between the two.
This change distinguishes the C++ types used for inside and outside
render pass command buffers:
- The type now documents which command buffer a function is able to
receive.
- `isRenderPass` flag passing, checking and asserting is largely
removed.
- A follow up change experiments with using different (Vulkan vs ANGLE)
secondary command buffers for inside and outside RP command buffers.
- A future change could specialize the pool behaviors per command buffer
type.
Bug: angleproject:6811
Change-Id: Ia4bc669d26ac7e94e8a0dfb9b361666c82f42cc3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3344373
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
eea78468
|
2021-12-23T11:48:36
|
|
Tests: Add Angry Birds 2 launch trace
Test: TracePerfTest.Run/*_angry_birds_2_launch
Bug: angleproject:6848
Change-Id: Id37fad6c7f78adbac872bcb98c3bd1f608194b14
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3355357
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
|
095d7c0a
|
2022-01-06T01:20:53
|
|
Translator: Clean up spec const / driver uniform types
Bug: angleproject:6755
Change-Id: I8fb1557a5e29fcc28d5cb2f3aaa2c4a14b72583d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3369125
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
5c9bd7ba
|
2022-01-07T12:23:08
|
|
Update Mac goldctl
Updates DEPS and the Chromium roller script to have both an x64
and arm64 version of goldctl on Mac. Also updates the goldctl
build group to include both binaries.
Bug: chromium:1280002
Change-Id: I82c9c93eb865fb68ad242454415606c9ef2846fd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3373623
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
|
|
9d042d68
|
2022-01-06T16:36:36
|
|
Cleanup after iOS build fixes
Bug: angleproject:6871
Change-Id: Ia5cd33c4532e10e61c1ca2c35d5190df97e36f5f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3370867
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
b0feea4e
|
2022-01-07T14:58:13
|
|
Suppress failing test on Vulkan/Intel/Linux.
Bug: angleproject:6881
Change-Id: I4ece10422e21f6c27a81da881421e60236463de0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3373167
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
60a8b593
|
2022-01-05T11:06:16
|
|
Vulkan: Remove std::unique_ptr usage from BufferVk::mBuffer
BufferVk::mBuffer is std::unique_ptr mostly because BufferHelper object
itself does not support move assignment. Now crrev.com/c/3366855 added
move assignment support, we can now use BufferHelper directly. The main
downside I can see is that in BufferVk::ghostMappedBuffer() and
BufferVk::acquireAndUpdate() functions where we have to use move
assignment of mBuffer object, it becomes slightly more expensive than
moving pointer. But switch to using BufferHelper directly makes code
simpler and other access to mBuffer (which is more common usage)
slightly cheaper by removing one pointer indirection.
Bug: b/208323792
Change-Id: Ia7e7731e284eb6c76db954fef194e9d1de82174b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3362252
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
217dc204
|
2022-01-07T13:43:07
|
|
Broaden TSAN EGL multithread suppression.
Other non-random tests can be flaky as well. Because we can't retry
crashing tests with the flaky expectation, mark these tests as
skipped for now.
For more info and possible workarounds see http://crbug.com/1275223
Bug: angleproject:6678
Change-Id: I48d9287e538d0f1141d6871d2948c3f2902ea1c4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3373166
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
ae1a56b6
|
2022-01-06T17:04:41
|
|
Vulkan: Turn on GL_EXT_shader_framebuffer_fetch for ARM
On ARM, coherent is the default behavior of framebuffer fetch, so
we can expose the GL extension.
Tests: Dead By Daylight app and trace
Bug: b/201764768
Bug: angleproject:6870
Bug: angleproject:6872
Change-Id: I0f98c57e20619d73d1507c4655e7f9bb8c10a53a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3371244
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
9d668d6c
|
2022-01-07T18:18:23
|
|
Revert "Frontend: separate lock in swap prep"
This reverts commit 40c5cb255c0a07bdab574aa076ee603e7d791ab3.
Reason for revert: Regression in TSAN caused by this CL:
https://ci.chromium.org/ui/p/angle/builders/ci/linux-tsan-test/352/overview
Original change's description:
> Frontend: separate lock in swap prep
>
> Swapchain-based backends like Vulkan might block a lot in
> vkAcquireNextImageKHR, which is bad for overall fast progress if we also
> hold the global EGL lock there.
>
> This CL starts to split the global EGL lock. We release the EGL lock
> when performing vkAcquireNextImageKHR, and only maintain a lock for
> surfaces.
>
> Bug: angleproject:6851
> Change-Id: I329d5c4c579718a4980c4261590f77099ce1400e
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3361249
> Reviewed-by: Charlie Lao <cclao@google.com>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Commit-Queue: Lingfeng Yang <lfy@google.com>
Bug: angleproject:6851
Change-Id: Ie03b784021f7b8b5c1ef95a911ef7da4029abd46
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3373165
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
b2dac79d
|
2022-01-07T06:55:04
|
|
Fix typo in EGLPrintInfo end2end Test
Version query had incorrect enum in EGLPrintInfo test.
Replace EGL_VENDOR enum with EGL_VERSION enum.
Bug: angleproject:4039
Test: EGLPrintEGLinfoTest.PrintEGLInfo
Change-Id: Ie056f4547f03d5c777b04f2a9cf652496e72702b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3373128
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: mohan maiya <m.maiya@samsung.com>
|
|
|
462cdb08
|
2022-01-06T18:46:21
|
|
Capture/Replay: Reset FBOs, RBOs, VAOs
Add resetting framebuffers, renderbuffers, and vertex arrays to
MaybeResetResources().
This is required to prevent leaks in app launch traces, such as Angry
Birds 2 (com.rovio.baba).
Bug: angleproject:4599
Change-Id: I34b45ecb1a1b5144f1e23b6bc56315f7713fed94
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3371881
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
|
4472b3b0
|
2022-01-07T11:47:32
|
|
Fix TSAN suppressions.
Bug: angleproject:6746
Change-Id: I015b45d3a258a368c031b040102efce4d2c7cd38
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3373164
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
40c5cb25
|
2022-01-06T13:31:54
|
|
Frontend: separate lock in swap prep
Swapchain-based backends like Vulkan might block a lot in
vkAcquireNextImageKHR, which is bad for overall fast progress if we also
hold the global EGL lock there.
This CL starts to split the global EGL lock. We release the EGL lock
when performing vkAcquireNextImageKHR, and only maintain a lock for
surfaces.
Bug: angleproject:6851
Change-Id: I329d5c4c579718a4980c4261590f77099ce1400e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3361249
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Lingfeng Yang <lfy@google.com>
|
|
|
c2a29614
|
2022-01-04T14:24:57
|
|
Test Expectations: Use file order as override priority.
Now expectations that happen first in the file will override those
later expressions. This fixes the weird conflict that could occur
when we use wildcards inside the expression. e.g.:
a) 6746 : *BadConfig = SKIP
b) 5076 : TestSuite.Test/* = TIMEOUT
Previously b) would override a) for TestSuite.Test/BadConfig and we
would give the expectation as TIMEOUT because the string length of
the expectation was longer.
This will allow us to use short skip expressions for e.g. TSAN.
Bug: angleproject:6746
Change-Id: I2dc651c3593c02b6f8723d67c0fc311701ee15f8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3365659
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
ece46380
|
2021-12-15T14:34:07
|
|
tests/EGLProtectedContentTest: Add QueryContext test.
Add a test that calls eglQueryContext to query
EGL_PROTECTED_CONTENT_EXT.
This functionality was implemented by
1fc9b7c6e0e4be4e6ebdc1bd8ccca58fa0fdecfd.
Test: angle_end2end_tests --gtest_filter="EGLProtectedContentTest.QueryContext*"
Bug: angleproject:6693
Bug: angleproject:6870
Change-Id: I05e6dde96e120ea81e7d4374990e05def100e290
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3358206
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
|
|
1e2856fd
|
2022-01-07T13:04:39
|
|
Update freetype-py wheel
Bug: chromium:1282168
Change-Id: I7daac60c540d6f67620fba2823ac0d4d36845a13
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3372783
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
2ebdd23b
|
2021-12-28T10:37:49
|
|
Cleanup TextureCubeTestES3.CubeMapPixelUnpackBuffer
Clean up TextureCubeTestES3.CubeMapPixelUnpackBuffer by removing the
unused shader variable 'uLod'.
Bug: b/194140619
Test: TextureCubeTestES3.CubeMapPixelUnpackBuffer
Change-Id: I14776b34c5921fc4d4177bdaed205843b27b9e94
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3359777
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
|
caf6433a
|
2022-01-04T14:37:29
|
|
Vulkan: Rename releaseStagingBuffer to releaseStagedUpdate
There is no more per ImageHelper dynamic buffer for staging, and this
function is not just removing staging buffer, but removing all staged
updates. Rename it to reflect what it actually does.
Bug: b/208323792
Change-Id: I5a2182291848a9e137ed29b888f31215664b46fd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3367078
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
93159c02
|
2021-12-30T16:01:52
|
|
Vulkan: Remove DynamicShadowBuffer implementation
This is no longer used since mShadowBuffer was removed from BufferVk in
https://chromium-review.googlesource.com/c/angle/angle/+/3313333
Bug: b/208323792
Change-Id: I0bb1d66c2f0f58bac74139a274c957681edf2ad4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3362504
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
cf381292
|
2022-01-06T21:23:18
|
|
Revert "Re-skip MSRTT tests on Linux/AMD/Vulkan"
This reverts commit 4b3e3ed5f0dab222b2a7613de75bfeacd5262ae8.
Reason for revert: tests pass on AMDVLK 2021.Q4.3
Original change's description:
> Re-skip MSRTT tests on Linux/AMD/Vulkan
>
> They crash when vkCreateRenderPass2 is used, as if the RP2 extension is
> exposed but the entry points are missing.
>
> Bug: angleproject:6845
> Change-Id: Ia21cf039b49d5ab2772c7ecddd03df6360449d20
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3363637
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Bug: angleproject:6845, angleproject:5380
Change-Id: I4ed7251438381560f2c171ee36a2a78bfa4d56a1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3370866
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
3263eb01
|
2021-12-28T10:10:50
|
|
Vulkan: Switch GPU translated vertex buffer to NonHostVisible
When we translate using GPU, there is no need to use host visible
memory. Use device local memory instead.
Bug: b/205337962
Change-Id: Ic76dcb28bde2f079f6ac406d846518bf5f369d74
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3340553
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
8589c456
|
2021-12-22T17:13:33
|
|
Vulkan: Remove mStagingBuffer from ImageHelper and ContextVk
This CL removes ImageHelper::mStagingBuffer and
ContextVk::mStagingBuffer and uses per shared group staging buffer pool
instead.
Bug: b/208323792
Change-Id: I46b5fd542697eb860def9c6d592dd147ad4dc973
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3354090
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
6da1ac81
|
2021-12-22T10:13:43
|
|
Vulkan: Switch ReadPixels from DynamicBuffer to shared pool
FramebufferVk::readPixelsImpl() and ImageHelper::copyImageDataToBuffer()
use per FramebufferVk DynamicBuffer. This CL removes this and uses
shared buffer pool to allocate a temporary staging buffer for readPixels
as needed and frees it immediately afterwards.
Bug: b/208323792
Change-Id: I65ddf9bf9f1f14578d9def63f5287cb1a4121dff
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3354038
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
ad27d5d6
|
2021-12-21T11:22:30
|
|
Reland "Vulkan: Consolidate all vertex conversion buffers to shared pool"
This is a reland of cca412cd8b349b7281727c50f2a59d115fd90a05
Further inspection shows it was red-herring. The original CL does not
have the un-intended diff that I saw in the commit email. This is
try to reland the original CL without any modification.
Original change's description:
> Vulkan: Consolidate all vertex conversion buffers to shared pool
>
> There are various conversion buffers that holds converted vertex or
> element or index data. They are DynamicBuffer for now. This CL switches
> them to use the shared group buffer pool. With this change, all
> allocation is represented by a BufferHelper object instead of an offset.
> I am able to remove the offset arguments from a lot of APIs.
>
> Bug: b/208323792
> Change-Id: Ib611beb0c16cddbdd9ddf7b8961c439da9fa5180
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3352489
> Reviewed-by: Tim Van Patten <timvp@google.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Charlie Lao <cclao@google.com>
Bug: b/208323792
Change-Id: I90852ad38c2b9ac423800bb6854757bcc17cd166
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3370602
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
a61a7f59
|
2021-12-28T18:16:40
|
|
Vulkan: Use correct aspectMask
Update ImageHelper::stageSubresourceUpdateFromImage() to use the correct
aspectMask flags based on the image's format, rather than assuming only
color formats.
Additionally, only call ensureMutable() for sRGB textures that indicate
srgbDecode == GL_SKIP_DECODE_EXT.
Bug: angleproject:6852
Test: DepthStencilFormatsTest.DepthTextureRender
Change-Id: Iaf1f167612144f836c5574b0f561cc1b58c3cb6a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3360090
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
|
4e85bdd9
|
2022-01-06T17:06:25
|
|
Revert "Vulkan: Consolidate all vertex conversion buffers to shared pool"
This reverts commit cca412cd8b349b7281727c50f2a59d115fd90a05.
Reason for revert: There is accidental code merge bug left in.
Original change's description:
> Vulkan: Consolidate all vertex conversion buffers to shared pool
>
> There are various conversion buffers that holds converted vertex or
> element or index data. They are DynamicBuffer for now. This CL switches
> them to use the shared group buffer pool. With this change, all
> allocation is represented by a BufferHelper object instead of an offset.
> I am able to remove the offset arguments from a lot of APIs.
>
> Bug: b/208323792
> Change-Id: Ib611beb0c16cddbdd9ddf7b8961c439da9fa5180
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3352489
> Reviewed-by: Tim Van Patten <timvp@google.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Charlie Lao <cclao@google.com>
Bug: b/208323792
Change-Id: I18bba207d1d8bb76dff32d9855a744dba93bc6d6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3370601
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
cca412cd
|
2021-12-21T11:22:30
|
|
Vulkan: Consolidate all vertex conversion buffers to shared pool
There are various conversion buffers that holds converted vertex or
element or index data. They are DynamicBuffer for now. This CL switches
them to use the shared group buffer pool. With this change, all
allocation is represented by a BufferHelper object instead of an offset.
I am able to remove the offset arguments from a lot of APIs.
Bug: b/208323792
Change-Id: Ib611beb0c16cddbdd9ddf7b8961c439da9fa5180
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3352489
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
02f6226b
|
2022-01-06T09:07:29
|
|
Avoid using GetCWD() on MacOS when possible
GetCWD is unreliable on MacOS and often fails or returns an
undesirable directory. This CL makes the number of GetCWD()
calls go from 2 to 0 when running content_shell locally on
MacOS, which makes it start successfully with SwANGLE
enabled. The 2 changes are:
1) Don't attempt to change the current working directory on
MacOS for Validation Layers. This doesn't work as intended
anyway and, on a GetCWD failure, ends up changing the ICD
from SwiftShader to Default when using SwANGLE, which can
make test runs fail.
2) Don't always call GetCWD() when calling
GetModuleDirectory(). It is only required when the module
path is not a full path, at which point some error info
was added to help understand what's happening if we get
into this case.
Bug: chromium:1246171
Change-Id: Ib96142661dee3e06980eac4ffc3743aae8b97950
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3370036
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
|
|
|
fd014271
|
2021-12-16T20:44:42
|
|
Vulkan: Match chromaFilter to min/mag for YUV AHBs
From the VVL:
VUID-VkSamplerCreateInfo-minFilter VkCreateSampler:
VK_FORMAT_FEATURE_SAMPLED_IMAGE_YCBCR_CONVERSION_SEPARATE_RECONSTRUCTION_FILTER_BIT
specifies that the format can have different chroma, min, and mag
filters. However,
VK_FORMAT_FEATURE_SAMPLED_IMAGE_YCBCR_CONVERSION_SEPARATE_RECONSTRUCTION_FILTER_BIT
is not supported for VkSamplerYcbcrConversionCreateInfo.format =
VK_FORMAT_UNDEFINED so chromaFilter needs to be equal to
minFilter/magFilter.
We don't know what the min/mag filters are when the AHB is imported, so
we need to update the YcbcrConversionDesc with the current min/mag
filter value before creating the VkSamplerYcbcrConversion when the
ImageView is created. Additionally, if the min/mag filters are updated
later, TextureVk::syncState() needs to recreate the ImageViews to ensure
the chromaFilter matches the new min/magFilters.
Test: atest android.media.cts.DecodeAccuracyTest#testGLViewDecodeAccuracy[0]
Test: ImageTestES3.SourceYUVAHBTargetExternalYUVSampleLinearFiltering
Bug: b/210526871
Change-Id: I95dbd9738f6e3fd0870e484518eee105e995f93a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3346394
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
abf17f01
|
2021-12-10T17:10:53
|
|
Metal: Support depth filtering queries for D32, D24S8
Port changes from https://bugs.webkit.org/show_bug.cgi?id=232071
Bug: angleproject:6779
Change-Id: Id2d7a0c215e4db072b8830aedd90b878f3817967
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3331666
Reviewed-by: Gregg Tavares <gman@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kyle Piddington <kpiddington@apple.com>
|
|
|
f13f440e
|
2021-12-15T15:11:05
|
|
Reland: Metal: Fix Webkit warnings in ANGLE build
Fix nullable warnings, unused functions
Add in additional function specification to FormatStringIntoVector
to correctly fix warning
Bug: angleproject:6781
Change-Id: I26af2d698f14d353832802aa7b5ce34c5a1f4b95
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3366796
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Kyle Piddington <kpiddington@apple.com>
|
|
39e1a2b2
|
2022-01-05T13:58:46
|
|
Suppress Vulkan/SwiftShader/AsyncQueue ASAN flakes.
TransformFeedbackTest.SpanMultipleRenderPasses/
ES3_Vulkan_SwiftShader_AsyncQueue
and several tests underneath:
ComputeShaderTest.*/ES3_1_Vulkan_SwiftShader_AsyncQueue
have been observed flaky on the CQ on both Windows and Linux ASAN
bots. Skip them temporarily.
Bug: angleproject:6875
Change-Id: I7a849510e0b1d32209cf518f17d1609a10572a54
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3364967
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
|
|
|
7126c3a3
|
2021-12-23T16:58:25
|
|
Capture/Replay: Limit caps for QC/SwS
On Pixel 4 (Qualcomm), GL_MAX_ATOMIC_COUNTER_BUFFER_BINDINGS = 6, so
limit mState.mCaps.maxAtomicCounterBufferBindings to 6 to make traces
more portable.
For SwiftShader, MAX_SHADER_STORAGE_BUFFER_BINDINGS = 12, so limit
mState.mCaps.maxShaderStorageBufferBindings to 12 to make traces more
portable.
These limits affect collecting traces for Angry Birds 2
(com.rovio.baba).
Bug: angleproject:6848
Test: TracePerfTest.Run/*_angry_birds_2_launch
Change-Id: Ie8364c8b04d1b82655c4a95b3983f618f478e23c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3355555
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
|
0e49a3dd
|
2022-01-04T11:23:54
|
|
Vulkan: Add std::move support for BufferHelper
There are needs to support std::move for BufferHelpers in other CLs (See
crrev.com/c/3352489). Without this support, we can not store
BufferHelper into std::vector. This CL adds move support for
BufferHelper class.
Bug: b/208323792
Change-Id: I93f79490715750abc1bcedd41b683ad0c2460ebb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3366855
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
43b0e92b
|
2021-12-13T15:38:32
|
|
Vulkan: Consolidate mHostVisibleBufferPool and mMapInvalidate
BufferVk::mHostVisibleBufferPool is allocated when BufferVk::mBuffer is
not hostvisible and we need to map it. In that case
mHostVisibleBufferPool is allocated and data copied from mBuffer to it
and the pointer to mHostVisibleBufferPool is returned to user.
BufferVk::mMapInvalidateRangeStagingBuffer is used when map is called on
a small range. In this case we allocate memory for the small range of
buffer and return that intead of waiting for entire buffer for GPU to
finish. Also when BufferSubData is called, we also needs to allocate a
staging buffer and issue a copyBuffer from staging buffer to main
buffer. This CL consolidate all these three usage cases into one
mStagingBuffer. It removes mHostVisibleBufferPool and
mMapInvalidateRangeStagingBuffer from BufferVk class. This makes overall
logic of managing data consistency much simpler as well since we only
have two buffers: The main buffer storage mBuffer or mStagingBuffer. And
mIsStagingBufferMapped tracks if mStagingBuffer is the one actually
mapped to user or not so that at unmap time we know if we should flush
the data to mBuffer or not.
Bug: b/208323792
Change-Id: I4f0c79a2d86da1a43844ed2ba83ddeb7dd4a5c0b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3335216
Reviewed-by: Lingfeng Yang <lfy@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
42cb6147
|
2022-01-05T07:59:51
|
|
Revert workarounds for exception handler code-gen with CFG enabled
This reverts two commits:-
Revert "disable cfguards for all deqp tests"
This reverts commit 1d2752d84f497c8012af1f54b1b3ec52f9b5cc92.
Change-Id: I6d2647340592d3b9b5f2430d4fd077835528ef0b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3244256
Revert "Disable cfguard for tcu/depq test files"
This reverts commit 2ca35522660e780a13235d80c9c643dfb0e53faf.
Change-Id: Iae75dc0f911a3430276909f4a14944d0f805fdf2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3241703
A fix in https://reviews.llvm.org/D114914 should make this workaround
unnecessary. See https://crbug.com/1260847 for discussion.
Building Chrome with the following gn args, the following tests pass.
build_angle_deqp_tests = true
dcheck_always_on = true
is_component_build = true
is_debug = false
symbol_level = 2
target_cpu = "x86"
use_goma = true
win_enable_cfg_guards = true
.\out\swangle\angle_deqp_gles2_tests.exe --use-angle=swiftshader --bot-mode
.\out\swangle\angle_deqp_gles31_tests.exe --use-angle=swiftshader --bot-mode
Tests: CQ
Bug: chromium:1260847
Bug: angleproject:6617
Change-Id: Iff3b2a3cedb21bb16bb7dd7b30c3d3b4ecd79d78
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3368184
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
e4c7efea
|
2022-01-05T10:49:02
|
|
Capture/Replay: Fix GN build on iOS.
Bug: angleproject:6871
Change-Id: Ic9375b119b0323f219224944f755237d89cd521e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3368201
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
cabc3b98
|
2021-12-30T14:33:31
|
|
Move atomic counter uniform range counter to executable.
This makes the code more consistent with the other ranges. It will
make way for future refactorings to moving more uniform code to
the executable.
Bug: angleproject:3570
Change-Id: Ie365c0e184039f813f19d3f38b401ad8a0b72120
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3359001
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
e9e9a2c6
|
2022-01-04T20:14:48
|
|
Do not pass mInstance to vkGetInstanceProcAddr
for vkEnumerateInstanceVersion
Bug: angleproject:6869
Change-Id: Ifc93a067824c3467003a47bad240b3be10874ab0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3366038
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
|
|
beda2459
|
2021-12-09T14:24:08
|
|
Add support for GL_MESA_framebuffer_flip_y 2/*
This is a second CL that adds actual implementation
for GL_MESA_framebuffer_flip_y extension.
Also, some tests are added to verify the functionality.
Please note that bots do not support this extension yet,
and the tests were verified by running them locally.
Bug: chromium:1231934
Change-Id: Iea483aa13a298df6b5cf0b7b5ffb795a4666e3bd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3329603
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
|
|
|
c984dad5
|
2021-12-03T16:02:49
|
|
FrameCapture: Don't remove protection from shared pages.
Don't remove protection from pages that are shared when a
persistent coherent buffer storage is unmapped.
The shared page can still be relevant when the the other buffer is kept
and written to.
Add a PageSharingBuffers test that produces this behaviour.
Test: angle_end2end_tests --gtest_filter="BufferStorageTestES3.PageSharingBuffers/*"
Bug: angleproject:5857
Change-Id: I6927f25229d2dfe9f68ba9a993e9d3e994bc7ce0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3306623
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
|
|
|
cfc4db34
|
2021-11-04T16:54:15
|
|
Metal: Provoking vertex support for Metal DrawArrays
Add in provoking vertex rewrite support for
drawArrays command, enabling 6 dEQP tests.
GLES3/functional_rasterization_flatshading_line_loop
GLES3/functional_rasterization_flatshading_line_strip
GLES3/functional_rasterization_flatshading_lines
GLES3/functional_rasterization_flatshading_triangle_fan
GLES3/functional_rasterization_flatshading_triangle_strip
GLES3/functional_rasterization_flatshading_triangles
This patch adds a new shader to the Provoking
Vertex helper that generates draw commands for
all simple data types.
Fix bug in provoking vertex helper that caused
reused index buffers to suffer from allocation issues.
Also fix Provoking vertex for triangle fan generation
Bug: angleproject:5325
Change-Id: I7a1211dfcd99329868269ea0666eef1915d487b5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3261635
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kyle Piddington <kpiddington@apple.com>
|
|
|
aad7ddb2
|
2021-12-30T20:38:03
|
|
Skip VulkanPerformanceCounterTest.InvalidateDrawDisable
on Linux Vulkan AMD
Bug: angleproject:6857
Change-Id: I07484ae2253227d1abad8e554401b4e6da825cb3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3359004
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
4b3e3ed5
|
2022-01-01T09:57:12
|
|
Re-skip MSRTT tests on Linux/AMD/Vulkan
They crash when vkCreateRenderPass2 is used, as if the RP2 extension is
exposed but the entry points are missing.
Bug: angleproject:6845
Change-Id: Ia21cf039b49d5ab2772c7ecddd03df6360449d20
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3363637
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
9aca4285
|
2021-12-30T09:18:32
|
|
Traces: Fix path in retrace script.
This was accidentally regressed when removing the auto-generation.
Bug: angleproject:5133
Change-Id: I44e88bd15c9baaca66c49b1e379b2e0dd7206b3f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3362295
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@google.com>
Commit-Queue: Jamie Madill <jmadill@google.com>
|
|
|
0331738b
|
2021-12-29T14:47:32
|
|
Fix extension download script, and update data.
This includes the update to the NV 1660s, and Intel driver update,
and automatically gathered SwiftShader data.
Bug: angleproject:6853
Change-Id: I481918105fd0e0224a2e2ddf5175b38e97918195
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3360784
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
58aeec65
|
2021-12-29T14:00:00
|
|
Capture/Replay: GN cleanups.
This adds a GN "angle_trace_library" template that will be used
with capture replay tests and restricted trace tests to share code.
It could also be theoretically used to fix the capture replay
sample.
Also changes the capture replay tests GN to make the test exe
always build even without the defines. This is possible because of
the switch to JSON from code autogen, and makes it easier to catch
and fix compile errors in this test harness.
Bug: angleproject:5133
Change-Id: Ia87b6bbb0ea6e1abb557f962ca16d074207325ef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3360783
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
b6399ac9
|
2021-12-29T13:04:17
|
|
Traces: Finish writing restricted trace doc updates.
Bug: angleproject:5133
Change-Id: I06e7da7d465cdc98e672bf87f54da2935eac557a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3360781
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
a400e76d
|
2021-12-22T12:24:13
|
|
Vulkan: Don't expose MSRTT without VK_KHR_depth_stencil_resolve
Previously, ANGLE exposed the EXT_multisampled_render_to_texture
extension even if VK_KHR_depth_stencil_resolve was not available. This
was due to scarcity of drivers on the bots with support for this
extension and allowed partial testing.
This is no longer true. Additionally, this cleans up the expectations
because old and buggy drivers are now simultaneously filtered out.
Bug: angleproject:6845
Change-Id: I8c285a5fa5d9beeb98b48d8b056cdc8779cce6fd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3353895
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
9f74ec61
|
2021-12-29T21:45:04
|
|
Skip angle_end2end_tests failing on Linux AMD RX 5500 XT
On Ubuntu 18.04 with 5.4.0-91 kernel
Bug: angleproject:6855
Change-Id: I679e3a222f432ed5fac6b1ac429534f713387159
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3360788
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
6f1c39b5
|
2021-12-16T16:10:49
|
|
Vulkan: Restore color attachment mask-related blend states
When we end up resetting blend state such as when changing to a
depth-only FBO and back, we can end up adding attachment states. They
need to be updated with the current GL blend state.
Bug: b/210543392
Bug: angleproject:6828
Change-Id: I3419acb8081eb7d662576a75382bb8684cc0d29f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3346320
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Lingfeng Yang <lfy@google.com>
|
|
0a28c6c6
|
2021-12-15T15:49:33
|
|
Capture/Replay: Capture some MultiDrawIndirect parameters
It seems some new tests were added that fail Capture/Replay.
Bug: angleproject:6180
Change-Id: I26ccc1e9defc7b7d66c7e26538df286230b47def
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3340945
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
|
|
|
5f53268c
|
2021-11-04T17:56:48
|
|
Capture/Replay: Gather Program sources directly from call
With CreateShaderProgramv the sources were collected from the
attached shaders, wich gave complications, because normally the
the shaders were detached right after program linking and a
different handling was needed when capture was enabled, handling
that let the replay tests fail.
To overcome this gather the shader source directly from the call
parameters instead of pulling it from the attached shaders.
Bug: angleproject:6180
Bug: angleproject:6659
Change-Id: I248c1aa0f58b61519b938fce1a77fb25dc0a7cfc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3262133
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
|
|
|
4d893a93
|
2021-09-07T11:47:23
|
|
Re-land: "Trace Tests: Remove auto-generated code."
No significant changes in the re-land.
Bug: angleproject:5133
Change-Id: Ib5bb8fba3e9e2f1f648d5af251b7b2319c9f37dd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3352432
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
542f7d80
|
2021-12-22T19:36:27
|
|
Vulkan: Copy buffer data to correct cube map face
TextureVk::copyBufferDataToImage() was failing to set
region.imageSubresource.baseArrayLayer to the correct cube map face
value, causing every glTexSubImage2D()-type call using
GL_PIXEL_UNPACK_BUFFER to only copy to the
GL_TEXTURE_CUBE_MAP_POSITIVE_X face. In the case of PUBG Mobile, this
left all other faces with "random" data, resulting in corrupted
reflections on things like water, the airplane, etc.
Bug: b/194140619
Test: TextureCubeTestES3.CubeMapPixelUnpackBuffer
Change-Id: I93a9219ce098985f9f4b906f8fe2e05850fb8d43
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3354091
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
|
|
|
2ebd583e
|
2021-12-22T11:24:43
|
|
Android: Remove setenv from common path
In Android production stress testing, the setenv call was causing a
race condition. To fix, only use setenv in the paths that need it
as a performance optimization. Specifically, FrameCapture makes
use of it every frame.
Bug: angleproject:6822
Change-Id: I452f1ef8607ca9baf15d69246932c47454a3ce46
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3353893
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
14af7a8d
|
2021-12-22T15:17:26
|
|
Log subprocess output in run_perf_tests.py
To aid with debugging a flaky hang listing tests on Android.
Bug: chromium:1279512
Change-Id: Icbdf753e1e7c21ab766fdd5767ca05d07b66485b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3353760
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
2f3e6cc0
|
2021-12-13T17:40:18
|
|
Vulkan: Remove mShadowBuffer from BufferVk class.
The shadow buffer was initially designed to avoid synchronization in
glMapBuffer call while buffer itself is still busy. There are many
optimization done inside BufferVk::mapImpl that try to avoid wait for
GPU as much as we can by distinguish GPU write versus read, by detecting
map call read/write intention by checking access bit, and finally by
allocating a staging buffer to return a CPU friendly copy of data to
caller. This shadow buffer implementation also have known bugs that are
not keeping data in sync. With all these optimization added after
initial mShadowBuffer implementation, I believe we do not have a good
reason to still keep mShadowBuffer. And this has been disabled for
months in main branch. This CL removes this code path completely which
makes code a lot simpler.
Bug: b/208323792
Change-Id: Ie5999e38b6120a371ec2e969f196e4754ebd0f8d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3313333
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: mohan maiya <m.maiya@samsung.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
7dfa69e6
|
2021-12-22T12:51:38
|
|
Unskip MRTSigned and MRTUnsigned BlendIntegerTest
VVL rolled into Chromium, so they should pass now.
Bug: angleproject:6841
Change-Id: Iff2dde0852b0261970bd5c59009f5412050862ff
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3353896
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
0e9353f6
|
2021-12-21T16:48:48
|
|
Skip RenderbufferDrawStencilThenUnresolveStencil on Linux Vulkan AMD
Bug: angleproject:6845
Change-Id: I465f185f45aad43be51de882cbfea43090045aa1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3352427
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
|
|
|
bc9d2d7d
|
2021-12-07T16:16:47
|
|
Vulkan: Consolidate BufferHelper's code paths into one
There are cases that BufferHelper may not sub-allocate from the pool.
For example, when buffer is created from external memory. Right now we
have two different code paths in the BufferHelper object and checking if
suballocation object is valid or not and pick different code path. This
CL consolidates both code path into one by making non sub-allocated case
also creates BufferSUbAllocation object and owns a BufferBlock object.
Bug: b/205337962
Change-Id: Iac82bdb0b69d424e4147b52d458ced6274e106a1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3322100
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
4114fe23
|
2021-11-20T22:05:56
|
|
Vulkan: Simplify transform feedback emulation logic
In [1], the program is transformed to not output transform feedback
logic when transform feedback is inactive. With that change, it's no
longer necessary to dedicate a driver uniform to indicate if transform
feedback is active.
[1]: https://chromium-review.googlesource.com/c/angle/angle/+/3294661
Bug: chromium:1209285
Change-Id: Ica725d0da08e2676f442fe6307962d367b443535
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3294702
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
ab288fea
|
2021-07-09T13:02:08
|
|
Upgrade restricted traces. (Re-land)
Includes removing capture to temporary ResourceMaps,
and including all source files in the JSON.
Bug: angleproject:5133
Change-Id: I0508dd46a9f613a96ca3635f82b6904c0f2523a7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3345222
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
c1f478fe
|
2021-12-20T12:37:33
|
|
Frame Capture: Allow for no FBO when running MEC.
Multi-context captures use the surfaceless context extension. That
was crashing MEC because we were assuming the context would have a
Framebuffer.
Bug: angleproject:5133
Change-Id: I6be12d332f4754f80c088d88973219327eca251a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3352084
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
eba2e620
|
2021-12-15T12:29:12
|
|
Capture/Replay: Fix uniform program indexing.
We were using the "native" version of the program ID in the update
call, which could overflow the bounds of our fixed-size program
maps. Instead use the captured (and upper-bounded) version of the
ID and only get the mapped ID when calling GetUniformLocation.
Bug: angleproject:6431
Bug: angleproject:6816
Change-Id: I807bd07c9dcff6ba5a50991e28b0a58d16f7bc63
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3345220
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
73e764dc
|
2021-12-21T13:41:37
|
|
Suppress capture/replay tests.
BlendIntegerTest.MRTSigned/* = NOT_RUN
BlendIntegerTest.MRTUnsigned/* = NOT_RUN
These tests became skipped after an expectations change. This CL
also updates our luci config to run the trace bots on expectations
changes to prevent this happening again.
Bug: angleproject:6840
Change-Id: Id40b11995fa9be4613bdbaaa1e3e44f9edfeb464
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3352426
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
1da7e3af
|
2021-12-21T15:55:38
|
|
Revert "Metal: Fix Webkit warnings in ANGLE build"
This reverts commit 6706799186683dd3733c4610de09d84721aa08c8.
Reason for revert: Includes pragma that disables a warning.
Original change's description:
> Metal: Fix Webkit warnings in ANGLE build
>
> Fix nullable warnings, unused functions
>
> Bug: angleproject:6781
> Change-Id: I063331e60d31a55b3cc9df0b41ace014d7d13659
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3343174
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Commit-Queue: Kenneth Russell <kbr@chromium.org>
Bug: angleproject:6781
Change-Id: Id5fce2afd0381030a974871b99e8adf075677bd1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3352086
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
a7e0d520
|
2021-12-21T00:16:25
|
|
Temporarily skip failing tests on Chromium
Bug: angleproject:6841
Change-Id: Ie911e09d7e070c5fcec16449fe3fb7c47c8f6417
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3349335
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
|
|
|
171bc07e
|
2021-12-20T13:10:33
|
|
Don't silently drop out-of-range bits in BitSetT
Notes:
- std::bitset's constructor accepts out-of-range bits (and drops them)
- std::bitset with initializer list doesn't exist and is a BitSetT
feature
- |=, &= and ^= with non-bitset is a BitSetT feature
- std::bitset's set(pos), reset(pos) and flip(pos) throw an exception if
pos is out of the range of the bitset.
This change adds an ASSERT in the functions that std::bitset would throw
an exception, as well as functions that are only in BitSetT.
Bug: angleproject:6840
Change-Id: Iab5bac40b05d4f7f29e0242ea0baa093721e3339
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3349980
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
eca427b2
|
2021-12-20T10:55:41
|
|
Vulkan: Add mutex to protect mVirtualBlock
mVirtualBlock could be accessed from multiple thread when
asyncCommandQueue is enabled, where the free call could come from the
submission thread. This CL adds a mVirtualBlockMutex in BufferBlock and
always take the lock when mVirtualBlock is been accessed.
This CL also adds ConditionalMutex class for the general usage that a
mutex is only used based on a boolean.
Bug: angleproject:6840
Change-Id: Ib647b4ff12ebfc08f2a70192d39f16e15a1fc5f5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3350798
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
c1598640
|
2021-11-30T23:44:30
|
|
Vulkan: Improve mid-RP clear warning message
One app does:
- Draw
- Draw
- Clear depth, then disable it
- Draw
In this case, the message generated for mid-RP clear, suggesting the
clear be done earlier is not meaningful as the previous draw calls did
use the depth/stencil image. The message now includes an alternative
suggestion to invalidate the depth/stencil image instead of clearing it.
Note that the app may still legitimately do multiple passes in one
render pass where depth/stencil is cleared in between, so the warning is
not applicable in all cases. It's still useful to notice issues in more
common scenarios.
Bug: angleproject:2472
Change-Id: I3abbecf8c83b7b856c2430675e69b1471e91c0c4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3308920
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
|
|
|
4a03668d
|
2021-12-20T20:58:17
|
|
Address comment in CL 3347143
Bug: chromium:1278515
Change-Id: I7d82d39ad94c6357b0df292fc716749cf610290f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3349938
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
|
|
|
cf8ac00a
|
2021-12-20T11:57:25
|
|
Vulkan: Fix MSRTT w.r.t stencil-only unresolve
The stencil bit was being silently masked out in a bitset in
FramebufferDesc that tracked whether the framebuffer requires any
unresolve. If only stencil needs unresolving, this mask was zero,
leading to an incorrect framebuffer getting pulled from the cache.
A follow up change will add an ASSERT in BitSetT to catch such errors
in the future.
This issue was only reproducible on SwiftShader and AMD as the only
implementers of VK_EXT_shader_stencil_export.
Bug: angleproject:6840
Bug: angleproject:6324
Change-Id: I4f055982ebd75f621ec1e34b0d60eaa497c27b17
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3349979
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
c07df6fe
|
2021-12-17T20:11:52
|
|
Disable vulkan device select layer for msan build
The vulkan device select layer is not built with chrome, so this
layer is not built with msan. So loading this layer will cause
MemorySanitizer errors. Those errors are false positive. So
disable it for msan build.
Bug: chromium:1259170
Change-Id: I513d6dd3d4fbc16c62aaa3aa1e7cf299e3e4144a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3347143
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
|
|
aabfe874
|
2021-12-17T15:43:22
|
|
Metal: Use the context device to Texture::resize
Makes the resized texture to be attributed to the owner.
Bug: angleproject:6832
Change-Id: Ia1eae1bb6c9e83e23fae51121f88d9ce37dc948b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3347642
Reviewed-by: John Cunningham <johncunningham@apple.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
34ea8111
|
2021-10-28T11:07:53
|
|
Reland "Vulkan: Don't expose MSRTT on SwiftShader"
This is a reland of fb77afd3c76301e11f5c7397d9a63d283f86036c
Original change's description:
> Vulkan: Don't expose MSRTT on SwiftShader
>
> Emulating this extension on SwiftShader is neither useful nor efficient
> (on the contrary, it hurts performance (which is true for all non-tiling
> architectures)). This extension was exposed purely to increase testing
> coverage, but is being disabled now as OOMs resulting from allocating
> the implict multisampled image is confusing Chrome. Note that
> SwiftShader exposes only a limited amount of memory.
>
> Bug: chromium:1263046
> Change-Id: Ia69b7fc63804169431885352a8f637a95ab08bd0
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3251581
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Bug: chromium:1263046
Change-Id: I88415f3c1a7532eda5473da6acbd22acf14ae11c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3260330
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
|
|
|
624e3c3d
|
2021-12-17T15:30:54
|
|
Fix dangerous use of AutoObjCPtr after ownership identity change
Metal new* methods create objects with +1 retain count.
AutoObjCPtr is intended to adopt this reference.
Otherwise, like before this patch, the AutoObjCPtr holds
object with +2 count. Before this patch, some but not all
call sites donated the extra retain count to autoreleasepool
"out of band", and as such the code did not leak that much.
Bug: angleproject:6831
Change-Id: I72bcbc712f2cadbcbc6148c6aedfa7e151314518
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3347641
Reviewed-by: John Cunningham <johncunningham@apple.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
4a148e9d
|
2021-12-20T13:39:48
|
|
Revert "Vulkan: Suppress VUID-vkCmdDraw-blendEnable"
This reverts commit 797ebdde9894b4411ed304a83fdaeb8d8a91fe56.
Reason for revert: The VVL bug has been fixed.
Original change's description:
> Vulkan: Suppress VUID-vkCmdDraw-blendEnable
>
> A new VVL causes failures in BlendIntegerTest.MRT*
>
> Bug: angleproject:6355
> Change-Id: If62b1a7934574acaeb95601d7fb0a61dc5d9c99a
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3140159
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Bug: angleproject:6355
Change-Id: I769d34fada1c2db00513f9912ef178dcd1eb4ee9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3347648
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
ede0b8b7
|
2021-12-17T14:35:47
|
|
Avoid ANGLE_MTL_AUTORELEASE inside ASSERT, it leaks on Release
Avoid ANGLE_MTL_AUTORELEASE inside ASSERT, it leaks on Release.
The create functions already return retained, instead of autoreleasepool
retained, so owning the reference via adopting AutoObjCObj is
as efficient as autoreleasepool on possible future ARC.
Thus use AutoObjCObj, that is safer than autoreleasepool with C++
and works towards being able to perhaps remove use of autoreleasepool.
Bug: angleproject:6830
Change-Id: I80f523d9a6846097a593fe94b5ea9715fa88ea15
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3347640
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: John Cunningham <johncunningham@apple.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
|
|
|
001221f0
|
2021-12-16T21:41:29
|
|
Metal: upstream fix from WebKit for texture leak.
Upstream fix by Kimmo Kinnunen for a leak of MTLTexture instances for
render targets from:
REGRESSION (r287068): [macOS arm64]
TestWebKitAPI.GraphicsContextGLCocoaTest.
UnrecycledDisplayBuffersNoLeaks is failing
https://bugs.webkit.org/show_bug.cgi?id=234356
The leak would happen through a temporary render pass descriptor that
would ref the render target texture. The descriptor was created
without an autoreleasepool in call stack.
Also fixes the error string leaks.
Bug: angleproject:6827
Bug: angleproject:6829
Change-Id: I07ec961886a9fb8caad6df334293358a175eaf15
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3346682
Reviewed-by: Kyle Piddington <kpiddington@apple.com>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
|
|
|
b9f2d9cc
|
2021-12-16T13:08:22
|
|
Use text expectations to skip a test
This instead of exiting the test in C++.
Bug: angleproject:6826
Change-Id: I1e91f38f0f581821178b3b54ba809e59570b440a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3345615
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Gregg Tavares <gman@chromium.org>
|
|
|
6c894e82
|
2021-11-04T14:49:41
|
|
Vulkan: Replace BufferVk::getBufferAndOffset() with getBuffer()
Now BufferHelper class already keeps offset information. There is no
reason for BufferVk to have that information any more.
Bug: b/205337962
Change-Id: I6e014fb480bfcd5018ef9231b0fb87a50021f179
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3266147
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
|
|
|
f2736f6d
|
2021-11-19T14:24:55
|
|
Tests: Add My Talking Tom Friends trace.
Test: angle_perftests --gtest_filter="*my_talking_tom_friends*"
Bug: angleproject:6749
Change-Id: I7d86e7ff0607841ab4bf999f0e986f4d324c5c44
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3310797
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
|
|
|
a93a3930
|
2021-12-08T20:36:07
|
|
Vulkan: Track enabled in VertexArray
Previously in sequences such as
glEnableVertexAttribArray(0)
glDrawElements()
glDisableVertexAttribArray(0)
glEnableVertexAttribArray(0)
glDrawElements()
the second glDrawElements() would always be called with dirty enable. On
some backends like Vulkan this could result in unnecessary pipeline
changes.
Bug: angleproject:6796
Change-Id: Ib44877b6030e8d0acede7cf5c591936ba3844b69
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3325208
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Lingfeng Yang <lfy@google.com>
|