|
ad701f05
|
2018-09-30T17:30:42
|
|
[circleci] Use an instrumented freetype on msan bot
|
|
|
57aabbc2
|
2018-09-30T16:31:28
|
|
[circleci] Another on fixing msan
|
|
|
24f148df
|
2018-09-30T14:46:56
|
|
[circleci] minor
|
|
|
0a9aab67
|
2018-09-30T14:45:43
|
|
[circleci] Try to fix msan bot
|
|
b5285b34
|
2018-09-30T12:23:01
|
|
[util] Remove unneeded virtual
clang warning:
../../util/options.hh:72:13: warning: destination for this 'memset' call is a pointer to dynamic class
'option_parser_t'; vtable pointer will be overwritten [-Wdynamic-class-memaccess]
memset (this, 0, sizeof (*this));
~~~~~~ ^
../../util/options.hh:72:13: note: explicitly cast the pointer to silence this warning
memset (this, 0, sizeof (*this));
^
(void*)
|
|
|
9caa432d
|
2018-09-30T05:49:08
|
|
[util] Use HB_FALLTHROUGH
Sure, gcc knows to warn about this as well:
../../util/options.cc:175:17: warning: this statement may fall through [-Wimplicit-fallthrough=]
case 1: m.r = m.t;
~~~~^~~~~
../../util/options.cc:176:5: note: here
case 2: m.b = m.t;
^~~~
But HOLY SMOKES, look at clang -Weverything bot message:
options.cc:176:5: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
case 2: m.b = m.t;
^
options.cc:176:5: note: insert 'HB_FALLTHROUGH;' to silence this warning
case 2: m.b = m.t;
^
HB_FALLTHROUGH;
Right, it's telling me to insert "HB_FALLTHROUGH;" there!!!!!!!!!
|
|
|
2e728a7d
|
2018-09-30T05:47:36
|
|
[util] Mark var static
From clang -Weverything bot:
options.cc:39:3: warning: no previous extern declaration for non-static variable 'supported_font_funcs' [-Wmissing-variable-declarations]
|
|
|
e910a1ae
|
2018-09-30T05:46:20
|
|
[util] Add empty virtual destructor to option_group_t
From clang -Weverything bot:
./options.hh:57:8: warning: 'option_group_t' has virtual functions but non-virtual destructor [-Wnon-virtual-dtor]
struct option_group_t
^
|
|
|
b1e07e1e
|
2018-09-30T05:43:22
|
|
[indic/khmer] Remove use of global constructors
Alternative woul have been to resurrect F_COMBINE that I removed in
70136a78cb9eda244767f8e8a3d30d0f3c569d01
But this does it for now. I'm not sure why check-static-inits.sh didn't
catch this before. Clang -Weverything bot did:
CXX libharfbuzz_la-hb-ot-shape-complex-indic.lo
hb-ot-shape-complex-indic.cc:99:1: warning: declaration requires a global constructor [-Wglobal-constructors]
indic_features[] =
^
1 warning generated.
CXX libharfbuzz_la-hb-ot-shape-complex-khmer.lo
hb-ot-shape-complex-khmer.cc:36:1: warning: declaration requires a global constructor [-Wglobal-constructors]
khmer_features[] =
^
1 warning generated.
|
|
|
89ed040b
|
2018-09-30T06:06:26
|
|
[util] Fix more non-virtual-destructor warnings
|
|
|
00cd00e6
|
2018-09-30T05:34:30
|
|
Tweak HB_TAG and HB_UNTAG
uint32_t was getting promoted to signed int, which is not what we wanted...
Wow, clang has become good at generating warnings...
../../src/hb-common.h:349:29: warning: signed shift result (0xFF000000) sets the sign bit of the shift expression's type ('int') and becomes negative [-Wshift-sign-overflow]
_HB_SCRIPT_MAX_VALUE = HB_TAG_MAX, /*< skip >*/
^~~~~~~~~~
../../src/hb-common.h:93:20: note: expanded from macro 'HB_TAG_MAX'
define HB_TAG_MAX HB_TAG(0xff,0xff,0xff,0xff)
^~~~~~~~~~~~~~~~~~~~~~~~~~~
../../src/hb-common.h:89:57: note: expanded from macro 'HB_TAG'
define HB_TAG(c1,c2,c3,c4) ((hb_tag_t)((((uint8_t)(c1))<<24)|(((uint8_t)(c2))<<16)|(((uint8_t)(c3))<<8)|((uint8_t)(c4))))
~~~~~~~~~~~~~~~^ ~~
../../src/hb-common.h:349:3: warning: ISO C restricts enumerator values to range of 'int' (4294967295 is too large) [-Wpedantic]
_HB_SCRIPT_MAX_VALUE = HB_TAG_MAX, /*< skip >*/
^ ~~~~~~~~~~
|
|
|
8a31e406
|
2018-09-30T05:27:39
|
|
[font] Make *_advance() fallback to *_advances
And remove redundant implementations.
|
|
|
2382dd07
|
2018-09-30T05:54:47
|
|
Minor
|
|
|
bd07d287
|
2018-09-30T03:54:40
|
|
Use buffer scratch_flags to remember if we had any joiners
|
|
|
ba0f0f15
|
2018-09-30T03:49:52
|
|
Document setlocale() threadsafety issue
"Fixes" //github.com/harfbuzz/harfbuzz/issues/1191
|
|
|
06be2aa9
|
2018-09-30T00:15:25
|
|
[ci] Build glib and freetype and enable msan bot (#1198)
|
|
|
cefdef02
|
2018-09-29T10:19:54
|
|
Minor on test-multithread, align the actual and expected results
|
|
|
678beff6
|
2018-09-29T10:16:14
|
|
[circleci] Add -Wno-reserved-id-macro to clang-everything
|
|
|
c763b944
|
2018-09-28T20:53:07
|
|
[test-multithread] Disable FreeType funcs
|
|
|
9b0b40b3
|
2018-09-28T11:16:18
|
|
Fix fallback kerning to check for current glyph's mask
|
|
|
909a07b5
|
2018-09-29T03:10:13
|
|
[circleci] Improve clang-everything bot log, more to come
#1196
|
|
|
9be8062b
|
2018-09-29T02:11:05
|
|
[ci] Another try on mingw bot
|
|
|
d4d261a9
|
2018-09-29T01:57:50
|
|
[ci] Another try on fixing mingw bots
Per https://github.com/Alexpux/MSYS2-packages/issues/163#issuecomment-73555971
|
|
|
7b68edf2
|
2018-09-28T20:53:48
|
|
[tests] Don't try to get glyph names on failures
As it may cause a race unrelated to the issue actually happened
|
|
|
d289d638
|
2018-09-28T20:47:21
|
|
[ci] Trying to fix mingw bot
As https://github.com/Alexpux/MSYS2-packages/issues/702
|
|
|
33231a85
|
2018-09-28T11:06:49
|
|
Fix pthread fail for real
Using a hack...
|
|
|
8cb8209c
|
2018-09-28T10:55:28
|
|
Fix bot fails
|
|
|
f4072e8c
|
2018-09-28T10:14:23
|
|
[morx] Remove mark_set from Insertion
text-rendering-tests test MORX-32 shows that for Insertion, an unset mark is treated
as mark set at 0. This is unlike the Reordering lookup where un unset mark performs
nothing.
Fixes MORX-32.
|
|
|
0d18ec54
|
2018-09-28T10:00:07
|
|
[morx] unsafe-to-break in Insertion
Makes MORX-29, MORX-30, MORX-31 pass.
|
|
|
02bebe42
|
2018-09-28T09:51:35
|
|
[test/text-rendering-tests] Update from upstream
|
|
|
4cd342ba
|
2018-09-28T09:47:45
|
|
Fix ubsan bot
|
|
|
b435df3a
|
2018-09-28T09:13:14
|
|
More atomic tuneup
|
|
|
7e6e094a
|
2018-09-28T08:45:57
|
|
[test-multithread] Install ot funcs before filling ref buffer
|
|
|
21fbee83
|
2018-09-28T08:43:37
|
|
[test-multithread] Take num-threads and num-iters from command-line
|
|
|
598be3bb
|
2018-09-28T08:33:26
|
|
Minor
|
|
|
c09bf3d5
|
2018-09-28T16:13:01
|
|
test-multithread, check the results on every iteration (#1194)
|
|
|
dbc3070a
|
2018-09-28T16:01:15
|
|
Make test-multithread pass the tsan bot test (#1193)
|
|
|
d2542cd2
|
2018-09-27T17:23:24
|
|
More atomic fixup
|
|
|
3ee96984
|
2018-09-27T17:20:26
|
|
Fixup atomics from recent change
|
|
|
30546870
|
2018-09-27T16:54:23
|
|
[cache] Use atomic writes in clear()
To help TSan.
|
|
9e9a36ee
|
2018-09-27T16:33:49
|
|
Fix infinite loop when walking up the directory hierarchy (#1183)
A single find_package(harfbuzz) line in user code resulted in this loop
getting stuck when _harfbuzz_libdir_iter became "/".
|
|
|
0c1d852b
|
2018-09-27T11:53:17
|
|
Use clang for compiling freetype for tsan bot
|
|
|
662f7d7e
|
2018-09-26T18:42:37
|
|
[arabic] Do the joiner-flipping only for rlig feature
See comment.
|
|
|
7f30629c
|
2018-09-26T16:40:23
|
|
[ft] Make TSan happy
|
|
|
ec743fce
|
2018-09-26T16:37:18
|
|
Add more atomic intrinsics
|
|
|
d183b33c
|
2018-09-26T16:29:35
|
|
Rename test
|
|
|
c9c75fe3
|
2018-09-27T00:08:06
|
|
[ci] Compile freetype on tsan and put sanitizer flags on correct places (#1188)
|
|
|
39da1914
|
2018-09-26T23:32:45
|
|
Test freetype funcs on test-multithread (#1187)
|
|
|
e88009a9
|
2018-09-26T22:53:02
|
|
Minor, remove the no longer needed comment on test-multithread
|
|
|
90a0f9fa
|
2018-09-26T15:03:07
|
|
Make TSan happy with make_immutable()
|
|
|
34d5a259
|
2018-09-26T15:02:21
|
|
Fix test-multithread and increase num_threads to 30
What were you thinking? ;)
|
|
|
8bb73dad
|
2018-09-26T20:50:51
|
|
Add a multithreaded test (#1184)
|
|
|
04caf116
|
2018-09-26T12:13:47
|
|
[hb-view] Change subpixel bits from 8 to 6
To match FreeType units, such that FreeType gets correct size from us.
This matters more now that we allow setting --ft-load-flags.
|
|
|
824111d4
|
2018-09-25T12:47:37
|
|
Fix iOS build
Fixes https://github.com/harfbuzz/harfbuzz/pull/1179
|
|
|
4b4be770
|
2018-09-25T09:24:35
|
|
[circle] Add an obsessive clang bot (#1178)
|
|
|
8282e881
|
2018-09-24T19:43:01
|
|
Disable msan bot again
Fixes https://github.com/harfbuzz/harfbuzz/issues/1175
|
|
|
6c0e7eb6
|
2018-09-24T19:07:23
|
|
Minor
|
|
|
d748dc76
|
2018-09-24T18:30:50
|
|
More iter inits
|
|
|
d9867497
|
2018-09-24T18:11:59
|
|
Minor
|
|
|
70136a78
|
2018-09-24T18:03:34
|
|
Remove F_COMBINE
Now I wonder if any bots will be unhappy we calling | in static const initializations...
Or would that cost runtime init? Our tests don't detect any..
|
|
|
f048ead8
|
2018-09-24T18:01:53
|
|
Some more
|
|
|
1676f608
|
2018-09-24T17:55:03
|
|
Minor refactoring
|
|
|
10203339
|
2018-09-25T01:00:32
|
|
[circleci] Update sanitizer bots with newer clang and Ubuntu version (#1176)
|
|
|
12b8baa7
|
2018-09-24T17:22:39
|
|
[msan] Enable again to get a build log, and try to play with suppressions
|
|
|
aec0d3cb
|
2018-09-24T13:12:15
|
|
[ubsan] Re-enable now that it passes locally
|
|
|
48398073
|
2018-09-24T13:11:34
|
|
[check-static-inits.sh] Allow some if ubsan is in effect
|
|
|
e45ba31d
|
2018-09-24T13:04:48
|
|
[check-symbols.sh] Allow weak objects "V"
ubsan generates these.
|
|
|
d07f3111
|
2018-09-24T13:01:35
|
|
Link API test programs with C++ linker
Needed to make ubsan work.
Fixes https://github.com/harfbuzz/harfbuzz/issues/1174
|
|
|
a96508cf
|
2018-09-24T12:52:42
|
|
[msan] Add MSAN_OPTIONS=exitcode=42
Default exit value is 77, which causes autotools to "skip" test.
|
|
|
45f5aa97
|
2018-09-24T12:43:29
|
|
[circleci] Disable msan and ubsan builds
https://github.com/harfbuzz/harfbuzz/issues/1174
https://github.com/harfbuzz/harfbuzz/issues/1175
|
|
|
2d93148a
|
2018-09-24T11:52:22
|
|
Ignore weak symbols in check-symbols.sh
Some clang versions leave a std::round(float) weak symbol around...
|
|
|
55bae682
|
2018-09-24T10:43:06
|
|
[docs] A few improvements
If we wrote just this much every day...
|
|
|
57fa2c23
|
2018-09-24T09:57:52
|
|
Readjust Hebrew composition again
|
|
|
7f335390
|
2018-09-24T09:56:18
|
|
Revert change that would decompose text if GPOS mark feature is available
https://github.com/harfbuzz/harfbuzz/issues/653#issuecomment-423905920
|
|
|
a6f4b2f7
|
2018-09-24T09:54:37
|
|
Fix normalization
https://github.com/harfbuzz/harfbuzz/commit/62d1e0852a5549a1b510ad46a4b89f12730bb708#commitcomment-30613091
|
|
|
3583fb03
|
2018-09-23T22:33:38
|
|
Simplify ZWJ-skipping a bit
Towards disabling ZWJ-skipping in certain GPOS contexts.
Part of https://github.com/flutter/flutter/issues/16886
|
|
|
9516cbd3
|
2018-09-23T22:00:34
|
|
Reinit skippy iters when auto_zwj / auto_zwnj change
Ouch. How did we not hit this bug before...
|
|
|
62d1e085
|
2018-09-23T21:32:18
|
|
Prefer decomposed form if font has GPOS mark feature
Fixes https://github.com/harfbuzz/harfbuzz/issues/653
|
|
|
d7f21777
|
2018-09-23T19:12:52
|
|
[ot-font] Fix leak
Fixes https://github.com/harfbuzz/harfbuzz/issues/1171
I'm glad we have leak-detector bots now.
|
|
|
ae39a53f
|
2018-09-22T14:22:17
|
|
Add bots with address- and thread-sanitizer
|
|
24dd6c1a
|
2018-09-23T18:08:30
|
|
src/hb-blob.cc: Fix mmap functionality with UWP.
|
|
b7f1bbc2
|
2018-09-22T16:41:56
|
|
[test] Fix printing subprocess error messages
Decode the string as Python 3 returns bytes string, and also don’t
assume that it ends with a new line.
|
|
|
40301948
|
2018-09-22T17:24:03
|
|
Fix test-subset-* leak issues
See also https://github.com/harfbuzz/harfbuzz/pull/1169
|
|
|
f6ebe1f4
|
2018-09-22T17:05:52
|
|
Fix test-ot-math leak issue
See also https://github.com/harfbuzz/harfbuzz/pull/1169
|
|
|
669ac81a
|
2018-09-22T16:49:23
|
|
Fix test-set leak issue
See also https://github.com/harfbuzz/harfbuzz/pull/1169
|
|
|
ef9307fd
|
2018-09-22T16:45:31
|
|
Fix test-font leak issue
See also https://github.com/harfbuzz/harfbuzz/pull/1169
|
|
|
5fd8bce9
|
2018-09-19T22:34:09
|
|
[morx] Fix mark_set check
|
|
|
0739b281
|
2018-09-19T17:32:21
|
|
[aat] Minor
|
|
|
7671cb9b
|
2018-09-19T17:10:26
|
|
[coretext] Minor
|
|
|
dc8ed452
|
2018-09-19T16:46:41
|
|
[morx] Implement forward/backward processing
We reverse too many times. Can be optimized. But I doubt many fonts
use reverse lookups, so doesn't matter.
Other than not applying user features, this completes morx table
implementation.
|
|
|
3bccd621
|
2018-09-19T16:24:34
|
|
[morx] Implement horiz-only/vert-only subtables
|
|
|
041a08de
|
2018-09-19T16:02:56
|
|
[morx] Improve buffer position in Insertion w DontAdvance and wo
Just speculation. Needs tests to determine which is correct behavior.
|
|
|
388ab916
|
2018-09-17T19:29:34
|
|
[morx] Implement InsertionChain
|
|
d8d1e7df
|
2018-09-17T11:09:51
|
|
Don't enforce a native direction for Old Hungarian
|
|
6a97d0f3
|
2018-09-17T10:33:34
|
|
Fix installation of cmake config when building with cmake (#1161)
When building with the auto tools, the manually mantained
harfbuzz-config.cmake is installed. When building with cmake, we can use
cmake to generate the correct config files for us and install them.
|
|
|
606bf574
|
2018-09-16T19:33:48
|
|
Revert forcing use of single-parameter static_assert()
Some clang versions define static_assert as a macro apparently, so we cannot
redefine it...
This reverts commit 94bfea0ce6a7b4d5641c198d50751748a353df11.
This reverts commit 4e62627831e7457ed60ff87712570065b14b200a.
|
|
|
cbcaba6f
|
2018-09-16T19:25:19
|
|
One more bot fix
|
|
|
94bfea0c
|
2018-09-16T19:12:19
|
|
Fix build, another try
|
|
|
89dd4b95
|
2018-09-16T18:11:46
|
|
Fix bots
"Unused private member" warning turned error. ugh.
|
|
|
4e626278
|
2018-09-16T18:09:36
|
|
Enforce single-param static_assert() only
So we don't accidentally break it again.
|