kc3-lang/libevent

Branch :

Log

Author Commit Date CI Message
f523cb79 2016-10-05 14:00:55 Add config for clang-format
807e2662 2016-10-05 14:00:40 Add config for uncrustify Original: https://strcpy.net/mark/libevent-uncrustify.cfg (@ellzey)
75216643 2016-09-16 16:37:59 be: just a simple mistake, reinclude the <errno.h> include the <errno.h> twice.
a4d044c0 2016-10-04 23:21:37 cmake: use PYTHON_EXECUTABLE to find python2 Since most of the distros have symlinks for this.
83c7cdf4 2016-10-03 03:24:28 Merge branch 'force-disable-clockgettime' * force-disable-clockgettime: Add -DEVENT__DISABLE_CLOCK_GETTIME switch for cmake Adding option to ignore clock_gettime: --disable-clock-gettime
91559607 2016-10-03 03:17:18 Add -DEVENT__DISABLE_CLOCK_GETTIME switch for cmake See-also: adc402ba5f0e15f4c77505852507f33b50f37ab6 ("Adding option to ignore clock_gettime: --disable-clock-gettime")
adc402ba 2016-09-29 18:31:53 Adding option to ignore clock_gettime: --disable-clock-gettime macOS 10.12 introduced `clock_gettime` to libsystem. This means, built on OS X 10.12 application would crash on earlier versions of OS X because it will try to call clock_gettime. This options is useful to make backwards compatible macOS apps. Fixes: #398 Fixes: #399 Fixes: #400
a73fb2f4 2016-08-27 01:53:31 Merge branch 'release-2.1.6-beta-pull' * release-2.1.6-beta-pull: Bump version to 2.1.6-beta everywhere ChangeLog: Add brief notes Update changelog for 2.1.6-beta (ugh, pretty huge) Update AUTHORS section in README
51019e94 2016-07-13 17:40:48 Bump version to 2.1.6-beta everywhere - cmake basic - cmake detecting from git -- event_fuzzy_version_from_git() - autotools - win32 - appveyor
81d21932 2016-07-05 16:17:38 ChangeLog: Add brief notes
ea2cee72 2016-07-04 18:13:02 Update changelog for 2.1.6-beta (ugh, pretty huge) Changes for: - 2.1.5-beta: 118 - 2.1.6-beta: 350 We should really hurry with the release!
3298c254 2016-08-07 23:27:22 Update AUTHORS section in README P.S. "Sebastian Hahn" was declared two times.
c6b1ec12 2016-08-24 17:16:32 Fix evhttp_uriencode() regression. http_uriencode_test() (in test/regress_http.c) has been failed after 72afe4c as "hello\0world" is encoded to "hello" instead of "hello%00world". This is because of a misplaced overflow check which causes the non-negative "size" specified in parameter being ignored in within-bound URI. Fixes: #392
e94250c8 2016-08-14 14:03:56 removed unused vars
72afe4c9 2016-08-14 14:00:02 pointer overflow checks for evhttp_uriencode Check to make sure pointer math is all OK.
43eb56c7 2016-08-11 16:15:45 tests: use waitpid(..., WNOWAIT) to fix failing of main/fork under solaris According to solaris docs: "One instance of a SIGCHLD signal is queued for each child process whose status has changed. If waitpid() returns because the status of a child process is available, and WNOWAIT was not specified in options, any pending SIGCHLD signal associated with the process ID of that child process is discarded. Any other pending SIGCHLD signals remain pending." And interesting thing that it works if you add sleep(1) before waitpid(), and also if you run with --verbose (some race or what). But linux doesn't support WNOWAIT in waitpid() so add detection into cmake/autotools. Fixes: #387 Link: https://bugzilla.redhat.com/show_bug.cgi?id=840782
16d220cb 2016-08-11 13:43:14 test: replace sleeping with syncing pair in main/fork About this syncing pair: - read endpoint, must be blocked, to make it a checkpoint or smth like this - write endpoint, must be nonblocking, to avoid readcb hung Refs: #387
685a6a19 2016-08-11 09:27:50 travis: split long lines, and make it cleaner
088ea5e0 2016-08-11 00:18:04 travis: fix autotools on osx by reinstalling libtool Link: mkrufky/libdvbtee#22
3189eb00 2016-08-10 16:04:33 be_sock: handle readv() returns ECONNREFUSED (freebsd 9.2) During testing sometimes bufferevent/bufferevent_connect_fail_eventcb fails, and after some digging I found that this was the case when connect() doesn't return ECONNREFUSED immediately, and instead next operation will return it (in our case evbuffer_read()->readv(), needless to say that after this bufferevent_writecb() called and it checks error with getsockopt() but of course it doesn't return any error), so this patch checks "errno" after "readv()" and installs "bufev::connection_refused" flag, to handle this from writecb and only once. Fixes: bufferevent/bufferevent_connect_fail_eventcb Fixes: bufferevent/bufferevent_connect_fail_eventcb_defer Refs: #388
500b6b75 2016-08-10 16:50:19 test/http: do not run tests that based on backlog filling (freebsd) I cannot find any other solution for now, so simply ignore them for now, we should think about normal fix for this. Refs: #388
5a157c87 2016-08-10 16:09:09 evutil: mark ai_find_protocol() static (prototype-less)
4410e9df 2016-08-10 12:07:32 test/bufferevent/iocp: fix test name for "bufferevent_connect_fail_eventcb"
40730ae3 2016-05-09 22:34:28 Fix getaddrinfo under solaris (for multiprotocol case) During testing on solaris 11.3, util/getaddrinfo failed at: memset(&hints, 0, sizeof(hints)); hints.ai_flags = EVUTIL_AI_NUMERICHOST; r = evutil_getaddrinfo("1.2.3.4", NULL, &hints, &ai); tt_assert(ai_find_by_protocol(ai, IPPROTO_TCP)); And this is because solaris's getaddrinfo() returns: $6 = { ai_flags = 32, ai_family = 2, ai_socktype = 0, ai_protocol = 0, <-- no proto ai_addrlen = 16, ai_canonname = 0x0, ai_addr = 0x815d658, ai_next = 0x0 <-- nothing else } So we should emulate this too. Plus introduce helper that will search through all results, not only first one. Fixes: util/getaddrinfo Fixes: #354
dc95823c 2016-08-10 00:27:59 cmake/solaris: set CMAKE_REQUIRED_LIBRARIES to fix functions detections Otherwise we will not detect next functions for instance: - gethostbyname_r # and related And now both autotools/cmake builds passes all regress tests in basic env (on solaris of course). Fixes: dns/client_fail_requests_getaddrinfo
050bfc7f 2016-08-10 00:16:48 cmake/solaris: fix building (link with socket,nsl)
00514a2a 2016-08-09 15:49:01 Merge branch 'appveyor-cmake-v6' This patch set introduces matrix for appveyor and fixes bugs related to win32, during debugging this matrix. This should greatly reduce number of work for making a release ('check under windows' part only). Right now tests on appveyor still failes in summary, but we should dig into problems, not hide them. Test matrix looks like this: - autotools - autotools --disable-openssl - autotools --disable-thread-support - autotools --disable-debug-mode - autotools --disable-malloc-replacement - cmake - cmake -DEVENT__DISABLE_OPENSSL=ON - cmake -DEVENT__DISABLE_THREAD_SUPPORT=ON - cmake -DEVENT__DISABLE_DEBUG_MODE=ON - cmake -DEVENT__DISABLE_MM_REPLACEMENT=ON - cmake -DEVENT__ENABLE_VERBOSE_DEBUG=ON - cmake -DCMAKE_C_FLAGS='-DUNICODE -D_UNICODE' And takes 90min (was 7min, and this is the sad part). * appveyor-cmake-v6: test/ssl: use send()/recv()/EVUTIL_ERR_RW_RETRIABLE()/EVUTIL_SOCKET_ERROR() to fix win32 test/https_basic: increase timeout for complete write (fixes win32) cmake: check for ZLIB_INCLUDE_DIR, since we can have only library without headers autotools/win32: fix searching ssl library appveyor/autotools: link with openssl by passing LDFLAGS/CFLAGS appveyor: image already had openssl installed cmake/win32: do not compile regress_thread on -DEVENT__DISABLE_THREAD_SUPPORT=ON cmake/win32: do not compile evthread_win32 on -DEVENT__DISABLE_THREAD_SUPPORT=ON appveyor: check -DUNICODE -D_UNICODE according to ReleaseChecklist (cmake only) cmake: fix -DEVENT__ENABLE_VERBOSE_DEBUG (typo on -DUSE_DEBUG) test: fix building with --disable-thread-support under win32 cmake: do not use stderr for notifications/version-info autoconf: fix --disable-thread-support build under win32 appveyor: ignore failure of mingw-get appveyor: drop shallow_clone, since we use tags for detecting version in cmake appveyor: support cmake & autotools using build matrix (like travis-ci has) Fixes: #364
6fcfa25d 2016-08-08 17:25:11 appveyor/autotools: link with openssl by passing LDFLAGS/CFLAGS This never works, hence green tests in production. and now it works: https://ci.appveyor.com/project/azat/libevent/build/2.1.5.100/job/eib4xqfb7d3ruo16 (look by /"evthread_win32.c")
4634b85b 2016-08-08 15:34:57 appveyor: image already had openssl installed Fixes messages like "Version mismatch for openssl: compiled with 1000201f but running with 1000208f" [1]. According to next link: http://help.appveyor.com/discussions/questions/1132-openssl-installation-issues Refs: appveyor/ci#576 [1]: https://ci.appveyor.com/project/azat/libevent/build/2.1.5.95/job/dcy9cfoj3rfo4gdh
de0c1965 2016-08-08 15:50:46 cmake/win32: do not compile regress_thread on -DEVENT__DISABLE_THREAD_SUPPORT=ON
ecb0ec82 2016-08-08 15:45:29 cmake/win32: do not compile evthread_win32 on -DEVENT__DISABLE_THREAD_SUPPORT=ON There is duplicated "evthread_win32.c" appending to ${SRC_CORE} list, leave only one that under if EVENT__DISABLE_THREAD_SUPPORT Fixes: https://ci.appveyor.com/project/azat/libevent/build/2.1.5.96/job/44q3rgifasny7gek
e9acc441 2016-08-07 23:51:21 appveyor: check -DUNICODE -D_UNICODE according to ReleaseChecklist (cmake only) Link: https://github.com/libevent/libevent/wiki/ReleaseChecklist
e35f2241 2016-08-07 23:46:26 cmake: fix -DEVENT__ENABLE_VERBOSE_DEBUG (typo on -DUSE_DEBUG) Fixes: 8b228e27f57300be61b57a41a2ec8666b726dc34 ("Lot's of cmake updates")
a487706e 2016-08-07 23:14:01 test: fix building with --disable-thread-support under win32
38716c65 2016-08-07 23:07:44 cmake: do not use stderr for notifications/version-info For all except "STATUS" message() will write to stderr, and this also includes case when you does not have <mode> at all. Plus for every message in stderr powershell generates exception and make appveyor fails. Fixes: https://ci.appveyor.com/project/azat/libevent/build/2.1.5.85/job/i10k7m0t80330mtr
bb09535b 2016-08-07 22:19:39 autoconf: fix --disable-thread-support build under win32 Fixes: https://ci.appveyor.com/project/azat/libevent/build/job/gvud4tcqsd5bnarl Fixes: https://ci.appveyor.com/project/azat/libevent/build/2.1.6.80/job/5frnb1c3n4quxxqy Fixes: https://ci.appveyor.com/project/azat/libevent/build/2.1.6.80/job/3wdahbrew7setmoa
18108574 2016-08-07 21:30:04 appveyor: ignore failure of mingw-get Since according to doc [1], appveyour will fail the build on every powershell's exception: "PowerShell script is considered successful if it finishes without exception." [1]: https://www.appveyor.com/docs/build-configuration#powershell
ac90133c 2016-08-07 20:52:41 appveyor: drop shallow_clone, since we use tags for detecting version in cmake
a9e8cd67 2016-08-09 12:25:11 test/ssl: use send()/recv()/EVUTIL_ERR_RW_RETRIABLE()/EVUTIL_SOCKET_ERROR() to fix win32 Fixes: https://ci.appveyor.com/project/azat/libevent/build/2.1.5.107/job/k70our1xdp0ym4dm#L1906 Fixes: ssl/bufferevent_connect_sleep
d5a2f2f9 2016-08-09 12:10:18 test/https_basic: increase timeout for complete write (fixes win32) Otherwise on win32 we got 2, but test is ok, some timings issue. Introduced-in: c968eb3 Fixes: https://ci.appveyor.com/project/azat/libevent/build/2.1.5.107/job/k70our1xdp0ym4dm#L1906
c4dfb93f 2016-08-09 10:56:34 cmake: check for ZLIB_INCLUDE_DIR, since we can have only library without headers
671a24f2 2016-08-08 18:10:56 autotools/win32: fix searching ssl library
8f950155 2016-06-19 14:15:41 appveyor: support cmake & autotools using build matrix (like travis-ci has) This will allow us to avoid possible compilation regressions, and also some failures in different environments (for example because of different sizeof(size_t)). For example we can avoid next issues: - #361 - #314 - #311 (And I'm pretty sure that this is not complete list) And of course it reduce job for maintainers. But it also have one downside, appveyor doesn't have such concurrency like travis-ci, so it can take a while to finish the whole build, but we can resolve this later, or reduce build matrix to only one for autotools and one for cmake. Fixes: #364
8a2c6c77 2016-08-08 18:15:41 Ignore `make dist` generated files
df6f99e5 2016-07-08 09:43:39 Check for Mac OS X 10.4 kqueue bug properly EV_ERROR is a bit in struct kevent::flags. Other bits may be set too. Actually we have osx builds on travis-ci, but it uses osx 10.9.5, and we don't have warnings there, since I guess that there is no OR'ing with previous flag in case of error, while in 10.12 there is OR. Fixes: #377 Fixes: #376 Link: https://crbug.com/626534 Link: https://travis-ci.org/libevent/libevent/jobs/141033429
8892f4cb 2016-07-07 13:15:41 buffer: don't mix code and declarations
666db91a 2016-06-29 15:11:50 Fix memory leak in signal-test.c
30316177 2016-06-28 10:37:24 [#372] check for errno.h
e7abef1c 2016-06-26 11:15:58 Merge pull request #367 from neerajbadlani/master Update gitignore file to ignore cscope gen'ed files
70040c09 2016-06-26 01:57:45 buffer: Merge branch '340-dig-v2' All details in this two patches (it's titles), and shortlog is below. * 340-dig-v2: buffer: fix overflow check in evbuffer_expand_singlechain() test/buffer: cover evbuffer_expand() for overflow
a3f4ccd1 2016-06-21 19:49:57 buffer: fix overflow check in evbuffer_expand_singlechain() Refs: #306 Fixes: #340 Fixes: 20d6d4458bee5d88bda1511c225c25b2d3198d6c
48dab7aa 2016-06-22 15:48:51 test/buffer: cover evbuffer_expand() for overflow Refs: #306 Refs: #340
17cc6362 2016-06-24 18:07:39 [Issue #313] set method to ASCII "NULL" if evhttp_method() returns NULL
0aaa4fbe 2016-06-22 21:15:53 Update gitignore file to ignore cscope gen'ed files
a69e4fad 2016-06-19 13:24:18 buffer: Merge branch 'evbuffer-empty-chains-fixes-v4' This fixes bug with empty-chains and evbuffer_add_buffer()/evbuffer_remove_buffer(). * evbuffer-empty-chains-fixes-v4: buffer: evbuffer_add_buffer(): clean empty chains from destination buffer test/buffer: evbuffer_add_buffer() with empty chains test/buffer: evbuffer_remove_buffer() with empty chains (prepend) test/buffer: evbuffer_remove_buffer() with empty chains (evbuffer_add_buffer()) Reported-by: Eduardo Panisset <eduardo@anchorfree.com>
9b294082 2016-06-19 13:21:15 bufferevent_filter: Merge branch 'be-filter-data-stuck' Fixes data stuck in filters with active watermarks. * be-filter-data-stuck: test/be_filter: creating test case for data stuck with active watermarks be_filter: avoid data stuck under active watermarks
766194b3 2016-06-19 02:09:50 test/be_filter: creating test case for data stuck with active watermarks v2: fix whitespaces s/int/size_t/ use tt_int_op() s/malloc/calloc (to avoid possible false-positive)
b627ad88 2016-06-17 10:46:32 be_filter: avoid data stuck under active watermarks Suppose we have bufferevent filter attached to bufferevent socket. Read high watermark for bufferevent filter is configured to 4096 bytes. Socket receives 4343 bytes. Due to watermark, 4096 bytes are transferred from socket input buffer to filter input buffer and 247 bytes are left in bufferevent socket. Suppose that no more data is received through socket. At this point 247 bytes will sit forever in input buffer of bufferevent socket. The patch attached solves this issue registering read callback to filter's input buffer if it reaches its read high water mark and data was left in corresponding underlying's input buffer. This read callback calls filter process input function as soon as filter input buffer falls below its read high watermark and there still is data left in underlying input buffer. Callback is deregistered as soon as filter input buffer falls below its read high watermark.
28518896 2016-05-21 21:05:11 Fix bufferevent_pair to properly set BEV_EVENT_{READING,WRITING} on flush. Here's some fun. From `bufferevent.h`: ``` #define BEV_EVENT_READING 0x01 /**< error encountered while reading */ #define BEV_EVENT_WRITING 0x02 /**< error encountered while writing */ ``` And from `event.h`: ``` /** Wait for a socket or FD to become readable */ #define EV_READ 0x02 /** Wait for a socket or FD to become writeable */ #define EV_WRITE 0x04 ``` Library users have to be very careful to get this right; it turns out, the library itself got this wrong in the `bufferevent_pair` code. It appears that in most of the code, only `BEV_EVENT_FINISHED` will indicate whether it's read or write; on error or timeout, it appears that "both" is assumed and not set in the callback. I read through all the other places where `BEV_EVENT_FINISHED` is passed to an event callback; it appears that the pair code is the only spot that got it wrong. azat: add TT_FORK to avoid breaking clean env, and rebase commit message (copied from #359) Fixes: #359
26fd9321 2016-06-07 18:31:48 buffer: evbuffer_add_buffer(): clean empty chains from destination buffer @EMPanisset reported a problem (#358) with evbuffer_remove_buffer(), but actually I think that the problem is in evbuffer_add_buffer() which introduces this empty chain, all other callers (except evbuffer_prepend_buffer(), but it doesn't have this problem though) should be safe. And FWIW the only API that allows empty chains is evbuffer_add_reference(), and we can add check there to avoid such issues, but for now I leaved this without fixing, since I think that evbuffer_add_reference() with empty chains can be used as a barrier (but this can be tricky). Fixes: regress evbuffer/remove_buffer_with_empty2 v2: introduce/fixes evbuffer/add_buffer_with_empty
a272bc42 2016-06-17 15:54:53 test/buffer: evbuffer_add_buffer() with empty chains Reported-by: @EMPanisset Link: https://github.com/libevent/libevent/issues/358#issuecomment-225345697
f0cfa146 2016-06-08 13:41:30 test/buffer: evbuffer_remove_buffer() with empty chains (prepend) Using: - evbuffer_add() - evbuffer_prepend_buffer() - evbuffer_add_reference() - evbuffer_remove_buffer()
2880ce6a 2016-06-07 14:56:32 test/buffer: evbuffer_remove_buffer() with empty chains (evbuffer_add_buffer()) Using: - evbuffer_add() - evbuffer_add_buffer() -- the one that has problem - evbuffer_add_reference() -- the only one that allows empty chains to be added - evbuffer_remove_buffer()
2a4bf294 2016-06-17 16:14:02 test/http: avoid using conditionals with omitted operands (fixes VS2015) But we need to add VS2015 build on appveyor. Fixes: #361 Reported-by: @nntrab
aabf1c2d 2016-06-17 16:07:15 test/http: don't mix declarations and code (fixes -Wdeclaration-after-statement)
c08d90ba 2016-06-17 15:54:31 test/buffer: fix leak in test_evbuffer_prepend()
e7d1e392 2016-06-17 15:43:26 test/buffer: avoid errors with --no-fork (reinitialize static vars)
b5ca3656 2016-05-30 16:53:41 For non GCC/clang on OSX the -Wno-deprecated-declarations may not be valid Closes: nmathewson/Libevent#129
41e54464 2016-05-12 00:40:25 Merge branch 'travis-ci-os-matrix-v2' This increases libevent coverage to: - os:osx - cmake -DEVENT__DISABLE_MM_REPLACEMENT=ON - cmake -DEVENT__ENABLE_VERBOSE_DEBUG=ON - configure --disable-openssl - configure --disable-thread-support - configure --disable-malloc-replacement - fix travis-ci builds under automake >1.11 Possible failures after this patch set (not always, IOW in some builds this issues aren't real issues): - some failures but mostly because of timing issues, must be fixed separately. - https://travis-ci.org/azat/libevent/jobs/129430229 # on brew update - https://travis-ci.org/azat/libevent/jobs/129430221 # some locking issues * travis-ci-os-matrix-v2: automake: define serial-tests only if automake have this option test/automake: don't use paralell test harness (since automake 1.12) travis-ci/osx: relink gcc/g++ instead of clang travis-ci: enable multi-os mode (osx, linux) travis-ci: increase matrix (--disable-foo) travis-ci: adjust alignment Fixes: #356 Travis-CI: https://travis-ci.org/azat/libevent/builds/129430181
61179dec 2016-05-11 16:02:02 automake: define serial-tests only if automake have this option P.S. I did try a lot of other ways, but seems that this is the only one that will work. Fixes: automake 1.11 Travis-CI: https://travis-ci.org/azat/libevent/jobs/129398265
44d755e0 2016-05-11 10:18:25 test/automake: don't use paralell test harness (since automake 1.12) Starting from automake 1.2 there is parallel test harness, that redirects all output to some log, which serial-test doesn't do. So in case of new runner we can get no output for 10 minutes, for example on my desktop: $ time make verify VERBOSE=1 PASS: test/test-script.sh ============================================================================ Testsuite summary for libevent 2.1.5-beta ============================================================================ # TOTAL: 1 # PASS: 1 # SKIP: 0 # XFAIL: 0 # FAIL: 0 # XPASS: 0 # ERROR: 0 ============================================================================ real 25m31.735s user 0m13.753s sys 0m7.648s And this means that this will fail on travis-ci, since it has timeout for 10 minutes. Sure we can use `travis wait 60` instead, but I think that it is better to fix this by writing result to output, instead of hacking around, so let's use serial-tests instead of parallel always. And now it works on travis-ci under linux because it has automake 1.11 while osx has at least 1.12. Links: https://docs.travis-ci.com/user/common-build-problems/ https://www.gnu.org/software/automake/manual/html_node/Serial-Test-Harness.html#Serial-Test-Harness https://www.gnu.org/software/automake/manual/html_node/Parallel-Test-Harness.html CI: https://travis-ci.org/azat/libevent/jobs/129171497 # ok on linux https://travis-ci.org/azat/libevent/jobs/129171532 # no output for 10 min on osx
481481d3 2016-05-10 10:25:05 travis-ci/osx: relink gcc/g++ instead of clang Since by default osx replaces /usr/bin/gcc with it's apple clang, while we have gcc in our build matrix, so use real gcc.
79917e48 2016-05-09 18:14:31 travis-ci: enable multi-os mode (osx, linux) - use addons.apt.packages instead of `apt-get install` - add `brew update`/`brew install ...` Link: https://docs.travis-ci.com/user/installing-dependencies/ Link: https://docs.travis-ci.com/user/multi-os/
59649f74 2016-05-09 18:48:56 travis-ci: increase matrix (--disable-foo) Use --disable-foo from https://github.com/libevent/libevent/wiki/ReleaseChecklist
c8be3395 2016-05-09 18:54:41 travis-ci: adjust alignment
38e0f4a5 2016-05-02 15:21:50 be_openssl: clear all pending errors before SSL_*() calls Refs: #350 Reported-by: @CapSel
ce389933 2016-04-21 02:16:21 Ignore all pkgconfig generated stuff In the referenced commit new *.pc added, and I think it is better to ignore them all. Refs: b8d7c6211a965c19c7c5de414135ff13b5fa2476 ("libevent_core and libevent_extra also deserve a pkgconfig file")
e77ff418 2016-04-21 01:47:29 test/buffer: cover n_add_for_cb when evbuffer_prepend() need to allocate buffer Regression-for: 0abd0393eaf029e1ead8a09b479ea6830f7152ee ("Fix n_add_for_cb in evbuffer_prepend() in case of new buffer required")
bd19a28a 2016-04-21 02:11:26 test/tinytest_macros: add new one tt_nstr_op()
0abd0393 2016-04-21 01:58:58 Fix n_add_for_cb in evbuffer_prepend() in case of new buffer required Signed-off-by: @luoming1224 Fixes: #349
b8d7c621 2016-04-20 07:31:25 libevent_core and libevent_extra also deserve a pkgconfig file
d5e634a8 2016-04-18 13:39:54 Merge branch 'be-filter-outputcb-disable-during-execution' * be-filter-outputcb-disable-during-execution: test/bufferevent: check that output_filter disabled during processing output be_filter: actually disable output_filter during processing output
ae288125 2016-04-18 12:50:24 test/bufferevent: check that output_filter disabled during processing output Regression-for: c031215d532c97f1d82efd672ecd622d31d3342d ("be_filter: actually disable output_filter during processing output")
c031215d 2016-02-28 16:49:15 be_filter: actually disable output_filter during processing output IOW: Make the code do what the comment says it should do.
2a71b332 2016-03-31 20:45:47 listener: unlock lev on error in listener_read_cb() Without this patch: $ regress --no-fork +listener/error_unlock listener/error_unlock: [warn] Error from accept() call: Too many open files [err] ../evthread.c:220: Assertion lock->count == 0 failed in ../evthread.c Aborted (core dumped) Fixes: #341 Fixes: listener/error_unlock
7d856516 2016-03-31 20:50:12 test/listener: regression for missing unlock in listener_read_cb() P.S. it triggers even without pthread, but this makes checks more strict. Refs: #341
b59ef3bd 2016-03-29 19:20:30 Merge remote-tracking branch 'origin/pr/339' * origin/pr/339: evbuffer_add: Use last_with_datap if set, not last. test/regress: add tests for evbuffer_add() breakage on empty last chain Fixes: #335
a8769ef1 2016-03-26 20:11:43 evbuffer_add: Use last_with_datap if set, not last. evbuffer_add() would always put data in the last chain, even if there was available space in a previous chain, and in doing so it also failed to update last_with_datap, causing subsequent calls to other functions that do look at last_with_datap to add data in the middle of the evbuffer instead of at the end. Fixes the evbuffer_add() part of issue #335, and the evbuffer/add2 and evbuffer/add3 tests, and also prevents wasting space available in the chain pointed to by last_with_datap.
d5ee7391 2016-03-26 14:14:44 test/regress: add tests for evbuffer_add() breakage on empty last chain The evbuffer/add* tests currenly break on 2.0.21, 2.0.22 and 2.1 HEAD due to issue #335. The evbuffer/reference2 test breaks on 2.0.21 and 2.0.22 due to commit b18c04dd not being applied.
bddad71e 2016-03-25 11:22:43 test/http: fix running some tests sequential (with --no-fork) After this patch $ regress --no-fork +http/.. Passed without failures.
cbc3209d 2016-03-25 11:04:51 test/http: localize evhttp server structure
24b52149 2016-03-25 10:21:48 evhttp_have_expect(): fix -Wlogical-not-parentheses ../http.c:589:6: warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses] if (!req->kind == EVHTTP_REQUEST || !REQ_VERSION_ATLEAST(req, 1, 1)) ^ ~~
ec65c420 2016-03-25 00:33:47 evdns: fix searching empty hostnames From #332: Here follows a bug report by **Guido Vranken** via the _Tor bug bounty program_. Please credit Guido accordingly. ## Bug report The DNS code of Libevent contains this rather obvious OOB read: ```c static char * search_make_new(const struct search_state *const state, int n, const char *const base_name) { const size_t base_len = strlen(base_name); const char need_to_append_dot = base_name[base_len - 1] == '.' ? 0 : 1; ``` If the length of ```base_name``` is 0, then line 3125 reads 1 byte before the buffer. This will trigger a crash on ASAN-protected builds. To reproduce: Build libevent with ASAN: ``` $ CFLAGS='-fomit-frame-pointer -fsanitize=address' ./configure && make -j4 ``` Put the attached ```resolv.conf``` and ```poc.c``` in the source directory and then do: ``` $ gcc -fsanitize=address -fomit-frame-pointer poc.c .libs/libevent.a $ ./a.out ================================================================= ==22201== ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60060000efdf at pc 0x4429da bp 0x7ffe1ed47300 sp 0x7ffe1ed472f8 READ of size 1 at 0x60060000efdf thread T0 ``` P.S. we can add a check earlier, but since this is very uncommon, I didn't add it. Fixes: #332
d7348bab 2016-03-25 00:21:06 test/dns: regression for empty hostname Refs: #332
d49a6587 2016-03-24 20:29:25 test/http: fix SERVER_TIMEOUT tests under win32 Seems that the hack with filling BACKLOG didn't work on win32, and hence we stuck in write() waiting, not in connect() And: $ time regress http/cancel_server_timeout - on linux: 10secs - on win32: 2-5secs I tried to debug this but you can't sniff TCP packages (wireshark/rawpcap) on localhost in windows xp (according to [RAWPCAP] and my testing). RAWPCAP: http://www.netresec.com/?page=RawCap
376f1073 2016-03-24 20:26:50 test/http: add a helper for creating timedout/failed request
d02a2858 2016-03-24 14:11:10 test/http: adopt for C90 (mixed code and declarations)
4db15e09 2016-03-24 12:49:47 evdns: avoid double-free in evdns_base_free() for probing requests http/cancel_by_host_no_ns: OK ../test/regress_http.c:1384: assert(regress_dnsserver(data->base, &portnum, search_table)) OK ../test/regress_http.c:1387: assert(dns_base) OK ../test/regress_http.c:1423: assert(evcon) OK ../test/regress_http.c:1444: assert(evhttp_make_request(evcon, req, EVHTTP_REQ_GET, "/delay") != -1): 0 vs -1 OK ../test/regress_http.c:1455: assert(test_ok == 2): 2 vs 2 OK ../test/regress_http.c:1480: assert(evhttp_make_request(evcon, req, EVHTTP_REQ_GET, "/test") != -1): 0 vs -1[msg] Nameserver 127.0.0.1:55948 has failed: request timed out. [msg] All nameservers have failed OK ../test/regress_http.c:1274: assert(!req) OK ../test/regress_http.c:1505: assert(evhttp_make_request(evcon, req, EVHTTP_REQ_GET, "/test") != -1): 0 vs -1 OK ../test/regress_http.c:1274: assert(!req)==19199== Invalid read of size 8 ==19199== at 0x4CC285: evdns_cancel_request (evdns.c:2849) ==19199== by 0x4CEDB2: evdns_nameserver_free (evdns.c:4018) ==19199== by 0x4CEF5B: evdns_base_free_and_unlock (evdns.c:4052) ==19199== by 0x4CF13B: evdns_base_free (evdns.c:4088) ==19199== by 0x4617A3: http_cancel_test (regress_http.c:1518) ==19199== by 0x490A78: testcase_run_bare_ (tinytest.c:105) ==19199== by 0x490D5A: testcase_run_one (tinytest.c:252) ==19199== by 0x491699: tinytest_main (tinytest.c:434) ==19199== by 0x47E0E0: main (regress_main.c:461) ==19199== Address 0x61e56d0 is 0 bytes inside a block of size 48 free'd ==19199== at 0x4C2AE6B: free (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==19199== by 0x4AAFFF: event_mm_free_ (event.c:3516) ==19199== by 0x4C5ADD: request_finished (evdns.c:693) ==19199== by 0x4CEE95: evdns_base_free_and_unlock (evdns.c:4040) ==19199== by 0x4CF13B: evdns_base_free (evdns.c:4088) ==19199== by 0x4617A3: http_cancel_test (regress_http.c:1518) ==19199== by 0x490A78: testcase_run_bare_ (tinytest.c:105) ==19199== by 0x490D5A: testcase_run_one (tinytest.c:252) ==19199== by 0x491699: tinytest_main (tinytest.c:434) ==19199== by 0x47E0E0: main (regress_main.c:461) ==19199== Block was alloc'd at ==19199== at 0x4C2BBD5: calloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==19199== by 0x4AAEB2: event_mm_calloc_ (event.c:3459) ==19199== by 0x4CAAA2: nameserver_send_probe (evdns.c:2327) ==19199== by 0x4C50FF: nameserver_prod_callback (evdns.c:494) ==19199== by 0x4A564C: event_process_active_single_queue (event.c:1646) ==19199== by 0x4A5B95: event_process_active (event.c:1738) ==19199== by 0x4A6296: event_base_loop (event.c:1961) ==19199== by 0x4A5C1D: event_base_dispatch (event.c:1772) ==19199== by 0x46172C: http_cancel_test (regress_http.c:1507) ==19199== by 0x490A78: testcase_run_bare_ (tinytest.c:105) ==19199== by 0x490D5A: testcase_run_one (tinytest.c:252) ==19199== by 0x491699: tinytest_main (tinytest.c:434) ==19199==
5830e331 2016-03-24 14:05:28 Merge branch 'bufev-cancellations-v5' This patch set fixes bufferevent via http request cancellations (connect() and dns-request), it survives tests and cancel.. with --no-fork, so this must be ok (though I have one patch for dns layer pending). But I'm not sure about cancel.. unit tests on win32, will fix disable them later if they will differs (plus maybe we must make them skip-by-default?). Fixes: #333 * bufev-cancellations-v5: http: set fd to -1 unconditioally, to avoid leaking of DNS requests test/http: cover NS timed out during request cancellations separatelly http: avoid leaking of fd in evhttp_connection_free() http: get fd from be layer during connection reset be_sock: cancel in-progress dns requests evdns: export cancel via callbacks in util (like async lib core/extra issues) test/http: request cancellation with resolving/{conn,write}-timeouts in progress
7a4b4729 2016-03-24 13:38:05 http: set fd to -1 unconditioally, to avoid leaking of DNS requests Otherwise: http/cancel_by_host_ns_timeout_inactive_server: [msg] Nameserver 127.0.0.1:37035 has failed: request timed out. [msg] All nameservers have failed OK 1 tests ok. (0 skipped) ==26211== ==26211== FILE DESCRIPTORS: 3 open at exit. ==26211== Open file descriptor 2: /dev/pts/47 ==26211== <inherited from parent> ==26211== ==26211== Open file descriptor 1: /dev/pts/47 ==26211== <inherited from parent> ==26211== ==26211== Open file descriptor 0: /dev/pts/47 ==26211== <inherited from parent> ==26211== ==26211== ==26211== HEAP SUMMARY: ==26211== in use at exit: 1,112 bytes in 5 blocks ==26211== total heap usage: 149 allocs, 144 frees, 18,826 bytes allocated ==26211== ==26211== 40 bytes in 1 blocks are indirectly lost in loss record 1 of 5 ==26211== at 0x4C2BBD5: calloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==26211== by 0x4AAEB2: event_mm_calloc_ (event.c:3459) ==26211== by 0x498F5B: evbuffer_add_cb (buffer.c:3309) ==26211== by 0x4A0EF5: bufferevent_socket_new (bufferevent_sock.c:366) ==26211== by 0x4BFADF: evhttp_connection_base_bufferevent_new (http.c:2375) ==26211== by 0x4BFC8F: evhttp_connection_base_new (http.c:2427) ==26211== by 0x460DAA: http_cancel_test (regress_http.c:1417) ==26211== by 0x490A78: testcase_run_bare_ (tinytest.c:105) ==26211== by 0x490D5A: testcase_run_one (tinytest.c:252) ==26211== by 0x491699: tinytest_main (tinytest.c:434) ==26211== by 0x47E0E0: main (regress_main.c:461) ==26211== ==26211== 136 bytes in 1 blocks are indirectly lost in loss record 2 of 5 ==26211== at 0x4C2BBD5: calloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==26211== by 0x4AAEB2: event_mm_calloc_ (event.c:3459) ==26211== by 0x491FF0: evbuffer_new (buffer.c:365) ==26211== by 0x49A1BE: bufferevent_init_common_ (bufferevent.c:300) ==26211== by 0x4A0E44: bufferevent_socket_new (bufferevent_sock.c:353) ==26211== by 0x4BFADF: evhttp_connection_base_bufferevent_new (http.c:2375) ==26211== by 0x4BFC8F: evhttp_connection_base_new (http.c:2427) ==26211== by 0x460DAA: http_cancel_test (regress_http.c:1417) ==26211== by 0x490A78: testcase_run_bare_ (tinytest.c:105) ==26211== by 0x490D5A: testcase_run_one (tinytest.c:252) ==26211== by 0x491699: tinytest_main (tinytest.c:434) ==26211== by 0x47E0E0: main (regress_main.c:461) ==26211== ==26211== 136 bytes in 1 blocks are indirectly lost in loss record 3 of 5 ==26211== at 0x4C2BBD5: calloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==26211== by 0x4AAEB2: event_mm_calloc_ (event.c:3459) ==26211== by 0x491FF0: evbuffer_new (buffer.c:365) ==26211== by 0x49A1FB: bufferevent_init_common_ (bufferevent.c:305) ==26211== by 0x4A0E44: bufferevent_socket_new (bufferevent_sock.c:353) ==26211== by 0x4BFADF: evhttp_connection_base_bufferevent_new (http.c:2375) ==26211== by 0x4BFC8F: evhttp_connection_base_new (http.c:2427) ==26211== by 0x460DAA: http_cancel_test (regress_http.c:1417) ==26211== by 0x490A78: testcase_run_bare_ (tinytest.c:105) ==26211== by 0x490D5A: testcase_run_one (tinytest.c:252) ==26211== by 0x491699: tinytest_main (tinytest.c:434) ==26211== by 0x47E0E0: main (regress_main.c:461) ==26211== ==26211== 536 bytes in 1 blocks are indirectly lost in loss record 4 of 5 ==26211== at 0x4C2BBD5: calloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==26211== by 0x4AAEB2: event_mm_calloc_ (event.c:3459) ==26211== by 0x4A0E15: bufferevent_socket_new (bufferevent_sock.c:350) ==26211== by 0x4BFADF: evhttp_connection_base_bufferevent_new (http.c:2375) ==26211== by 0x4BFC8F: evhttp_connection_base_new (http.c:2427) ==26211== by 0x460DAA: http_cancel_test (regress_http.c:1417) ==26211== by 0x490A78: testcase_run_bare_ (tinytest.c:105) ==26211== by 0x490D5A: testcase_run_one (tinytest.c:252) ==26211== by 0x491699: tinytest_main (tinytest.c:434) ==26211== by 0x47E0E0: main (regress_main.c:461) ==26211== ==26211== 1,112 (264 direct, 848 indirect) bytes in 1 blocks are definitely lost in loss record 5 of 5 ==26211== at 0x4C2BBD5: calloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==26211== by 0x4AAEB2: event_mm_calloc_ (event.c:3459) ==26211== by 0x4D0564: evdns_getaddrinfo (evdns.c:4685) ==26211== by 0x4B13BA: evutil_getaddrinfo_async_ (evutil.c:1575) ==26211== by 0x4A139E: bufferevent_socket_connect_hostname (bufferevent_sock.c:524) ==26211== by 0x4C02DB: evhttp_connection_connect_ (http.c:2588) ==26211== by 0x4C04DD: evhttp_make_request (http.c:2643) ==26211== by 0x4615FF: http_cancel_test (regress_http.c:1504) ==26211== by 0x490A78: testcase_run_bare_ (tinytest.c:105) ==26211== by 0x490D5A: testcase_run_one (tinytest.c:252) ==26211== by 0x491699: tinytest_main (tinytest.c:434) ==26211== by 0x47E0E0: main (regress_main.c:461) ==26211== ==26211== LEAK SUMMARY: ==26211== definitely lost: 264 bytes in 1 blocks ==26211== indirectly lost: 848 bytes in 4 blocks ==26211== possibly lost: 0 bytes in 0 blocks ==26211== still reachable: 0 bytes in 0 blocks ==26211== suppressed: 0 bytes in 0 blocks