src/joystick


Log

Author Commit Date CI Message
divVerent 91ad208d 2023-03-06T18:33:18 Fix Xbox One gamepad axis assignment on SDL_JOYSTICK_ANDROID API (#7405) (cherry picked from commit 6f1f586086a18ab32ddccc05e4616aac02774a1b)
Sam Lantinga f47a08ab 2023-03-01T16:47:48 Fixed typo in previous cherry-pick
Sam Lantinga 660fc899 2023-03-01T16:38:48 Don't clobber an existing entry with a different version when adding a gamepad mapping (cherry picked from commit 727c7d4e2f44102bb571180929bfbb5d527f4f27)
Sam Lantinga c0fb0924 2023-02-28T08:36:31 Fixed locking up the Logitech F310 with the PlayStation controller detection (cherry picked from commit da134a30396e12786c14fe8d1190ab05c67d9dba)
Sam Lantinga 715749f5 2023-02-27T15:19:34 Added mapping for DualSense Edge Wireless Controller on Linux This is a mapping when using evdev, not the more advanced HIDAPI support. (cherry picked from commit 206fa4dafb633ed074b930cbb3440a9925c532f2)
Sam Lantinga 3bf9c70a 2023-02-23T12:24:15 Changed the VID/PID used for the Backbone One controller on iOS (cherry picked from commit 516e48515e32f74aa98a3df4cbdb23b9c477f2f0)
Sam Lantinga ea710308 2023-02-23T11:57:48 Added support for the Backbone One PlayStation Edition (cherry picked from commit 59bf1c2853d5b06295c939099f6cf5f1611f70b5)
Sam Lantinga 13969f85 2023-02-21T15:31:32 De-duplicate Google Stadia controllers on macOS (cherry picked from commit 87a83787a3a0a9922b02b35ba809d9da86930fc8)
Sam Lantinga 9be85b84 2023-02-21T15:05:57 Rumbling the Google Stadia Controller over Bluetooth works on Linux and macOS (cherry picked from commit 4aeec9d8c2ad2fa0465999ecb4fd5c20734f1b27)
Sam Lantinga 35c9b104 2023-02-21T12:47:33 Fixed the packet size for Xbox One controllers (cherry picked from commit 021a7cfa13c20d518ebfb6e96c3305150256983b)
Sam Lantinga 31a57c05 2023-02-10T16:46:21 Fixed the share button on the ThrustMaster eSwap PRO Controller Xbox (cherry picked from commit e4face7c1d41698067b9afdd8c7f0a8f76774da2)
Sam Lantinga 3dff5d3c 2023-02-06T20:14:12 Added support for the Turtle Beach REACT-R and Recon Xbox controllers (cherry picked from commit 5fded632d6fa532ac25e76ad9a676c9ea726dd02)
Sam Lantinga 4c9a79dd 2023-02-20T18:24:52 Removed duplicated conditional (cherry picked from commit 1a15d506a69d5d73a53728c569ef84a69db51833)
Sam Lantinga 7c4f5e1d 2023-02-20T17:14:18 Fixed rumble caps for the Nintendo Joy-Con controllers (cherry picked from commit 02cea5fca107991774792c431efc96319ef2d060)
Sam Lantinga abe8dbbf 2023-02-20T15:14:20 Added support for the Razer Wolverine V2 controllers (cherry picked from commit 4994654d4f2d5c96a0faa972ebbb6c653f939d56)
Sam Lantinga f741adc8 2023-02-17T11:29:27 Added other names for the DragonRise Inc. Wired Wheel (thanks @felimwhiteley!) (cherry picked from commit eede2066fbcc342e96592fbbbfe94b2420feb524)
Sam Lantinga e86f4943 2023-02-16T09:50:04 Hold the joystick lock while opening the HID device on non-Android platforms On Windows the main thread can be enumerating DirectInput devices while the Windows.Gaming.Input thread is calling back with a new controller available, and in this case HIDAPI_IsDevicePresent() returned false since the controller initialization hadn't completed yet, creating a duplicate controller. Fixes https://github.com/libsdl-org/SDL/issues/7304 (cherry picked from commit ece8a7bb8e2dae9cb53115980cea9ef1213a0160)
Sam Lantinga 69b2baec 2023-02-14T18:02:12 Map the Android MENU button back to the SDL MENU key Thanks to @AntTheAlchemist for the investigation! Fixes https://github.com/libsdl-org/SDL/issues/7318 (cherry picked from commit beb6a2afdc74a00f07ec230297c2675920a7bf79)
Sam Lantinga 2c699577 2023-02-14T17:51:16 Fixed handling simple mode PS4 reports Fixes https://github.com/libsdl-org/SDL/issues/7270 (cherry picked from commit 5925cd4ef377a2211fd057ef6fa9f41141999cb7)
Sam Lantinga 7285f0d4 2023-02-10T17:18:02 Sorted controller list (cherry picked from commit 68e2f230662a0b3f2ce7c0085f781f1652901af3)
Alfredo Escobar ca3468cb 2023-01-30T16:08:52 Add Hori Pokken Tournament DX Pro Pad (cherry picked from commit 76552e4780a57f24ec1cd77fb942b7cabe1219d8)
Sylvain 17515f4a 2023-02-04T15:51:37 Backport simplify flags PR #7220
Sam Lantinga d77eb8a8 2023-02-08T14:22:39 Make sure we synchronously re-enable USB reporting mode for Switch controllers (thanks @SortaCore!) Fixes https://github.com/libsdl-org/SDL/issues/3450 (cherry picked from commit b7c6fec10a152e47f8fa18350134188b75e9df0b)
Sam Lantinga 3fb9118c 2023-02-08T14:16:24 Note the Google Stadia controller doesn't support rumble over Bluetooth (cherry picked from commit 50575ed2233b9924198e10c9a261c10323d9089e)
Sam Lantinga 71fb4e3d 2023-02-08T14:16:21 Fixed mis-detecting the share button on the Xbox controller over NDIS (cherry picked from commit 00e02de77b615d5faf94af709760fd0f2e749a39)
Sam Lantinga 2518e32d 2023-02-08T14:16:17 Dynamically update the serial number if it isn't available at first This happens for Xbox One controllers using newer firmware connected over NDIS (cherry picked from commit d1c72bb0bc54fba41ba89930a3ed98f8767be724)
Sam Lantinga e8938fc6 2023-01-20T09:31:22 Enable paddles on the Xbox Elite controller when connected over USB (cherry picked from commit c4db0725e4cf5eb6ec5239e6f03346958e88b9cf)
Ozkan Sezer fde63236 2023-02-07T01:11:02 fix build after the Logitech ChillStream patch.
Sam Lantinga 71546059 2023-02-06T13:28:00 Added support for the Logitech ChillStream (cherry picked from commit 6f7edaf8920c504ebd3e797bd04ec1d2e46c4aa9)
Sam Lantinga 5b5a72e3 2023-02-05T08:43:26 Sorted controller list (cherry picked from commit 1c03ddefc320ec9969d5f81c2c3cb988d94a8b4c)
Antonis Geralis 58fa43e7 2023-02-05T10:35:53 Added Elecom 8button gamepad (cherry picked from commit 52cd9fcbb074771804f443e7a9b2e9436485fe83)
Leonardo Brondani Schenkel 4266cf85 2023-01-04T13:46:01 Add Linux mapping for 8BitDo Pro 2 Wired Controller for Xbox Without these mappings, this controller "kinda" works out of the box: - `SDL_GameControllerMapping()` works because it will notice "Xbox" in the name and use the default XInput mappings - `SDL_GameControllerMappingForGUID()` will not find any mapping lsusb: ``` ID 2dc8:2000 8BitDo 8BitDo Pro 2 Wired Controller for Xbox ``` In Linux this controller is supported by two drivers: - `xpad` (built-in to the kernel), exposes the controller name from the USB descriptor and the GUID starts with 03 (0x03 = BUS_USB) - `xone` (https://github.com/medusalix/xone), exposes a virtual controller which is always named "Microsoft X-Box One pad" and the GUID starts with 06 (0x06 = BUS_VIRTUAL) This commit adds the 2 GUIDs from both drivers so mappings will always be found and the real controller name will always be reported.
Alynne 92779a5b 2023-01-30T01:46:03 Adds Stadia BT mapping (cherry picked from commit 4dea13e02fbfd2ac9eeb0a5cbb35cf5d1d53f549)
Sam Lantinga c4a493de 2023-02-02T08:39:54 Don't accept official mappings for controllers that aren't unique For example, the DragonRise Inc. Generic USB Joystick See https://github.com/gabomdq/SDL_GameControllerDB/issues/202 for details (cherry picked from commit 673bc5764942e3f645f1ff7d64f3d6a2059e3cdb)
Sam Lantinga 4a87abc9 2023-02-02T08:38:22 Fixed sort_controllers.py and resorted game controller database (cherry picked from commit 917607c335a87edcb3870b8504247609bea3c04d)
Sam Lantinga 2290d713 2023-02-01T23:09:53 Added gamepad mappings for the Xin-Mo Dual Arcade Fightstick (cherry picked from commit d29e1f363239b45aedf5f81683fbb6cf52029bc2)
happyharryh 2cb42236 2023-01-10T20:36:13 Fixed the hat_map to avoid segmentation fault (cherry picked from commit 57e78f4cf53b0fc84900a047120263c3c71e721c)
Narr the Reg fa934dd4 2023-01-09T17:42:17 hidapi: switch: Add user calibration support (cherry picked from commit 9fa55d9cabc93532cd5cf44105ec589a4db1d097)
Sam Lantinga 0479df53 2023-01-09T09:48:21 Updated copyright for 2023
Sam Lantinga ebc2fb41 2023-01-08T09:32:31 Fixed infinite loop shutting down WGI controllers We are guaranteed that the lock will be held during shutdown, so if we are in InvokeRemoved(), it's because we're shutting down controllers and need to remove them from our internal list. Fixes https://github.com/libsdl-org/SDL/issues/7016 (cherry picked from commit ac99db9fc8d528a79abb98a5641e0fd94aa20a9e)
Sam Lantinga 988866ca 2023-01-03T15:12:47 Fixed line wrapping for HID packet dump (cherry picked from commit e85839cd5694a79f69ac16f48a5d845cdc62f809)
Sam Lantinga 2cb7a0a0 2023-01-03T15:12:18 Added support for the ThrustMaster eSwap PRO Controller Xbox (cherry picked from commit dacdb1c310d97ca3c3e6492cae0611f86b281b34)
Sam Lantinga 29a4c5eb 2022-12-28T12:51:36 Fixed getting the VID/PID of a virtual joystick (cherry picked from commit e40a96155fc488feaeeeb79f947eb43399faa481)
Sam Lantinga 903df79b 2022-12-27T12:14:43 Make sure we match the same way when adding a mapping and looking up a mapping Fixes https://github.com/libsdl-org/SDL/issues/6898 (cherry picked from commit 3db9112ef4cbb936b11f941f8a98c1704e37e140)
Sam Lantinga 6969b3be 2022-12-19T09:14:04 Don't send Razer devices the Sony third-party query feature report Some of them lock up or reset, and the vast majority of devices are not actually game controllers. Fixes https://github.com/libsdl-org/SDL/issues/6733 (cherry picked from commit 83b29f9ce1fe6caa06769544c3b5f6c10ea97a0f)
Sam Lantinga 3b0cd441 2022-12-17T06:51:02 Fixed compiler warning ``` ./src/joystick/SDL_joystick.c:105:12: warning: no previous extern declaration for non-static variable 'SDL_joystick_lock' [-Wmissing-variable-declarations] SDL_mutex *SDL_joystick_lock = NULL; /* This needs to support recursive locks */ ^ ./src/joystick/SDL_joystick.c:105:1: note: declare 'static' if the variable is not intended to be used outside of this translation unit SDL_mutex *SDL_joystick_lock = NULL; /* This needs to support recursive locks */ ^ ``` 1 warning generated.
Sam Lantinga a53382e4 2022-12-15T18:00:51 Sorted PS4 controllers, note that the NACON Wireless Controller for PS4 actually reports as an XInput device
Sam Lantinga e99b9ca9 2022-12-15T17:58:29 Note that the NACON Daija Arcade Stick is an arcade stick
Sam Lantinga 7a9966af 2022-12-14T14:24:58 Fixed crash in SDL_PrivateGameControllerRefreshMapping()
Sam Lantinga d59caffe 2022-12-13T14:03:40 Added support for clang thread-safety analysis The annotations have been added to SDL_mutex.h and have been made public so applications can enable this for their own code. Clang assumes that locking and unlocking can't fail, but SDL has the concept of a NULL mutex, so the mutex functions have been changed not to report errors if a mutex hasn't been initialized. We do have mutexes that might be accessed when they are NULL, notably in the event system, so this is an important change. This commit cleans up a bunch of rare race conditions in the joystick and game controller code so now everything should be completely protected by the joystick lock. To test this, change the compiler to "clang -Wthread-safety -Werror=thread-safety -DSDL_THREAD_SAFETY_ANALYSIS"
Sam Lantinga 817454cf 2022-12-12T18:00:57 Don't try to open the Razer Huntsman Elite keyboard as a controller
Sam Lantinga 802b5ef7 2022-12-12T10:54:29 Added support for the STRIKEPAD PS4 Grip Add-on to the HIDAPI driver (cherry picked from commit 618340bf990512247ed29a1beb38606e371d60e8)
Sam Lantinga fc689a6c 2022-12-07T16:06:17 Fixed build
Sam Lantinga b4d54790 2022-12-07T14:53:33 Use the correct name for the DualSense controllers (cherry picked from commit 9a6bcca6b8db999217f157dab8c44bf27b0a8eb4)
Sam Lantinga 4ee36a94 2022-12-07T14:25:53 Added support for the DualSense Edge paddles (cherry picked from commit 9339085593dc20b1f003f26b3c40615cf04504b0)
Sam Lantinga d1b48105 2022-12-05T13:36:51 Fixed centering the D-pad on some joysticks Fixes https://github.com/libsdl-org/SDL/issues/6767
Max Bachmann 7ac66972 2022-12-03T09:45:04 Detect Logitech PRO Racing Wheel as wheel (cherry picked from commit 5650046f931e9b1d7d7f4a1867e6e1ed75a5e7c5)
Sam Lantinga 423c558e 2022-12-01T14:43:34 Detect the G923 (Xbox style) and PXN V900 (PS3 mode) as wheels (cherry picked from commit 7237c5649994d2b2c2b364c3b116a6db80ea671d)
Pierre Wendling d0bbfdbf 2022-12-01T16:07:03 Clang-Tidy fixes (#6725) (cherry picked from commit 3c501b963dd8f0605a6ce7978882df39ba76f9cd)
Sylvain 09ee811f 2022-12-01T09:39:08 Small format changed (using clang-format 15.0.2-1) (cherry picked from commit 778b8926b4808f0642a331ed84a9e8e19899b6db)
Sam Lantinga 6e40c7a9 2022-11-30T17:03:29 Added support for the Logitech Cordless Precision PS3 controller
Sam Lantinga 01541bc3 2022-11-30T16:42:00 Added support for the HORIPAD Pro for Xbox Series X
Sam Lantinga 4504c10f 2022-11-30T16:37:20 Re-enabled support for third party PS3 controllers
Sam Lantinga 9e997cc7 2022-11-30T15:39:10 Fixed Victrix FS Pro V2 controller hang on reboot
Sam Lantinga b8d85c69 2022-11-30T12:51:59 Update for SDL3 coding style (#6717) I updated .clang-format and ran clang-format 14 over the src and test directories to standardize the code base. In general I let clang-format have it's way, and added markup to prevent formatting of code that would break or be completely unreadable if formatted. The script I ran for the src directory is added as build-scripts/clang-format-src.sh This fixes: #6592 #6593 #6594 (cherry picked from commit 5750bcb174300011b91d1de20edb288fcca70f8c)
Sam Lantinga 2d24baaa 2022-11-29T09:26:29 Fixed building on Windows with SDL_VIDEO=OFF Fixes https://github.com/libsdl-org/SDL/issues/6562
Sam Lantinga 89e9f7b4 2022-11-28T23:10:02 Added support for the Xbox Elite controller paddles with firmware version 5.13+
Vasily Khoruzhick b6c875a9 2022-11-28T17:01:16 Add support for the 8BitDo Ultimate Wireless 2.4GHz Controller in DirectInput mode Generated using controller map
Sam Lantinga 37d244ea 2022-11-28T14:48:32 Added support for the 8BitDo Ultimate Wired Controller in DirectInput mode, including the misc button and paddles
Sam Lantinga a937b5c4 2022-11-28T13:47:30 Add 8BitDo to the list of Xbox 360 third party vendors Allows detection of the 8BitDo Ultimate Wired Controller
Sylvain Becker fb0ce375 2022-11-27T17:38:43 Cleanup add brace (#6545) * Add braces after if conditions * More add braces after if conditions * Add braces after while() conditions * Fix compilation because of macro being modified * Add braces to for loop * Add braces after if/goto * Move comments up * Remove extra () in the 'return ...;' statements * More remove extra () in the 'return ...;' statements * More remove extra () in the 'return ...;' statements after merge * Fix inconsistent patterns are xxx == NULL vs !xxx * More "{}" for "if() break;" and "if() continue;" * More "{}" after if() short statement * More "{}" after "if () return;" statement * More fix inconsistent patterns are xxx == NULL vs !xxx * Revert some modificaion on SDL_RLEaccel.c * SDL_RLEaccel: no short statement * Cleanup 'if' where the bracket is in a new line * Cleanup 'while' where the bracket is in a new line * Cleanup 'for' where the bracket is in a new line * Cleanup 'else' where the bracket is in a new line (cherry picked from commit 6a2200823c66e53bd3cda4a25f0206b834392652 to reduce conflicts merging between SDL2 and SDL3)
Sylvain Becker 192cdf3d 2022-11-24T16:07:03 SDL_mfijoystick.m: remove VLA, so that projects can be built with error on vla
Sam James 4c7156c1 2022-11-24T05:21:21 Avoid use of deprecated egrep/fgrep GNU grep 3.8 emits a deprecation warning on use of egrep/fgrep. Signed-off-by: Sam James <sam@gentoo.org> (cherry picked from commit 3e7952ce8a0affd325c802755cae5fd843b86d99)
Joshua Root 242ce20c 2022-11-24T07:37:36 SDL_mfijoystick.m: fix build with Xcode < 9 Fixes #6601. (cherry picked from commit 53ca1f77029289a58f1a9963a00b637b903f494d)
Sam Lantinga dce6ed56 2022-11-22T10:56:44 Removed G29 from controller_type.c We don't want the G29 to show up as a gamepad, Steam will create a virtual Xbox controller for it, which breaks racing games.
Sam Lantinga e3d430b8 2022-11-22T10:53:28 Revert "Added Linux mappings for the Logitech G29 in PS3 and PS4 modes" This reverts commit 33a68f575f484723aa326f8a2d96f2b8a084da4a. We don't want the G29 to show up as a gamepad, Steam will create a virtual Xbox controller for it, which breaks racing games.
Sam Lantinga d167cd67 2022-11-21T09:02:10 Added the Gunfighter Mk.III ‘Space Combat Edition’ as a flight stick
Sam Lantinga 8b20b568 2022-11-21T07:41:35 Don't report battery level for disconnected batteries Fixes https://github.com/libsdl-org/SDL/issues/6536
Sam Lantinga 509939b1 2022-11-18T18:20:53 Disable the third party PS3 HIDAPI driver by default, the L3/R3 buttons are unknown
Sylvain 60c6cd55 2022-11-17T09:34:27 Fixed bug #6533 - PS2_JoystickUpdate: some invalid condition
Ryan C. Gordon 389ffab7 2022-11-16T12:53:48 Code style fixes, etc. Reference PR #6345.
ulatekh ec58a817 2022-10-05T19:26:09 Fixes made in response to running a static code analyzer under MS Windows. Most of these are probably harmless, but the changes to SDL_immdevice.c and SDL_pixels.c appear to have fixed genuine bugs. SDL_audiocvt.c: By separating the calculation of the divisor, I got rid of the suspicion that dividing a double by an integer led to loss of precision. SDL_immdevice.c: Added a missing test, one that could have otherwise led to dereferencing a null pointer. SDL_events.c, SDL_gamecontroller.c, SDL_joystick.c, SDL_malloc.c, SDL_video.c: Made it clear the return values weren't used. SDL_hidapi_shield.c: The size is zero, so nothing bad would have happened, but the SDL_memset() was still being given an address outside of the array's range. SDL_dinputjoystick.c: Initialize local data, just in case IDirectInputDevice8_GetProperty() isn't guaranteed to write to it. SDL_render_sw.c: drawstate.viewport could be null (as seen on line 691). SDL.c: SDL_MostSignificantBitIndex32() could return -1, though I don't know if you want to cope with that (what I did) or SDL_assert() that it can't happen. SDL_hints.c: Replaced boolean tests on pointer values with comparisons to NULL. SDL_pixels.c: Looks like the switch is genuinely missing a break! SDL_rect_impl.h: The MacOS static checker pointed out issues with the X comparisons that were handled by assertions; I added assertions for the Y comparisons. SDL_yuv.c, SDL_windowskeyboard.c, SDL_windowswindow.c: Checked error-result returns.
Pierre Wendling bf4f9aaa 2022-11-14T16:11:58 N3DS: Use designated initialiser for drivers. Just a sanity check that the functions are actually mapped correctly.
Sam Lantinga b7e65a81 2022-11-11T08:57:07 Fixed incorrect WGI controller state when the application loses focus Recenter the controller elements when WGI stops reporting valid state Fixes https://github.com/libsdl-org/SDL/issues/5261
Sam Lantinga 0dfc829a 2022-11-10T19:16:53 Added simple BLE Steam Controller support on all platforms This is still disabled by default via the hint SDL_HINT_JOYSTICK_HIDAPI_STEAM
Sam Lantinga 7c05ea0a 2022-11-10T13:35:40 Added mappings for the GameSir T3 and T4 Pro controllers
Sam Lantinga 404cb276 2022-11-10T13:28:03 Added macOS mappings for the Nintendo Switch Pro Controller over Bluetooth
meyraud705 3dc88da0 2022-11-08T13:27:56 Fix Dualshock 4 rumble stopping too early Dualshock 4 controller only rumbles for 5 seconds maximum. Resend rumble command every 2 seconds to make long rumble work.
Sam Lantinga 6432f45a 2022-11-08T10:27:21 Don't treat the Nintendo IMU as a separate game controller on Linux
Sam Lantinga 2e3b4f3f 2022-11-08T07:50:51 Don't send rumble to the Amazon Luna controller on macOS Sending rumble to the Amazon Luna controller on macOS gets there, but IOHIDDeviceSetReport() blocks for a long time and eventually fails. This appears to be a bug in the macOS Bluetooth stack, ref rdar://99265496
Sam Lantinga 02bc359b 2022-11-07T19:31:18 Shorten "Bensussen Deutsch & Associates,Inc.(BDA)" to "BDA" for controller names
Sam Lantinga f2ce7c5f 2022-11-06T08:23:08 Added the G29 as a PlayStation controller
Sam Lantinga 9d1dbd2a 2022-11-06T01:16:52 Added note about trigger rumble availability across third-party Xbox One controllers
Sam Lantinga e7a56323 2022-11-06T01:43:05 Make sure we wait after sending the rumble packet when initializing the PowerA Xbox One Mini Wired Controller
Sam Lantinga 6875e62a 2022-11-06T01:15:20 Make sure we don't send Xbox controllers rumble so quickly that it overwhelms the firmware Fixes https://github.com/libsdl-org/SDL/issues/6435
Sam Lantinga 38af459d 2022-11-06T01:15:19 Fixed potential clobbering of packets of different types using SDL_HIDAPI_SendRumble()
Sam Lantinga e45cb5b1 2022-11-06T01:15:18 Fixed initializing the PowerA Xbox One Mini Wired Controller
Sam Lantinga a4626dea 2022-11-05T14:24:41 Fixed initializing the PDP Xbox One and Victrix Gambit controllers
Sam Lantinga 7e11b09b 2022-11-05T13:50:37 The PowerA Xbox One Mini Wired Controller works with the HIDAPI driver now
Sam Lantinga a2d66b6a 2022-11-05T13:12:10 SDL_GameControllerMapping() should return the string for the actual mapping that was used when opening a gamecontroller, rather than do a GUID match again Also don't match against the zero guid if that happens to be in the mapping list for some reason