Log

Author Commit Date CI Message
Ran Benita 18d6aebe 2017-12-11T22:41:55 keysym: add xkb_keysym_to_{lower,upper} to public API These can be useful in some odd cases. There is already an implementation (+ tests) for internal use, so all that's needed is to export them. If xkbcommon were to provide a way to convert a Unicode codepoint to a keysym, this could have been implemented externally as follows: uint32_t codepoint = xkb_keysym_to_utf32(keysym); uint32_t upper_codepoint = my_unicode_library_to_upper(codepoint); xkb_keysym_t upper_keysym = theoretical_xkb_keysym_from_utf32(upper_codepoint); However keysym -> codepoint is not injective so such a function is not possible strictly speaking. Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 6456835f 2017-12-03T13:04:35 test/data: sync with xkeyboard-config 2.22 Some tweaks to the de(neo) keyseq tests were required. It seems to have improved. Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 8db924b8 2017-10-03T13:28:32 Merge pull request #53 from whitslack/missing-ucs-codes keysym-utf: Add missing codes for signifblank and permille keysyms
Matt Whitlock 0db1d313 2017-09-28T21:31:28 keysym-utf: Add missing codes for signifblank and permille keysyms
Ran Benita 5eeba0fe 2017-09-10T09:18:54 build/meson: require meson >= 0.41.0 With previous versions, the compilation fails with linker errors. Fixes https://github.com/xkbcommon/libxkbcommon/issues/52 Reported-by: @rezso Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 41f10188 2017-09-08T12:16:13 expr: paper over a maybe-uninitialized warning Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 14686cd1 2017-08-16T20:24:27 test/interactive-wayland: avoid unused function warning due to configuration test/interactive-wayland.c:95:1: warning: ‘set_cloexec_or_close’ defined but not used [-Wunused-function] Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 76348754 2017-08-16T20:23:54 build: add missing configure function checks for test/interactive-wayland Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita f468f0b2 2017-08-13T17:55:45 xkbcommon-compose.h: change recommended locale fallback code to treat empty string same as unset The previous code would cause failures to find the Compose file if one of the environment variables LC_ALL, LC_CTYPE or LANG are set to the empty string. The description of the fallback procedure in loclale(7) talks about "non-null environment variable"; I interpreted this to mean the environment variable is unset, but it actually means unset or empty (I verified this by looking at what glibc and musl do). A recent bug in systemd https://github.com/systemd/systemd/issues/6407 exposed this issue. It causes these these variables to be set to the empty string in TTY sessions. Reported by "doodoo" in https://bbs.archlinux.org/viewtopic.php?id=228658 Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita ba9568bd 2017-08-04T16:28:36 Bump version to 0.7.2 Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita c99f6a58 2017-08-04T16:17:27 Update NEWS Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 5c2da779 2017-08-04T15:31:06 build/autotools: fix doc installation Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita fbd86e44 2017-08-03T13:38:14 test/symbols-leak-test.bash: make it easier to read Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 2a16c3c4 2017-08-02T18:28:17 build/autotools: fix symbol versioning configure check Regressed in 4309735. I thought `$top_srcdir` works in configure too, apparently not! See: https://github.com/xkbcommon/libxkbcommon/issues/50#issuecomment-319693694 Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita c665b450 2017-08-02T18:26:19 build/autotools: make doxygen's input relative Was meant to be a part of 41bea9a. Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita cd642b27 2017-08-01T23:36:33 build/autotools: dist the meson build files So that it's possible to build with meson from autotools-generated tarballs. Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita fd82b89e 2017-08-01T23:32:57 build/autotools: install documentation under html/ To be consistent with the meson build; also makes more sense as doxygen can generate more than html (though we currently are not doing that). Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 41bea9ab 2017-08-01T22:19:48 build: make doxygen run from the source tree I couldn't find any other way to make this work! Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita ccc3415e 2017-07-31T20:57:31 Merge pull request #49 from bluetech/meson build: add meson build system
Ran Benita 86434d84 2017-07-25T21:57:42 build: add meson build system Meson is easier to maintain, much faster, encourages better practices, and is not built on a pile of shell scripts. The autotools build system is kept intact for now, in order to ease the migration. The intention is to remove it sooner rather than later, if all goes well. Run `meson build && mesonconf build` to see the configuration options for the new system. Conversion should be straightforward. Environment variables like CFLAGS work the same. If meson is used, xorg-util-macros is not required. In terms of functionality the two systems have about the same capabilities. Here are some differences I noticed: - Meson uses `-g` by default, autotools uses `-g -O2`. - In autotools the default behavior is to install both static and shared versions of the libraries. In meson the user must choose exactly one (using -Ddefault_library=static/shared). It is possible to workaround if needed (install twice...), but hopefully meson will add the option in the future. - Autotools has builtin ctags/cscope targets, meson doesn't. Easy to run the tools directly. - Meson has builtin benchmarks target. Handy. - Meson has builtin support for sanitizers/clang-analyzer/lto/pgo/ coverage etc. Also handy. Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 75ec764c 2017-07-26T12:40:09 build: remove Android.mk I don't think it will work with meson, and I also don't think anyone is using it. Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 2f6616a5 2017-07-26T12:27:53 build: remove -uninstalled pkg-config files Meson doesn't support them directly, and I don't think anyone is using them. Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita a0c858cd 2017-07-31T18:22:54 travis: do the build out-of-tree To catch problems like the previous commit. Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 993f4837 2017-07-31T18:16:37 build: fix out-of-tree build The change in d44ba48 removed -I$(top_builddir)/src/xkbcomp, but this is needed in order to find the generated parser.h file which is put in the build dir. I also added -I$(top_builddir)/src in order to match the meson behavior. Fixes https://github.com/xkbcommon/libxkbcommon/issues/50 Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 2d964065 2017-07-29T23:31:19 test/x11comp: fix compiler warnings Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 4309735d 2017-07-31T11:24:28 build: use top_srcdir consistently Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 4983dbcf 2017-07-28T18:19:40 build: change doxygen target to be properly dependency-based This hackery (thanks libinput) is clearer and more precise than the previous hackery. Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 0a19267f 2017-07-29T14:37:23 build: move custom targets to scripts/ and remove from makefile These scripts generate source code that is committed to git and hence do not really belong in the build system. A maintainer runs them as needed. Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 00b08eae 2017-07-29T13:54:02 build: rewrite the update-keysyms sed script in python A bit more manageable this way, and the other part of the target is already using python. The output is the same, except I removed the reference to Makefile.am. Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita d44ba481 2017-07-29T22:43:08 build: remove unneeded preprocessor include flags Better to avoid these unexpected include paths. Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 1b6fa029 2017-07-29T22:41:26 build: explain why we don't AC_DEFINE a couple of constants Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita daebdb5e 2017-07-31T10:18:54 x11/keymap,test/interactive-evdev: fix a couple of clang-analyzer warnings From my analysis these values cannot be null, but the analyzer cannot see this. So assert it. Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 42f80017 2017-05-27T12:23:27 Merge pull request #48 from namandixit/patch-1 Fixed a minor bug in error detection in Wayland test
Naman Dixit 4f17fc60 2017-05-27T09:15:26 Fixed a minor bug in error detection in Wayland test
Ran Benita ca12d2fd 2017-05-12T14:48:47 Merge pull request #46 from jwrdegoede/master Sync Keysyms with recent xproto additions
Hans de Goede 939d0909 2017-05-10T14:46:03 Sync Keysyms with recent xproto additions xproto recently has been extended with 4 new keysyms: XF86XK_Keyboard XF86XK_WWAN XF86XK_RFKill XF86XK_AudioPreset This commit is the result of running "make update-keysyms" on a system with the updated xproto installed. Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Ran Benita 148aec8b 2017-04-29T15:26:38 doc/compat: correct the XKB protocol version from 1.1 to 1.0 There is no XKB 1.1! Thanks to Oded Arbel for catching this. Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita c9832d43 2017-04-28T09:33:25 test/interactive-x11: handle NULL from xcb_wait_for_event Can happen in cases like: - There was an error between the error check and the call. - The internal poll() fails. Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 6b57344c 2017-04-27T20:06:21 state: cure boolean blindness in the filter functions' result Makes it a little easier to understand the filters. Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 927fd8f8 2017-04-27T19:17:53 state: remove unneeded NULL check xkb_filter_new() cannot return NULL. Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita d44c3ab2 2017-04-27T19:14:56 state: reorder new() functions before the set() functions in the code So that they may be read more naturally in chronological order. Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 5d821aed 2017-04-11T20:19:15 test/x11comp: be a bit more careful with kill() We did it correctly but better be safe and appease clang. Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 9d941458 2017-04-11T20:39:10 test/interactive-wayland: mark a local function static Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 03f4a03e 2017-04-11T20:06:01 test/interactive-wayland: handle unrecognized SHM format The enum seems large, and we don't handle all of the values in it. Previously if we got an unrecognized SHM format we would use an uninitialized `stride`. Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 0f43cfa2 2017-04-11T20:01:19 test/interactive-wayland: fix uninitialized `ret` in error path Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 4812adb0 2017-04-11T21:01:03 Merge pull request #45 from fooishbar/xdg-shell-v6 Wayland: xdg-shell v6 support
Daniel Stone 90bd9fdb 2017-04-11T15:09:50 interactive-wayland: Port to xdg-shell v6 Mutter only implements v6 now, and Weston also implements that. Port interactive-wayland to this so people can keep on using it. Signed-off-by: Daniel Stone <daniels@collabora.com>
Daniel Stone ce38f96e 2017-04-11T15:09:23 Add explicit fallthrough case statements When we fall through to another label in a case, add an explicit comment noting so, to quiet GCC 7's warnings. Signed-off-by: Daniel Stone <daniels@collabora.com>
Ran Benita 877fe59a 2017-01-18T20:17:46 Bump version to 0.7.1 Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 18d53732 2017-01-18T20:16:15 Update NEWS Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 47d6e5a8 2017-01-15T18:27:22 compose/doc: note that it is safe to pass the result of getenv() as locale See the NOTES section of getenv(3). Somewhat obscure but it doesn't hurt to reassure the readers who know about this. Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 1ec14d09 2016-12-02T22:46:53 compose: remove the keysym_from_name cache The hit rate is high, but either the cache is slow or the function is not fast enough -- the cache no longer holds its weight, leading only to very modest improvements. If it's the former, it can definitely be improved, the code is very dumb (though it worked just as well as any other I tried back then). But instead, let's just kill it. Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 7984a30b 2016-12-02T23:55:19 doc: note that XKB_KEYSYM_CASE_INSENSITIVE does C folding only and not locale-dependent. Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita b5586a6c 2016-12-02T22:15:19 keysym: fix locale dependence in xkb_keysym_from_name() We currently use strcasecmp, which is locale-dependent. In particular, one well-known surprise even if restricted just ASCII input is found in the tr_TR (Turkish) locale, see e.g. https://msdn.microsoft.com/en-us/library/ms973919.aspx#stringsinnet20_topic5 We have known to avoid locale-dependent functions before, but in this case, we forgot. Fix it by implementing our own simple ASCII-only strcasecmp/strncasecmp. Might have been possible to use strcasecmp_l() with the C locale, but went the easy route. Side advantage is that even this non-optimized version is faster than the optimized libc one (__strcasecmp_l_sse42) since it doesn't need to do the locale stuff. xkb_keysym_from_name(), which uses strcasecmp heavily, becomes faster, and so for example Compose file parsing, which uses xkb_keysym_from_name() heavily, becomes ~20% faster. Resolves https://github.com/xkbcommon/libxkbcommon/issues/42 Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 327364d2 2016-11-14T17:37:35 utils: rename popcount to avoid conflict in NetBSD Resolves https://github.com/xkbcommon/libxkbcommon/issues/41 Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita d596f6e3 2016-11-11T20:02:41 Bump version to 0.7.0 Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita e7f73940 2016-11-11T20:00:26 Update NEWS Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 0aa704bc 2016-10-31T13:07:45 Merge pull request #31 from bluetech/consumed-modes Consumed modifiers modes
Ran Benita babc9e0c 2016-02-27T22:31:16 state: add GTK consumed modifiers mode This is more or less what is implemented here: https://git.gnome.org/browse/gtk+/tree/gdk/x11/gdkkeys-x11.c?h=3.19.10#n1131 The implementation here is more technically correct but should provide the same results. Try it out with ./test/interactive-evdev -g (modifiers prefixed with "-" are consumed). https://bugzilla.gnome.org/show_bug.cgi?id=754110 https://github.com/xkbcommon/libxkbcommon/issues/17 Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita a0a41332 2016-02-27T19:06:14 state: allow different modes for calculating consumed modifiers The current functions dealing with consumed modifiers use the traditional XKB definition of consumed modifiers (see description in the added documentation). However, for several users of the library (e.g. GTK) this definition is unsuitable or too eager. This is exacerbated by some less-than-ideal xkeyboard-config type definitions (CTRL+ALT seems to cause most grief...). So, because we - want to enable alternative interpretations, but - don't want to expose too much internal details, and - want to keep things simple for all library users, we add a high-level "mode" parameter which selects the desired interpretation. New ones can be added as long as they make some sense. All of the old consumed-modifiers functions keep using the traditional ("XKB") mode. I mark xkb_state_mod_mask_remove_consumed() and as deprecated without adding a *2 variant because I don't it is very useful (or used) in practice. Alternative modes are added in subsequent commits (this commit only adds a mode for the existing behavior). https://github.com/xkbcommon/libxkbcommon/issues/17 Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 90611719 2016-02-27T22:29:57 utils: add popcount function Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 914c060a 2016-10-22T20:13:11 test/state: move wrongly-placed assert Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita fe81dcbd 2016-09-19T10:09:12 bench: fix compilation on hurd Patch by Samuel Thibault. https://github.com/xkbcommon/libxkbcommon/issues/39 Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 853b7502 2016-09-16T09:36:27 bench/compose: tabs -> spaces Signed-off-by: Ran Benita <ran234@gmail.com>
Bryce Harrington af2c83b6 2016-09-15T14:31:55 README: Add basic build directions In particular, highlight the use of configure flags to control locating X11 keyboard stuff when building for Wayland. Of particular note, if the locale root is not specified, then xkbcommon will look for them under $prefix (i.e. /usr/local/share/X11/locale). But unless the user has specifically installed them there, it is better to look in the standard system location, /usr/share/X11/locale. Otherwise, xkbcommon will error when it can't find them, e.g.: xkbcommon: ERROR: ~/.XCompose:4:9: failed to expand %L to the locale Compose file xkbcommon: ERROR: ~/.XCompose:4:12: unterminated string literal Signed-off-by: Bryce Harrington <bryce@osg.samsung.com> Signed-off-by: Ran Benita <ran234@gmail.com>
Bryce Harrington e92e0b88 2016-09-15T14:31:54 README: Bug *reports* are welcome Signed-off-by: Bryce Harrington <bryce@osg.samsung.com> Reviewed-by: Yong Bakos <ybakos@humanoriented.com> Signed-off-by: Ran Benita <ran234@gmail.com>
Bryce Harrington ea9a5bcf 2016-09-15T14:12:38 bench: Check for errors opening Compose file Otherwise it can segfault e.g. running ./compose inside the bench directory. Signed-off-by: Bryce Harrington <bryce@bryceharrington.org> Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 599fd9ba 2016-09-01T21:17:43 doc/compat: (! MODIFIER) syntax is parsed but ignored Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita c29afcc3 2016-09-01T21:13:49 doc/compat.md: xkbcomp ignores multiple-keysyms these days https://cgit.freedesktop.org/xorg/app/xkbcomp/commit/?id=e119cbec7e750ffc4d4bd08b577db2c697035a30 Signed-off-by: Ran Benita <ran234@gmail.com>
Bryce Harrington d58fc90a 2016-06-15T17:36:18 doc: Also mention the wayland test client in the quick guide Signed-off-by: Bryce Harrington <bryce@osg.samsung.com>
Bryce Harrington 094c8dc5 2016-06-15T17:36:17 doc: Declare keymap for wayland example keymap was defined in the X11 example, but also define it in the wayland example just to make it a bit more standalone Signed-off-by: Bryce Harrington <bryce@osg.samsung.com>
Bryce Harrington 832e32dc 2016-06-15T17:36:16 doc: Fix ctx type in example xkb_context_new() returns a xkb_context pointer, so change the variable definition to be consistent. Signed-off-by: Bryce Harrington <bryce@osg.samsung.com>
Daniel Stone 07be44ab 2016-04-12T13:47:26 PACKAGING: Update for interactive-wayland Signed-off-by: Daniel Stone <daniels@collabora.com>
Ran Benita 8978ec39 2016-06-09T17:23:55 test/interactive-wayland: fix control reaches end of non-void function AFAICS there is nothing that can fail directly in this function, so change it to void. Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 0dd610fb 2016-06-09T16:32:05 keymap-dump: use consistent order set/latch/lock (style) Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita c8e6996f 2016-06-09T15:30:21 src/state: match_mod_masks can return bool instead of int Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 81ee012a 2016-06-09T14:52:34 test/symbols-leak-test: use more portable shebang Some BSDs don't want to give bash the honor of /bin and put it elsewhere. So look it up in PATH instead. Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 316c7e24 2016-05-05T15:43:59 test/interactive-wayland: don't ignore asprintf return value Fixes warn_unused_result warning. Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita fc41d3d6 2016-05-05T15:41:13 test: use termios instead of system() for disabling terminal echo Takes care of GCC's annoyingly persistent warn_unused_result warnings. But it's better to avoid system() I suppose. Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 0da70c8d 2016-04-19T12:39:24 gitignore: ignore generated wayland protocol stubs Signed-off-by: Ran Benita <ran234@gmail.com>
Daniel Stone 48d5b44f 2016-04-12T13:19:25 interactive-wayland: Valgrind-proofing More meticulously free everything we create, including hooking up the buffer-release callback so we actually free those when required. Make sure seats are actually in the display's seat list. The xkbcommon object-unref functions don't actually require NULL-checking, so we can elide those. Signed-off-by: Daniel Stone <daniels@collabora.com>
Daniel Stone 7e123a10 2016-04-12T12:03:32 test: Add interactive-wayland interactive-wayland is very similar to x11/xev, and dumps out as much state as possible. It provides no titlebar and a completely random cursor, but such is life. Signed-off-by: Daniel Stone <daniels@collabora.com>
Daniel Stone 03f5d36b 2016-04-08T10:28:36 Bump version to 0.6.1 Our most minor release yet. Signed-off-by: Daniel Stone <daniels@collabora.com>
Daniel Stone bea54b1f 2016-03-31T16:42:41 Add LICENSE to distributed files Signed-off-by: Daniel Stone <daniels@collabora.com>
Ran Benita b91584a8 2016-03-26T01:53:18 doc: update reference to compat symbol to its new name Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 3fee46a2 2016-03-16T10:18:15 Bump version to 0.6.0 Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 4c24f7fa 2016-03-15T20:42:21 test: assert/ignore some warn_unused_result's Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 02628607 2016-03-15T20:38:16 Merge pull request #33 from bluetech/travis-enable-x11 travis: remove --disable-x11
Ran Benita ba3e6ce7 2016-03-15T19:44:48 travis: remove --disable-x11 Looks like the CI machines can use Ubuntu 14.04, which has libxcb 1.10, which is new enough. Lets see if it works. Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 02e8b26c 2016-03-15T19:53:45 Merge pull request #32 from fooishbar/master doc: Fix Doxygen include for srcdir != builddir
Daniel Stone b04344ff 2016-03-15T11:30:57 travis: Enable documentation build Make sure Doxygen is installed before we build. Signed-off-by: Daniel Stone <daniels@collabora.com>
Daniel Stone a2974d5f 2016-03-15T11:20:35 doc: Fix Doxygen include for srcdir != builddir Instead of giving Doxygen a series of absolute paths to the source files and a relative path to the output directory, run it from the source directory with purely relative paths to the source files, and give it an absolute path to the build directory. This fixes the parsing of README.md with a separate build directory, since the relative includes for doc/quick-guide.md and doc/compat.md don't resolve otherwise. Doxygen's INCLUDE_PATH turns out not to fix this either, since that's just a set of paths to open and parse, rather than an analogue to cpp's -I. Signed-off-by: Daniel Stone <daniels@collabora.com>
Ran Benita d627549c 2016-03-13T23:38:40 Update NEWS Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 919b97a8 2016-03-13T23:33:18 NEWS: add some spacing Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 914e84e0 2016-03-13T23:09:21 build: don't run test/x11comp in make check for now For some reason, the dumped keymap started repeating the two key types FOUR_LEVEL_PLUS_LOCK and FOUR_LEVEL_KEYPAD. I need to investigate, but let's disable it for now until I do (the problem would likely not be in the xkbcommon - at most in the test itself). Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 37ee8e65 2016-03-13T22:56:48 test/x11comp: fix memory leak Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita fa1b4543 2016-03-13T20:56:58 test: add a test that all symbol version file is updated It is easy to forget to update these files when adding new symbols. Stolen with slight changes from libinput (commit by Marek Chalupa): https://cgit.freedesktop.org/wayland/libinput/commit/?id=a9f216ab47ea2f643f20ed741b741a2b5766eba3 Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 1c6d21b4 2016-03-13T20:42:39 Add symbol versions forgotten in 0ce17ef3ea3722c1cfe7af3 Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 712b39ac 2016-03-13T21:32:28 build: make it easier to add non-built (e.g. script) tests Signed-off-by: Ran Benita <ran234@gmail.com>
Ran Benita 763e2b7e 2016-03-13T20:24:44 src/utils: check if fileno() failed in map_file fileno() can fail, if called on e.g. fmemopen() FILEs which are not backed by a file descriptor. This functions uses mmap to map the entire file to memory, so using such FILEs will not work. (There is actually no change of behavior here, since the following fstat would have already failed with EBADF. But lets make it clear.) Another possibility is to fall back to the !HAVE_MMAP case; but it sounds like a better idea to leave it to the programmer to use the new_from_string/new_from_buffer functions instead, instead of doing double allocation behind their back. Signed-off-by: Ran Benita <ran234@gmail.com>