kmx git

Commit	Date	Message
7d80e208	2023-07-05T13:52:37	emscripten: Add JS library dependencies using EM_JS_DEPS macro See https://github.com/emscripten-core/emscripten/pull/19780 (cherry picked from commit 042243471fb7ecf6ba5e53f0ba35e825a8bb066a)
348cc05b	2023-08-02T17:10:28	minor os/2 stuff merged from the bitwiseworks' fork (cosmetics only.) (cherry picked from commit b58557a3a60de6e945536c41147061afa8468286)
b4d87654	2023-07-25T11:40:02	os2 audio refactoring and capture support - Fixed audio device detection and usage. - Implemented audio capture support - Refactored buffer handling to separate pointers to fill and drain buffers. Based on patches by josch1710 and Lars Erdmann: https://github.com/bitwiseworks/SDL2-os2/pull/7 (cherry picked from commit 890bee64a4494b8575c53c68adfaf7c594d07c27)
3f1fd5ab	2023-05-23T10:59:03	Updated source to match SDL function prototype style
92a487f2	2023-05-19T14:10:02	style fixes for SDL_PROC macros.
4a0b9522	2023-05-17T20:06:58	audio: Load .WAV files with format->blockalign==0. In theory this is illegal, but legit wavefiles in the field do it, and it's easy to bump it to 1 for general purposes. Formats with more specific alignment requirements already check for them separately. Fixes #7714. (cherry picked from commit 2e646c7141b3009628abda2a964ba5f9d1702e1a)
86786ed5	2023-05-08T14:25:01	coreaudio: Flush/stop the AudioQueue before disposing of it. Otherwise, a CoreAudio thread lingers forever, and coreaudiod eats CPU until the SDL process terminates. Fixes #7689.
446e0943	2023-03-17T10:58:45	wasapi: Force WIN_CoInitialize duing device open. Otherwise this won't work if you open a device on a background thread. Fixes #7478.
76e9d64b	2023-03-10T08:13:51	Removed space between sizeof and parentheses
e9f9cb29	2023-03-10T08:09:44	Fixed build warning on Android (cherry picked from commit 2af6f4a3e4f0a82ccbb7ce142c914b5aa5df2000)
ef347776	2023-03-09T17:34:51	Uses integer arithmetics in SDL_ResampleAudio - Avoids precision loss caused by large floating point numbers. - Adds unit test to test the signal-to-noise ratio and maximum error of resampler. - Code cleanup (cherry-picked from commit 20e17559e545c5d3cfe86c1c4772365e70090779)
0d763800	2023-03-09T15:10:00	Code style: changed "sizeof foo" to "sizeof(foo)" (thanks @sezero!) (cherry picked from commit c6443d86c92e962683a1efe5f123a144988875b5)
5a7ea76e	2023-02-22T10:30:56	fix MSVC build failures in CI after commit 1e5e8e2f (cherry picked from commit a2f8cf8fc0c6f4fe8a904284060f61f19f129efa)
9403c9e9	2023-02-21T12:56:02	resampler: Work at double precision on x86-64 machines. We get audio artifacts if we don't work at the higher precision, but this is painful on CPUs that have to use a software fallback for this, so for now (that is, until we have a better solution), get better output on amd64 chips, where the cost is less painful. (cherry picked from commit 1e5e8e2fda3796e76e6f7b1c39683925a3e9fed9)
2b66ef0d	2023-02-11T21:10:26	Fixed audio
7d2012af	2023-02-10T13:51:16	emscripten: Update deprecated calls to EM_ASM*. `EM_ASM_` and `EM_ASM_INT_V` are calls that have been deprecated for a long time. Since the return value isn't used for the call to `EM_ASM_`, it can be replaced with `EM_ASM`. `EM_ASM_INT_V` is now (for the last few years) `EM_ASM_INT`. (cherry picked from commit a8e89f2567b9069c919f9b21996e0a46cd4bb679)
17515f4a	2023-02-04T15:51:37	Backport simplify flags PR #7220
8efa1f8f	2023-01-16T15:17:26	add support for libsamplerate's "linear" resampling mode Fixes #6998
c638b4a6	2023-01-16T09:21:24	SDL_CreateAudioStream: check for invalid parameters
0479df53	2023-01-09T09:48:21	Updated copyright for 2023
4e3fc0c1	2022-12-18T12:07:38	Android: make Detect devices common between aaudio and android driver. (#6828) remove VLA, dynamic alloc, check max length get using GetIntArrayRegion
741499de	2022-12-16T17:38:57	Android audio device selection (#6824) Make it possible to select a specific audio device for Android
d59caffe	2022-12-13T14:03:40	Added support for clang thread-safety analysis The annotations have been added to SDL_mutex.h and have been made public so applications can enable this for their own code. Clang assumes that locking and unlocking can't fail, but SDL has the concept of a NULL mutex, so the mutex functions have been changed not to report errors if a mutex hasn't been initialized. We do have mutexes that might be accessed when they are NULL, notably in the event system, so this is an important change. This commit cleans up a bunch of rare race conditions in the joystick and game controller code so now everything should be completely protected by the joystick lock. To test this, change the compiler to "clang -Wthread-safety -Werror=thread-safety -DSDL_THREAD_SAFETY_ANALYSIS"
e986c798	2022-12-12T16:07:48	wasapi: Fixed incorrect assertions. Fixes #6795. (cherry picked from commit 12486e144be0e7a37abd87b8bf90547a992ff66b)
b5483f2c	2022-12-01T18:03:36	Fix formatting on Wayland and Pipewire function signatures Fixes the formatting on some function signatures that clang-format missed. (cherry picked from commit 378b1c286a9c3206e827a47f0147384e92c4c2b2)
d0bbfdbf	2022-12-01T16:07:03	Clang-Tidy fixes (#6725) (cherry picked from commit 3c501b963dd8f0605a6ce7978882df39ba76f9cd)
b8d85c69	2022-11-30T12:51:59	Update for SDL3 coding style (#6717) I updated .clang-format and ran clang-format 14 over the src and test directories to standardize the code base. In general I let clang-format have it's way, and added markup to prevent formatting of code that would break or be completely unreadable if formatted. The script I ran for the src directory is added as build-scripts/clang-format-src.sh This fixes: #6592 #6593 #6594 (cherry picked from commit 5750bcb174300011b91d1de20edb288fcca70f8c)
fb0ce375	2022-11-27T17:38:43	Cleanup add brace (#6545) * Add braces after if conditions * More add braces after if conditions * Add braces after while() conditions * Fix compilation because of macro being modified * Add braces to for loop * Add braces after if/goto * Move comments up * Remove extra () in the 'return ...;' statements * More remove extra () in the 'return ...;' statements * More remove extra () in the 'return ...;' statements after merge * Fix inconsistent patterns are xxx == NULL vs !xxx * More "{}" for "if() break;" and "if() continue;" * More "{}" after if() short statement * More "{}" after "if () return;" statement * More fix inconsistent patterns are xxx == NULL vs !xxx * Revert some modificaion on SDL_RLEaccel.c * SDL_RLEaccel: no short statement * Cleanup 'if' where the bracket is in a new line * Cleanup 'while' where the bracket is in a new line * Cleanup 'for' where the bracket is in a new line * Cleanup 'else' where the bracket is in a new line (cherry picked from commit 6a2200823c66e53bd3cda4a25f0206b834392652 to reduce conflicts merging between SDL2 and SDL3)
81452121	2022-11-27T22:46:54	SDL_ResampleAudio: Fix float accumulation error While 78f97108f9dad22db6708f28322561eb9828fc36 reduced the accumulation error, it was still big enough to cause distortions. Fixes #6196.
89572af6	2022-11-17T11:43:46	Fixed bug #6537 - AIX: use PAUDIO_WaitDevice
ce5da5d5	2022-11-16T21:47:43	Don't compare pointer against '0', but NULL
ec58a817	2022-10-05T19:26:09	Fixes made in response to running a static code analyzer under MS Windows. Most of these are probably harmless, but the changes to SDL_immdevice.c and SDL_pixels.c appear to have fixed genuine bugs. SDL_audiocvt.c: By separating the calculation of the divisor, I got rid of the suspicion that dividing a double by an integer led to loss of precision. SDL_immdevice.c: Added a missing test, one that could have otherwise led to dereferencing a null pointer. SDL_events.c, SDL_gamecontroller.c, SDL_joystick.c, SDL_malloc.c, SDL_video.c: Made it clear the return values weren't used. SDL_hidapi_shield.c: The size is zero, so nothing bad would have happened, but the SDL_memset() was still being given an address outside of the array's range. SDL_dinputjoystick.c: Initialize local data, just in case IDirectInputDevice8_GetProperty() isn't guaranteed to write to it. SDL_render_sw.c: drawstate.viewport could be null (as seen on line 691). SDL.c: SDL_MostSignificantBitIndex32() could return -1, though I don't know if you want to cope with that (what I did) or SDL_assert() that it can't happen. SDL_hints.c: Replaced boolean tests on pointer values with comparisons to NULL. SDL_pixels.c: Looks like the switch is genuinely missing a break! SDL_rect_impl.h: The MacOS static checker pointed out issues with the X comparisons that were handled by assertions; I added assertions for the Y comparisons. SDL_yuv.c, SDL_windowskeyboard.c, SDL_windowswindow.c: Checked error-result returns.
6801d676	2022-11-16T09:52:33	Revert "pulseaudio: Only use PA_STREAM_ADJUST_LATENCY if buffer isn't super small." This reverts commit d8b1ef42aee52dad4ac3de69795ca2e8d2fd7704. This turned out to be unnecessary (it was a problem on the user's system, not an SDL bug). Reference Issue #6121.
d8b1ef42	2022-11-15T22:18:51	pulseaudio: Only use PA_STREAM_ADJUST_LATENCY if buffer isn't super small. Fixes #6121.
85aa9b8b	2022-11-11T13:47:36	wasapi: Favor the system resampler again, for now. Reference Issue #5538.
b0dc6709	2022-11-07T14:26:48	coreaudio: Don't use deprecated kAudioObjectPropertyElementMaster symbol. Fixes #6449.
5dc93451	2022-11-06T20:49:37	JANITORIAL : Correct some more spelling mistakes (#6489)
78f97108	2022-11-05T10:38:33	audio: Avoid accumulation errors in resampler. Fixes #6391.
61f3662c	2022-10-30T08:34:47	SDL_QSA_AUDIO.C: Correct spelling mistake occured -> occurred
e7ab581d	2022-10-19T09:14:16	coreaudio: Dispose of AudioQueue before waiting on the thread. Otherwise the thread might block for a long time (more than 10 seconds!). It's not clear to me why this happens, or why its safe to do this with a resource that's still in use, but we have, until recently, always disposed of the AudioQueue first, so changing back is probably okay. Also changed the disposal to allow in-flight buffers to reach hardware; otherwise you lose the last little bit of audio that's already been queued but not played, which you can hear clearly in the loopwave test program. Fixes #6377.
f4e3af15	2022-10-17T07:23:40	Simplify OSS test by removing OpenBSD specific location of the soundcard.h header OpenBSD has long since stopped using OSS. Remove checking for OpenBSD specific header.
22461383	2022-10-15T15:54:12	SDL_audiocvt: Respct the SDL_HINT_AUDIO_RESAMPLING_MODE hint This implements using libsamplerate for the SDL_AudioCVT API. This library was already being used for audio streams when this hint is set.
65527537	2021-03-30T04:32:39	N3DS port (squashed) A dedicated renderer using Citro3D would likely allow for better much better graphical performances.
484d5fd6	2022-10-05T13:19:38	audio open: ensure 2 devices don't get the same id
e41942e8	2022-10-05T13:36:25	fix compilation error SDL_coreaudio mixing declarations and code
e6640ef2	2022-09-30T14:53:07	coreaudio: Possibly fixed another shutdown race condition. Reference Issue #6159.
40893821	2022-09-29T10:33:07	coreaudio: Add support for SDL_GetDefaultAudioInfo (#6277) Co-authored-by: Ethan Lee <flibitijibibo@gmail.com> Co-authored-by: Ozkan Sezer <sezeroz@gmail.com>
f6565c32	2022-09-28T09:27:45	coreaudio: Remove redundant variable.
411582c7	2022-09-28T09:22:17	coreaudio: Don't crash on shutdown in a race condition. Fixed #6159.
b9e3cae5	2022-08-26T16:58:21	Add more valid configurations to PS2 audio driver
5b4b4fa1	2022-08-14T12:01:56	Decrease audio thread priority when created
f1390780	2022-08-02T15:25:44	Fix use after free when removing Windows audio device
8ff738f2	2022-07-26T12:40:47	audio: Report SDL_AUDIODEVICEREMOVED for unopened devices. Unopened devices, if removed, now send SDL_AUDIODEVICEREMOVED events with a `which` field set to zero. Apps can use this to decide if they need to refresh a list of devices being shown in an options menu, etc. It's safe to call SDL_CloseAudioDevice(0), so even if they try to clean up this bogus id, it should be safe. Fixes #5199.
8c51cae7	2022-07-23T14:56:04	audio/aaudio, audio/openslES: fix -Wdeclaration-after-statement errors Fixes https://github.com/libsdl-org/SDL/issues/5950
f3008e4a	2022-07-20T19:08:31	audio: 3- and 5-channel formats are now supported
45c3b59d	2022-07-20T17:23:42	audio: Turn off DEBUG_CONFIG logging again.
bec721f0	2022-07-20T17:22:41	audio: Fixed dst pointer on channel conversions that grow in-place.
9f56c7cf	2022-07-20T16:39:19	audio: Remove 5.1->X SIMD converters, add SSE mono->stereo. The 5.1 versions didn't use the new algorithm, and making that new algorithm work took so many permutes that it was significantly slower than just using the scalar versions. However, mono-to-stereo is an extremely common conversion, and it's trivial to accelerate it with plain SSE, so that was added!
b83ae9f2	2022-07-19T22:40:51	audio: Replaced some debug-printfs with debug-SDL_Logs. :)
49ec8db5	2022-07-19T22:04:49	audio: Generate the channel converter code from a program.
f06cc3e9	2022-07-19T22:03:56	audio: "SL" means "surround left" not "side left", etc.
5a0c8198	2022-07-19T22:03:02	audio: Add channel convert filter _after_ choosing an SIMD version.
fe160840	2022-07-19T16:04:48	audio: LOG_DEBUG_CONVERT should use SDL_Log, not fprintf(stderr).
25727790	2022-07-19T02:16:08	audio: first attempt at rewriting the channel converters. This is not ready for production use!
b700a326	2022-07-20T07:01:10	audio, pipewire: fix signatures of pw_get_library_version and pw_init. Reference issue: https://github.com/libsdl-org/SDL/issues/5938
6e210d37	2022-07-20T07:01:10	audio, pipewire: pipewire_version_xx globals out of dynamic loading Fixes build with --disable-pipewire-shared Reference issue: https://github.com/libsdl-org/SDL/issues/5938
b299cb3d	2022-07-17T08:31:16	Added a utility function to calculate the next power of 2 for a value
90b86b13	2022-07-17T10:35:09	audio: Handle non-power-of-two spec.samples when unsupported Fixes #3685
a09d62e4	2022-07-15T23:45:56	directsound: Remove redundant SubFormat copy
c5e408ae	2022-07-15T11:31:59	directsound: For channel counts > 2, generate a dwChannelMask for CreateSoundBuffer
fff34f63	2022-07-15T09:46:53	windows: SDL_IMMDevice needed more deinit code from the Win32 path. Fixes #5919
37aecda2	2022-07-14T11:38:51	pipewire: Use PW_KEY_TARGET_OBJECT to specify stream connection nodes Pipewire 0.3.44 introduced PW_KEY_TARGET_OBJECT, which is to be used to specify target connection nodes for streams. This parameter takes either a node path (PW_KEY_NODE_NAME) or serial number (PW_KEY_OBJECT_SERIAL) to specify a target node. The former is used in this case since the path is already being retrieved and stored for other purposes. The target_id parameter in pw_stream_connect() is now deprecated and should always be PW_ID_ANY when PW_KEY_TARGET_OBJECT is used.
36d8460c	2022-07-11T16:59:23	pipewire: Dynamically allocate the buffer for node strings Calculate and allocate the buffer for the IO node name and path strings dynamically instead of using arbitrary sized static buffers.
996cea31	2022-07-11T15:15:48	pipewire: Update default audio devices during runtime Make the default device metadata node persist for the lifetime of the hotplug loop so the default source/sink devices will be updated if they change during runtime.
60da11f0	2022-07-11T14:31:20	pipewire: Remove deprecated configuration key With Pipewire now requiring a minimum version 0.3.24, the PW_KEY_CONTEXT_PROFILE_MODULES value is no longer required for legacy compatability and can be safely removed.
ecfbdce6	2022-07-11T13:09:48	pipewire: Require version 0.3.24 or newer at runtime
2f0816ad	2022-07-11T13:08:30	Add SDL_GetDefaultAudioInfo. This API is supported on pipewire, pulseaudio, wasapi, and directsound. Co-authored-by: Frank Praznik <frank.praznik@gmail.com>
ae105ae1	2022-07-10T12:59:33	windows: Move IMMDevice work to common file, implement DirectSound enumeration support
4aad594a	2022-07-08T16:17:46	Update SDL_qsa_audio.c Fix qnx platform compile error, change SDL_Bool to SDL_bool.
6c536afd	2022-06-27T15:43:17	Fix C89 declaration for macOS modules. Since Clang 14, `-Wdeclaration-after-statement` is enforced on every standard.
e4a80875	2022-06-24T16:43:20	Initial Audio driver
3b191580	2022-06-27T17:19:39	Windows GDK Support (#5830) * Added GDK * Simplfied checks in SDL_config_wingdk.h * Added testgdk sample * Added GDK readme * Fixed error in merge of SDL_windows.h * Additional GDK fixes * OpenWatcom should not export _SDL_GDKGetTaskQueue * Formatting fixes * Moved initialization code into SDL_GDKRunApp
abe38bca	2022-06-18T13:08:58	Support SDL_AUDIODRIVER set to "dsound", which was used by SDL 1.2 Fixes https://github.com/libsdl-org/SDL/issues/5818
adc68758	2022-06-17T10:22:28	Added SDL_copyp to avoid size mismatch when copying values (thanks @1bsyl!) Closes https://github.com/libsdl-org/SDL/pull/5811
dc62fec5	2022-05-20T21:07:25	audio: Fix locking in backends that manage their own callback threads. Otherwise you might get a race where an app pauses the device, but the audio callback still manages to run after the pause is in place.
501a4991	2022-05-05T18:44:32	Add clang-format on/off comments where necessary. Comments were added in places where INDENT-ON/OFF comments are. Places like stdlib's asm don't need it as clang-format doesn't try to indent it.
0cca71a8	2022-05-18T22:12:05	Use SDLCALL for callbacks in public APIs
29694869	2022-04-28T15:56:52	audio: Revert one of the resampler optimizations. This is the one that splits the "left wing" into two for loops to bubble out the conditional that decides if it should read from the left padding or the input buffer. I still believe the optimization is good, but the basic logic of it was incorrect, and needs to be reexamined and fixed before going back into revision control.
5066910b	2022-04-10T13:44:01	audio: Make pregenerated resampler kaiser filter more precise.
111c3add	2022-04-10T13:23:51	audio: Resampler optimizations. - Calculate `j * RESAMPLER_SAMPLES_PER_ZERO_CROSSING` once per loop iteration since we use it multiple times. - Do the left-wing loop in two sections: while `srcframe < 0` and then the remaining calculations when `srcframe >= 0`. This bubbles a conditional out of every iteration of a tight loop, giving us a boost. We could _probably_ do this to the right-wing loop too, but it's less straightforward there. - The real win: Use floats instead of doubles. This almost doubles the speed of the entire function on Intel CPUs, and for embedded things without hardware-level support for doubles, the speedup is enormous. This in theory might reduce audio quality, though, and I had to put a check in place to avoid a division-by-zero that we avoided at higher precision, but this is likely to be worth keeping for at least the Sony PSP and other smaller platforms, if not everyone.
de019568	2022-04-09T23:43:57	audio: Prebake the resampler's kaiser table instead of doing it at runtime.
f6eb4b07	2022-04-26T13:14:15	pulseaudio: Feed audio data in response to write callbacks. Instead of waiting until the entire buffer from the SDL callback is ready to be accepted by PulseAudio, we use pa_stream_set_write_callback and feed some portion of the buffer as callbacks come in asking for more. This lets us remove the halving of the buffer size during device open, and also (hopefully) solves several strange hangs that happen in unusual circumstances. Fixes #4387 Fixes #2262
9e264b92	2022-04-18T09:20:47	Certain audio drivers, like the RME "Pro" Audio driver, have resampling quality issues when using WASAPI. We'll use SDL's resampling algorithm so we have consistent quality between platforms and drivers. Fixes https://github.com/libsdl-org/SDL/issues/5538
c1336b21	2022-04-17T12:43:32	hints: Make SDL_VIDEODRIVER and SDL_AUDIODRIVER formal hints. They were just environment variables before. Fixes #5528.
727eef70	2022-04-09T10:12:49	audio: SDL_ConvertStereoToMono_SSE3 missed an unaligned load.
178ac196	2022-03-29T23:48:08	Vita: add audio capture support
aec86ba8	2022-03-26T15:31:33	emscriptenaudio: proxy calls to main thread
4fe7b2cb	2022-03-24T11:00:43	static analysis: Fixed several complaints from codechecker. There are still some pending Objective-C specific issues. Reference issue #4600.
0af2db6f	2022-03-23T19:04:29	Vita: support audio format fallback
24ffcbd9	2022-03-20T17:23:34	audio: Set error message on dsp init failure. if SDL_EnumUnixAudioDevices() fails to find any devices, set an error message on the exit path. Without this, SDL_Init() could fail without any message available in SDL_GetError().

7d80e208

2023-07-05T13:52:37

emscripten: Add JS library dependencies using EM_JS_DEPS macro See https://github.com/emscripten-core/emscripten/pull/19780 (cherry picked from commit 042243471fb7ecf6ba5e53f0ba35e825a8bb066a)

348cc05b

2023-08-02T17:10:28

minor os/2 stuff merged from the bitwiseworks' fork (cosmetics only.) (cherry picked from commit b58557a3a60de6e945536c41147061afa8468286)

b4d87654

2023-07-25T11:40:02

os2 audio refactoring and capture support - Fixed audio device detection and usage. - Implemented audio capture support - Refactored buffer handling to separate pointers to fill and drain buffers. Based on patches by josch1710 and Lars Erdmann: https://github.com/bitwiseworks/SDL2-os2/pull/7 (cherry picked from commit 890bee64a4494b8575c53c68adfaf7c594d07c27)

3f1fd5ab

2023-05-23T10:59:03

Updated source to match SDL function prototype style

92a487f2

2023-05-19T14:10:02

style fixes for SDL_PROC macros.

4a0b9522

2023-05-17T20:06:58

audio: Load .WAV files with format->blockalign==0. In theory this is illegal, but legit wavefiles in the field do it, and it's easy to bump it to 1 for general purposes. Formats with more specific alignment requirements already check for them separately. Fixes #7714. (cherry picked from commit 2e646c7141b3009628abda2a964ba5f9d1702e1a)

86786ed5

2023-05-08T14:25:01

coreaudio: Flush/stop the AudioQueue before disposing of it. Otherwise, a CoreAudio thread lingers forever, and coreaudiod eats CPU until the SDL process terminates. Fixes #7689.

446e0943

2023-03-17T10:58:45

wasapi: Force WIN_CoInitialize duing device open. Otherwise this won't work if you open a device on a background thread. Fixes #7478.

76e9d64b

2023-03-10T08:13:51

Removed space between sizeof and parentheses

e9f9cb29

2023-03-10T08:09:44

Fixed build warning on Android (cherry picked from commit 2af6f4a3e4f0a82ccbb7ce142c914b5aa5df2000)

ef347776

2023-03-09T17:34:51

Uses integer arithmetics in SDL_ResampleAudio - Avoids precision loss caused by large floating point numbers. - Adds unit test to test the signal-to-noise ratio and maximum error of resampler. - Code cleanup (cherry-picked from commit 20e17559e545c5d3cfe86c1c4772365e70090779)

0d763800

2023-03-09T15:10:00

Code style: changed "sizeof foo" to "sizeof(foo)" (thanks @sezero!) (cherry picked from commit c6443d86c92e962683a1efe5f123a144988875b5)

5a7ea76e

2023-02-22T10:30:56

fix MSVC build failures in CI after commit 1e5e8e2f (cherry picked from commit a2f8cf8fc0c6f4fe8a904284060f61f19f129efa)

9403c9e9

2023-02-21T12:56:02

resampler: Work at double precision on x86-64 machines. We get audio artifacts if we don't work at the higher precision, but this is painful on CPUs that have to use a software fallback for this, so for now (that is, until we have a better solution), get better output on amd64 chips, where the cost is less painful. (cherry picked from commit 1e5e8e2fda3796e76e6f7b1c39683925a3e9fed9)

2b66ef0d

2023-02-11T21:10:26

Fixed audio

7d2012af

2023-02-10T13:51:16

emscripten: Update deprecated calls to EM_ASM*. `EM_ASM_` and `EM_ASM_INT_V` are calls that have been deprecated for a long time. Since the return value isn't used for the call to `EM_ASM_`, it can be replaced with `EM_ASM`. `EM_ASM_INT_V` is now (for the last few years) `EM_ASM_INT`. (cherry picked from commit a8e89f2567b9069c919f9b21996e0a46cd4bb679)

17515f4a

2023-02-04T15:51:37

Backport simplify flags PR #7220

8efa1f8f

2023-01-16T15:17:26

add support for libsamplerate's "linear" resampling mode Fixes #6998

c638b4a6

2023-01-16T09:21:24

SDL_CreateAudioStream: check for invalid parameters

0479df53

2023-01-09T09:48:21

Updated copyright for 2023

4e3fc0c1

2022-12-18T12:07:38

Android: make Detect devices common between aaudio and android driver. (#6828) remove VLA, dynamic alloc, check max length get using GetIntArrayRegion

741499de

2022-12-16T17:38:57

Android audio device selection (#6824) Make it possible to select a specific audio device for Android

d59caffe

2022-12-13T14:03:40

Added support for clang thread-safety analysis The annotations have been added to SDL_mutex.h and have been made public so applications can enable this for their own code. Clang assumes that locking and unlocking can't fail, but SDL has the concept of a NULL mutex, so the mutex functions have been changed not to report errors if a mutex hasn't been initialized. We do have mutexes that might be accessed when they are NULL, notably in the event system, so this is an important change. This commit cleans up a bunch of rare race conditions in the joystick and game controller code so now everything should be completely protected by the joystick lock. To test this, change the compiler to "clang -Wthread-safety -Werror=thread-safety -DSDL_THREAD_SAFETY_ANALYSIS"

e986c798

2022-12-12T16:07:48

wasapi: Fixed incorrect assertions. Fixes #6795. (cherry picked from commit 12486e144be0e7a37abd87b8bf90547a992ff66b)

b5483f2c

2022-12-01T18:03:36

Fix formatting on Wayland and Pipewire function signatures Fixes the formatting on some function signatures that clang-format missed. (cherry picked from commit 378b1c286a9c3206e827a47f0147384e92c4c2b2)

d0bbfdbf

2022-12-01T16:07:03

Clang-Tidy fixes (#6725) (cherry picked from commit 3c501b963dd8f0605a6ce7978882df39ba76f9cd)

b8d85c69

2022-11-30T12:51:59

Update for SDL3 coding style (#6717) I updated .clang-format and ran clang-format 14 over the src and test directories to standardize the code base. In general I let clang-format have it's way, and added markup to prevent formatting of code that would break or be completely unreadable if formatted. The script I ran for the src directory is added as build-scripts/clang-format-src.sh This fixes: #6592 #6593 #6594 (cherry picked from commit 5750bcb174300011b91d1de20edb288fcca70f8c)

fb0ce375

2022-11-27T17:38:43

Cleanup add brace (#6545) * Add braces after if conditions * More add braces after if conditions * Add braces after while() conditions * Fix compilation because of macro being modified * Add braces to for loop * Add braces after if/goto * Move comments up * Remove extra () in the 'return ...;' statements * More remove extra () in the 'return ...;' statements * More remove extra () in the 'return ...;' statements after merge * Fix inconsistent patterns are xxx == NULL vs !xxx * More "{}" for "if() break;" and "if() continue;" * More "{}" after if() short statement * More "{}" after "if () return;" statement * More fix inconsistent patterns are xxx == NULL vs !xxx * Revert some modificaion on SDL_RLEaccel.c * SDL_RLEaccel: no short statement * Cleanup 'if' where the bracket is in a new line * Cleanup 'while' where the bracket is in a new line * Cleanup 'for' where the bracket is in a new line * Cleanup 'else' where the bracket is in a new line (cherry picked from commit 6a2200823c66e53bd3cda4a25f0206b834392652 to reduce conflicts merging between SDL2 and SDL3)

81452121

2022-11-27T22:46:54

SDL_ResampleAudio: Fix float accumulation error While 78f97108f9dad22db6708f28322561eb9828fc36 reduced the accumulation error, it was still big enough to cause distortions. Fixes #6196.

89572af6

2022-11-17T11:43:46

Fixed bug #6537 - AIX: use PAUDIO_WaitDevice

ce5da5d5

2022-11-16T21:47:43

Don't compare pointer against '0', but NULL

ec58a817

2022-10-05T19:26:09

Fixes made in response to running a static code analyzer under MS Windows. Most of these are probably harmless, but the changes to SDL_immdevice.c and SDL_pixels.c appear to have fixed genuine bugs. SDL_audiocvt.c: By separating the calculation of the divisor, I got rid of the suspicion that dividing a double by an integer led to loss of precision. SDL_immdevice.c: Added a missing test, one that could have otherwise led to dereferencing a null pointer. SDL_events.c, SDL_gamecontroller.c, SDL_joystick.c, SDL_malloc.c, SDL_video.c: Made it clear the return values weren't used. SDL_hidapi_shield.c: The size is zero, so nothing bad would have happened, but the SDL_memset() was still being given an address outside of the array's range. SDL_dinputjoystick.c: Initialize local data, just in case IDirectInputDevice8_GetProperty() isn't guaranteed to write to it. SDL_render_sw.c: drawstate.viewport could be null (as seen on line 691). SDL.c: SDL_MostSignificantBitIndex32() could return -1, though I don't know if you want to cope with that (what I did) or SDL_assert() that it can't happen. SDL_hints.c: Replaced boolean tests on pointer values with comparisons to NULL. SDL_pixels.c: Looks like the switch is genuinely missing a break! SDL_rect_impl.h: The MacOS static checker pointed out issues with the X comparisons that were handled by assertions; I added assertions for the Y comparisons. SDL_yuv.c, SDL_windowskeyboard.c, SDL_windowswindow.c: Checked error-result returns.

6801d676

2022-11-16T09:52:33

Revert "pulseaudio: Only use PA_STREAM_ADJUST_LATENCY if buffer isn't super small." This reverts commit d8b1ef42aee52dad4ac3de69795ca2e8d2fd7704. This turned out to be unnecessary (it was a problem on the user's system, not an SDL bug). Reference Issue #6121.

d8b1ef42

2022-11-15T22:18:51

pulseaudio: Only use PA_STREAM_ADJUST_LATENCY if buffer isn't super small. Fixes #6121.

85aa9b8b

2022-11-11T13:47:36

wasapi: Favor the system resampler again, for now. Reference Issue #5538.

b0dc6709

2022-11-07T14:26:48

coreaudio: Don't use deprecated kAudioObjectPropertyElementMaster symbol. Fixes #6449.

5dc93451

2022-11-06T20:49:37

JANITORIAL : Correct some more spelling mistakes (#6489)

78f97108

2022-11-05T10:38:33

audio: Avoid accumulation errors in resampler. Fixes #6391.

61f3662c

2022-10-30T08:34:47

SDL_QSA_AUDIO.C: Correct spelling mistake occured -> occurred

e7ab581d

2022-10-19T09:14:16

coreaudio: Dispose of AudioQueue before waiting on the thread. Otherwise the thread might block for a long time (more than 10 seconds!). It's not clear to me why this happens, or why its safe to do this with a resource that's still in use, but we have, until recently, always disposed of the AudioQueue first, so changing back is probably okay. Also changed the disposal to allow in-flight buffers to reach hardware; otherwise you lose the last little bit of audio that's already been queued but not played, which you can hear clearly in the loopwave test program. Fixes #6377.

f4e3af15

2022-10-17T07:23:40

Simplify OSS test by removing OpenBSD specific location of the soundcard.h header OpenBSD has long since stopped using OSS. Remove checking for OpenBSD specific header.

22461383

2022-10-15T15:54:12

SDL_audiocvt: Respct the SDL_HINT_AUDIO_RESAMPLING_MODE hint This implements using libsamplerate for the SDL_AudioCVT API. This library was already being used for audio streams when this hint is set.

65527537

2021-03-30T04:32:39

N3DS port (squashed) A dedicated renderer using Citro3D would likely allow for better much better graphical performances.

484d5fd6

2022-10-05T13:19:38

audio open: ensure 2 devices don't get the same id

e41942e8

2022-10-05T13:36:25

fix compilation error SDL_coreaudio mixing declarations and code

e6640ef2

2022-09-30T14:53:07

coreaudio: Possibly fixed another shutdown race condition. Reference Issue #6159.

40893821

2022-09-29T10:33:07

coreaudio: Add support for SDL_GetDefaultAudioInfo (#6277) Co-authored-by: Ethan Lee <flibitijibibo@gmail.com> Co-authored-by: Ozkan Sezer <sezeroz@gmail.com>

f6565c32

2022-09-28T09:27:45

coreaudio: Remove redundant variable.

411582c7

2022-09-28T09:22:17

coreaudio: Don't crash on shutdown in a race condition. Fixed #6159.

b9e3cae5

2022-08-26T16:58:21

Add more valid configurations to PS2 audio driver

5b4b4fa1

2022-08-14T12:01:56

Decrease audio thread priority when created

f1390780

2022-08-02T15:25:44

Fix use after free when removing Windows audio device

8ff738f2

2022-07-26T12:40:47

audio: Report SDL_AUDIODEVICEREMOVED for unopened devices. Unopened devices, if removed, now send SDL_AUDIODEVICEREMOVED events with a `which` field set to zero. Apps can use this to decide if they need to refresh a list of devices being shown in an options menu, etc. It's safe to call SDL_CloseAudioDevice(0), so even if they try to clean up this bogus id, it should be safe. Fixes #5199.

8c51cae7

2022-07-23T14:56:04

audio/aaudio, audio/openslES: fix -Wdeclaration-after-statement errors Fixes https://github.com/libsdl-org/SDL/issues/5950

f3008e4a

2022-07-20T19:08:31

audio: 3- and 5-channel formats are now supported

45c3b59d

2022-07-20T17:23:42

audio: Turn off DEBUG_CONFIG logging again.

bec721f0

2022-07-20T17:22:41

audio: Fixed dst pointer on channel conversions that grow in-place.

9f56c7cf

2022-07-20T16:39:19

audio: Remove 5.1->X SIMD converters, add SSE mono->stereo. The 5.1 versions didn't use the new algorithm, and making that new algorithm work took so many permutes that it was significantly slower than just using the scalar versions. However, mono-to-stereo is an extremely common conversion, and it's trivial to accelerate it with plain SSE, so that was added!

b83ae9f2

2022-07-19T22:40:51

audio: Replaced some debug-printfs with debug-SDL_Logs. :)

49ec8db5

2022-07-19T22:04:49

audio: Generate the channel converter code from a program.

f06cc3e9

2022-07-19T22:03:56

audio: "SL" means "surround left" not "side left", etc.

5a0c8198

2022-07-19T22:03:02

audio: Add channel convert filter _after_ choosing an SIMD version.

fe160840

2022-07-19T16:04:48

audio: LOG_DEBUG_CONVERT should use SDL_Log, not fprintf(stderr).

25727790

2022-07-19T02:16:08

audio: first attempt at rewriting the channel converters. This is not ready for production use!

b700a326

2022-07-20T07:01:10

audio, pipewire: fix signatures of pw_get_library_version and pw_init. Reference issue: https://github.com/libsdl-org/SDL/issues/5938

6e210d37

2022-07-20T07:01:10

audio, pipewire: pipewire_version_xx globals out of dynamic loading Fixes build with --disable-pipewire-shared Reference issue: https://github.com/libsdl-org/SDL/issues/5938

b299cb3d

2022-07-17T08:31:16

Added a utility function to calculate the next power of 2 for a value

90b86b13

2022-07-17T10:35:09

audio: Handle non-power-of-two spec.samples when unsupported Fixes #3685

a09d62e4

2022-07-15T23:45:56

directsound: Remove redundant SubFormat copy

c5e408ae

2022-07-15T11:31:59

directsound: For channel counts > 2, generate a dwChannelMask for CreateSoundBuffer

fff34f63

2022-07-15T09:46:53

windows: SDL_IMMDevice needed more deinit code from the Win32 path. Fixes #5919

37aecda2

2022-07-14T11:38:51

pipewire: Use PW_KEY_TARGET_OBJECT to specify stream connection nodes Pipewire 0.3.44 introduced PW_KEY_TARGET_OBJECT, which is to be used to specify target connection nodes for streams. This parameter takes either a node path (PW_KEY_NODE_NAME) or serial number (PW_KEY_OBJECT_SERIAL) to specify a target node. The former is used in this case since the path is already being retrieved and stored for other purposes. The target_id parameter in pw_stream_connect() is now deprecated and should always be PW_ID_ANY when PW_KEY_TARGET_OBJECT is used.

36d8460c

2022-07-11T16:59:23

pipewire: Dynamically allocate the buffer for node strings Calculate and allocate the buffer for the IO node name and path strings dynamically instead of using arbitrary sized static buffers.

996cea31

2022-07-11T15:15:48

pipewire: Update default audio devices during runtime Make the default device metadata node persist for the lifetime of the hotplug loop so the default source/sink devices will be updated if they change during runtime.

60da11f0

2022-07-11T14:31:20

pipewire: Remove deprecated configuration key With Pipewire now requiring a minimum version 0.3.24, the PW_KEY_CONTEXT_PROFILE_MODULES value is no longer required for legacy compatability and can be safely removed.

ecfbdce6

2022-07-11T13:09:48

pipewire: Require version 0.3.24 or newer at runtime

2f0816ad

2022-07-11T13:08:30

Add SDL_GetDefaultAudioInfo. This API is supported on pipewire, pulseaudio, wasapi, and directsound. Co-authored-by: Frank Praznik <frank.praznik@gmail.com>

ae105ae1

2022-07-10T12:59:33

windows: Move IMMDevice work to common file, implement DirectSound enumeration support

4aad594a

2022-07-08T16:17:46

Update SDL_qsa_audio.c Fix qnx platform compile error, change SDL_Bool to SDL_bool.

6c536afd

2022-06-27T15:43:17

Fix C89 declaration for macOS modules. Since Clang 14, `-Wdeclaration-after-statement` is enforced on every standard.

e4a80875

2022-06-24T16:43:20

Initial Audio driver

3b191580

2022-06-27T17:19:39

Windows GDK Support (#5830) * Added GDK * Simplfied checks in SDL_config_wingdk.h * Added testgdk sample * Added GDK readme * Fixed error in merge of SDL_windows.h * Additional GDK fixes * OpenWatcom should not export _SDL_GDKGetTaskQueue * Formatting fixes * Moved initialization code into SDL_GDKRunApp

abe38bca

2022-06-18T13:08:58

Support SDL_AUDIODRIVER set to "dsound", which was used by SDL 1.2 Fixes https://github.com/libsdl-org/SDL/issues/5818

adc68758

2022-06-17T10:22:28

Added SDL_copyp to avoid size mismatch when copying values (thanks @1bsyl!) Closes https://github.com/libsdl-org/SDL/pull/5811

dc62fec5

2022-05-20T21:07:25

audio: Fix locking in backends that manage their own callback threads. Otherwise you might get a race where an app pauses the device, but the audio callback still manages to run after the pause is in place.

501a4991

2022-05-05T18:44:32

Add clang-format on/off comments where necessary. Comments were added in places where INDENT-ON/OFF comments are. Places like stdlib's asm don't need it as clang-format doesn't try to indent it.

0cca71a8

2022-05-18T22:12:05

Use SDLCALL for callbacks in public APIs

29694869

2022-04-28T15:56:52

audio: Revert one of the resampler optimizations. This is the one that splits the "left wing" into two for loops to bubble out the conditional that decides if it should read from the left padding or the input buffer. I still believe the optimization is good, but the basic logic of it was incorrect, and needs to be reexamined and fixed before going back into revision control.

5066910b

2022-04-10T13:44:01

audio: Make pregenerated resampler kaiser filter more precise.

111c3add

2022-04-10T13:23:51

audio: Resampler optimizations. - Calculate `j * RESAMPLER_SAMPLES_PER_ZERO_CROSSING` once per loop iteration since we use it multiple times. - Do the left-wing loop in two sections: while `srcframe < 0` and then the remaining calculations when `srcframe >= 0`. This bubbles a conditional out of every iteration of a tight loop, giving us a boost. We could _probably_ do this to the right-wing loop too, but it's less straightforward there. - The real win: Use floats instead of doubles. This almost doubles the speed of the entire function on Intel CPUs, and for embedded things without hardware-level support for doubles, the speedup is enormous. This in theory might reduce audio quality, though, and I had to put a check in place to avoid a division-by-zero that we avoided at higher precision, but this is likely to be worth keeping for at least the Sony PSP and other smaller platforms, if not everyone.

de019568

2022-04-09T23:43:57

audio: Prebake the resampler's kaiser table instead of doing it at runtime.

f6eb4b07

2022-04-26T13:14:15

pulseaudio: Feed audio data in response to write callbacks. Instead of waiting until the entire buffer from the SDL callback is ready to be accepted by PulseAudio, we use pa_stream_set_write_callback and feed some portion of the buffer as callbacks come in asking for more. This lets us remove the halving of the buffer size during device open, and also (hopefully) solves several strange hangs that happen in unusual circumstances. Fixes #4387 Fixes #2262

9e264b92

2022-04-18T09:20:47

Certain audio drivers, like the RME "Pro" Audio driver, have resampling quality issues when using WASAPI. We'll use SDL's resampling algorithm so we have consistent quality between platforms and drivers. Fixes https://github.com/libsdl-org/SDL/issues/5538

c1336b21

2022-04-17T12:43:32

hints: Make SDL_VIDEODRIVER and SDL_AUDIODRIVER formal hints. They were just environment variables before. Fixes #5528.

727eef70

2022-04-09T10:12:49

audio: SDL_ConvertStereoToMono_SSE3 missed an unaligned load.

178ac196

2022-03-29T23:48:08

Vita: add audio capture support

aec86ba8

2022-03-26T15:31:33

emscriptenaudio: proxy calls to main thread

4fe7b2cb

2022-03-24T11:00:43

static analysis: Fixed several complaints from codechecker. There are still some pending Objective-C specific issues. Reference issue #4600.

0af2db6f

2022-03-23T19:04:29

Vita: support audio format fallback

24ffcbd9

2022-03-20T17:23:34

audio: Set error message on dsp init failure. if SDL_EnumUnixAudioDevices() fails to find any devices, set an error message on the exit path. Without this, SDL_Init() could fail without any message available in SDL_GetError().

kc3-lang/SDL/src/audio

src/audio

Log