kmx git

Commit	Date	Message
5e13087b	2019-01-04T22:01:14	Updated copyright for 2019
4773690d	2018-06-25T12:55:23	Deal with possible malloc(0) calls, as pointed out by static analysis.
e3cc5b2c	2018-01-03T10:03:25	Updated copyright for 2018
e830ef34	2017-10-20T16:53:42	Fixed typo converting 4 channel audio to 2 channel
9a291c1e	2017-10-20T14:51:22	Added a note about adjusting channel weights when converting to fewer channels
72932906	2017-10-19T18:05:42	audio: Added SDL_AudioStreamFlush().
e98920f5	2017-10-18T23:49:46	Check correct variable for malloc() results.
653ab5d9	2017-10-18T19:26:36	Added a staging buffer to the audio stream so that we can accumulate small amounts of data if needed when resampling
80f8464d	2017-10-18T15:54:05	Added audio stream conversion functions: SDL_NewAudioStream SDL_AudioStreamPut SDL_AudioStreamGet SDL_AudioStreamAvailable SDL_AudioStreamClear SDL_FreeAudioStream
ba10d2b6	2017-10-12T13:55:35	Fixed compiler warning
5e5f2290	2017-10-11T12:07:43	audio: Turns out the accumulation errors sound better. :/ Moving to double fixed the overflows, but using "time = i * incr" instead of "time += incr" causes clicks in the output.
9bd2c6b4	2017-10-11T11:51:14	audio: Moved the resampler state up to double precision. Fixes more buffer overflows.
b2f5123b	2017-10-11T11:43:35	audio: calculate resampling time directly, don't increment (thanks, Eric!). Fixes buffer overruns as floating point errors accumulate. Partially fixes Bugzilla #3848.
763c3871	2017-10-11T02:33:55	audio: clamp resampler interpolation values to prevent buffer overflow. Partially fixes Bugzilla #3848.
0085f917	2017-10-11T02:31:58	audio: Moved unchanging variable out of loop.
cb8bf6bb	2017-10-11T02:03:05	audio: Make sure audio stream resampling doesn't overflow buffers.
459e2b0b	2017-10-11T01:37:11	audio: Fixed check for minimum audio stream put size.
903ff641	2017-10-10T22:31:02	audio: SDL_ResampleCVT() should use memmove instead of memcpy. This copy can overlap. Fixes Bugzilla #3849.
42fff7ce	2017-10-10T22:18:46	audio: Don't stack-allocate resampler padding. (I thought padding size ranged from 5 frames to ~30 frames (based around RESAMPLER_ZERO_CROSSINGS, which is 5), but it's actually between 512 and several thousands (based on RESAMPLER_SAMPLES_PER_ZERO_CROSSING)). It gets big fast when downsampling.
37d89aa1	2017-10-10T16:12:56	audio: reworked audio streams to have right-hand resampling padding available. Fixes Bugzilla #3851.
099ae43e	2017-09-22T22:28:21	audio: Fixed compiler warning on Visual Studio.
d74c00e6	2017-09-22T08:51:45	Fixed memory leak when HAVE_ALLOCA isn't defined
6d206a7b	2017-09-22T07:42:24	audio: Stream resampling now saves some samples from previous run for padding. Previously, the padding was silence, which was a problem when streaming since you would sample a little bit of this silence between each buffer. We still need a means to get padding data for the right hand side, but this patch makes the resampler output more correct.
1a3b95a1	2017-09-21T02:51:14	audio: Replaced the resampler. Again. This time it's using real math from a real whitepaper instead of my previous amateur, fast-but-low-quality attempt. The new resampler does "bandlimited interpolation," as described here: https://ccrma.stanford.edu/~jos/resample/ The output appears to sound cleaner, especially at high frequencies, and of course works with non-power-of-two rate conversions. There are some obvious optimizations to be done to this still, and there is other fallout: this doesn't resample a buffer in-place, the 2-channels-Sint16 fast path is gone because this resampler does a _lot_ of floating point math. There is a nasty hack to make it work with SDL_AudioCVT. It's possible these issues are solvable, but they aren't solved as of yet. Still, I hope this effort is slouching in the right direction.
d619d885	2017-08-28T21:42:39	Fixed bug 3662 - Error message when using the audio conversion setup without an initialized audio subsystem is a bit vague Simon Hug This issue actually raises the question if this API change (requirement of initialized audio subsystem) is breaking backwards compatibility. I don't see the documentation saying it is needed in 2.0.5.
b128e880	2017-08-29T00:41:45	audio: A whole bunch of improvements to audio conversion (thanks, Solra!). "Major changes, roughly in order of appearance: - Use float math everywhere, instead of promoting to double and casting back all the time. - Conserve sound energy when downmixing any channel into two other channels. - Add a QuadToStereo filter. (The previous technique of reusing StereoToMono never worked, since it assumed an incorrect channel layout for 4.0.) - Add a 71to51 filter. This removes just under half of the cases the previous code would silently break in. - Add a QuadTo51 filter. More silent breakage fixed. - Add a 51to71 filter, removing another almost-half of the silently broken cases. - Add 8 to the list of values SDL_SupportedChannelCount will accept. - Change SDL_BuildAudioCVT's channel-related logic to handle every case, and to actually fail if it fails instead of silently corrupting sound data and/or crashing down the road." (Note that SDL doesn't otherwise support 7.1 audio yet, but hopefully it will soon and the 7.1 converters are an important piece of that. --ryan.) Fixes Bugzilla #3727.
e3e6b4fd	2017-08-18T16:52:19	audio: better docs on conversion APIs, error if not init'd (thanks, Simon!). Fixes Bugzilla #3662.
1683a0c1	2017-07-05T12:04:37	audio: trying to pacify static analysis.
a509719f	2017-06-12T21:35:24	audio: Converter now checks a strict list of channels and formats we support.
553b3286	2017-06-12T16:39:15	Fixed bug 3668 - Overflow of SDL_AudioCVT.filters with some downmixes Simon Hug There's a chance that an audio conversion from many channels to a few can use more than 9 audio filters. SDL_AudioCVT has 10 SDL_AudioFilter pointers of which one has to be the terminating NULL pointer. The SDL code has no checks for this limit. If it overflows there can be stack or heap corruption or a call to 0xa. Attached patch adds a function that checks for this limit and throws an error if it is reached. Also adds some documentation. Test parameters that trigger this issue: AUDIO_U16MSB with 224 channels at 46359 Hz V AUDIO_S16MSB with 6 channels at 27463 Hz The fuzzer program I uploaded in bug 3667 has more of them.
ca0bf151	2017-03-03T16:38:17	Fix some more compiler warnings on armcc.
d526b8a1	2017-03-02T13:33:04	Some patches to make SDL compile with armcc (ARM's C compiler).
ad9c702f	2017-02-13T16:56:41	audio: SDL_AudioStream's *_sample_frame_size should be in bytes, not bits. Fixes failures where SDL_AudioStreamGet() incorrectly thinks it got a partial sample frame request.
47e2f4e9	2017-01-24T20:30:48	audio: libsamplerate can't resample in-place; make space for a copy if needed.
c7f9dcb6	2017-01-24T15:52:22	audio: Offer a hint for libsamplerate quality/speed tradeoff. This defaults to the internal SDL resampler, since that's the likely default without a system-wide install of libsamplerate, but those that need more can tweak this.
1da3a337	2017-01-24T10:09:29	audio: Fix static analysis concerns about a dead assignment.
8f627c1c	2017-01-24T00:51:33	audio: Make sure SDL_AudioStream's work buffer is 16-byte aligned, for SIMD. Note the giantic FIXME, though!
17dcee20	2017-01-24T00:17:40	audio: Streams now resample in-place. Removed second allocated buffer.
b5eeab77	2017-01-24T00:08:24	audio: allow stereo Sint16 resampling fast path in SDL_AudioStream. This currently favors libsamplerate over the fast path (quality over speed), but I'm not sure that's the correct approach, as there may be surprising changes in performance metrics depending on what packages are available on a user's system. That being said, currently, the only thing with access to SDL_AudioStream is an SDL audio device's thread, and it might be mostly idle otherwise, so maybe this is generally good.
a80cb672	2017-01-24T00:03:36	audio: Fixed off-by-one error in upsampling.
dad07f96	2017-01-23T16:45:50	audio: Resampler now special-cases stereo and mono processing. Turns out that iterating from 0 to channels-1 was a serious performance hit! These cases now tend to match or beat the original audio resampler's speed!
8ce6ddf1	2017-01-23T16:42:47	audio: Fixed incorrect pointer in SDL_ResampleCVT_si16_c2(). Forgot to update this when we changed this to process in-place. Whoops!
3594bf8e	2017-01-23T01:05:44	audio: Wired up new SSE code to build system.
64056e81	2017-01-23T00:57:19	audio: Added SSE3 implementation of SDL_ConvertStereoToMono().
8855daac	2017-01-22T23:48:15	audio: Make the simple resampler operate in-place. This allows us to avoid an extra copy, allocate less memory and reduce cache pressure. On the downside: we have to do a lot of tapdancing to resample the buffer in reverse when the output is growing.
202ab30c	2017-01-22T20:27:48	audio: Special case for resampling stereo AUDIO_S16SYS audio data. This is a fairly common case, so we avoid the conversion to/from float here.
a7f86f2f	2017-01-22T20:18:59	audio: don't cast to double in SDL_ConvertStereoToMono(). It's expensive and (hopefully) unnecessary. If this becomes an overflow problem, we could multiply both values by 0.5f before adding them, but let's see if we can get by without the extra multiplication first.
83454c82	2017-01-20T16:26:24	audio: removed conditional from simple resampler's inner loop. We never seem to overflow the source buffer now; this might have been a leftover from a bug that was covered by Vitaly's fixes? Removing this conditional makes the resampler 10-20% faster. Left an assert in there for debug builds, in case this still happens.
3e1679c8	2017-01-18T02:11:56	audio: Several fixes to "simple" resampler (thanks, Vitaly!). Fixes Bugzilla #3551.
1e66d457	2017-01-15T05:01:59	audio: Some fixes to the audio data type converter code. Removed some needless things ("len / sizeof (Uint8)"), and made sure the int32 -> float code uses doubles to avoid working with large integer values in a 32-bit float.
bf11cd50	2017-01-09T20:37:52	Fixed bug 3552 - Building SDL in release mode fails under VS 2017 RC Lukasz Biel Tried to compile SDL2 using newest version of VS. Got: SDL_audiocvt.obj : error LNK2019: unresolved external symbol memcpy referenced in function SDL_ResampleCVT 1>E:\Users\dotPo\Lib\SDL\VisualC\x64\Release\SDL2.dll : fatal error LNK1120: 1 unresolved externals whole compilation process: http://pastebin.com/eWDAvBce Steps to reproduce: clone http://hg.libsdl.org/SDL using tortoise hg, open SDL\VisualC\SDL.sln, when promted if should retarget solution click ok, select release x64 build type, Build/Build Solution attempt 2, using Visual Studio cmake support: open folder SDL\ select release x64 build type, run CMake\Build CMakeLists.txt build fails When switched to debug build type, buils succeeds in both cases. VS 2017 is still beta.
23020f92	2017-01-09T16:31:57	audio: Don't ever use libsamplerate in the SDL_AudioCVT codepath. It causes audio pops if you're converting in chunks (and needs to allocate/initialize/free on each convert). We'll either adjust this interface when we break ABI for 2.1 to make this usable, or publish the SDL_AudioStream API for those that want a streaming solution. In the meantime, the "simple" resampler produces "good enough" audio without pops and doesn't have to be initialized, so that'll do for now on the SDL_AudioCVT interface.
063c9d40	2017-01-09T06:00:58	audio: Replaced older resamplers in SDL_AudioCVT with the new ones.
38854e03	2017-01-08T16:18:49	audio: Improvements in channel conversion code.
d005dc21	2017-01-08T14:23:15	audio: Patched to compile with libsamplerate support.
19e937fc	2017-01-08T14:18:03	audio: libsamplerate loading now happens once at init time.
98cc9d10	2017-01-08T14:17:09	Fixed coding style on a function signature.
df25258a	2017-01-06T20:43:53	Added configure and cmake support for libsamplerate
c5825b69	2017-01-06T21:23:51	audio: Don't call a NULL function pointer when clearing audio streams. (Partially?) fixes Bugzilla #3547.
cbe44f7f	2017-01-06T02:16:26	Added support for using libsamplerate to do audio resampling
3443dc19	2017-01-05T23:53:46	Don't do any audio conversion if none is necessary
992124d4	2017-01-06T01:02:58	audio: Fixed SDL_AudioStreamGet() function parameters. There was a draft of this where it did audio conversion into the final buffer, if there was enough room available past what you asked for, but that interface got removed, so the parameters didn't make sense (and we were using the wrong one in any case, too!).
3761b5f6	2017-01-05T20:11:19	Fixed a few compiler warnings.
30178a9b	2017-01-05T19:29:38	audio: Added SDL_AudioStream. Non-power-of-two resampling now works!
f12ab8f2	2017-01-05T19:12:20	audio: More effort to improve and simplify audio resamplers.
45b774e3	2017-01-01T18:33:28	Updated copyright for 2017
6380d5c2	2016-11-07T21:10:01	Fixed audio conversion for unsigned 16 bit data.
6ed82130	2016-11-05T01:52:28	Fixed Windows build
a17abf10	2016-11-05T03:56:55	Also patched to compile on C89 compilers.
067f0c84	2016-11-05T03:53:59	Patched to compile on C89 compilers.
f3456e9a	2016-11-05T02:34:38	Reworked audio converter code. This no longer uses a script to generate code for every possible type conversion or resampler. This caused a bloat in binary size and and compile times. Now we use a handful of more generic functions and assume staying in the CPU cache is the most important thing anyhow. This shrinks the size of the final build (in this case: macOS X amd64, -Os to optimize for size) by 15%. When compiling on a single core, build times drop by about 15% too (although the previous cost was largely hidden by multicore builds).
42065e78	2016-01-02T10:10:34	Updated copyright to 2016
0e45984f	2015-06-21T17:33:46	Fixed crash if initialization of EGL failed but was tried again later. The internal function SDL_EGL_LoadLibrary() did not delete and remove a mostly uninitialized data structure if loading the library first failed. A later try to use EGL then skipped initialization and assumed it was previously successful because the data structure now already existed. This led to at least one crash in the internal function SDL_EGL_ChooseConfig() because a NULL pointer was dereferenced to make a call to eglBindAPI().
2c4a6ea0	2015-05-26T06:27:46	Updated the copyright year to 2015
b72938c8	2015-04-20T12:22:44	Windows: Always set the system timer resolution to 1ms by default. An existing hint lets apps that don't need the timer resolution changed avoid this, to save battery, etc, but this fixes several problems in timing, audio callbacks not firing fast enough, etc. Fixes Bugzilla #2944.
fe6c797c	2015-04-10T23:30:31	Fixed an iOS view orientation issue when SDL_GL_CreateContext or SDL_CreateRenderer is called.
b88ca1b4	2015-02-10T16:28:56	the last parameter of XChangeProperty is the number of elements.. and when the element format is 32.. the element is "long" so we have 5 long elements here. Yes this seems confusing as on mac+linux Long is either 32 or 64bits depending on the architecture, but this is how the X11 protocol is defined. Thus 5 is the correct value for the nelts here. Not 5 or 10 depending on the architecture. More info on the confusion https://bugs.freedesktop.org/show_bug.cgi?id=16802
b48e54aa	2015-01-26T22:00:29	Fixed bug 2802 - [patch] Fix android build compiling in wrong filesystem implementation Jonas Kulla The configure script didn't differentiate between Linux and Android, unconditionally compiling in the unix implementation of SDL_sysfilesystem.c. I'm probably one of the very few people building SDL for android using classic configure + standalone toolchain, so this has gone undetected all along.
70438be2	2014-12-03T10:55:23	WinRT: fixed bug whereby SDL would override an app's default orientation WinRT apps can set a default, preferred orientation via a .appxmanifest file. SDL was overriding this on app startup, and making the app use all possible orientations (landscape and portrait). Thanks to Eric Wing for the heads up on this!
9c398852	2014-11-22T22:20:40	Corrected header file documentation comment.
24c86b55	2014-09-11T19:24:42	[X11] Reconcile logical keyboard state with physical state on FocusIn since the window system doesn't do it for us like other platforms. This prevents sticky keys and missed keys when going in and out of focus, for example Alt would appear to stick if switching away from an SDL app with Alt-Tab and had to be pressed again. CR: Sam
3dcb451f	2014-04-09T21:29:19	Added a README file regarding WinRT support To note, this file is currently formatted with CRLF line endings, rather than LF, to allow the file to be viewed with Notepad.
d3cf7360	2014-02-21T13:57:53	Fix audio conversion when channel count changes - Use the SDL_AUDIO_MASK_DATATYPE bit when selecting an implementation where it matters. Previously two existing AUDIO_F32 cases had been written, but were unreachable. - Add AUDIO_F32 case for SDL_ConvertSurround_4. - Fix incorrect pointer arithmetic causing the 2 to 6 channel conversion for 4 byte audio formats to read and write beyond the end of the buffer.
58edac3e	2014-02-02T00:53:27	Fixed bug 2374 - Update copyright for 2014... Is it that time already??
f848adff	2013-11-29T10:06:08	Improve Android pause/resume behavior.
7e1289af	2013-11-24T23:56:17	Make internal SDL sources include SDL_internal.h instead of SDL_config.h The new header will include SDL_config.h, but allows for other global stuff.
dad42067	2013-08-12T11:13:50	Fixes #2022, do not resume on Android when surfaceChanged If the app is in landscape mode and the user presses the power button, a pause is followed immediately by a surfaceChanged event because the lock screen is shown in portrait mode. This triggers a "false" resume. So, we just pause and resume following the onWindowFocusChanged events. Also, wait for SDL_APP_WILLENTERBACKGROUND and SDL_APP_DIDENTERBACKGROUND before blocking the event pump.
1ad936eb	2013-08-11T19:56:43	Fixed bug 2027 - Full-screen appears to be broken - hang in SDL_DestroyWindow() Rainer Deyke I'm running Linux Mint 15 with the Cinnamon window manager. SDL_DestroyWindow consistently locks up for me when the window if fullscreen.

5e13087b

2019-01-04T22:01:14

Updated copyright for 2019

4773690d

2018-06-25T12:55:23

Deal with possible malloc(0) calls, as pointed out by static analysis.

e3cc5b2c

2018-01-03T10:03:25

Updated copyright for 2018

e830ef34

2017-10-20T16:53:42

Fixed typo converting 4 channel audio to 2 channel

9a291c1e

2017-10-20T14:51:22

Added a note about adjusting channel weights when converting to fewer channels

72932906

2017-10-19T18:05:42

audio: Added SDL_AudioStreamFlush().

e98920f5

2017-10-18T23:49:46

Check correct variable for malloc() results.

653ab5d9

2017-10-18T19:26:36

Added a staging buffer to the audio stream so that we can accumulate small amounts of data if needed when resampling

80f8464d

2017-10-18T15:54:05

Added audio stream conversion functions: SDL_NewAudioStream SDL_AudioStreamPut SDL_AudioStreamGet SDL_AudioStreamAvailable SDL_AudioStreamClear SDL_FreeAudioStream

ba10d2b6

2017-10-12T13:55:35

Fixed compiler warning

5e5f2290

2017-10-11T12:07:43

audio: Turns out the accumulation errors sound better. :/ Moving to double fixed the overflows, but using "time = i * incr" instead of "time += incr" causes clicks in the output.

9bd2c6b4

2017-10-11T11:51:14

audio: Moved the resampler state up to double precision. Fixes more buffer overflows.

b2f5123b

2017-10-11T11:43:35

audio: calculate resampling time directly, don't increment (thanks, Eric!). Fixes buffer overruns as floating point errors accumulate. Partially fixes Bugzilla #3848.

763c3871

2017-10-11T02:33:55

audio: clamp resampler interpolation values to prevent buffer overflow. Partially fixes Bugzilla #3848.

0085f917

2017-10-11T02:31:58

audio: Moved unchanging variable out of loop.

cb8bf6bb

2017-10-11T02:03:05

audio: Make sure audio stream resampling doesn't overflow buffers.

459e2b0b

2017-10-11T01:37:11

audio: Fixed check for minimum audio stream put size.

903ff641

2017-10-10T22:31:02

audio: SDL_ResampleCVT() should use memmove instead of memcpy. This copy can overlap. Fixes Bugzilla #3849.

42fff7ce

2017-10-10T22:18:46

audio: Don't stack-allocate resampler padding. (I thought padding size ranged from 5 frames to ~30 frames (based around RESAMPLER_ZERO_CROSSINGS, which is 5), but it's actually between 512 and several thousands (based on RESAMPLER_SAMPLES_PER_ZERO_CROSSING)). It gets big fast when downsampling.

37d89aa1

2017-10-10T16:12:56

audio: reworked audio streams to have right-hand resampling padding available. Fixes Bugzilla #3851.

099ae43e

2017-09-22T22:28:21

audio: Fixed compiler warning on Visual Studio.

d74c00e6

2017-09-22T08:51:45

Fixed memory leak when HAVE_ALLOCA isn't defined

6d206a7b

2017-09-22T07:42:24

audio: Stream resampling now saves some samples from previous run for padding. Previously, the padding was silence, which was a problem when streaming since you would sample a little bit of this silence between each buffer. We still need a means to get padding data for the right hand side, but this patch makes the resampler output more correct.

1a3b95a1

2017-09-21T02:51:14

audio: Replaced the resampler. Again. This time it's using real math from a real whitepaper instead of my previous amateur, fast-but-low-quality attempt. The new resampler does "bandlimited interpolation," as described here: https://ccrma.stanford.edu/~jos/resample/ The output appears to sound cleaner, especially at high frequencies, and of course works with non-power-of-two rate conversions. There are some obvious optimizations to be done to this still, and there is other fallout: this doesn't resample a buffer in-place, the 2-channels-Sint16 fast path is gone because this resampler does a _lot_ of floating point math. There is a nasty hack to make it work with SDL_AudioCVT. It's possible these issues are solvable, but they aren't solved as of yet. Still, I hope this effort is slouching in the right direction.

d619d885

2017-08-28T21:42:39

Fixed bug 3662 - Error message when using the audio conversion setup without an initialized audio subsystem is a bit vague Simon Hug This issue actually raises the question if this API change (requirement of initialized audio subsystem) is breaking backwards compatibility. I don't see the documentation saying it is needed in 2.0.5.

b128e880

2017-08-29T00:41:45

audio: A whole bunch of improvements to audio conversion (thanks, Solra!). "Major changes, roughly in order of appearance: - Use float math everywhere, instead of promoting to double and casting back all the time. - Conserve sound energy when downmixing any channel into two other channels. - Add a QuadToStereo filter. (The previous technique of reusing StereoToMono never worked, since it assumed an incorrect channel layout for 4.0.) - Add a 71to51 filter. This removes just under half of the cases the previous code would silently break in. - Add a QuadTo51 filter. More silent breakage fixed. - Add a 51to71 filter, removing another almost-half of the silently broken cases. - Add 8 to the list of values SDL_SupportedChannelCount will accept. - Change SDL_BuildAudioCVT's channel-related logic to handle every case, and to actually fail if it fails instead of silently corrupting sound data and/or crashing down the road." (Note that SDL doesn't otherwise support 7.1 audio yet, but hopefully it will soon and the 7.1 converters are an important piece of that. --ryan.) Fixes Bugzilla #3727.

e3e6b4fd

2017-08-18T16:52:19

audio: better docs on conversion APIs, error if not init'd (thanks, Simon!). Fixes Bugzilla #3662.

1683a0c1

2017-07-05T12:04:37

audio: trying to pacify static analysis.

a509719f

2017-06-12T21:35:24

audio: Converter now checks a strict list of channels and formats we support.

553b3286

2017-06-12T16:39:15

Fixed bug 3668 - Overflow of SDL_AudioCVT.filters with some downmixes Simon Hug There's a chance that an audio conversion from many channels to a few can use more than 9 audio filters. SDL_AudioCVT has 10 SDL_AudioFilter pointers of which one has to be the terminating NULL pointer. The SDL code has no checks for this limit. If it overflows there can be stack or heap corruption or a call to 0xa. Attached patch adds a function that checks for this limit and throws an error if it is reached. Also adds some documentation. Test parameters that trigger this issue: AUDIO_U16MSB with 224 channels at 46359 Hz V AUDIO_S16MSB with 6 channels at 27463 Hz The fuzzer program I uploaded in bug 3667 has more of them.

ca0bf151

2017-03-03T16:38:17

Fix some more compiler warnings on armcc.

d526b8a1

2017-03-02T13:33:04

Some patches to make SDL compile with armcc (ARM's C compiler).

ad9c702f

2017-02-13T16:56:41

audio: SDL_AudioStream's *_sample_frame_size should be in bytes, not bits. Fixes failures where SDL_AudioStreamGet() incorrectly thinks it got a partial sample frame request.

47e2f4e9

2017-01-24T20:30:48

audio: libsamplerate can't resample in-place; make space for a copy if needed.

c7f9dcb6

2017-01-24T15:52:22

audio: Offer a hint for libsamplerate quality/speed tradeoff. This defaults to the internal SDL resampler, since that's the likely default without a system-wide install of libsamplerate, but those that need more can tweak this.

1da3a337

2017-01-24T10:09:29

audio: Fix static analysis concerns about a dead assignment.

8f627c1c

2017-01-24T00:51:33

audio: Make sure SDL_AudioStream's work buffer is 16-byte aligned, for SIMD. Note the giantic FIXME, though!

17dcee20

2017-01-24T00:17:40

audio: Streams now resample in-place. Removed second allocated buffer.

b5eeab77

2017-01-24T00:08:24

audio: allow stereo Sint16 resampling fast path in SDL_AudioStream. This currently favors libsamplerate over the fast path (quality over speed), but I'm not sure that's the correct approach, as there may be surprising changes in performance metrics depending on what packages are available on a user's system. That being said, currently, the only thing with access to SDL_AudioStream is an SDL audio device's thread, and it might be mostly idle otherwise, so maybe this is generally good.

a80cb672

2017-01-24T00:03:36

audio: Fixed off-by-one error in upsampling.

dad07f96

2017-01-23T16:45:50

audio: Resampler now special-cases stereo and mono processing. Turns out that iterating from 0 to channels-1 was a serious performance hit! These cases now tend to match or beat the original audio resampler's speed!

8ce6ddf1

2017-01-23T16:42:47

audio: Fixed incorrect pointer in SDL_ResampleCVT_si16_c2(). Forgot to update this when we changed this to process in-place. Whoops!

3594bf8e

2017-01-23T01:05:44

audio: Wired up new SSE code to build system.

64056e81

2017-01-23T00:57:19

audio: Added SSE3 implementation of SDL_ConvertStereoToMono().

8855daac

2017-01-22T23:48:15

audio: Make the simple resampler operate in-place. This allows us to avoid an extra copy, allocate less memory and reduce cache pressure. On the downside: we have to do a lot of tapdancing to resample the buffer in reverse when the output is growing.

202ab30c

2017-01-22T20:27:48

audio: Special case for resampling stereo AUDIO_S16SYS audio data. This is a fairly common case, so we avoid the conversion to/from float here.

a7f86f2f

2017-01-22T20:18:59

audio: don't cast to double in SDL_ConvertStereoToMono(). It's expensive and (hopefully) unnecessary. If this becomes an overflow problem, we could multiply both values by 0.5f before adding them, but let's see if we can get by without the extra multiplication first.

83454c82

2017-01-20T16:26:24

audio: removed conditional from simple resampler's inner loop. We never seem to overflow the source buffer now; this might have been a leftover from a bug that was covered by Vitaly's fixes? Removing this conditional makes the resampler 10-20% faster. Left an assert in there for debug builds, in case this still happens.

3e1679c8

2017-01-18T02:11:56

audio: Several fixes to "simple" resampler (thanks, Vitaly!). Fixes Bugzilla #3551.

1e66d457

2017-01-15T05:01:59

audio: Some fixes to the audio data type converter code. Removed some needless things ("len / sizeof (Uint8)"), and made sure the int32 -> float code uses doubles to avoid working with large integer values in a 32-bit float.

bf11cd50

2017-01-09T20:37:52

Fixed bug 3552 - Building SDL in release mode fails under VS 2017 RC Lukasz Biel Tried to compile SDL2 using newest version of VS. Got: SDL_audiocvt.obj : error LNK2019: unresolved external symbol memcpy referenced in function SDL_ResampleCVT 1>E:\Users\dotPo\Lib\SDL\VisualC\x64\Release\SDL2.dll : fatal error LNK1120: 1 unresolved externals whole compilation process: http://pastebin.com/eWDAvBce Steps to reproduce: clone http://hg.libsdl.org/SDL using tortoise hg, open SDL\VisualC\SDL.sln, when promted if should retarget solution click ok, select release x64 build type, Build/Build Solution attempt 2, using Visual Studio cmake support: open folder SDL\ select release x64 build type, run CMake\Build CMakeLists.txt build fails When switched to debug build type, buils succeeds in both cases. VS 2017 is still beta.

23020f92

2017-01-09T16:31:57

audio: Don't ever use libsamplerate in the SDL_AudioCVT codepath. It causes audio pops if you're converting in chunks (and needs to allocate/initialize/free on each convert). We'll either adjust this interface when we break ABI for 2.1 to make this usable, or publish the SDL_AudioStream API for those that want a streaming solution. In the meantime, the "simple" resampler produces "good enough" audio without pops and doesn't have to be initialized, so that'll do for now on the SDL_AudioCVT interface.

063c9d40

2017-01-09T06:00:58

audio: Replaced older resamplers in SDL_AudioCVT with the new ones.

38854e03

2017-01-08T16:18:49

audio: Improvements in channel conversion code.

d005dc21

2017-01-08T14:23:15

audio: Patched to compile with libsamplerate support.

19e937fc

2017-01-08T14:18:03

audio: libsamplerate loading now happens once at init time.

98cc9d10

2017-01-08T14:17:09

Fixed coding style on a function signature.

df25258a

2017-01-06T20:43:53

Added configure and cmake support for libsamplerate

c5825b69

2017-01-06T21:23:51

audio: Don't call a NULL function pointer when clearing audio streams. (Partially?) fixes Bugzilla #3547.

cbe44f7f

2017-01-06T02:16:26

Added support for using libsamplerate to do audio resampling

3443dc19

2017-01-05T23:53:46

Don't do any audio conversion if none is necessary

992124d4

2017-01-06T01:02:58

audio: Fixed SDL_AudioStreamGet() function parameters. There was a draft of this where it did audio conversion into the final buffer, if there was enough room available past what you asked for, but that interface got removed, so the parameters didn't make sense (and we were using the wrong one in any case, too!).

3761b5f6

2017-01-05T20:11:19

Fixed a few compiler warnings.

30178a9b

2017-01-05T19:29:38

audio: Added SDL_AudioStream. Non-power-of-two resampling now works!

f12ab8f2

2017-01-05T19:12:20

audio: More effort to improve and simplify audio resamplers.

45b774e3

2017-01-01T18:33:28

6380d5c2

2016-11-07T21:10:01

Fixed audio conversion for unsigned 16 bit data.

6ed82130

2016-11-05T01:52:28

Fixed Windows build

a17abf10

2016-11-05T03:56:55

Also patched to compile on C89 compilers.

067f0c84

2016-11-05T03:53:59

Patched to compile on C89 compilers.

f3456e9a

2016-11-05T02:34:38

Reworked audio converter code. This no longer uses a script to generate code for every possible type conversion or resampler. This caused a bloat in binary size and and compile times. Now we use a handful of more generic functions and assume staying in the CPU cache is the most important thing anyhow. This shrinks the size of the final build (in this case: macOS X amd64, -Os to optimize for size) by 15%. When compiling on a single core, build times drop by about 15% too (although the previous cost was largely hidden by multicore builds).

42065e78

2016-01-02T10:10:34

0e45984f

2015-06-21T17:33:46

Fixed crash if initialization of EGL failed but was tried again later. The internal function SDL_EGL_LoadLibrary() did not delete and remove a mostly uninitialized data structure if loading the library first failed. A later try to use EGL then skipped initialization and assumed it was previously successful because the data structure now already existed. This led to at least one crash in the internal function SDL_EGL_ChooseConfig() because a NULL pointer was dereferenced to make a call to eglBindAPI().

2c4a6ea0

2015-05-26T06:27:46

b72938c8

2015-04-20T12:22:44

Windows: Always set the system timer resolution to 1ms by default. An existing hint lets apps that don't need the timer resolution changed avoid this, to save battery, etc, but this fixes several problems in timing, audio callbacks not firing fast enough, etc. Fixes Bugzilla #2944.

fe6c797c

2015-04-10T23:30:31

Fixed an iOS view orientation issue when SDL_GL_CreateContext or SDL_CreateRenderer is called.

b88ca1b4

2015-02-10T16:28:56

the last parameter of XChangeProperty is the number of elements.. and when the element format is 32.. the element is "long" so we have 5 long elements here. Yes this seems confusing as on mac+linux Long is either 32 or 64bits depending on the architecture, but this is how the X11 protocol is defined. Thus 5 is the correct value for the nelts here. Not 5 or 10 depending on the architecture. More info on the confusion https://bugs.freedesktop.org/show_bug.cgi?id=16802

b48e54aa

2015-01-26T22:00:29

Fixed bug 2802 - [patch] Fix android build compiling in wrong filesystem implementation Jonas Kulla The configure script didn't differentiate between Linux and Android, unconditionally compiling in the unix implementation of SDL_sysfilesystem.c. I'm probably one of the very few people building SDL for android using classic configure + standalone toolchain, so this has gone undetected all along.

70438be2

2014-12-03T10:55:23

WinRT: fixed bug whereby SDL would override an app's default orientation WinRT apps can set a default, preferred orientation via a .appxmanifest file. SDL was overriding this on app startup, and making the app use all possible orientations (landscape and portrait). Thanks to Eric Wing for the heads up on this!

9c398852

2014-11-22T22:20:40

Corrected header file documentation comment.

24c86b55

2014-09-11T19:24:42

[X11] Reconcile logical keyboard state with physical state on FocusIn since the window system doesn't do it for us like other platforms. This prevents sticky keys and missed keys when going in and out of focus, for example Alt would appear to stick if switching away from an SDL app with Alt-Tab and had to be pressed again. CR: Sam

3dcb451f

2014-04-09T21:29:19

Added a README file regarding WinRT support To note, this file is currently formatted with CRLF line endings, rather than LF, to allow the file to be viewed with Notepad.

d3cf7360

2014-02-21T13:57:53

Fix audio conversion when channel count changes - Use the SDL_AUDIO_MASK_DATATYPE bit when selecting an implementation where it matters. Previously two existing AUDIO_F32 cases had been written, but were unreachable. - Add AUDIO_F32 case for SDL_ConvertSurround_4. - Fix incorrect pointer arithmetic causing the 2 to 6 channel conversion for 4 byte audio formats to read and write beyond the end of the buffer.

58edac3e

2014-02-02T00:53:27

f848adff

2013-11-29T10:06:08

Improve Android pause/resume behavior.

7e1289af

2013-11-24T23:56:17

Make internal SDL sources include SDL_internal.h instead of SDL_config.h The new header will include SDL_config.h, but allows for other global stuff.

dad42067

2013-08-12T11:13:50

Fixes #2022, do not resume on Android when surfaceChanged If the app is in landscape mode and the user presses the power button, a pause is followed immediately by a surfaceChanged event because the lock screen is shown in portrait mode. This triggers a "false" resume. So, we just pause and resume following the onWindowFocusChanged events. Also, wait for SDL_APP_WILLENTERBACKGROUND and SDL_APP_DIDENTERBACKGROUND before blocking the event pump.

1ad936eb

2013-08-11T19:56:43

Fixed bug 2027 - Full-screen appears to be broken - hang in SDL_DestroyWindow() Rainer Deyke I'm running Linux Mint 15 with the Cinnamon window manager. SDL_DestroyWindow consistently locks up for me when the window if fullscreen.

kc3-lang/SDL/src/audio/SDL_audiocvt.c

src/audio/SDL_audiocvt.c

Log